several UFSHPB changes
cover several UFSHPB changes
From: Bean Huo <[email protected]>
*** BLURB HERE ***
Bean Huo (4):
scsi: ufshpb: Merge ufshpb_reset() and ufshpb_reset_host()
scsi: ufshpb: Remove 0 assignment for enum value
scsi: ufshpb: Cleanup the handler when device reset HPB information
scsi: ufshpb: Add device reset HPB regions Infor handling for HPB
device mode
drivers/scsi/ufs/ufshcd.c | 4 +- drivers/scsi/ufs/ufshpb.c | 142 +++++++++++++++++++++++--------------- drivers/scsi/ufs/ufshpb.h | 10 ++- 3 files changed, 94 insertions(+), 62 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/4 scsi: ufshpb: Merge ufshpb_reset() and ufshpb_reset_host()
From: Bean Huo <[email protected]>
There is no functional change in this patch, just merge ufshpb_reset() and ufshpb_reset_host() into one function ufshpb_toggle().
--- drivers/scsi/ufs/ufshcd.c | 4 ++-- drivers/scsi/ufs/ufshpb.c | 36 +++++++++++++----------------------- drivers/scsi/ufs/ufshpb.h | 6 ++---- 3 files changed, 17 insertions(+), 29 deletions(-)
drivers/scsi/ufs/ufshcd.c +2 -2
@@ -7223,7 +7223,7 @@ static int ufshcd_host_reset_and_restore(struct ufs_hba *hba)* Stop the host controller and complete the requests * cleared by h/w */ -ufshpb_reset_host (hba); +ufshpb_toggle (hba,HPB_PRESENT ,HPB_RESET );ufshcd_hba_stop (hba); hba->silence_err_logs = true;ufshcd_complete_requests (hba);
@@ -8184,7 +8184,7 @@ static int ufshcd_probe_hba(struct ufs_hba *hba, bool init_dev_params)/* Enable Auto-Hibernate if configured */ ufshcd_auto_hibern8_enable (hba); -ufshpb_reset (hba); +ufshpb_toggle (hba,HPB_RESET ,HPB_PRESENT ); out:spin_lock_irqsave (hba->host->host_lock, flags);if (ret)
drivers/scsi/ufs/ufshpb.c +13 -23
@@ -2278,38 +2278,28 @@ static bool ufshpb_check_hpb_reset_query(struct ufs_hba *hba)return flag_res; } -void ufshpb_reset (struct ufs_hba *hba) +/** +* ufshpb_toggle - switch HPB state of all LUs +* @hba: per-adapter instance +* @src: expected current HPB state +* @dest: expected target HPB state +*/ +void ufshpb_toggle (struct ufs_hba *hba,enum UFSHPB_STATE src,enum UFSHPB_STATE dest) {struct ufshpb_lu *hpb;struct scsi_device *sdev;shost_for_each_device (sdev, hba->host) { hpb =ufshpb_get_hpb_data (sdev); -if (!hpb) -continue ; - -if (ufshpb_get_state (hpb) !=HPB_RESET ) -continue ; - -ufshpb_set_state (hpb,HPB_PRESENT ); - } -} - -void ufshpb_reset_host (struct ufs_hba *hba) -{ -struct ufshpb_lu *hpb; -struct scsi_device *sdev; -shost_for_each_device (sdev, hba->host) { - hpb =ufshpb_get_hpb_data (sdev); -if (!hpb) +if (!hpb ||ufshpb_get_state (hpb) != src)continue ; +ufshpb_set_state (hpb, dest); -if (ufshpb_get_state (hpb) !=HPB_PRESENT ) -continue ; -ufshpb_set_state (hpb,HPB_RESET ); -ufshpb_cancel_jobs (hpb); -ufshpb_discard_rsp_lists (hpb); +if (dest ==HPB_RESET ) { +ufshpb_cancel_jobs (hpb); +ufshpb_discard_rsp_lists (hpb); + } } }
drivers/scsi/ufs/ufshpb.h +2 -4
@@ -288,8 +288,7 @@ static int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) { return 0;static void ufshpb_rsp_upiu (struct ufs_hba *hba,struct ufshcd_lrb *lrbp) {}static void ufshpb_resume (struct ufs_hba *hba) {}static void ufshpb_suspend (struct ufs_hba *hba) {} -static void ufshpb_reset (struct ufs_hba *hba) {} -static void ufshpb_reset_host (struct ufs_hba *hba) {} +static void ufshpb_toggle (struct ufs_hba *hba,enum UFSHPB_STATE src,enum UFSHPB_STATE dest) {}static void ufshpb_init (struct ufs_hba *hba) {}static void ufshpb_init_hpb_lu (struct ufs_hba *hba,struct scsi_device *sdev) {}static void ufshpb_destroy_lu (struct ufs_hba *hba,struct scsi_device *sdev) {}
@@ -303,8 +302,7 @@ int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp);void ufshpb_rsp_upiu (struct ufs_hba *hba,struct ufshcd_lrb *lrbp);void ufshpb_resume (struct ufs_hba *hba);void ufshpb_suspend (struct ufs_hba *hba); -void ufshpb_reset (struct ufs_hba *hba); -void ufshpb_reset_host (struct ufs_hba *hba); +void ufshpb_toggle (struct ufs_hba *hba,enum UFSHPB_STATE src,enum UFSHPB_STATE dest);void ufshpb_init (struct ufs_hba *hba);void ufshpb_init_hpb_lu (struct ufs_hba *hba,struct scsi_device *sdev);void ufshpb_destroy_lu (struct ufs_hba *hba,struct scsi_device *sdev);
Signature · 1 line
2.34.1
PATCH 2/4 scsi: ufshpb: Remove 0 assignment for enum value
In reply to Bean HuoFrom: Bean Huo <[email protected]>
If the first enumerator has no initializer, the value of the corresponding constant is zero.
--- drivers/scsi/ufs/ufshpb.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/ufs/ufshpb.h +2 -2
@@ -59,8 +59,8 @@ enum UFSHPB_MODE { };enum UFSHPB_STATE { -HPB_INIT =0 , -HPB_PRESENT =1 , +HPB_INIT , +HPB_PRESENT ,HPB_SUSPEND ,HPB_FAILED ,HPB_RESET ,
Signature · 1 line
2.34.1
PATCH 3/4 scsi: ufshpb: Cleanup the handler when device reset HPB information
In reply to Bean HuoFrom: Bean Huo <[email protected]>
"When the device is powered off by the host, the device may restore L2P map data upon power up or build from the host’s HPB READ command. In case device powered up and lost HPB information, device can signal to the host through HPB Sense data, by setting HPB Operation as ‘2’ which will inform the host that device reset HPB information."
This patch is to clean up the handler and make the intent of this handler more readable.
--- drivers/scsi/ufs/ufshpb.c | 35 +++++++++++++++++++++++------------ 1 file changed, 23 insertions(+), 12 deletions(-)
drivers/scsi/ufs/ufshpb.c +23 -12
@@ -1231,7 +1231,10 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb,queue_work (ufshpb_wq, &hpb->map_work); } -static void ufshpb_dev_reset_handler (struct ufshpb_lu *hpb) +/** +* Set the flags of all active regions to RGN_FLAG_UPDATE, letting the host reload its L2P entries. +*/ +static void ufshpb_set_region_update (struct ufshpb_lu *hpb) {struct victim_select_info *lru_info = &hpb->lru_info;struct ufshpb_region *rgn;
@@ -1245,6 +1248,24 @@ static void ufshpb_dev_reset_handler(struct ufshpb_lu *hpb)spin_unlock_irqrestore (&hpb->rgn_state_lock, flags); } +static void ufshpb_dev_reset_handler (struct ufs_hba *hba) +{ +struct scsi_device *sdev; +struct ufshpb_lu *hpb; + +__shost_for_each_device (sdev, hba->host) { + hpb =ufshpb_get_hpb_data (sdev); +if (hpb && hpb->is_hcm) +/* +* For the HPB host mode, in case device powered up and lost HPB +* information, we will set the region flag to be RGN_FLAG_UPDATE, +* it will let host reload its L2P entries(re-activate the region +* in the UFS device). +*/ +ufshpb_set_region_update (hpb); + } +} +/* * This function will parse recommended active subregion information in sense * data field of response UPIU with SAM_STAT_GOOD state.
@@ -1319,17 +1340,7 @@ void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)case HPB_RSP_DEV_RESET :dev_warn (&hpb->sdev_ufs_lu->sdev_dev,"UFS device lost HPB information during PM.\n" ); - -if (hpb->is_hcm) { -struct scsi_device *sdev; - -__shost_for_each_device (sdev, hba->host) { -struct ufshpb_lu *h = sdev->hostdata; - -if (h) -ufshpb_dev_reset_handler (h); - } - } +ufshpb_dev_reset_handler (hba);break ;default :
Signature · 1 line
2.34.1
PATCH 4/4 scsi: ufshpb: Add device reset HPB regions Infor handling for HPB device mode
In reply to Bean HuoFrom: Bean Huo <[email protected]>
In UFS HPB Spec JESD220-3A,
"5.8. Active and inactive information upon power cycle
...
When the device is powered off by the host, the device may restore L2P map data upon power up or build from the host’s HPB READ command. In case device powered up and lost HPB information, device can signal to the host through HPB Sense data, by setting HPB Operation as ‘2’ which will inform the host that device reset HPB information."
So, for the HPB device mode, if the UFS device is reset by the RST_N pin, the active regions's information in the device will be reset, and then the device will notify the host side that it is recommended to deactivate all active region in the host HPB memory.
--- drivers/scsi/ufs/ufshpb.c | 73 ++++++++++++++++++++++++++++----------- 1 file changed, 53 insertions(+), 20 deletions(-)
drivers/scsi/ufs/ufshpb.c +53 -20
@@ -1143,6 +1143,39 @@ static int ufshpb_add_region(struct ufshpb_lu *hpb, struct ufshpb_region *rgn)spin_unlock_irqrestore (&hpb->rgn_state_lock, flags);return ret; } +/** +*ufshpb_update_region_inactive - update a region to be deactivated later +*@hpb: per-LU HPB instance +*@region_index: the region index will be activated later +*/ +static void ufshpb_update_region_inactive (struct ufshpb_lu *hpb,int region_index) +{ +int subregion_index; +struct ufshpb_region *rgn; +struct ufshpb_subregion *srgn; + +/* +* Delete this region from acctive list and add it to inactive list +*/ +spin_lock (&hpb->rsp_list_lock); +ufshpb_update_inactive_info (hpb, region_index); +spin_unlock (&hpb->rsp_list_lock); + + rgn = hpb->rgn_tbl + region_index; + +/* +* Set subregion state to be HPB_SRGN_INVALID, there will no HPB read on this subregion +*/ +spin_lock (&hpb->rgn_state_lock); +if (rgn->rgn_state !=HPB_RGN_INACTIVE ) { +for (subregion_index =0 ; subregion_index < rgn->srgn_cnt; subregion_index++) { + srgn = rgn->srgn_tbl + subregion_index; +if (srgn->srgn_state ==HPB_SRGN_VALID ) + srgn->srgn_state =HPB_SRGN_INVALID ; + } + } +spin_unlock (&hpb->rgn_state_lock); +}static void ufshpb_rsp_req_region_update (struct ufshpb_lu *hpb,struct utp_hpb_rsp *rsp_field)
@@ -1202,25 +1235,8 @@ static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb,for (i =0 ; i < rsp_field->inactive_rgn_cnt; i++) { rgn_i =be16_to_cpu (rsp_field->hpb_inactive_field[i]); -dev_dbg (&hpb->sdev_ufs_lu->sdev_dev, -"inactivate(%d) region %d\n" , i, rgn_i); - -spin_lock (&hpb->rsp_list_lock); -ufshpb_update_inactive_info (hpb, rgn_i); -spin_unlock (&hpb->rsp_list_lock); - - rgn = hpb->rgn_tbl + rgn_i; - -spin_lock (&hpb->rgn_state_lock); -if (rgn->rgn_state !=HPB_RGN_INACTIVE ) { -for (srgn_i =0 ; srgn_i < rgn->srgn_cnt; srgn_i++) { - srgn = rgn->srgn_tbl + srgn_i; -if (srgn->srgn_state ==HPB_SRGN_VALID ) - srgn->srgn_state =HPB_SRGN_INVALID ; - } - } -spin_unlock (&hpb->rgn_state_lock); - +dev_dbg (&hpb->sdev_ufs_lu->sdev_dev,"inactivate(%d) region %d\n" , i, rgn_i); +ufshpb_update_region_inactive (hpb, rgn_i); } out:
@@ -1255,7 +1271,10 @@ static void ufshpb_dev_reset_handler(struct ufs_hba *hba)__shost_for_each_device (sdev, hba->host) { hpb =ufshpb_get_hpb_data (sdev); -if (hpb && hpb->is_hcm) +if (!hpb) +continue ; + +if (hpb->is_hcm) {/* * For the HPB host mode, in case device powered up and lost HPB * information, we will set the region flag to be RGN_FLAG_UPDATE,
@@ -1263,6 +1282,20 @@ static void ufshpb_dev_reset_handler(struct ufs_hba *hba)* in the UFS device). */ ufshpb_set_region_update (hpb); + }else { +/* +* For the HPB device mode, we add all active regions to inactive list, +* they will be inactivated later in ufshpb_map_work_handler() +*/ +struct victim_select_info *lru_info = &hpb->lru_info; +struct ufshpb_region *rgn; + +list_for_each_entry (rgn, &lru_info->lh_lru_rgn, list_lru_rgn) +ufshpb_update_region_inactive (hpb, rgn->rgn_idx); + +if (ufshpb_get_state (hpb) ==HPB_PRESENT ) +queue_work (ufshpb_wq, &hpb->map_work); + } } }
Signature · 1 line
2.34.1
Quoted 4 lines
From: Bean Huo <[email protected]>
*** BLURB HERE ***
Forgot to paste your cover letter.
Thanks,
Avri