Skip to contentSkip to conversation

clk: bcm: rpi: Add support for two more clocks

PATCH Superseded Ivan T. Ivanov 1 participant 3 messages Apr 19, 2022

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover clk: bcm: rpi: Add support for two more clocks

Add missing clock required by RPiVid video decoder and make HDMI pixel clock more reliable.

Changes since v2
- Added Acks from Maxime Ripard and Dave Stevenson

Changes since v1
- Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
- Rework downstream changes on top of recent Maxime changes.

Ivan T. Ivanov (2):
clk: bcm: rpi: Add support HEVC clock
clk: bcm: rpi: Handle pixel clock in firmware

 drivers/clk/bcm/clk-raspberrypi.c | 6 ++++++
 1 file changed, 6 insertions(+)
Signature · 1 line
2.34.1
#1 lore raw

PATCH v3 1/2 clk: bcm: rpi: Add support HEVC clock

Export clock required for RPiVid video decoder hardware.

---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/bcm/clk-raspberrypi.c +3 -0
index 9d09621549b9..2e2491d85835 100644
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_HEVC_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
 		.export = true,
 	},
Signature · 1 line
2.34.1
#2 lore raw

PATCH v3 2/2 clk: bcm: rpi: Handle pixel clock in firmware

In reply to Ivan T. Ivanov

The clk-bcm2835 handling of the pixel clock does not function correctly when the HDMI power domain is disabled.

The firmware supports it correctly, so add it to the firmware clock driver.

---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/bcm/clk-raspberrypi.c +3 -0
index 2e2491d85835..530820d13104 100644
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_PIXEL_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_HEVC_CLK_ID] = {
 		.export = true,
 	},
Signature · 1 line
2.34.1