Skip to contentSkip to conversation

Raspberry Pi Sense HAT driver

PATCH Superseded Charles Mirabile 9 participants 18 messages Apr 19, 2022 – Jun 23, 2022 1 message not in the archive

Subsystems (6)

v9 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

v9 cover Raspberry Pi Sense HAT driver

This patch series adds a set of drivers for operating the Sense HAT peripheral device. This board is an add on for the Raspberry Pi that is designed to connect using the GPIO connector and communicate via I2C.

It features:
- a joystick
- an 8x8 RGB LED matrix display
- a whole bunch of environmental sensors with their own drivers (those are already in upstream Linux)

This is a refactor of the work of Serge Schneider, the author of a version of this driver that is currently in the Raspberry Pi downstream kernel. We modified his code to make it suitable for upstream Linux.

A couple of tests are available for the driver in the test folder in this repo: https://github.com/underground-software/sensehat.git
- sensehat_joystick_test logs the input events from the joystick to the console
- sensehat_display_test displays various solid colors on the LED panel.
- full_sensehat_test displays a single lit cell that can be moved with the joystick. Pressing the joystick ends the program.

For more information about the Sense HAT, visit:
https://www.raspberrypi.org/products/sense-hat/

Changes since v8:
- Fixed a few small things in the device tree bindings. I forgot to include the fact that Rob Herring had already reviewed them when I posted v8, so Krzysztof Kozlowski jumped in and offered his input. The suggestions were good so we decided to include them. Sorry for the confusion.
- Corrected a typo in the description of the display driver. The format of the special file used by the driver was changed in v8 and this was described in the cover letter of the patch, but not in the actual note attached to that patch. This is now fixed.

Charles Mirabile (6):
drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick
driver
drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema
MAINTAINERS: Add sensehat driver authors to MAINTAINERS DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4

 .../raspberrypi,sensehat-display.yaml         |  27 +++
 .../input/raspberrypi,sensehat-joystick.yaml  |  32 +++
 .../bindings/mfd/raspberrypi,sensehat.yaml    |  58 +++++
 MAINTAINERS                                   |  11 +
 drivers/auxdisplay/Kconfig                    |   8 +
 drivers/auxdisplay/Makefile                   |   1 +
 drivers/auxdisplay/sensehat-display.c         | 205 ++++++++++++++++++
 drivers/input/joystick/Kconfig                |  11 +
 drivers/input/joystick/Makefile               |   1 +
 drivers/input/joystick/sensehat-joystick.c    | 137 ++++++++++++
 drivers/mfd/simple-mfd-i2c.c                  |   1 +
 sensehat.dtbs                                 |  52 +++++
 12 files changed, 544 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
 create mode 100644 Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
 create mode 100644 drivers/auxdisplay/sensehat-display.c
 create mode 100644 drivers/input/joystick/sensehat-joystick.c
 create mode 100644 sensehat.dtbs
Signature · 1 line
2.31.1
#1 lore raw

PATCH v9 1/6 drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c

This patch adds the compatible string for the Sense HAT device to the list of compatible strings in the simple_mfd_i2c driver so that it can match against the device and load its children and their drivers

---
 drivers/mfd/simple-mfd-i2c.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mfd/simple-mfd-i2c.c +1 -0
index f4c8fc3ee463..c47f36581f3f 100644
@@ -75,6 +75,7 @@ static const struct simple_mfd_data silergy_sy7636a = {
 static const struct of_device_id simple_mfd_i2c_of_match[] = {
 	{ .compatible = "kontron,sl28cpld" },
 	{ .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
+	{ .compatible = "raspberrypi,sensehat" },
 	{}
 };
 MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match);
Signature · 1 line
2.31.1
#2 lore raw

PATCH v9 2/6 drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver

In reply to Charles Mirabile

This patch adds the driver for the Sense HAT joystick. It outputs BTN_DPAD key events when moved in any of the four directions and the BTN_SELECT event when depressed.

---
 drivers/input/joystick/Kconfig             |  11 ++
 drivers/input/joystick/Makefile            |   1 +
 drivers/input/joystick/sensehat-joystick.c | 137 +++++++++++++++++++++
 3 files changed, 149 insertions(+)
 create mode 100644 drivers/input/joystick/sensehat-joystick.c
drivers/input/joystick/Kconfig +11 -0
index 3b23078bc7b5..505a032e2786 100644
@@ -399,4 +399,15 @@ config JOYSTICK_N64
 	  Say Y here if you want enable support for the four
 	  built-in controller ports on the Nintendo 64 console.
 
+config JOYSTICK_SENSEHAT
+	tristate "Raspberry Pi Sense HAT joystick"
+	depends on INPUT && I2C
+	select MFD_SIMPLE_MFD_I2C
+	help
+	  Say Y here if you want to enable the driver for the
+	  the Raspberry Pi Sense HAT.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called sensehat_joystick.
+
 endif
drivers/input/joystick/Makefile +1 -0
index 5174b8aba2dd..39c8b5c6e5ae 100644
@@ -28,6 +28,7 @@ obj-$(CONFIG_JOYSTICK_N64)		+= n64joy.o
 obj-$(CONFIG_JOYSTICK_PSXPAD_SPI)	+= psxpad-spi.o
 obj-$(CONFIG_JOYSTICK_PXRC)		+= pxrc.o
 obj-$(CONFIG_JOYSTICK_QWIIC)		+= qwiic-joystick.o
+obj-$(CONFIG_JOYSTICK_SENSEHAT)         += sensehat-joystick.o
 obj-$(CONFIG_JOYSTICK_SIDEWINDER)	+= sidewinder.o
 obj-$(CONFIG_JOYSTICK_SPACEBALL)	+= spaceball.o
 obj-$(CONFIG_JOYSTICK_SPACEORB)		+= spaceorb.o
drivers/input/joystick/sensehat-joystick.c new file +137 -0

137 lines not on this page · raw message

Signature · 1 line
2.31.1
#3 lore raw

Re: [PATCH v9 2/6] drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver

Hi--

drivers/input/joystick/Kconfig config JOYSTICK_N64 · line 405

Quoted 12 lines · Charles Mirabile
drivers/input/joystick/Kconfig +4 -0
index 3b23078bc7b5..505a032e2786 100644
@@ -399,4 +399,15 @@ config JOYSTICK_N64
 	  Say Y here if you want enable support for the four
 	  built-in controller ports on the Nintendo 64 console.
 
+config JOYSTICK_SENSEHAT
+	tristate "Raspberry Pi Sense HAT joystick"
+	depends on INPUT && I2C
+	select MFD_SIMPLE_MFD_I2C

Looks like this also needs
depends on HAS_IOMEM

since everything in drivers/mfd/Kconfig depends on HAS_IOMEM and since this 'select' causes a kconfig warning when HAS_IOMEM is not set:

WARNING: unmet direct dependencies detected for MFD_SIMPLE_MFD_I2C
Depends on [n]: HAS_IOMEM [=n] && I2C [=y]
Selected by [y]:
- JOYSTICK_SENSEHAT [=y] && INPUT_JOYSTICK [=y] && INPUT [=y] && I2C [=y]

drivers/input/joystick/Kconfig config JOYSTICK_N64 · line 413

Quoted 8 lines
drivers/input/joystick/Kconfig +7 -0
+	help
+	  Say Y here if you want to enable the driver for the
+	  the Raspberry Pi Sense HAT.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called sensehat_joystick.
+
 endif

Thanks.

maintainer
#4 lore raw

Re: [PATCH v9 2/6] drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver

Hi Randy,

Quoted 19 lines · Randy Dunlap

Hi--

drivers/input/joystick/Kconfig config JOYSTICK_N64 · line 405

Quoted 12 lines · Charles Mirabile
drivers/input/joystick/Kconfig +4 -0
index 3b23078bc7b5..505a032e2786 100644
@@ -399,4 +399,15 @@ config JOYSTICK_N64
 	  Say Y here if you want enable support for the four
 	  built-in controller ports on the Nintendo 64 console.
 
+config JOYSTICK_SENSEHAT
+	tristate "Raspberry Pi Sense HAT joystick"
+	depends on INPUT && I2C
+	select MFD_SIMPLE_MFD_I2C

Looks like this also needs
depends on HAS_IOMEM

Quoted 7 lines

since everything in drivers/mfd/Kconfig depends on HAS_IOMEM and since this 'select' causes a kconfig warning when HAS_IOMEM is not set:

WARNING: unmet direct dependencies detected for MFD_SIMPLE_MFD_I2C
Depends on [n]: HAS_IOMEM [=n] && I2C [=y]
Selected by [y]:
- JOYSTICK_SENSEHAT [=y] && INPUT_JOYSTICK [=y] && INPUT [=y] && I2C [=y]

Do you mind sending a patch?

Thanks.

Signature · 1 line
Dmitry
#5 lore raw

Re: [PATCH v9 2/6] drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick driver

Quoted 25 lines · Dmitry Torokhov

Hi Randy,

Quoted 22 lines · Randy Dunlap

Hi--

drivers/input/joystick/Kconfig config JOYSTICK_N64 · line 405

Quoted 12 lines · Charles Mirabile
drivers/input/joystick/Kconfig +4 -0
index 3b23078bc7b5..505a032e2786 100644
@@ -399,4 +399,15 @@ config JOYSTICK_N64
 	  Say Y here if you want enable support for the four
 	  built-in controller ports on the Nintendo 64 console.
 
+config JOYSTICK_SENSEHAT
+	tristate "Raspberry Pi Sense HAT joystick"
+	depends on INPUT && I2C
+	select MFD_SIMPLE_MFD_I2C

Looks like this also needs
depends on HAS_IOMEM

since everything in drivers/mfd/Kconfig depends on HAS_IOMEM and since this 'select' causes a kconfig warning when HAS_IOMEM is not set:

Quoted 6 lines
Quoted 4 lines

WARNING: unmet direct dependencies detected for MFD_SIMPLE_MFD_I2C
Depends on [n]: HAS_IOMEM [=n] && I2C [=y]
Selected by [y]:
- JOYSTICK_SENSEHAT [=y] && INPUT_JOYSTICK [=y] && INPUT [=y] && I2C [=y]

Do you mind sending a patch?

OK, will do.

Signature · 1 line
~Randy
#6 lore raw

PATCH v9 3/6 drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver

In reply to Charles Mirabile

This patch adds the driver for the 8x8 RGB LED matrix display on the Sense HAT. It appears as a character device named sense-hat in /dev/. That special file is 192 bytes large and contains 64 RGB triplets (3 bytes each) one for each pixel in row major order.

---
 drivers/auxdisplay/Kconfig            |   8 +
 drivers/auxdisplay/Makefile           |   1 +
 drivers/auxdisplay/sensehat-display.c | 205 ++++++++++++++++++++++++++
 3 files changed, 214 insertions(+)
 create mode 100644 drivers/auxdisplay/sensehat-display.c
drivers/auxdisplay/Kconfig +8 -0
index 64012cda4d12..9bad1aade7a0 100644
@@ -203,6 +203,14 @@ config ARM_CHARLCD
 	  line and the Linux version on the second line, but that's
 	  still useful.
 
+config SENSEHAT_DISPLAY
+	tristate "Raspberry Pi Sense HAT display driver"
+	depends on I2C
+	select MFD_SIMPLE_MFD_I2C
+	help
+	 This is a driver for the Raspberry Pi Sensehat 8x8 RBG-LED matrix
+	 you can access it as a misc device at /dev/sense-hat
+
 menuconfig PARPORT_PANEL
 	tristate "Parallel port LCD/Keypad Panel support"
 	depends on PARPORT
drivers/auxdisplay/Makefile +1 -0
index 6968ed4d3f0a..30b2b7934046 100644
@@ -14,3 +14,4 @@ obj-$(CONFIG_HT16K33)		+= ht16k33.o
 obj-$(CONFIG_PARPORT_PANEL)	+= panel.o
 obj-$(CONFIG_LCD2S)		+= lcd2s.o
 obj-$(CONFIG_LINEDISP)		+= line-display.o
+obj-$(CONFIG_SENSEHAT_DISPLAY)	+= sensehat-display.o
drivers/auxdisplay/sensehat-display.c new file +205 -0

205 lines not on this page · raw message

Signature · 1 line
2.31.1
#7 lore raw

Re: [PATCH v9 3/6] drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver

Hi!

Quoted 4 lines

This patch adds the driver for the 8x8 RGB LED matrix display on the Sense HAT. It appears as a character device named sense-hat in /dev/. That special file is 192 bytes large and contains 64 RGB triplets (3 bytes each) one for each pixel in row major order.

Is that right interface? Should we treat it as a tiny framebuffer, instead?

Best regards,
Pavel

Signature · 7 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#8 lore raw

PATCH v9 4/6 dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema

In reply to Charles Mirabile

This patch adds the device tree bindings for the Sense HAT and each of its children devices in yaml form.

---
 .../raspberrypi,sensehat-display.yaml         | 27 +++++++++
 .../input/raspberrypi,sensehat-joystick.yaml  | 32 ++++++++++
 .../bindings/mfd/raspberrypi,sensehat.yaml    | 58 +++++++++++++++++++
 3 files changed, 117 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
 create mode 100644 Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml new file +27 -0
new file mode 100644
index 000000000000..5e41d6b7817d
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/auxdisplay/raspberrypi,sensehat-display.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Raspberry Pi Sensehat Display
+
+maintainers:
+  - Charles Mirabile <[email protected]>
+  - Mwesigwa Guma <[email protected]>
+  - Joel Savitz <[email protected]>
+
+description:
+  This device is part of the sensehat multi function device.
+  For more information see ../mfd/raspberrypi,sensehat.yaml.
+
+  This device features a programmable 8x8 RGB LED matrix.
+
+properties:
+  compatible:
+    const: raspberrypi,sensehat-display
+
+required:
+  - compatible
+
+additionalProperties: false
Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml new file +32 -0
new file mode 100644
index 000000000000..2c8bc10e6436
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/raspberrypi,sensehat-joystick.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Raspberry Pi Sensehat Joystick
+
+maintainers:
+  - Charles Mirabile <[email protected]>
+  - Mwesigwa Guma <[email protected]>
+  - Joel Savitz <[email protected]>
+
+description:
+  This device is part of the sensehat multi function device.
+  For more information see ../mfd/raspberrypi,sensehat.yaml.
+
+  This device features a five button joystick (up, down,left,
+  right, click)
+
+properties:
+  compatible:
+    const: raspberrypi,sensehat-joystick
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - interrupts
+
+additionalProperties: false
Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml new file +58 -0

58 lines not on this page · raw message

Signature · 1 line
2.31.1
Reviewed-by on v9 4/6
#9 lore raw

Re: [PATCH v9 4/6] dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema

Quoted 9 lines · Charles Mirabile

This patch adds the device tree bindings for the Sense HAT and each of its children devices in yaml form.

---

Best regards,
Krzysztof

#10 lore raw

PATCH v9 5/6 MAINTAINERS: Add sensehat driver authors to MAINTAINERS

In reply to Charles Mirabile

This patch adds the driver authors to MAINAINERS.

---
 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)
MAINTAINERS +11 -0
index 40fa1955ca3f..b93f060322a3 100644
@@ -17747,6 +17747,17 @@ F:	Documentation/ABI/testing/sysfs-bus-iio-chemical-sunrise-co2
 F:	Documentation/devicetree/bindings/iio/chemical/senseair,sunrise.yaml
 F:	drivers/iio/chemical/sunrise_co2.c
 
+SENSEHAT DRIVER
+M:	Charles Mirabile <[email protected]>
+M:	Mwesigwa Guma <[email protected]>
+M:	Joel Savitz <[email protected]>
+S:	Maintained
+F:	Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
+F:	Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
+F:	Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
+F:	drivers/auxdisplay/sensehat-display.c
+F:	drivers/input/joystick/sensehat-joystick.c
+
 SENSIRION SCD30 CARBON DIOXIDE SENSOR DRIVER
 M:	Tomasz Duszynski <[email protected]>
 S:	Maintained
Signature · 1 line
2.31.1
#11 lore raw

PATCH v9 6/6 DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4

In reply to Charles Mirabile

This patch shold not be merged - dtbs files are not stored in the kernel tree. We just provide this file so the code can be tested.

This overlay is suitable for testing the driver, it can be compiled with dtc and put in the /boot/overlays/ folder then specified in config.txt by putting the lines:

dtoverlay= #suppress loading of default overlay for HAT
dtoverlay=sensehat #load custom overlay

at the beginning before any other lines in config.txt

---
 sensehat.dtbs | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 sensehat.dtbs
sensehat.dtbs new file +52 -0
new file mode 100644
index 000000000000..9e5a6d9229b1
@@ -0,0 +1,52 @@
+/dts-v1/;
+/plugin/;
+
+/ {
+	compatible = "brcm,bcm2835";
+};
+
+&i2c1 {
+	#address-cells = <0x01>;
+	#size-cells = <0x00>;
+	status = "okay";
+
+	sensehat@46 {
+		compatible = "raspberrypi,sensehat";
+		reg = <0x46>;
+		interrupt-parent = <&gpio>;
+		status = "okay";
+		display {
+			compatible = "raspberrypi,sensehat-display";
+			status = "okay";
+		};
+		joystick {
+			compatible = "raspberrypi,sensehat-joystick";
+			interrupts = <23 1>;
+			status = "okay";
+		};
+	};
+
+	lsm9ds1-magn@1c {
+		compatible = "st,lsm9ds1-magn";
+		reg = <0x1c>;
+		status = "okay";
+	};
+
+	lsm9ds1-accel@6a {
+		compatible = "st,lsm9ds1-accel";
+		reg = <0x6a>;
+		status = "okay";
+	};
+
+	lps25h-press@5c {
+		compatible = "st,lps25h-press";
+		reg = <0x5c>;
+		status = "okay";
+	};
+
+	hts221-humid@5f {
+		compatible = "st,hts221-humid\0st,hts221";
+		reg = <0x5f>;
+		status = "okay";
+	};
+};
Signature · 1 line
2.31.1
#12 lore raw
In reply to Charles Mirabile
Quoted 4 lines · Charles Mirabile

This patch series adds a set of drivers for operating the Sense HAT peripheral device. This board is an add on for the Raspberry Pi that is designed to connect using the GPIO connector and communicate via I2C.

Is there any feedback left to address? Which tree should take this?

Thanks for your work upstreaming this!

Cheers,
Miguel

A message that is not in the archive (sent off-list or not yet received): CABe3_aE-nQzZazLfxk1OnCNRF0sDqcWi6gieYSf4O4aYS_Ahog@mail.gmail.com

#14 lore raw

Hi Charles, Miguel,

Quoted 7 lines · Charles Mirabile

Hi Miguel—

Thanks for your help in reviewing this patch. I think all of the feedback is cleared up.

I am not sure which tree this should go into, but maybe the Raspberry Pi tree maintained by Nicolas Saenz Julienne (git://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-
rpi.git)? What do you think? Thanks!

Since there is no code dependency between the different drivers/patches I suggest for each patch to go through its respective maintainer tree. Also, if we were to move the whole series through as single tree, it's important to have ACKs from all the subsystem maintainers.

I'll do a last review during the week.

Regards,

Signature · 7 lines
Nicolás Sáenz


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#15 lore raw

Am 26.04.22 um 12:18 schrieb Nicolas Saenz Julienne:

Quoted 7 lines

Hi Charles, Miguel,

Quoted 4 lines · Charles Mirabile

Hi Miguel—

Thanks for your help in reviewing this patch. I think all of the feedback is cleared up.

Quoted 7 lines
Quoted 3 lines

I am not sure which tree this should go into, but maybe the Raspberry Pi tree maintained by Nicolas Saenz Julienne (git://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-
rpi.git)? What do you think? Thanks!

Since there is no code dependency between the different drivers/patches I suggest for each patch to go through its respective maintainer tree. Also, if we were to move the whole series through as single tree, it's important to have ACKs from all the subsystem maintainers.

Yes, we still need a Ack of Rob for the device tree bindings. Please give him the common 2 weeks for a review.

Quoted 5 lines

I'll do a last review during the week.

Regards,

#16 lore raw
Quoted 8 lines · Stefan Wahren

Am 26.04.22 um 12:18 schrieb Nicolas Saenz Julienne:

Quoted 7 lines

Hi Charles, Miguel,

Quoted 4 lines · Charles Mirabile

Hi Miguel—

Thanks for your help in reviewing this patch. I think all of the feedback is cleared up.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

I am not sure which tree this should go into, but maybe the Raspberry Pi tree maintained by Nicolas Saenz Julienne (git://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-
rpi.git)? What do you think? Thanks!

Since there is no code dependency between the different drivers/patches I suggest for each patch to go through its respective maintainer tree. Also, if we were to move the whole series through as single tree, it's important to have ACKs from all the subsystem maintainers.

Yes, we still need a Ack of Rob for the device tree bindings. Please give him the common 2 weeks for a review.

You have one from Krzysztof on the bindings, that should be sufficient?

https://docs.kernel.org/process/maintainers.html#open-firmware-and-flattened-device-tree-bindings

Quoted 5 lines
Quoted 5 lines

I'll do a last review during the week.

Regards,

#17 lore raw

Am 26.04.22 um 14:03 schrieb [email protected]:

Quoted 12 lines · Stefan Wahren
Quoted 11 lines

Am 26.04.22 um 12:18 schrieb Nicolas Saenz Julienne:

Quoted 10 lines

Hi Charles, Miguel,

Quoted 7 lines · Charles Mirabile

Hi Miguel—

Thanks for your help in reviewing this patch. I think all of the feedback is cleared up.

I am not sure which tree this should go into, but maybe the Raspberry Pi tree maintained by Nicolas Saenz Julienne (git://git.kernel.org/pub/scm/linux/kernel/git/nsaenz/linux-
rpi.git)? What do you think? Thanks!

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

Since there is no code dependency between the different drivers/patches I suggest for each patch to go through its respective maintainer tree. Also, if we were to move the whole series through as single tree, it's important to have ACKs from all the subsystem maintainers.

Yes, we still need a Ack of Rob for the device tree bindings. Please give him the common 2 weeks for a review.

You have one from Krzysztof on the bindings, that should be sufficient?

https://docs.kernel.org/process/maintainers.html#open-firmware-and-flattened-device-tree-bindings

Yes, you are right

Quoted 9 lines
Quoted 5 lines
Quoted 5 lines

I'll do a last review during the week.

Regards,

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#18 lore raw
In reply to Charles Mirabile

Hi Charles,

Am 19.04.22 um 22:51 schrieb Charles Mirabile:

Quoted 47 lines

This patch series adds a set of drivers for operating the Sense HAT peripheral device. This board is an add on for the Raspberry Pi that is designed to connect using the GPIO connector and communicate via I2C.

It features:
- a joystick
- an 8x8 RGB LED matrix display
- a whole bunch of environmental sensors with their own drivers (those are already in upstream Linux)

This is a refactor of the work of Serge Schneider, the author of a version of this driver that is currently in the Raspberry Pi downstream kernel. We modified his code to make it suitable for upstream Linux.

A couple of tests are available for the driver in the test folder in this repo: https://github.com/underground-software/sensehat.git
- sensehat_joystick_test logs the input events from the joystick to the console
- sensehat_display_test displays various solid colors on the LED panel.
- full_sensehat_test displays a single lit cell that can be moved with the joystick. Pressing the joystick ends the program.

For more information about the Sense HAT, visit:
https://www.raspberrypi.org/products/sense-hat/

Changes since v8:
- Fixed a few small things in the device tree bindings. I forgot to include the fact that Rob Herring had already reviewed them when I posted v8, so Krzysztof Kozlowski jumped in and offered his input. The suggestions were good so we decided to include them. Sorry for the confusion.
- Corrected a typo in the description of the display driver. The format of the special file used by the driver was changed in v8 and this was described in the cover letter of the patch, but not in the actual note attached to that patch. This is now fixed.

Quoted 8 lines

Charles Mirabile (6):
drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick
driver
drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema
MAINTAINERS: Add sensehat driver authors to MAINTAINERS DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4

since only the joystick patch has been applied, could you please send a rebased v10 without the joystick driver?

Please take care of the fact that Florian is the new BCM2835 maintainer.

Thanks