Skip to contentSkip to conversation

imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

PATCH In review Ying-Chun Liu 3 participants 4 messages Apr 20, 2022 – Apr 22, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

v2 cover imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

From: "Ying-Chun Liu (PaulLiu)" <[email protected]>

Previously there's no implementation of board_fix_fdt(). But commit 35bb60787b88 introduced one in arch/arm/mach-imx/imx8m/soc.c. Since the board_fix_fdt() in imx8mm-cl-iot-gate is empty, we should remove it and use the one from soc.c.

v2: reword commit comment

Ying-Chun Liu (PaulLiu) (1):
imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

 board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 5 -----
 1 file changed, 5 deletions(-)
Signature · 1 line
2.35.1
#1 lore raw

PATCH v2 1/1 imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

From: "Ying-Chun Liu (PaulLiu)" <[email protected]>

In arch/arm/mach-imx/imx8m/soc.c there's an implementation of board_fix_fdt() introduced by commit 35bb60787b88. Remove the redundant one to avoid failed to build from source when enabling CONFIG_OF_BOARD_FIXUP.

---
v2: reword commit comment

---
 board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 5 -----
 1 file changed, 5 deletions(-)
board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c +0 -5
index e6021a4566..3d7fff34d2 100644
@@ -335,11 +335,6 @@ static int iot_gate_imx8_update_ext_ied(void)
 	return 0;
 }
 
-int board_fix_fdt(void *rw_fdt_blob)
-{
-	return 0;
-}
-
 int extension_board_scan(struct list_head *extension_list)
 {
 	struct extension *extension = NULL;
Signature · 1 line
2.35.1
reviewer Reviewed-by on v2 1/1
#2 lore raw

Hi Paul,

Quoted 8 lines · Ying-Chun Liu

From: "Ying-Chun Liu (PaulLiu)" <[email protected]>

In arch/arm/mach-imx/imx8m/soc.c there's an implementation of board_fix_fdt() introduced by commit 35bb60787b88. Remove the redundant one to avoid failed to build from source when enabling CONFIG_OF_BOARD_FIXUP.

Quoted 5 lines

---
v2: reword commit comment

This version looks good:

#3 lore raw

PATCH v2 1/1 imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

In reply to Ying-Chun Liu
Quoted 9 lines

From: "Ying-Chun Liu (PaulLiu)" <[email protected]> In arch/arm/mach-imx/imx8m/soc.c there's an implementation of board_fix_fdt() introduced by commit 35bb60787b88. Remove the redundant one to avoid failed to build from source when enabling CONFIG_OF_BOARD_FIXUP.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================