Skip to contentSkip to conversation

imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

PATCH Superseded Ying-Chun Liu 2 participants 3 messages Apr 20, 2022 Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

From: "Ying-Chun Liu (PaulLiu)" <[email protected]>

Previously there's no implementation of board_fix_fdt(). But recently there's one in arch/arm/mach-imx/imx8m/soc.c. Since the board_fix_fdt() in imx8mm-cl-iot-gate is empty, we should remove it and use the one from soc.c.

Ying-Chun Liu (PaulLiu) (1):
imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

 board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 5 -----
 1 file changed, 5 deletions(-)
Signature · 1 line
2.35.1
#1 lore raw

PATCH 1/1 imx8mm-cl-iot-gate: Remove redundant board_fix_fdt()

From: "Ying-Chun Liu (PaulLiu)" <[email protected]>

In arch/arm/mach-imx/imx8m/soc.c there's an implementation of board_fix_fdt(). Remove the redundant one to avoid FTBFS.

---
 board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 5 -----
 1 file changed, 5 deletions(-)
board/compulab/imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c +0 -5
index e6021a4566..3d7fff34d2 100644
@@ -335,11 +335,6 @@ static int iot_gate_imx8_update_ext_ied(void)
 	return 0;
 }
 
-int board_fix_fdt(void *rw_fdt_blob)
-{
-	return 0;
-}
-
 int extension_board_scan(struct list_head *extension_list)
 {
 	struct extension *extension = NULL;
Signature · 1 line
2.35.1
reviewer
#2 lore raw

Hi Paul,

Quoted 4 lines · Ying-Chun Liu

From: "Ying-Chun Liu (PaulLiu)" <[email protected]>

In arch/arm/mach-imx/imx8m/soc.c there's an implementation of

Please mention that commit 35bb60787b88 ("imx: imx8mp: disable fused IP for UltraLite")
was the one that introduced board_fix_fdt() in arch/arm/mach-imx/imx8m/soc.c.

Quoted 1 line

board_fix_fdt(). Remove the redundant one to avoid FTBFS.

Sorry, what does FTBFS mean?