Skip to contentSkip to conversation

ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM

PATCH In review Marek Vasut 4 participants 8 messages May 1, 2022 – May 10, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM

The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM may be extended with other MAC options connected to FMC2 bus, like the DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the packet buffers of such limited MACs, which leads to e.g. TFTP timeouts. This also avoids receiving a short packet fragment at the end of each TFTP block, which led to reduced performance.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Ramon Fried <[email protected]>
---
 configs/stm32mp15_dhcom_basic_defconfig | 1 -
 configs/stm32mp15_dhcor_basic_defconfig | 1 -
 2 files changed, 2 deletions(-)
configs/stm32mp15_dhcom_basic_defconfig +0 -1
index ec955eae200..0ff015cae49 100644
@@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
configs/stm32mp15_dhcor_basic_defconfig +0 -1
index 387e068155e..83614b9fc8e 100644
@@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
Signature · 1 line
2.35.1
#1 lore raw

PATCH 2/2 ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM

Long TFTP transfers lead to a wall of # characters on UART, which in the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to print progress in fewer # characters.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Ramon Fried <[email protected]>
---
 configs/stm32mp15_dhcom_basic_defconfig | 1 +
 configs/stm32mp15_dhcor_basic_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/stm32mp15_dhcom_basic_defconfig +1 -0
index 0ff015cae49..7f7aecf2510 100644
@@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
configs/stm32mp15_dhcor_basic_defconfig +1 -0
index 83614b9fc8e..35e43a9a2fc 100644
@@ -77,6 +77,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
Signature · 1 line
2.35.1
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM

Quoted 39 lines · Marek Vasut

Long TFTP transfers lead to a wall of # characters on UART, which in the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to print progress in fewer # characters.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Ramon Fried <[email protected]>
---
 configs/stm32mp15_dhcom_basic_defconfig | 1 +
 configs/stm32mp15_dhcor_basic_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/stm32mp15_dhcom_basic_defconfig +1 -0
index 0ff015cae49..7f7aecf2510 100644
@@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
configs/stm32mp15_dhcor_basic_defconfig +1 -1
index 83614b9fc8e..35e43a9a2fc 100644
@@ -77,6 +77,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
--
Quoted 2 lines

2.35.1

Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM

In reply to Marek Vasut

Hi,

Quoted 30 lines · Marek Vasut

Long TFTP transfers lead to a wall of # characters on UART, which in the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to print progress in fewer # characters.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Ramon Fried <[email protected]>
---
  configs/stm32mp15_dhcom_basic_defconfig | 1 +
  configs/stm32mp15_dhcor_basic_defconfig | 1 +
  2 files changed, 2 insertions(+)
configs/stm32mp15_dhcom_basic_defconfig +1 -0
index 0ff015cae49..7f7aecf2510 100644
@@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
  CONFIG_SPL_ENV_IS_NOWHERE=y
  CONFIG_NET_RANDOM_ETHADDR=y
  CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
  CONFIG_STM32_ADC=y
  CONFIG_SPL_BLOCK_CACHE=y
  CONFIG_DFU_MMC=y
configs/stm32mp15_dhcor_basic_defconfig +0 -0
index 83614b9fc8e..35e43a9a2fc 100644

configs/stm32mp15_dhcor_basic_defconfig CONFIG_SYS_RELOC_GD_ENV_ADDR=y · line 83

Quoted 7 lines
configs/stm32mp15_dhcor_basic_defconfig +1 -0
@@ -77,6 +77,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
  CONFIG_SPL_ENV_IS_NOWHERE=y
  CONFIG_NET_RANDOM_ETHADDR=y
  CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
  CONFIG_STM32_ADC=y
  CONFIG_SPL_BLOCK_CACHE=y
  CONFIG_DFU_MMC=y

Thanks
Patrick

#4 lore raw

Re: [PATCH 2/2] ARM: stm32: Use CONFIG_TFTP_TSIZE on DHSOM

In reply to Marek Vasut
Quoted 30 lines · Marek Vasut

Long TFTP transfers lead to a wall of # characters on UART, which in the end may slow down the transfer itself. Use CONFIG_TFTP_TSIZE to print progress in fewer # characters.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Ramon Fried <[email protected]>
---
 configs/stm32mp15_dhcom_basic_defconfig | 1 +
 configs/stm32mp15_dhcor_basic_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/stm32mp15_dhcom_basic_defconfig +1 -0
index 0ff015cae49..7f7aecf2510 100644
@@ -80,6 +80,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
configs/stm32mp15_dhcor_basic_defconfig +0 -0
index 83614b9fc8e..35e43a9a2fc 100644

configs/stm32mp15_dhcor_basic_defconfig CONFIG_SYS_RELOC_GD_ENV_ADDR=y · line 83

Quoted 7 lines
configs/stm32mp15_dhcor_basic_defconfig +1 -0
@@ -77,6 +77,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
+CONFIG_TFTP_TSIZE=y
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y

Applied to u-boot-stm32

Thanks
Patrice

Reviewed-by on v1 1/2
#5 lore raw
In reply to Marek Vasut
Quoted 43 lines · Marek Vasut

The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM may be extended with other MAC options connected to FMC2 bus, like the DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the packet buffers of such limited MACs, which leads to e.g. TFTP timeouts. This also avoids receiving a short packet fragment at the end of each TFTP block, which led to reduced performance.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Ramon Fried <[email protected]>
---
 configs/stm32mp15_dhcom_basic_defconfig | 1 -
 configs/stm32mp15_dhcor_basic_defconfig | 1 -
 2 files changed, 2 deletions(-)
configs/stm32mp15_dhcom_basic_defconfig +0 -1
index ec955eae200..0ff015cae49 100644
@@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
configs/stm32mp15_dhcor_basic_defconfig +0 -2
index 387e068155e..83614b9fc8e 100644
@@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_ENV_IS_NOWHERE=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
 CONFIG_STM32_ADC=y
 CONFIG_SPL_BLOCK_CACHE=y
 CONFIG_DFU_MMC=y
--
Quoted 2 lines

2.35.1

Reviewed-by on v1 1/2
#6 lore raw
In reply to Marek Vasut

Hi Marek,

Quoted 34 lines · Marek Vasut

The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM may be extended with other MAC options connected to FMC2 bus, like the DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the packet buffers of such limited MACs, which leads to e.g. TFTP timeouts. This also avoids receiving a short packet fragment at the end of each TFTP block, which led to reduced performance.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Ramon Fried <[email protected]>
---
  configs/stm32mp15_dhcom_basic_defconfig | 1 -
  configs/stm32mp15_dhcor_basic_defconfig | 1 -
  2 files changed, 2 deletions(-)
configs/stm32mp15_dhcom_basic_defconfig +0 -1
index ec955eae200..0ff015cae49 100644
@@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
  CONFIG_SPL_ENV_IS_NOWHERE=y
  CONFIG_NET_RANDOM_ETHADDR=y
  CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
  CONFIG_STM32_ADC=y
  CONFIG_SPL_BLOCK_CACHE=y
  CONFIG_DFU_MMC=y
configs/stm32mp15_dhcor_basic_defconfig +0 -0
index 387e068155e..83614b9fc8e 100644

configs/stm32mp15_dhcor_basic_defconfig CONFIG_SYS_RELOC_GD_ENV_ADDR=y · line 82

Quoted 7 lines
configs/stm32mp15_dhcor_basic_defconfig +0 -1
@@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
  CONFIG_SPL_ENV_IS_NOWHERE=y
  CONFIG_NET_RANDOM_ETHADDR=y
  CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
  CONFIG_STM32_ADC=y
  CONFIG_SPL_BLOCK_CACHE=y
  CONFIG_DFU_MMC=y

Thanks
Patrick

#7 lore raw
Quoted 49 lines · Patrick DELAUNAY

Hi Marek,

Quoted 34 lines · Marek Vasut

The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM may be extended with other MAC options connected to FMC2 bus, like the DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the packet buffers of such limited MACs, which leads to e.g. TFTP timeouts. This also avoids receiving a short packet fragment at the end of each TFTP block, which led to reduced performance.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Ramon Fried <[email protected]>

---
  configs/stm32mp15_dhcom_basic_defconfig | 1 -
  configs/stm32mp15_dhcor_basic_defconfig | 1 -

  2 files changed, 2 deletions(-)
configs/stm32mp15_dhcom_basic_defconfig +0 -0
index ec955eae200..0ff015cae49 100644
@@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y

  CONFIG_SPL_ENV_IS_NOWHERE=y
  CONFIG_NET_RANDOM_ETHADDR=y
  CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
  CONFIG_STM32_ADC=y
  CONFIG_SPL_BLOCK_CACHE=y
  CONFIG_DFU_MMC=y

configs/stm32mp15_dhcor_basic_defconfig +0 -0
index 387e068155e..83614b9fc8e 100644
@@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
Quoted 7 lines

  CONFIG_SPL_ENV_IS_NOWHERE=y
  CONFIG_NET_RANDOM_ETHADDR=y
  CONFIG_IP_DEFRAG=y
-CONFIG_TFTP_BLOCKSIZE=1536
  CONFIG_STM32_ADC=y
  CONFIG_SPL_BLOCK_CACHE=y
  CONFIG_DFU_MMC=y

Quoted 3 lines

Thanks
Patrick

Applied to u-boot-stm32

Thanks
Patrice