Add device tree for Intel n6000
v2 cover Add device tree for Intel n6000
From: Matthew Gerlach <[email protected]>
This patch set adds a device tree for the Hard Processor System (HPS) on an Agilex based Intel n6000 board.
Patch 1 defines the device tree binding for the HPS Copy Engine IP used to copy a bootable image from host memory to HPS DDR.
Patch 2 defines the binding for the Intel n6000 board itself.
Patch 3 adds the device tree for the n6000 board.
Changelog v1 -> v2:
- add dt binding for copy enging
- add dt binding for n6000 board
- fix copy engine node name
- fix compatible field for copy engine
- remove redundant status field
- add compatibility field for the board
- fix SPDX
- fix how osc1 clock frequency is set
Matthew Gerlach (3):
dt-bindings: misc: add bindings for Intel HPS Copy Engine
dt-bindings: intel: add binding for Intel n6000
arm64: dts: intel: add device tree for n6000
.../bindings/arm/intel,socfpga.yaml | 1 + .../bindings/misc/intel,hps-copy-engine.yaml | 48 ++++++++++++ arch/arm64/boot/dts/intel/Makefile | 3 +- .../boot/dts/intel/socfpga_agilex_n6000.dts | 76 +++++++++++++++++++ 4 files changed, 127 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
Signature · 1 line
2.25.1
PATCH v2 1/3 dt-bindings: misc: add bindings for Intel HPS Copy Engine
From: Matthew Gerlach <[email protected]>
Add device tree bindings documentation for the Intel Hard Processor System (HPS) Copy Engine.
--- .../bindings/misc/intel,hps-copy-engine.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +48 -0
@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (C) 2022, Intel Corporation +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/misc/intel,hps-copy-engine.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Intel HPS Copy Engine + +maintainers: + - Matthew Gerlach <[email protected]> + +description: | + The Intel Hard Processor System (HPS) Copy Engine is an IP block used to copy + a bootable image from host memory to HPS DDR. Additionally, there is a + register the HPS can use to indicate the state of booting the copied image as + well as a keep-a-live indication to the host. + +properties: + compatible: + items: + - const: intel,hps-copy-engine + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + agilex_hps_bridges: bus@80000000 { + compatible = "simple-bus"; + reg = <0x80000000 0x60000000>, + <0xf9000000 0x00100000>; + reg-names = "axi_h2f", "axi_h2f_lw"; + #address-cells = <0x2>; + #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>; + + hps_cp_eng@0 { + compatible = "intel,hps-copy-engine"; + reg = <0x00000000 0x00000000 0x00001000>; + }; + };
Signature · 1 line
2.25.1
Re: [PATCH v2 1/3] dt-bindings: misc: add bindings for Intel HPS Copy Engine
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml
Quoted 16 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add device tree bindings documentation for the Intel Hard Processor System (HPS) Copy Engine.
Signed-off-by Matthew Gerlach <[email protected]>--- .../bindings/misc/intel,hps-copy-engine.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yamlDocumentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +0
-0
Please find appropriate directory matching this hardware, not "misc". As a fallback SoC related bindings end up in "soc".
Quoted 12 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +11
-0@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (C) 2022, Intel Corporation +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/misc/intel,hps-copy-engine.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Intel HPS Copy Engine + +maintainers: + - Matthew Gerlach <[email protected]>
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 21
Quoted 10 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +10
-0+ +description: | + The Intel Hard Processor System (HPS) Copy Engine is an IP block used to copy + a bootable image from host memory to HPS DDR. Additionally, there is a + register the HPS can use to indicate the state of booting the copied image as + well as a keep-a-live indication to the host. + +properties: + compatible: + items:
No "items", you have just one item.
Quoted 4 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +4
-0+ - const: intel,hps-copy-engine + + reg: + maxItems: 1
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 35
Quoted 10 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +10
-0+ +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + agilex_hps_bridges: bus@80000000 {
Unused label...
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 40
Quoted 5 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +5
-0+ compatible = "simple-bus"; + reg = <0x80000000 0x60000000>, + <0xf9000000 0x00100000>; + reg-names = "axi_h2f", "axi_h2f_lw"; + #address-cells = <0x2>;
$ git grep address-cell Do not use inconsistent coding. The same applies to your DTS.
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 42
Quoted 2 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +2
-0+ #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>;
Why do you even need the simple-bus above and cannot put the device directly on the bus?
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 44
Quoted 2 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +2
-0+ + hps_cp_eng@0 {
No underscores in node names. Generic node name.
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 48
Quoted 4 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +4
-0+ compatible = "intel,hps-copy-engine"; + reg = <0x00000000 0x00000000 0x00001000>; + }; + };
Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: misc: add bindings for Intel HPS Copy Engine
Quoted 12 lines · Krzysztof Kozlowski
Quoted 11 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add device tree bindings documentation for the Intel Hard Processor System (HPS) Copy Engine.
Signed-off-by Matthew Gerlach <[email protected]>--- .../bindings/misc/intel,hps-copy-engine.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml
Quoted 8 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml
Quoted 5 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +0
-0Please find appropriate directory matching this hardware, not "misc". As a fallback SoC related bindings end up in "soc".
I thought misc seemed appropriate because it is a very specific IP block in the FPGA connected to the HPS. It does perform a simple DMA function; so I considered putting it in the dma directory, but it also has some hand-shaking registers between the HPS and a host processor connected to the
FPGA via PCIe; so I thought misc. Since the HPS "soc" accesses the component, I can put it in the "soc" directory, unless there is a better suggestion.
Quoted 17 lines
Quoted 17 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +15
-0@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (C) 2022, Intel Corporation +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/misc/intel,hps-copy-engine.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Intel HPS Copy Engine + +maintainers: + - Matthew Gerlach <[email protected]> + +description: | + The Intel Hard Processor System (HPS) Copy Engine is an IP block used to copy + a bootable image from host memory to HPS DDR. Additionally, there is a
Quoted 8 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 21
Quoted 6 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +6
-0+ register the HPS can use to indicate the state of booting the copied image as + well as a keep-a-live indication to the host. + +properties: + compatible: + items:No "items", you have just one item.
Got it. I will change it in v3.
Quoted 17 lines
Quoted 5 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +4
-0+ - const: intel,hps-copy-engine + + reg: + maxItems: 1Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 35
Quoted 10 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +10
-0+ +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + agilex_hps_bridges: bus@80000000 {Unused label...
I will remove unused label in v3.
Quoted 9 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 40
Quoted 6 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +5
-0+ compatible = "simple-bus"; + reg = <0x80000000 0x60000000>, + <0xf9000000 0x00100000>; + reg-names = "axi_h2f", "axi_h2f_lw"; + #address-cells = <0x2>;$ git grep address-cell Do not use inconsistent coding. The same applies to your DTS.
Is the inconsistency the use of '0x' in the values of #address-cells and #size-cells, or is the consistency having different values for #address-cells and #size-cells or both?
Quoted 6 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 42
Quoted 3 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +2
-0+ #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>;Why do you even need the simple-bus above and cannot put the device directly on the bus?
On an Agilex chip, the HPS is connected to the FPGA via two bridges, referred as the "HPS to FPGA bridge" and the "Lightweight HPS to FPGA bridge". An IP block in the FPGA could be connected to one or both of these bridges. I am anticipating device tree overlays being applied for other IP blocks instantiated in the FPGA.
Quoted 5 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 44
Quoted 3 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +2
-0+ + hps_cp_eng@0 {No underscores in node names. Generic node name.
I understand. I am considering dma@0 for the generic node name.
Quoted 10 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml line 48
Quoted 5 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +4
-0+ compatible = "intel,hps-copy-engine"; + reg = <0x00000000 0x00000000 0x00001000>; + }; + };Best regards,
Krzysztof
Thank you for the review,
Matthew
Re: [PATCH v2 1/3] dt-bindings: misc: add bindings for Intel HPS Copy Engine
Quoted 10 lines · On 05/05/2022 00:41, [email protected] wrote:
Quoted 2 lines
Please find appropriate directory matching this hardware, not "misc". As a fallback SoC related bindings end up in "soc".
I thought misc seemed appropriate because it is a very specific IP block in the FPGA connected to the HPS. It does perform a simple DMA function; so I considered putting it in the dma directory, but it also has some hand-shaking registers between the HPS and a host processor connected to the FPGA via PCIe; so I thought misc. Since the HPS "soc" accesses the component, I can put it in the "soc" directory, unless there is a better suggestion.
So let it be "soc".
Quoted 7 lines
Quoted 3 lines
$ git grep address-cell Do not use inconsistent coding. The same applies to your DTS.Is the inconsistency the use of '0x' in the values of #address-cells and #size-cells, or is the consistency having different values for #address-cells and #size-cells or both?
It's about "0x".
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +2
-0+ #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>;
Quoted 8 lines
Quoted 2 lines
Why do you even need the simple-bus above and cannot put the device directly on the bus?
On an Agilex chip, the HPS is connected to the FPGA via two bridges, referred as the "HPS to FPGA bridge" and the "Lightweight HPS to FPGA bridge". An IP block in the FPGA could be connected to one or both of these bridges. I am anticipating device tree overlays being applied for other IP blocks instantiated in the FPGA.
OK
Quoted 8 lines
Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +2
-0+ + hps_cp_eng@0 {No underscores in node names. Generic node name.
I understand. I am considering dma@0 for the generic node name.
Let's keep the same as in DTS.
Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: misc: add bindings for Intel HPS Copy Engine
Quoted 12 lines · Krzysztof Kozlowski
Quoted 10 lines · On 05/05/2022 00:41, [email protected] wrote:
Quoted 2 lines
Please find appropriate directory matching this hardware, not "misc". As a fallback SoC related bindings end up in "soc".
I thought misc seemed appropriate because it is a very specific IP block in the FPGA connected to the HPS. It does perform a simple DMA function; so I considered putting it in the dma directory, but it also has some hand-shaking registers between the HPS and a host processor connected to the FPGA via PCIe; so I thought misc. Since the HPS "soc" accesses the component, I can put it in the "soc" directory, unless there is a better suggestion.
Quoted 1 line
So let it be "soc".
I will move it to the soc directory.
Quoted 10 lines
Quoted 8 lines
Quoted 4 lines
$ git grep address-cell Do not use inconsistent coding. The same applies to your DTS.Is the inconsistency the use of '0x' in the values of #address-cells and #size-cells, or is the consistency having different values for #address-cells and #size-cells or both?
It's about "0x".
Got it. I will remove the 0x.
Quoted 19 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Documentation/devicetree/bindings/misc/intel,hps-copy-engine.yaml new file +2
-0+ #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>;Quoted 8 lines
Quoted 2 lines
Why do you even need the simple-bus above and cannot put the device directly on the bus?
On an Agilex chip, the HPS is connected to the FPGA via two bridges, referred as the "HPS to FPGA bridge" and the "Lightweight HPS to FPGA bridge". An IP block in the FPGA could be connected to one or both of these bridges. I am anticipating device tree overlays being applied for other IP blocks instantiated in the FPGA.
OK
Quoted 2 lines
Quoted 2 lines
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ + hps_cp_eng@0 {No underscores in node names. Generic node name.
I understand. I am considering dma@0 for the generic node name.
Let's keep the same as in DTS.
Yes, we want the example and the DTS to be the same. It will be called dma-controller@0.
Thank you for the feedback,
Matthew
Quoted 5 lines
Best regards,
Krzysztof
PATCH v2 2/3 dt-bindings: intel: add binding for Intel n6000
In reply to [email protected]From: Matthew Gerlach <[email protected]>
Add the binding string for the Agilex based Intel n6000 board.
--- Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/intel,socfpga.yaml +1 -0
@@ -18,6 +18,7 @@ properties: items: - enum: - intel,n5x-socdk + - intel,socfpga-agilex-n6000 - intel,socfpga-agilex-socdk - const: intel,socfpga-agilex
Signature · 1 line
2.25.1
Re: [PATCH v2 2/3] dt-bindings: intel: add binding for Intel n6000
Quoted 5 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add the binding string for the Agilex based Intel n6000 board.
Signed-off-by Matthew Gerlach <[email protected]>
Best regards,
Krzysztof
Re: [PATCH v2 2/3] dt-bindings: intel: add binding for Intel n6000
Quoted 8 lines · Krzysztof Kozlowski
Quoted 5 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add the binding string for the Agilex based Intel n6000 board.
Signed-off-by Matthew Gerlach <[email protected]>
Thank you for your time and the Acked-by. I will add it to my v3 patch set.
Matthew
Quoted 5 lines
Best regards,
Krzysztof
PATCH v2 3/3 arm64: dts: intel: add device tree for n6000
In reply to [email protected]From: Matthew Gerlach <[email protected]>
Add a device tree for the n6000 instantiation of Agilex Hard Processor System (HPS).
---
v2:
- fix copy engine node name
- fix compatible field for copy engine
- remove redundant status field
- add compatibility field for the board
- fix SPDX
- fix how osc1 clock frequency is set
--- arch/arm64/boot/dts/intel/Makefile | 3 +- .../boot/dts/intel/socfpga_agilex_n6000.dts | 76 +++++++++++++++++++ 2 files changed, 78 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
arch/arm64/boot/dts/intel/Makefile +2 -1
@@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_socdk.dtb \ +dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \ + socfpga_agilex_socdk.dtb \ socfpga_agilex_socdk_nand.dtb \ socfpga_n5x_socdk.dtb dtb-$(CONFIG_ARCH_KEEMBAY) += keembay-evm.dtb
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +76 -0
76 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
Quoted 6 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add a device tree for the n6000 instantiation of Agilex Hard Processor System (HPS).
Signed-off-by Matthew Gerlach <[email protected]>
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts line 66
Quoted 9 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +9
-0+ +&spi0 { + status = "okay"; + + spidev: spidev@0 { + status = "okay"; + compatible = "linux,spidev"; + spi-max-frequency = <25000000>; + reg = <0>;
You should see big fat warnings - from checkpatch and when you boot your device. This compatible is not accepted.
Please be sure you run checkpatch on your patches. Using reviewers time instead of automated tool for the same job is discouraged...
Best regards,
Krzysztof
Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add a device tree for the n6000 instantiation of Agilex Hard Processor System (HPS).
Quoted 13 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts line 66
Quoted 10 lines
Signed-off-by Matthew Gerlach <[email protected]>arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +9
-0+ +&spi0 { + status = "okay"; + + spidev: spidev@0 { + status = "okay"; + compatible = "linux,spidev"; + spi-max-frequency = <25000000>; + reg = <0>;You should see big fat warnings - from checkpatch and when you boot your device. This compatible is not accepted.
I must have missed the warning for the compatible string. I see it now, and I remove the node in the v3 patch set.
Thanks for the feedback.
Quoted 8 lines
Please be sure you run checkpatch on your patches. Using reviewers time instead of automated tool for the same job is discouraged...
Best regards,
Krzysztof
Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
In reply to [email protected]Quoted 9 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add a device tree for the n6000 instantiation of Agilex Hard Processor System (HPS).
Signed-off-by Matthew Gerlach <[email protected]>arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +2
-0+ + soc {
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts line 39
Quoted 10 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +10
-0+ agilex_hps_bridges: bus@80000000 { + compatible = "simple-bus"; + reg = <0x80000000 0x60000000>, + <0xf9000000 0x00100000>; + reg-names = "axi_h2f", "axi_h2f_lw"; + #address-cells = <0x2>; + #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>; + + hps_cp_eng@0 {
No underscores in node names. dtc W=1 should complain about it. The node name should be generic, matching class of a device. What is this exactly?
Best regards,
Krzysztof
Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add a device tree for the n6000 instantiation of Agilex Hard Processor System (HPS).
Signed-off-by Matthew Gerlach <[email protected]>
Quoted 14 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts line 39
Quoted 12 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +12
-0+ + soc { + agilex_hps_bridges: bus@80000000 { + compatible = "simple-bus"; + reg = <0x80000000 0x60000000>, + <0xf9000000 0x00100000>; + reg-names = "axi_h2f", "axi_h2f_lw"; + #address-cells = <0x2>; + #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>; + + hps_cp_eng@0 {No underscores in node names. dtc W=1 should complain about it.
I will remove the underscores in the name. I didn't see a complaint when I compiled it with "make W=1" in the kernel tree.
Quoted 2 lines
The node name should be generic, matching class of a device. What is this exactly?
The component is a specialized IP block instantiated in the FPGA directly connected to the HPS. In one sense the IP block is a simple DMA controller, but it also has some registers for hand shaking between the HPS and a host processor connected to the FPGA via PCIe. Should I call the node, dma@0?
Thanks for your review,
Matthew
Quoted 3 lines
Quoted 1 line
Best regards,
Krzysztof
Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
Quoted 30 lines · On 04/05/2022 23:22, [email protected] wrote:
Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add a device tree for the n6000 instantiation of Agilex Hard Processor System (HPS).
Signed-off-by Matthew Gerlach <[email protected]>Quoted 14 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts line 39
Quoted 12 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +12
-0+ + soc { + agilex_hps_bridges: bus@80000000 { + compatible = "simple-bus"; + reg = <0x80000000 0x60000000>, + <0xf9000000 0x00100000>; + reg-names = "axi_h2f", "axi_h2f_lw"; + #address-cells = <0x2>; + #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>; + + hps_cp_eng@0 {No underscores in node names. dtc W=1 should complain about it.
I will remove the underscores in the name. I didn't see a complaint when I compiled it with "make W=1" in the kernel tree.
Quoted 8 lines
Quoted 2 lines
The node name should be generic, matching class of a device. What is this exactly?
The component is a specialized IP block instantiated in the FPGA directly connected to the HPS. In one sense the IP block is a simple DMA controller, but it also has some registers for hand shaking between the HPS and a host processor connected to the FPGA via PCIe. Should I call the node, dma@0?
Then maybe the closest is dma-controller.
Best regards,
Krzysztof
Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
Quoted 34 lines · Krzysztof Kozlowski
Quoted 33 lines · On 04/05/2022 23:22, [email protected] wrote:
Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · On 03/05/2022 21:45, [email protected] wrote:
From: Matthew Gerlach <[email protected]>
Add a device tree for the n6000 instantiation of Agilex Hard Processor System (HPS).
Signed-off-by Matthew Gerlach <[email protected]>Quoted 14 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts line 39
Quoted 12 lines
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +12
-0+ + soc { + agilex_hps_bridges: bus@80000000 { + compatible = "simple-bus"; + reg = <0x80000000 0x60000000>, + <0xf9000000 0x00100000>; + reg-names = "axi_h2f", "axi_h2f_lw"; + #address-cells = <0x2>; + #size-cells = <0x1>; + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>; + + hps_cp_eng@0 {No underscores in node names. dtc W=1 should complain about it.
I will remove the underscores in the name. I didn't see a complaint when I compiled it with "make W=1" in the kernel tree.
Quoted 2 lines
The node name should be generic, matching class of a device. What is this exactly?
Quoted 7 lines
Quoted 5 lines
The component is a specialized IP block instantiated in the FPGA directly connected to the HPS. In one sense the IP block is a simple DMA controller, but it also has some registers for hand shaking between the HPS and a host processor connected to the FPGA via PCIe. Should I call the node, dma@0?
Then maybe the closest is dma-controller.
OK, I will call it dma-controller@0.
Thanks,
Matthew
Quoted 5 lines
Best regards,
Krzysztof