Add unit test module for AMD P-State driver
v5 cover Add unit test module for AMD P-State driver
Hi all:
AMD P-State unit test(amd-pstate-ut) is a kernel module for testing the functions of amd-pstate driver.
It could import as a module to launch some test tasks.
1) It can help all users to verify their processor support (SBIOS/ Firmware or Hardware).
2) Kernel can have a basic function test to avoid the kernel regression during the update.
3) We can introduce more functional or performance tests to align the together, it will benefit power and performance scale optimization.
We upstream out AMD P-state driver into Linux kernel and use this unit test module to verify the required conditions and basic functions of amd-pstate before integration test.
We use test module in the kselftest frameworks to implement it. We create amd-pstate-ut module and tie it into kselftest.
For example: The test case aput_acpi_cpc is used to check whether the _CPC object is exist in SBIOS.
The amd-pstate initialization will fail if the _CPC in ACPI SBIOS is not existed at the detected processor, so it is a necessary condition.
At present, it only implements the basic framework and some simple test cases.
TODO : 1) we will add more test cases to improve the depth and coverage of the test.
Please check the documentation amd-pstate.rst for details of the test steps.
See patch series in below git repo:
V1: https://lore.kernel.org/linux-pm/[email protected]/
V2: https://lore.kernel.org/lkml/[email protected]/
V3: https://lore.kernel.org/lkml/[email protected]/
V4: https://lore.kernel.org/lkml/[email protected]/
Changes from V1 -> V2:
- cpufreq: amd-pstate:
- - add a trailing of amd-pstate.h to MAINTAINER AMD PSTATE DRIVER.
- selftests: cpufreq:
- - add a wrapper shell script for the amd_pstate_testmod module.
- selftests: cpufreq:
- - remove amd_pstate_testmod kernel module to .../cpufreq/amd_pstate_testmod.
- Documentation: amd-pstate:
- - amd_pstate_testmod rst document is not provided at present.
Changes from V2 -> V3:
- cpufreq: amd-pstate:
- - adjust the order of add amd-pstate.h in MAINTAINERS.
- selftests: cpufreq:
- - remove the call of amd_pstate_testmod.sh from cpufreq Makefile to main.sh.
- selftests: cpufreq:
- - add explain the goal or intention of the AMD P-State Unit Test module.
- - modify comments.
- - use the checkpatch.pl to check my patches.
- - add conditions judgment before formal test.
- - delete some unnecessary test cases.
- - modify test cases about perf and performance etc.
Changes from V3 -> V4:
- selftests: amd-pstate:
- - remove script and test module to tools/testing/selftests/amd-pstate/
- - uniformly named amd-pstate-ut.
- - check current architectures and cpufreq driver in amd-pstate-ut.sh
- - delete codes about conditions in amd-pstate-ut.c
- Documentation: amd-pstate:
- - add introduce document about amd-pstate unit test.
Changes from V4 -> V5:
- selftests: amd-pstate:
- - add print the current scaling_driver.
- - add amd-pstate-ut.ko into TEST_GEN_FILES.
- - move "insmod/rmmod amd-pstate-ut.ko" stuff into script amd_pstate_ut.sh
- - add a check of read back from X86_FEATURE_CPPC in get_shared_mem().
- Documentation: amd-pstate:
- - delete the test step about insmod/rmmod amd-pstate-ut.ko
Thanks,
Jasmine
Meng Li (3):
cpufreq: amd-pstate: Expose struct amd_cpudata
selftests: amd-pstate: Add test module for amd-pstate driver
Documentation: amd-pstate: Add unit test introduction
Documentation/admin-guide/pm/amd-pstate.rst | 85 ++++++ MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--- include/linux/amd-pstate.h | 77 +++++ tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 15 + .../selftests/amd-pstate/amd-pstate-ut.sh | 45 +++ .../amd-pstate/amd-pstate-ut/Makefile | 20 ++ .../amd-pstate/amd-pstate-ut/amd-pstate-ut.c | 278 ++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 10 files changed, 524 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.h create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c create mode 100644 tools/testing/selftests/amd-pstate/config
Signature · 1 line
2.25.1
PATCH v5 1/3 cpufreq: amd-pstate: Expose struct amd_cpudata
Expose struct amd_cpudata to AMD P-State unit test module.
This data struct will be used on the following AMD P-State unit test (amd-pstate-ut) module. The amd-pstate-ut module can get some AMD infomations by this data struct. For example: highest perf, nominal perf, boost supported etc.
--- MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--------------------------- include/linux/amd-pstate.h | 77 ++++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.h
MAINTAINERS +1 -0
@@ -1021,6 +1021,7 @@ L: [email protected] S: Supported F: Documentation/admin-guide/pm/amd-pstate.rst F: drivers/cpufreq/amd-pstate* +F: include/linux/amd-pstate.h F: tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py AMD PTDMA DRIVER
drivers/cpufreq/amd-pstate.c +1 -59
72 lines not on this page · raw message
include/linux/amd-pstate.h new file +77 -0
77 lines not on this page · raw message
Signature · 1 line
2.25.1
PATCH v5 2/3 selftests: amd-pstate: Add test module for amd-pstate driver
In reply to Meng LiAdd amd-pstate-ut module, which is conceptually out-of-tree module and provides ways for selftests/amd-pstate driver to test various kernel module-related functionality. This module will be expected by some of selftests to be present and loaded.
--- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 15 + .../selftests/amd-pstate/amd-pstate-ut.sh | 45 +++ .../amd-pstate/amd-pstate-ut/Makefile | 20 ++ .../amd-pstate/amd-pstate-ut/amd-pstate-ut.c | 278 ++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 6 files changed, 360 insertions(+) create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c create mode 100644 tools/testing/selftests/amd-pstate/config
tools/testing/selftests/Makefile +1 -0
@@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 TARGETS += alsa +TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpoints
tools/testing/selftests/amd-pstate/Makefile new file +15 -0
@@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Makefile for amd-pstate/ function selftests + +uname_M := $(shell uname -m 2>/dev/null || echo not) +ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) + +ifeq (x86,$(ARCH)) +TEST_GEN_FILES := amd-pstate-ut/amd-pstate-ut.ko +endif + +TEST_PROGS := amd-pstate-ut.sh + +include ../lib.mk + +$(TEST_GEN_FILES): $(HEADERS)
tools/testing/selftests/amd-pstate/amd-pstate-ut.sh new file +45 -0
45 lines not on this page · raw message
tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile new file +20 -0
@@ -0,0 +1,20 @@ +AMD_PSTATE_UT_DIR := $(realpath $(dir $(abspath $(lastword $(MAKEFILE_LIST))))) +KDIR ?= $(abspath $(AMD_PSATE_UT_DIR)/../../../../..) + +ifeq ($(V),1) +Q = +else +Q = @ +endif + +MODULES = amd-pstate-ut.ko + +obj-m += amd-pstate-ut.o +CFLAGS_amd-pstate-ut.o = -I$(src) + +all: + +$(Q)make -C $(KDIR) M=$(AMD_PSTATE_UT_DIR) modules + +clean: + +$(Q)make -C $(KDIR) M=$(AMD_PSTATE_UT_DIR) clean +
tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c new file +278 -0
278 lines not on this page · raw message
tools/testing/selftests/amd-pstate/config new file +1 -0
@@ -0,0 +1 @@ +CONFIG_X86_AMD_PSTATE_UT=m
Signature · 1 line
2.25.1
PATCH v5 3/3 Documentation: amd-pstate: Add unit test introduction
In reply to Meng LiIntroduce the AMD P-State unit test module design and implementation.
--- Documentation/admin-guide/pm/amd-pstate.rst | 85 +++++++++++++++++++++ 1 file changed, 85 insertions(+)
Documentation/admin-guide/pm/amd-pstate.rst +85 -0
@@ -182,6 +182,7 @@ to the ``struct sugov_cpu`` that the utilization update belongs to. Then, ``amd-pstate`` updates the desired performance according to the CPU scheduler assigned. +.. _processor_support: Processor Support =======================
@@ -282,6 +283,8 @@ efficiency frequency management method on AMD processors. Kernel Module Options for ``amd-pstate`` ========================================= +.. _shared_mem: + ``shared_mem`` Use a module param (shared_mem) to enable related processors manually with **amd_pstate.shared_mem=1**.
@@ -393,6 +396,85 @@ about part of the output. :: CPU_005 712 116384 39 49 166 0.7565 9645075 2214891 38431470 25.1 11.646 469 2.496 kworker/5:0-40 CPU_006 712 116408 39 49 166 0.6769 8950227 1839034 37192089 24.06 11.272 470 2.496 kworker/6:0-1264 +Unit Tests for amd-pstate +------------------------- + +``amd-pstate-ut`` is a test module for testing the ``amd-pstate`` driver. + + * It can help all users to verify their processor support (SBIOS/Firmware or Hardware). + + * Kernel can have a basic function test to avoid the kernel regression during the update. + + * We can introduce more functional or performance tests to align the result together, it will benefit power and performance scale optimization. + +1. Test case decriptions + + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | Index | Functions | Description | + +=========+================================+====================================================================================+ + | 0 | aput_acpi_cpc || Check whether the _CPC object is present in SBIOS. | + | | || | + | | || The detail refer to `Processor Support <processor_support_>`_. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 1 | aput_check_enabled || Check whether AMD P-State is enabled. | + | | || | + | | || AMD P-States and ACPI hardware P-States always can be supported in one processor. | + | | | But AMD P-States has the higher priority and if it is enabled with | + | | | :c:macro:`MSR_AMD_CPPC_ENABLE` or ``cppc_set_enable``, it will respond to the | + | | | request from AMD P-States. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 2 | aput_check_perf || Check if the each performance values are reasonable. | + | | || highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 3 | aput_check_freq || Check if the each frequency values and max freq when set support boost mode | + | | | are reasonable. | + | | || max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0 | + | | || If boost is not active but supported, this maximum frequency will be larger than | + | | | the one in ``cpuinfo``. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + +#. How to execute the tests + + We use test module in the kselftest frameworks to implement it. + We create amd-pstate-ut module and tie it into kselftest.(for + details refer to Linux Kernel Selftests [4]_). + + 1. Build :: + + jasminemeng@jasmine-meng:~/amd-brahma$ cd linux + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make modules M=tools/testing/selftests/amd-pstate/amd-pstate-ut + CC [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.o + MODPOST tools/testing/selftests/amd-pstate/amd-pstate-ut/Module.symvers + CC [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.mod.o + LD [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.ko + BTF [M] tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.ko + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/selftests + + #. Installation & Steps :: + + jasmine@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/selftests install INSTALL_PATH=~/kselftest + jasmine@jasmine-meng:~$ sudo ./kselftest/run_kselftest.sh -c amd-pstate + TAP version 13 + 1..1 + # selftests: amd-pstate: amd-pstate-ut.sh + # amd-pstate-ut: ok + ok 1 selftests: amd-pstate: amd-pstate-ut.sh + + #. Results :: + + jasmine@jasmine-meng:~$ dmesg | grep "amd-pstate-ut" | tee log.txt + [76697.480217] amd-pstate-ut: loaded. + [76697.480222] amd-pstate-ut: ****** Begin 1 acpi_cpc_valid ****** + [76697.480227] amd-pstate-ut: ****** End 1 acpi_cpc_valid ****** + [76697.480228] amd-pstate-ut: ****** Begin 2 check_enabled ****** + [76697.480253] amd-pstate-ut: ****** End 2 check_enabled ****** + [76697.480255] amd-pstate-ut: ****** Begin 3 check_perf ****** + [76697.480554] amd-pstate-ut: ****** End 3 check_perf ****** + [76697.480556] amd-pstate-ut: ****** Begin 4 check_freq ****** + [76697.480558] amd-pstate-ut: ****** End 4 check_freq ****** + [76697.480559] amd-pstate-ut: all 4 tests passed + [76697.482507] amd-pstate-ut: unloaded. + Reference ===========
@@ -405,3 +487,6 @@ Reference .. [3] Processor Programming Reference (PPR) for AMD Family 19h Model 51h, Revision A1 Processors https://www.amd.com/system/files/TechDocs/56569-A1-PUB.zip + +.. [4] Linux Kernel Selftests, + https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html
Signature · 1 line
2.25.1
Huang Rui
maintainerQuoted 82 lines · Li (Jassmine)
Hi all:
AMD P-State unit test(amd-pstate-ut) is a kernel module for testing the functions of amd-pstate driver.
It could import as a module to launch some test tasks.
1) It can help all users to verify their processor support (SBIOS/ Firmware or Hardware).
2) Kernel can have a basic function test to avoid the kernel regression during the update.
3) We can introduce more functional or performance tests to align the together, it will benefit power and performance scale optimization.We upstream out AMD P-state driver into Linux kernel and use this unit test module to verify the required conditions and basic functions of amd-pstate before integration test.
We use test module in the kselftest frameworks to implement it. We create amd-pstate-ut module and tie it into kselftest.
For example: The test case
aput_acpi_cpcis used to check whether the_CPCobject is exist in SBIOS.
The amd-pstate initialization will fail if the_CPCin ACPI SBIOS is not existed at the detected processor, so it is a necessary condition.At present, it only implements the basic framework and some simple test cases.
TODO : 1) we will add more test cases to improve the depth and coverage of the test.
Please check the documentation
amd-pstate.rstfor details of the test steps.See patch series in below git repo:
V1: https://lore.kernel.org/linux-pm/[email protected]/
V2: https://lore.kernel.org/lkml/[email protected]/
V3: https://lore.kernel.org/lkml/[email protected]/
V4: https://lore.kernel.org/lkml/[email protected]/Changes from V1 -> V2:
- cpufreq: amd-pstate:
- - add a trailing ofamd-pstate.hto MAINTAINER AMD PSTATE DRIVER.
- selftests: cpufreq:
- - add a wrapper shell script for theamd_pstate_testmodmodule.
- selftests: cpufreq:
- - removeamd_pstate_testmodkernel module to .../cpufreq/amd_pstate_testmod.
- Documentation: amd-pstate:
- -amd_pstate_testmodrst document is not provided at present.Changes from V2 -> V3:
- cpufreq: amd-pstate:
- - adjust the order of addamd-pstate.hinMAINTAINERS.
- selftests: cpufreq:
- - remove the call ofamd_pstate_testmod.shfrom cpufreqMakefiletomain.sh.
- selftests: cpufreq:
- - add explain the goal or intention of the AMD P-State Unit Test module.
- - modify comments.
- - use the checkpatch.pl to check my patches.
- - add conditions judgment before formal test.
- - delete some unnecessary test cases.
- - modify test cases about perf and performance etc.Changes from V3 -> V4:
- selftests: amd-pstate:
- - remove script and test module totools/testing/selftests/amd-pstate/
- - uniformly named amd-pstate-ut.
- - check current architectures and cpufreq driver inamd-pstate-ut.sh
- - delete codes about conditions inamd-pstate-ut.c
- Documentation: amd-pstate:
- - add introduce document about amd-pstate unit test.Changes from V4 -> V5:
- selftests: amd-pstate:
- - add print the currentscaling_driver.
- - add amd-pstate-ut.ko intoTEST_GEN_FILES.
- - move "insmod/rmmod amd-pstate-ut.ko" stuff into scriptamd_pstate_ut.sh
- - add a check of read back fromX86_FEATURE_CPPCinget_shared_mem().
- Documentation: amd-pstate:
- - delete the test step about insmod/rmmod amd-pstate-ut.ko
Quoted 7 lines
Thanks,
JasmineMeng Li (3):
cpufreq: amd-pstate: Expose structamd_cpudata
selftests: amd-pstate: Add test module for amd-pstate driver
Documentation: amd-pstate: Add unit test introduction
Series are Acked-by: Huang Rui <[email protected]>
Thanks Jassmine! Let's wait for Khan's review comments.
Best Regards,
Ray
Quoted 22 lines
Documentation/admin-guide/pm/amd-pstate.rst | 85 ++++++ MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--- include/linux/amd-pstate.h | 77 +++++ tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 15 + .../selftests/amd-pstate/amd-pstate-ut.sh | 45 +++ .../amd-pstate/amd-pstate-ut/Makefile | 20 ++ .../amd-pstate/amd-pstate-ut/amd-pstate-ut.c | 278 ++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 10 files changed, 524 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.h create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/Makefile create mode 100644 tools/testing/selftests/amd-pstate/amd-pstate-ut/amd-pstate-ut.c create mode 100644 tools/testing/selftests/amd-pstate/configSignature · 1 line
2.25.1
Shuah Khan
maintainerQuoted 49 lines · Huang Rui
Quoted 48 lines · Li (Jassmine)
Hi all:
AMD P-State unit test(amd-pstate-ut) is a kernel module for testing the functions of amd-pstate driver.
It could import as a module to launch some test tasks.
1) It can help all users to verify their processor support (SBIOS/ Firmware or Hardware).
2) Kernel can have a basic function test to avoid the kernel regression during the update.
3) We can introduce more functional or performance tests to align the together, it will benefit power and performance scale optimization.We upstream out AMD P-state driver into Linux kernel and use this unit test module to verify the required conditions and basic functions of amd-pstate before integration test.
We use test module in the kselftest frameworks to implement it. We create amd-pstate-ut module and tie it into kselftest.
For example: The test case
aput_acpi_cpcis used to check whether the_CPCobject is exist in SBIOS.
The amd-pstate initialization will fail if the_CPCin ACPI SBIOS is not existed at the detected processor, so it is a necessary condition.At present, it only implements the basic framework and some simple test cases.
TODO : 1) we will add more test cases to improve the depth and coverage of the test.
Please check the documentation
amd-pstate.rstfor details of the test steps.See patch series in below git repo:
V1: https://lore.kernel.org/linux-pm/[email protected]/
V2: https://lore.kernel.org/lkml/[email protected]/
V3: https://lore.kernel.org/lkml/[email protected]/
V4: https://lore.kernel.org/lkml/[email protected]/Changes from V4 -> V5:
- selftests: amd-pstate:
- - add print the currentscaling_driver.
- - add amd-pstate-ut.ko intoTEST_GEN_FILES.
- - move "insmod/rmmod amd-pstate-ut.ko" stuff into scriptamd_pstate_ut.sh
- - add a check of read back fromX86_FEATURE_CPPCinget_shared_mem().
- Documentation: amd-pstate:
- - delete the test step about insmod/rmmod amd-pstate-ut.ko
Quoted 3 lines
Quoted 3 lines
Thanks,
Jasmine
Sorry for the delay on this. I will review the series in the next couple of days.
Did you consider using KUnit for this? I think asked that question when reviewing the previous version.
thanks,
-- Shuah
Shuah Khan
maintainerQuoted 54 lines · Shuah Khan
Quoted 49 lines · Huang Rui
Quoted 48 lines · Li (Jassmine)
Hi all:
AMD P-State unit test(amd-pstate-ut) is a kernel module for testing the functions of amd-pstate driver.
It could import as a module to launch some test tasks.
1) It can help all users to verify their processor support (SBIOS/ Firmware or Hardware).
2) Kernel can have a basic function test to avoid the kernel regression during the update.
3) We can introduce more functional or performance tests to align the together, it will benefit power and performance scale optimization.We upstream out AMD P-state driver into Linux kernel and use this unit test module to verify the required conditions and basic functions of amd-pstate before integration test.
We use test module in the kselftest frameworks to implement it. We create amd-pstate-ut module and tie it into kselftest.
For example: The test case
aput_acpi_cpcis used to check whether the_CPCobject is exist in SBIOS.
The amd-pstate initialization will fail if the_CPCin ACPI SBIOS is not existed at the detected processor, so it is a necessary condition.At present, it only implements the basic framework and some simple test cases.
TODO : 1) we will add more test cases to improve the depth and coverage of the test.
Please check the documentation
amd-pstate.rstfor details of the test steps.See patch series in below git repo:
V1: https://lore.kernel.org/linux-pm/[email protected]/
V2: https://lore.kernel.org/lkml/[email protected]/
V3: https://lore.kernel.org/lkml/[email protected]/
V4: https://lore.kernel.org/lkml/[email protected]/Changes from V4 -> V5:
- selftests: amd-pstate:
- - add print the currentscaling_driver.
- - add amd-pstate-ut.ko intoTEST_GEN_FILES.
- - move "insmod/rmmod amd-pstate-ut.ko" stuff into scriptamd_pstate_ut.sh
- - add a check of read back fromX86_FEATURE_CPPCinget_shared_mem().
- Documentation: amd-pstate:
- - delete the test step about insmod/rmmod amd-pstate-ut.koQuoted 3 lines
Quoted 3 lines
Thanks,
Jasmine
Quoted 6 lines
Sorry for the delay on this. I will review the series in the next couple of days.
Did you consider using KUnit for this? I think asked that question when reviewing the previous version.
I reviewed the patches and the test driver amd-pstate-ut doesn't belong under selftests. I would recommend the following approach:
- add this test driver under drivers/cpufreq
- KUnit is a better fit for this unit test driver unless you want to be able to run this without KUnit configured
- add the test script under selftests - the script then can load the test driver and run tests and unload the driver.
thanks,
-- Shuah
Huang Rui
maintainerQuoted 65 lines · Shuah Khan
Quoted 54 lines · Shuah Khan
Quoted 49 lines · Huang Rui
Quoted 48 lines · Li (Jassmine)
Hi all:
AMD P-State unit test(amd-pstate-ut) is a kernel module for testing the functions of amd-pstate driver.
It could import as a module to launch some test tasks.
1) It can help all users to verify their processor support (SBIOS/ Firmware or Hardware).
2) Kernel can have a basic function test to avoid the kernel regression during the update.
3) We can introduce more functional or performance tests to align the together, it will benefit power and performance scale optimization.We upstream out AMD P-state driver into Linux kernel and use this unit test module to verify the required conditions and basic functions of amd-pstate before integration test.
We use test module in the kselftest frameworks to implement it. We create amd-pstate-ut module and tie it into kselftest.
For example: The test case
aput_acpi_cpcis used to check whether the_CPCobject is exist in SBIOS.
The amd-pstate initialization will fail if the_CPCin ACPI SBIOS is not existed at the detected processor, so it is a necessary condition.At present, it only implements the basic framework and some simple test cases.
TODO : 1) we will add more test cases to improve the depth and coverage of the test.
Please check the documentation
amd-pstate.rstfor details of the test steps.See patch series in below git repo:
V1: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-pm%2F20220323071502.2674156-1-li.meng%40amd.com%2F&data=05%7C01%7Cray.huang%40amd.com%7C267a994f51e34371021c08da384042f1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637884145911708064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=m9BlIFlf8IEeSGjycWdppnIMoZTbfmi3tIsuRJZL6cw%3D&reserved=0
V2: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20220413090510.4039589-1-li.meng%40amd.com%2F&data=05%7C01%7Cray.huang%40amd.com%7C267a994f51e34371021c08da384042f1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637884145911708064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=h1o69SJ5iaVChb1h8a3FZURAeKAj6vlB%2FmR%2BtfmpoE4%3D&reserved=0
V3: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20220421074152.599419-1-li.meng%40amd.com%2F&data=05%7C01%7Cray.huang%40amd.com%7C267a994f51e34371021c08da384042f1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637884145911708064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WcXo7q2snNWM8nUSF08HjPDB7UuwFMDTTwe6zLcXHyY%3D&reserved=0
V4: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20220427135315.3447550-1-li.meng%40amd.com%2F&data=05%7C01%7Cray.huang%40amd.com%7C267a994f51e34371021c08da384042f1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637884145911708064%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Rnn9bLhc1sDkNyBlmwmb8Zy4IJUKwtIq0M0qhcUbdM8%3D&reserved=0Changes from V4 -> V5:
- selftests: amd-pstate:
- - add print the currentscaling_driver.
- - add amd-pstate-ut.ko intoTEST_GEN_FILES.
- - move "insmod/rmmod amd-pstate-ut.ko" stuff into scriptamd_pstate_ut.sh
- - add a check of read back fromX86_FEATURE_CPPCinget_shared_mem().
- Documentation: amd-pstate:
- - delete the test step about insmod/rmmod amd-pstate-ut.koQuoted 3 lines
Quoted 3 lines
Thanks,
JasmineQuoted 6 lines
Sorry for the delay on this. I will review the series in the next couple of days.
Did you consider using KUnit for this? I think asked that question when reviewing the previous version.
I reviewed the patches and the test driver amd-pstate-ut doesn't belong under selftests. I would recommend the following approach:
Quoted 8 lines
- add this test driver under
drivers/cpufreq- KUnit is a better fit for this unit test driver unless you want to be able to run this without KUnit configured
- add the test script under selftests - the script then can load the test driver and run tests and unload the driver.
Thanks Shuah. We would like to introduce more CPU benchmark testing based the amd-pstate-ut next step, it may not be all the stuff in the kernel module. E.X. use the script to trigger the tbench, gitsource, kernbench, netperf, speedometer, and etc. testing and monitor the cpu frequency and performance goals change, power consumption at runtime. Can the KUnit + Kselftests work more straight forward in user scenario?
Thanks,
Ray
Shuah Khan
maintainerQuoted 14 lines · Huang Rui
Quoted 11 lines · Shuah Khan
I reviewed the patches and the test driver amd-pstate-ut doesn't belong under selftests. I would recommend the following approach:
- add this test driver under
drivers/cpufreq- KUnit is a better fit for this unit test driver unless you want to be able to run this without KUnit configured
- add the test script under selftests - the script then can load the test driver and run tests and unload the driver.
Quoted 7 lines
Thanks Shuah. We would like to introduce more CPU benchmark testing based the amd-pstate-ut next step, it may not be all the stuff in the kernel module. E.X. use the script to trigger the tbench, gitsource, kernbench, netperf, speedometer, and etc. testing and monitor the cpu frequency and performance goals change, power consumption at runtime. Can the KUnit + Kselftests work more straight forward in user scenario?
I am not sure if I understand your question. Also I am not sure if understand the scope of the testing you are intending to do using amd-pstate-ut.
tbench, gitsource etc. are external tests (meaning not in kernel repo). Do these tests depend on amd-pstate-ut?
It would be helpful to understand the scope first. What exactly will amd-pstate-ut used for? Based on the patch series it looked like:
-- amd-pstate-ut has unit test code which will be triggered from kselftest
This is perfectly fine. The driver can reside under drivers/cpufreq and a test.sh can reside under selftests. It can just use kselftest framework.
Based on what you are saying. kselftest might be a good choice.
thanks,
-- Shuah