Skip to contentSkip to conversation

Add device tree for Intel n6000

PATCH Superseded [email protected] 2 participants 6 messages May 6, 2022 – May 7, 2022 Device tree bindings

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add device tree for Intel n6000

From: Matthew Gerlach <[email protected]>

This patch set adds a device tree for the Hard Processor System (HPS) on an Agilex based Intel n6000 board.

Patch 1 defines the device tree binding for the HPS Copy Engine IP used to copy a bootable image from host memory to HPS DDR.

Patch 2 defines the binding for the Intel n6000 board itself.

Patch 3 adds the device tree for the n6000 board.

Changelog v2 -> v3:
- remove unused label
- move from misc to soc
- remove 0x from #address-cells/#size-cells values
- change hps_cp_eng@0 to dma-controller@0
- remote inaccurate 'items:' tag
- added Acked-by
- add unit number to memory node
- remove spi node with unaccepted compatible value

Changelog v1 -> v2:
- add dt binding for copy enging
- add dt binding for n6000 board
- fix copy engine node name
- fix compatible field for copy engine
- remove redundant status field
- add compatibility field for the board
- fix SPDX
- fix how osc1 clock frequency is set

Matthew Gerlach (3):
dt-bindings: soc: add bindings for Intel HPS Copy Engine
dt-bindings: intel: add binding for Intel n6000
arm64: dts: intel: add device tree for n6000

 .../bindings/arm/intel,socfpga.yaml           |  1 +
 .../bindings/soc/intel,hps-copy-engine.yaml   | 51 ++++++++++++++
 arch/arm64/boot/dts/intel/Makefile            |  3 +-
 .../boot/dts/intel/socfpga_agilex_n6000.dts   | 66 +++++++++++++++++++
 4 files changed, 120 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/soc/intel,hps-copy-engine.yaml
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
Signature · 1 line
2.25.1
#1 lore raw

PATCH v3 1/3 dt-bindings: soc: add bindings for Intel HPS Copy Engine

From: Matthew Gerlach <[email protected]>

Add device tree bindings documentation for the Intel Hard Processor System (HPS) Copy Engine.

---
v3:
- remove unused label
- move from misc to soc
- remove 0x from #address-cells/#size-cells values
- change hps_cp_eng@0 to dma-controller@0
- remote inaccurate 'items:' tag

---
 .../bindings/soc/intel,hps-copy-engine.yaml   | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/intel,hps-copy-engine.yaml
Documentation/devicetree/bindings/soc/intel,hps-copy-engine.yaml new file +51 -0
new file mode 100644
index 000000000000..606208233b67
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) 2022, Intel Corporation
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/intel,hps-copy-engine.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Intel HPS Copy Engine
+
+maintainers:
+  - Matthew Gerlach <[email protected]>
+
+description: |
+  The Intel Hard Processor System (HPS) Copy Engine is an IP block used to copy
+  a bootable image from host memory to HPS DDR.  Additionally, there is a
+  register the HPS can use to indicate the state of booting the copied image as
+  well as a keep-a-live indication to the host.
+
+properties:
+  compatible:
+    const: intel,hps-copy-engine
+
+  '#dma-cells':
+    const: 1
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    bus@80000000 {
+        compatible = "simple-bus";
+        reg = <0x80000000 0x60000000>,
+              <0xf9000000 0x00100000>;
+        reg-names = "axi_h2f", "axi_h2f_lw";
+        #address-cells = <2>;
+        #size-cells = <1>;
+        ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>;
+
+        dma-controller@0 {
+            compatible = "intel,hps-copy-engine";
+            reg = <0x00000000 0x00000000 0x00001000>;
+            #dma-cells = <1>;
+        };
+    };
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v3 1/3] dt-bindings: soc: add bindings for Intel HPS Copy Engine

Quoted 13 lines · On 06/05/2022 17:41, [email protected] wrote:

From: Matthew Gerlach <[email protected]>

Add device tree bindings documentation for the Intel Hard Processor System (HPS) Copy Engine.

---
v3:
- remove unused label
- move from misc to soc
- remove 0x from #address-cells/#size-cells values
- change hps_cp_eng@0 to dma-controller@0
- remote inaccurate 'items:' tag

Quoted 4 lines
---
 .../bindings/soc/intel,hps-copy-engine.yaml   | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/intel,hps-copy-engine.yaml

There are no files laying around in bindings/soc. Each is in its own vendor subdirectory, so let's don't introduce inconsistencies. Intel should not be different/special.

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH v3 1/3] dt-bindings: soc: add bindings for Intel HPS Copy Engine

Quoted 19 lines · Krzysztof Kozlowski
Quoted 13 lines · On 06/05/2022 17:41, [email protected] wrote:

From: Matthew Gerlach <[email protected]>

Add device tree bindings documentation for the Intel Hard Processor System (HPS) Copy Engine.

---
v3:
- remove unused label
- move from misc to soc
- remove 0x from #address-cells/#size-cells values
- change hps_cp_eng@0 to dma-controller@0
- remote inaccurate 'items:' tag

Quoted 4 lines
---
 .../bindings/soc/intel,hps-copy-engine.yaml   | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/intel,hps-copy-engine.yaml
Quoted 3 lines

There are no files laying around in bindings/soc. Each is in its own vendor subdirectory, so let's don't introduce inconsistencies. Intel should not be different/special.

I certainly don't want to be different or special. I will move the file to an intel subdirectory.

Thanks for the feedback,
Matthew

Quoted 4 lines

Best regards,
Krzysztof

#4 lore raw

PATCH v3 2/3 dt-bindings: intel: add binding for Intel n6000

In reply to [email protected]

From: Matthew Gerlach <[email protected]>

Add the binding string for the Agilex based Intel n6000 board.

---
v3:
- added Acked-by

---
 Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/intel,socfpga.yaml +1 -0
index 6e043459fcd5..61a454a40e87 100644
@@ -18,6 +18,7 @@ properties:
         items:
           - enum:
               - intel,n5x-socdk
+              - intel,socfpga-agilex-n6000
               - intel,socfpga-agilex-socdk
           - const: intel,socfpga-agilex
 
Signature · 1 line
2.25.1
#5 lore raw

PATCH v3 3/3 arm64: dts: intel: add device tree for n6000

In reply to [email protected]

From: Matthew Gerlach <[email protected]>

Add a device tree for the n6000 instantiation of Agilex Hard Processor System (HPS).

---
v3:
- add unit number to memory node
- remove unused label
- remove 0x from #address-cells/#size-cells values
- change hps_cp_eng@0 to dma-controller@0
- remove spi node with unaccepted compatible value

v2:
- fix copy engine node name
- fix compatible field for copy engine
- remove redundant status field
- add compatibility field for the board
- fix SPDX
- fix how osc1 clock frequency is set

---
 arch/arm64/boot/dts/intel/Makefile            |  3 +-
 .../boot/dts/intel/socfpga_agilex_n6000.dts   | 66 +++++++++++++++++++
 2 files changed, 68 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
arch/arm64/boot/dts/intel/Makefile +2 -1
index 0b5477442263..c2a723838344 100644
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
-dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_socdk.dtb \
+dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
+				socfpga_agilex_socdk.dtb \
 				socfpga_agilex_socdk_nand.dtb \
 				socfpga_n5x_socdk.dtb
 dtb-$(CONFIG_ARCH_KEEMBAY) += keembay-evm.dtb
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts new file +66 -0

66 lines not on this page · raw message

Signature · 1 line
2.25.1