mmc: fsl_esdhc_spl: Fix checking for number of read sectors
PATCH 1/1 mmc: fsl_esdhc_spl: Fix checking for number of read sectors
Commit 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support") changed number of sectors which are read but did not adjusted error check.
Fix it and check for if correct number of sectors were read.
--- drivers/mmc/fsl_esdhc_spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/fsl_esdhc_spl.c +1 -1
@@ -106,7 +106,7 @@ again: blk_off = (sector *512 ) % mmc->read_bl_len; blk_cnt =DIV_ROUND_UP (512 , mmc->read_bl_len); err = mmc->block_dev.block_read (&mmc->block_dev, blk_start, blk_cnt, tmp_buf); -if (err !=1 ) { +if (err != blk_cnt) {puts ("spl: mmc read failed!!\n" );hang (); }
Signature · 1 line
2.20.1
Quoted 8 lines · Pali Rohár
Commit
0980cbba7b3c("mmc:fsl_esdhc_spl: pre-PBL: implement redundancy support") changed number of sectors which are read but did not adjusted error check.Fix it and check for if correct number of sectors were read.
Fixes 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support")Signed-off-by Pali Rohár <[email protected]>
Best Regards,
Jaehoon Chung
Quoted 17 lines
--- drivers/mmc/fsl_esdhc_spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/fsl_esdhc_spl.c +1
-1@@ -106,7 +106,7 @@ again: blk_off = (sector *512 ) % mmc->read_bl_len; blk_cnt =DIV_ROUND_UP (512 , mmc->read_bl_len); err = mmc->block_dev.block_read (&mmc->block_dev, blk_start, blk_cnt, tmp_buf); -if (err !=1 ) { +if (err != blk_cnt) {puts ("spl: mmc read failed!!\n" );hang (); }
Quoted 9 lines · Pali Rohár
Commit
0980cbba7b3c("mmc:fsl_esdhc_spl: pre-PBL: implement redundancy support") changed number of sectors which are read but did not adjusted error check.Fix it and check for if correct number of sectors were read.
Fixes 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support")Signed-off-by Pali Rohár <[email protected]>Reviewed-by Jaehoon Chung <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom