Skip to contentSkip to conversation

mdadm test suite improvements

DISCUSSION Mariusz Tkaczyk 5 participants 7 messages May 16, 2022 – May 17, 2022 1 message not in the archive MD RAID

lore
Share & tools
lore
#0 lore raw

Hello All,
I'm working on names handling in mdadm and I need to add some new test to the mdadm scope - to verify that it is working as desired.
Bash is not best choice for testing and in current form, our tests are not friendly for developers. I would like to introduce another python based test scope and add it to repository. I will integrate it with current framework.

I can see that currently test are not well used and they aren't often updated. I want to bring new life to them. Adopting more modern approach seems to be good start point.
Any thoughts?

Thanks in advance,
Mariusz

#1 lore raw
Quoted 11 lines · Mariusz Tkaczyk

Hello All,
I'm working on names handling in mdadm and I need to add some new test to the mdadm scope - to verify that it is working as desired.
Bash is not best choice for testing and in current form, our tests are not friendly for developers. I would like to introduce another python based test scope and add it to repository. I will integrate it with current framework.

I can see that currently test are not well used and they aren't often updated. I want to bring new life to them. Adopting more modern approach seems to be good start point.
Any thoughts?

Hi Mariusz,

Yes IMHO python is more ideal than bash. Personally I am supportive to this idea.

Thanks.

Coly Li

#2 lore raw
In reply to Mariusz Tkaczyk
Quoted 7 lines · Mariusz Tkaczyk

Hello All,
I'm working on names handling in mdadm and I need to add some new test to the mdadm scope - to verify that it is working as desired.
Bash is not best choice for testing and in current form, our tests are not friendly for developers. I would like to introduce another python based test scope and add it to repository. I will integrate it with current framework.

Quoted 8 lines

I can see that currently test are not well used and they aren't often updated. I want to bring new life to them. Adopting more modern approach seems to be good start point.
Any thoughts?

Thanks in advance,
Mariusz

Hello Mariusz,

Python is a great choice. Good with me.

-Nigel

#3 lore raw
In reply to Mariusz Tkaczyk

Mariusz,

Quoted 9 lines · Mariusz Tkaczyk

Hello All,
I'm working on names handling in mdadm and I need to add some new test to the mdadm scope - to verify that it is working as desired.
Bash is not best choice for testing and in current form, our tests are not friendly for developers. I would like to introduce another python based test scope and add it to repository. I will integrate it with current framework.

Quoted 7 lines

I can see that currently test are not well used and they aren't often updated. I want to bring new life to them. Adopting more modern approach seems to be good start point.
Any thoughts?

Thanks in advance,
Mariusz

FWIW, Python is the right choice to modernize the framework. I recently ran the test suite and sent out a series [1] addressing issues we found with the test cases. I would agree that python would be more helpful in the wider adoption of the test framework.

[1] https://marc.info/?l=linux-raid&m=165220252031480&w=2

--
Himanshu Madhani Oracle Linux Engineering

#4 lore raw
In reply to Mariusz Tkaczyk

Hi Mariusz

Thanks for the effort. Have you init the git project to start this? If so, you can send it, so we can
work together about this.

Best Regards
Xiao

Quoted 16 lines · Mariusz Tkaczyk

Hello All,
I'm working on names handling in mdadm and I need to add some new test to the mdadm scope - to verify that it is working as desired.
Bash is not best choice for testing and in current form, our tests are not friendly for developers. I would like to introduce another python based test scope and add it to repository. I will integrate it with current framework.

I can see that currently test are not well used and they aren't often updated. I want to bring new life to them. Adopting more modern approach seems to be good start point.
Any thoughts?

Thanks in advance,
Mariusz

A message that is not in the archive (sent off-list or not yet received): -laavsfgtlo10lebdsj460ptakf7ob3swf0up-4xyanlxfob29oebwn0um9140l133r8-rukduq-tekz50-og1qjp-za66of-qnod9a-cdghzt8enrbc-ei4sg9-7sa12trdyicp-e03x62jcjj2j-h0xih6.1652752832458@email.android.com

#6 lore raw

Hi,
I wanted to add it to the mdadm repo, let say under directory "python_tests". I didn't started work yet. Those tests should stay with mdadm, so we can develop them with Coly using mdadm-ci and later ask Jes to merge the branch.

I don't have any details, I just asked to gather feedback. Seems that there is big interest in this change. If there is any volunteer to take this topic and prepare python API for testing and first tests- I will be pleased to help.

I could take long time before I will start this topic.

Thanks,
Mariusz

Quoted 48 lines · On Tue, 17 May 2022 10:00:32 +0800 ‪Coly Li‬ <[email protected]> wrote:

Hi Xiao,

Yes there is a git repo specific for test scripts, to test the mdadm-ci repo. It is located on kernel.org git server, which currently only contains bash scripts copied from mdadm.

Coly

From my phone

-------- 原始邮件 --------
发件人: Xiao Ni <[email protected]>
日期: 2022年5月17日周二 上午9:48
收件人: Mariusz Tkaczyk <[email protected]>
抄送: Nigel Croxon <[email protected]>, Coly Li <[email protected]>, Jes Sorensen <[email protected]>, linux-raid <[email protected]> 主 题: Re: mdadm test suite improvements Hi Mariusz

Quoted 29 lines

Thanks for the effort. Have you init the git project to start this? If so, you can send it, so we can
work together about this.

Best Regards
Xiao

Quoted 17 lines · Mariusz Tkaczyk

Hello All,
I'm working on names handling in mdadm and I need to add some new test to the mdadm scope - to verify that it is working as desired. Bash is not best choice for testing and in current form, our tests are not friendly for developers. I would like to introduce another python based test scope and add it to repository. I will integrate it with current framework.

I can see that currently test are not well used and they aren't often updated. I want to bring new life to them. Adopting more modern approach seems to be good start point.
Any thoughts?

Thanks in advance,
Mariusz

#7 lore raw
Quoted 5 lines · Mariusz Tkaczyk

Hi,
I wanted to add it to the mdadm repo, let say under directory "python_tests". I didn't started work yet. Those tests should stay with mdadm, so we can develop them with Coly using mdadm-ci and later ask Jes to merge the branch.

I am fine and supportive to this idea. mdadm-tests is from the ci testing itself, I can copy python_tests to it time to time.

Quoted 6 lines

I don't have any details, I just asked to gather feedback. Seems that there is big interest in this change. If there is any volunteer to take this topic and prepare python API for testing and first tests- I will be pleased to help.

I could take long time before I will start this topic.

Let's wait for response. If no one response for a while, then the person should be me LOL. I am learning Python now, and the progress might take time anyway.

Thanks.

Coly Li

Quoted 52 lines

Thanks,
Mariusz

Quoted 45 lines · On Tue, 17 May 2022 10:00:32 +0800 ‪Coly Li‬ <[email protected]> wrote:

Hi Xiao,

Yes there is a git repo specific for test scripts, to test the mdadm-ci repo. It is located on kernel.org git server, which currently only contains bash scripts copied from mdadm.

Coly

From my phone

-------- 原始邮件 --------
发件人: Xiao Ni <[email protected]>
日期: 2022年5月17日周二 上午9:48
收件人: Mariusz Tkaczyk <[email protected]>
抄送: Nigel Croxon <[email protected]>, Coly Li <[email protected]>, Jes Sorensen <[email protected]>, linux-raid <[email protected]> 主 题: Re: mdadm test suite improvements Hi Mariusz

Quoted 26 lines

Thanks for the effort. Have you init the git project to start this? If so, you can send it, so we can
work together about this.

Best Regards
Xiao

Quoted 16 lines · Mariusz Tkaczyk

Hello All,
I'm working on names handling in mdadm and I need to add some new test to the mdadm scope - to verify that it is working as desired. Bash is not best choice for testing and in current form, our tests are not friendly for developers. I would like to introduce another python based test scope and add it to repository. I will integrate it with current framework.

I can see that currently test are not well used and they aren't often updated. I want to bring new life to them. Adopting more modern approach seems to be good start point.
Any thoughts?

Thanks in advance,
Mariusz