Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")
Subsystems (3)
v2 cover Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")
From: Matthias Brugger <[email protected]>
The mt8192-msdc clock is only a single clock gate. This gate is accessed from the mmc driver directly. With4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes") the only consumer of this binding was deleted. Delete the binding decription and the clock driver bound to it.
Changes in v2:
- Delete compatible in binding descprition as well
- add Reviewed-by tag
Matthias Brugger (2):
dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
clk: mediatek: Delete MT8192 msdc gate
.../arm/mediatek/mediatek,mt8192-clock.yaml | 8 ------- drivers/clk/mediatek/clk-mt8192-msdc.c | 21 ------------------- 2 files changed, 29 deletions(-)
Signature · 1 line
2.34.1
PATCH v2 1/2 dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
From: Matthias Brugger <[email protected]>
The msdc gate is part of the MMC driver. Delete the binding description of this node.
---
Changes in v2:
- Delete compatible in binding descprition as well
.../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 -------- 1 file changed, 8 deletions(-)
Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +0 -8
@@ -24,7 +24,6 @@ properties: - mediatek,mt8192-imp_iic_wrap_w - mediatek,mt8192-imp_iic_wrap_n - mediatek,mt8192-msdc_top - - mediatek,mt8192-msdc - mediatek,mt8192-mfgcfg - mediatek,mt8192-imgsys - mediatek,mt8192-imgsys2
@@ -107,13 +106,6 @@ examples: #clock-cells = <1>; }; - - | - msdc: clock-controller@11f60000 { - compatible = "mediatek,mt8192-msdc"; - reg = <0x11f60000 0x1000>; - #clock-cells = <1>; - }; - - | mfgcfg: clock-controller@13fbf000 { compatible = "mediatek,mt8192-mfgcfg";
Signature · 1 line
2.34.1
Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
Il 29/04/22 14:31, [email protected] ha scritto:
Quoted 6 lines
From: Matthias Brugger <[email protected]>
The msdc gate is part of the MMC driver. Delete the binding description of this node.
Signed-off-by Matthias Brugger <[email protected]>
Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
In reply to [email protected]Quoted 4 lines
The msdc gate is part of the MMC driver. Delete the binding description of this node.
Signed-off-by Matthias Brugger <[email protected]>
Rob Herring
maintainerRe: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
In reply to [email protected]Quoted 4 lines · On Fri, Apr 29, 2022 at 02:31:31PM +0200, [email protected] wrote:
From: Matthias Brugger <[email protected]>
The msdc gate is part of the MMC driver. Delete the binding description of this node.
An ABI break is okay because ...?
Quoted 40 lines
Signed-off-by Matthias Brugger <[email protected]>---
Changes in v2:
- Delete compatible in binding descprition as well.../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 -------- 1 file changed, 8 deletions(-)Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +0
-8@@ -24,7 +24,6 @@ properties: - mediatek,mt8192-imp_iic_wrap_w - mediatek,mt8192-imp_iic_wrap_n - mediatek,mt8192-msdc_top - - mediatek,mt8192-msdc - mediatek,mt8192-mfgcfg - mediatek,mt8192-imgsys - mediatek,mt8192-imgsys2@@ -107,13 +106,6 @@ examples: #clock-cells = <1>; }; - - | - msdc: clock-controller@11f60000 { - compatible = "mediatek,mt8192-msdc"; - reg = <0x11f60000 0x1000>; - #clock-cells = <1>; - }; - - | mfgcfg: clock-controller@13fbf000 { compatible = "mediatek,mt8192-mfgcfg";Signature · 1 line
2.34.1
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
Hi Rob,
Quoted 6 lines
Quoted 4 lines
From: Matthias Brugger <[email protected]>
The msdc gate is part of the MMC driver. Delete the binding description of this node.
An ABI break is okay because ...?
Sorry for that,
If the mediatek,mt8192-msdc part is removed from the driver,
Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
e.g.,
- mediatek,mt8192-msdc # deprecated
thanks,
Miles
Quoted 40 lines
Signed-off-by Matthias Brugger <[email protected]>---
Changes in v2:
- Delete compatible in binding descprition as well.../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 -------- 1 file changed, 8 deletions(-)Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +0
-8@@ -24,7 +24,6 @@ properties: - mediatek,mt8192-imp_iic_wrap_w - mediatek,mt8192-imp_iic_wrap_n - mediatek,mt8192-msdc_top - - mediatek,mt8192-msdc - mediatek,mt8192-mfgcfg - mediatek,mt8192-imgsys - mediatek,mt8192-imgsys2@@ -107,13 +106,6 @@ examples: #clock-cells = <1>; }; - - | - msdc: clock-controller@11f60000 { - compatible = "mediatek,mt8192-msdc"; - reg = <0x11f60000 0x1000>; - #clock-cells = <1>; - }; - - | mfgcfg: clock-controller@13fbf000 { compatible = "mediatek,mt8192-mfgcfg";Signature · 1 line
2.34.1
Rob Herring
maintainerRe: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
Quoted 4 lines · Miles Chen
Hi Rob,
Quoted 2 lines
Quoted 2 lines
From: Matthias Brugger <[email protected]>
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
The msdc gate is part of the MMC driver. Delete the binding description of this node.
An ABI break is okay because ...?
Sorry for that,
If the mediatek,mt8192-msdc part is removed from the driver,
That's an ABI break too. You just need to explain why as Matthias did in the commit message if the ABI break is okay.
Quoted 2 lines
Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
We do that sometimes, but depends on the situation.
Rob
Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
Hi Rob,
Quoted 8 lines · Miles Chen
Quoted 7 lines
Hi Rob,
Quoted 5 lines
Quoted 4 lines
From: Matthias Brugger <[email protected]>
The msdc gate is part of the MMC driver. Delete the binding description of this node.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
An ABI break is okay because ...?
Sorry for that,
If the mediatek,mt8192-msdc part is removed from the driver,
That's an ABI break too. You just need to explain why as Matthias did in the commit message if the ABI break is okay.
Thanks for your explanation.
I would like to learn more about this. In this case
If there was a user (say xxx.c) but the user was removed, can I remove mediatek,mt8192-msdc?
thanks,
Miles
Quoted 7 lines
Quoted 3 lines
Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
We do that sometimes, but depends on the situation.
Rob
Matthias Brugger
maintainerRe: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
In reply to Rob HerringQuoted 8 lines · Rob Herring
Quoted 4 lines · On Fri, Apr 29, 2022 at 02:31:31PM +0200, [email protected] wrote:
From: Matthias Brugger <[email protected]>
The msdc gate is part of the MMC driver. Delete the binding description of this node.
An ABI break is okay because ...?
Because the code controlling the clock gate was moved to the consumer. This node did never ever represent any working implementation of a peripheral. Just a lonely clock gate that wasn't used.
Regards,
Matthias
Quoted 40 lines
Quoted 40 lines
Signed-off-by Matthias Brugger <[email protected]>---
Changes in v2:
- Delete compatible in binding descprition as well.../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 -------- 1 file changed, 8 deletions(-)Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +0
-8@@ -24,7 +24,6 @@ properties: - mediatek,mt8192-imp_iic_wrap_w - mediatek,mt8192-imp_iic_wrap_n - mediatek,mt8192-msdc_top - - mediatek,mt8192-msdc - mediatek,mt8192-mfgcfg - mediatek,mt8192-imgsys - mediatek,mt8192-imgsys2@@ -107,13 +106,6 @@ examples: #clock-cells = <1>; }; - - | - msdc: clock-controller@11f60000 { - compatible = "mediatek,mt8192-msdc"; - reg = <0x11f60000 0x1000>; - #clock-cells = <1>; - }; - - | mfgcfg: clock-controller@13fbf000 { compatible = "mediatek,mt8192-mfgcfg";Signature · 1 line
2.34.1
Stephen Boyd
maintainerRe: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
Quoting Matthias Brugger (2022-05-05 09:47:30)
Quoted 9 lines · Rob Herring
Quoted 6 lines · On Fri, Apr 29, 2022 at 02:31:31PM +0200, [email protected] wrote:
Quoted 4 lines
From: Matthias Brugger <[email protected]>
The msdc gate is part of the MMC driver. Delete the binding description of this node.
Quoted 6 lines
Quoted 2 lines
An ABI break is okay because ...?
Because the code controlling the clock gate was moved to the consumer. This node did never ever represent any working implementation of a peripheral. Just a lonely clock gate that wasn't used.
Can you add that to the description and resend?
PATCH v2 2/2 clk: mediatek: Delete MT8192 msdc gate
In reply to [email protected]From: Matthias Brugger <[email protected]>
The msdc gate is part of the MMC driver. Delete the not used code.
---
Changes in v2:
- add Reviewed-by tag
drivers/clk/mediatek/clk-mt8192-msdc.c | 21 --------------------- 1 file changed, 21 deletions(-)
drivers/clk/mediatek/clk-mt8192-msdc.c +0 -21
@@ -12,28 +12,15 @@#include <dt-bindings/clock/mt8192-clk.h> -static const struct mtk_gate_regs msdc_cg_regs = { - .set_ofs =0xb4 , - .clr_ofs =0xb4 , - .sta_ofs =0xb4 , -}; -static const struct mtk_gate_regs msdc_top_cg_regs = { .set_ofs =0x0 , .clr_ofs =0x0 , .sta_ofs =0x0 , }; -#define GATE_MSDC (_id, _name, _parent, _shift) \ - GATE_MTK(_id, _name, _parent, &msdc_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv) -#define GATE_MSDC_TOP (_id, _name, _parent, _shift) \ GATE_MTK(_id, _name, _parent, &msdc_top_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv) -static const struct mtk_gate msdc_clks[] = { -GATE_MSDC (CLK_MSDC_AXI_WRAP ,"msdc_axi_wrap" ,"axi_sel" ,22 ), -}; -static const struct mtk_gate msdc_top_clks[] = {GATE_MSDC_TOP (CLK_MSDC_TOP_AES_0P ,"msdc_top_aes_0p" ,"aes_msdcfde_sel" ,0 ),GATE_MSDC_TOP (CLK_MSDC_TOP_SRC_0P ,"msdc_top_src_0p" ,"infra_msdc0_src" ,1 ),
@@ -52,11 +39,6 @@ static const struct mtk_gate msdc_top_clks[] = { GATE_MSDC_TOP(CLK_MSDC_TOP_AHB2AXI_BRG_AXI, "msdc_top_ahb2axi_brg_axi", "axi_sel", 14), }; -static const struct mtk_clk_desc msdc_desc = { - .clks = msdc_clks, - .num_clks =ARRAY_SIZE (msdc_clks), -}; -static const struct mtk_clk_desc msdc_top_desc = { .clks = msdc_top_clks, .num_clks =ARRAY_SIZE (msdc_top_clks),
@@ -64,9 +46,6 @@ static const struct mtk_clk_desc msdc_top_desc = {static const struct of_device_id of_match_clk_mt8192_msdc[] = { { - .compatible ="mediatek,mt8192-msdc" , - .data = &msdc_desc, - }, { .compatible ="mediatek,mt8192-msdc_top" , .data = &msdc_top_desc, }, {
Signature · 1 line
2.34.1
Re: [PATCH v2 2/2] clk: mediatek: Delete MT8192 msdc gate
Quoted 4 lines
The msdc gate is part of the MMC driver. Delete the not used code.
Signed-off-by Matthias Brugger <[email protected]>Reviewed-by AngeloGioacchino Del Regno <[email protected]>