Skip to contentSkip to conversation

x86/vmware: use unsigned integer for shifting

PATCH Superseded Shreenidhi Shedi 1 participant 1 message May 23, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 x86/vmware: use unsigned integer for shifting

From: Shreenidhi Shedi <[email protected]>

Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.

Fixes 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform")
---
 arch/x86/kernel/cpu/vmware.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/vmware.c +3 -2
index c04b933f48d3..25a4366dc5e3 100644
@@ -28,6 +28,7 @@
 #include <linux/cpu.h>
 #include <linux/reboot.h>
 #include <linux/static_call.h>
+#include <linux/bits.h>
 #include <asm/div64.h>
 #include <asm/x86_init.h>
 #include <asm/hypervisor.h>
@@ -476,8 +477,8 @@ static bool __init vmware_legacy_x2apic_available(void)
 {
 	uint32_t eax, ebx, ecx, edx;
 	VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx);
-	return (eax & (1 << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
-	       (eax & (1 << VMWARE_CMD_LEGACY_X2APIC)) != 0;
+	return !(eax & BIT(VMWARE_CMD_VCPU_RESERVED)) &&
+		(eax & BIT(VMWARE_CMD_LEGACY_X2APIC));
 }
 
 #ifdef CONFIG_AMD_MEM_ENCRYPT

--
2.36.1