Skip to contentSkip to conversation

x86/vmware: use unsigned integer for shifting

PATCH In review Shreenidhi Shedi 3 participants 3 messages May 27, 2022 – May 31, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 x86/vmware: use unsigned integer for shifting

From: Shreenidhi Shedi <[email protected]>

Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.

Fixes 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform")
---
 arch/x86/kernel/cpu/vmware.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/vmware.c +2 -2
index c04b933f4..02039ec35 100644
@@ -476,8 +476,8 @@ static bool __init vmware_legacy_x2apic_available(void)
 {
 	uint32_t eax, ebx, ecx, edx;
 	VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx);
-	return (eax & (1 << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
-	       (eax & (1 << VMWARE_CMD_LEGACY_X2APIC)) != 0;
+	return !(eax & BIT(VMWARE_CMD_VCPU_RESERVED)) &&
+		(eax & BIT(VMWARE_CMD_LEGACY_X2APIC));
 }
 
 #ifdef CONFIG_AMD_MEM_ENCRYPT

--
2.36.1

#1 lore raw
Quoted 4 lines · Shreenidhi Shedi

From: Shreenidhi Shedi <[email protected]>

Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.

The kernel builds with -fno-strict-overflow and as such this behaviour is well defined.

Quoted 1 line
Fixes 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform")

Nothing broken, therefore nothing fixed.
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#2 lore raw
Quoted 9 lines · Peter Zijlstra
Quoted 4 lines · Shreenidhi Shedi

From: Shreenidhi Shedi <[email protected]>

Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.

The kernel builds with -fno-strict-overflow and as such this behaviour is well defined.

Ah, I see. Thank you, Peter!

Quoted 4 lines
Quoted 1 line
Fixes 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform")

Nothing broken, therefore nothing fixed.

Agreed.

I think using the BIT() macro still provides a nice readability improvement. So, Shreenidhi, could you spin a new version of the patch with the same code changes but with a different commit message about using the BIT() macro to simplify the code, and also include a clarification as to why the existing code is correct (which Peter pointed out), please?

Thank you!

Regards,
Srivatsa
VMware Photon OS
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization