Skip to contentSkip to conversation

mm/daemon: describe NR_DAMON_OPS in damon_ops_id

PATCH In review Khalid Masum 2 participants 2 messages May 23, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/daemon: describe NR_DAMON_OPS in damon_ops_id

NR_DAMON_OPS in the enum damon_ops_id is not described. Describe it for better readability and also to fix a warning generated by make docs.

"NR" is described as "Total Number" and "DAMON_OPS" is described as "Monitoring operations" in the same file. Hence describe NR_DAMON_OPS as "Total number of damon operations".

---
 include/linux/damon.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/damon.h +1 -0
index f23cbfa42..9e9fb4d78 100644
@@ -262,6 +262,7 @@ struct damos {
  *
  * @DAMON_OPS_VADDR:	Monitoring operations for virtual address spaces
  * @DAMON_OPS_PADDR:	Monitoring operations for the physical address space
+ * @NR_DAMON_OPS:	Total number of monitoring operations
  */
 enum damon_ops_id {
 	DAMON_OPS_VADDR,
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Hi Khalid,

Quoted 6 lines · On Tue, 24 May 2022 02:53:36 +0600 Khalid Masum <[email protected]>…

NR_DAMON_OPS in the enum damon_ops_id is not described. Describe it for better readability and also to fix a warning generated by make docs.

"NR" is described as "Total Number" and "DAMON_OPS" is described as "Monitoring operations" in the same file. Hence describe NR_DAMON_OPS as "Total number of damon operations".

Thank you for this patch! However, same patch has already posted by other and merged in mm-stable[1], sorry. Looking forward to your next patches, though!

[1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-stable&id=d4a157f5a26fbf1f1fd5da47a4772a738306348f

Thanks,
SJ

Quoted 21 lines
---
 include/linux/damon.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/damon.h +1 -0
index f23cbfa42..9e9fb4d78 100644
@@ -262,6 +262,7 @@ struct damos {
  *
  * @DAMON_OPS_VADDR:	Monitoring operations for virtual address spaces
  * @DAMON_OPS_PADDR:	Monitoring operations for the physical address space
+ * @NR_DAMON_OPS:	Total number of monitoring operations
  */
 enum damon_ops_id {
 	DAMON_OPS_VADDR,
Signature · 1 line
2.25.1