Skip to contentSkip to conversation

net: Add missing PCI dependency for CONFIG_E1000

PATCH In review Pali Rohár 4 participants 6 messages May 23, 2022 – May 25, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: Add missing PCI dependency for CONFIG_E1000

---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +1 -0
index 7fe0e00649cf..84d859c21eb8 100644
@@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
 
 config E1000
 	bool "Intel PRO/1000 Gigabit Ethernet support"
+	depends on PCI
 	help
 	  This driver supports Intel(R) PRO/1000 gigabit ethernet family of
 	  adapters.  For more information on how to identify your adapter, go
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Pali Rohár
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +1 -1
index 7fe0e00649cf..84d859c21eb8 100644
@@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
 
 config E1000
        bool "Intel PRO/1000 Gigabit Ethernet support"
+       depends on PCI
        help
          This driver supports Intel(R) PRO/1000 gigabit ethernet family of
          adapters.  For more information on how to identify your adapter, go
--
Quoted 2 lines

2.20.1

#2 lore raw
In reply to Pali Rohár

Hi Pali,

Quoted 11 lines · Pali Rohár
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +0 -0
index 7fe0e00649cf..84d859c21eb8 100644

drivers/net/Kconfig config DWC_ETH_QOS_TEGRA186 · line 237

Quoted 7 lines
drivers/net/Kconfig +1 -0
@@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
 
 config E1000
 	bool "Intel PRO/1000 Gigabit Ethernet support"
+	depends on PCI
 	help
 	  This driver supports Intel(R) PRO/1000 gigabit ethernet family of
 	  adapters.  For more information on how to identify your adapter, go

This appears to be a duplicate of [1].

[1] https://lore.kernel.org/u-boot/[email protected]/

--Sean

#3 lore raw
Quoted 24 lines · On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:

Hi Pali,

Quoted 11 lines · Pali Rohár
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +0 -0
index 7fe0e00649cf..84d859c21eb8 100644

drivers/net/Kconfig config DWC_ETH_QOS_TEGRA186 · line 237

Quoted 7 lines
drivers/net/Kconfig +1 -0
@@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
 
 config E1000
 	bool "Intel PRO/1000 Gigabit Ethernet support"
+	depends on PCI
 	help
 	  This driver supports Intel(R) PRO/1000 gigabit ethernet family of
 	  adapters.  For more information on how to identify your adapter, go

This appears to be a duplicate of [1].

Quoted 3 lines

[1] https://lore.kernel.org/u-boot/[email protected]/

--Sean

Interesting... this is my second duplicate patch this week.

Any idea why above patch was not accepted yet?

I'm just testing U-Boot builds and I hit the same issue in dependency graph.

#4 lore raw
Quoted 25 lines · Pali Rohár
Quoted 24 lines · On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:

Hi Pali,

Quoted 11 lines · Pali Rohár
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +0 -0
index 7fe0e00649cf..84d859c21eb8 100644

drivers/net/Kconfig config DWC_ETH_QOS_TEGRA186 · line 237

Quoted 7 lines
drivers/net/Kconfig +1 -0
@@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
 
 config E1000
 	bool "Intel PRO/1000 Gigabit Ethernet support"
+	depends on PCI
 	help
 	  This driver supports Intel(R) PRO/1000 gigabit ethernet family of
 	  adapters.  For more information on how to identify your adapter, go

This appears to be a duplicate of [1].

Quoted 7 lines
Quoted 3 lines

[1] https://lore.kernel.org/u-boot/[email protected]/

--Sean

Interesting... this is my second duplicate patch this week.

Any idea why above patch was not accepted yet?

Looks like Ramon has not done a pull request since mid April [1]. Though based on the past pattern, it seems like he just makes one PR each release. Perhaps Tom can pick this up?

[1] https://lore.kernel.org/u-boot/CAGi-RUK9peV+J8ocjXTEjxNKy-LM+3sGYsCKUYjeRhLDzxacXQ@mail.gmail.com/

--Sean

#5 lore raw
Quoted 34 lines · Sean Anderson
Quoted 31 lines · Pali Rohár
Quoted 24 lines · On Tuesday 24 May 2022 13:12:02 Sean Anderson wrote:

Hi Pali,

Quoted 11 lines · Pali Rohár
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/Kconfig +0 -0
index 7fe0e00649cf..84d859c21eb8 100644

drivers/net/Kconfig config DWC_ETH_QOS_TEGRA186 · line 237

Quoted 7 lines
drivers/net/Kconfig +1 -0
@@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186
 
 config E1000
 	bool "Intel PRO/1000 Gigabit Ethernet support"
+	depends on PCI
 	help
 	  This driver supports Intel(R) PRO/1000 gigabit ethernet family of
 	  adapters.  For more information on how to identify your adapter, go

This appears to be a duplicate of [1].

Quoted 3 lines

[1] https://lore.kernel.org/u-boot/[email protected]/

--Sean

Interesting... this is my second duplicate patch this week.

Quoted 7 lines
Quoted 1 line

Any idea why above patch was not accepted yet?

Looks like Ramon has not done a pull request since mid April [1]. Though based on the past pattern, it seems like he just makes one PR each release. Perhaps Tom can pick this up?

[1] https://lore.kernel.org/u-boot/CAGi-RUK9peV+J8ocjXTEjxNKy-LM+3sGYsCKUYjeRhLDzxacXQ@mail.gmail.com/

Sure. It didn't stand out as a critical thing so I was assuming at the time it would come in eventually. I've put it in my bundle of stuff to not forget.

Signature · 1 line
Tom