Skip to contentSkip to conversation

dt-bindings: PCI: apple: Add missing 'power-domains' property

PATCH Applied Rob Herring 2 participants 3 messages May 31, 2022 – Jun 2, 2022

Subsystems (4)
Device tree bindings PCI PCI native host bridge and endpoint drivers Arm/Apple machine support
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v2 1/1 dt-bindings: PCI: apple: Add missing 'power-domains' property

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.

The Apple PCIe host schema is missing 'power-domains' in the schema. The example has 3 power domains. However, this is wrong too as actual dts files have a single power domain and Sven confirmed 1 is correct.

Cc Sven Peter <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
v2:
- Correct the power-domains to be 1 and update the example

---
 Documentation/devicetree/bindings/pci/apple,pcie.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/apple,pcie.yaml +4 -1
index daf602ac0d0f..aa38680aaaca 100644
@@ -68,6 +68,9 @@ properties:
   iommu-map: true
   iommu-map-mask: true
 
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg

@@ -134,7 +137,7 @@ examples:
         ranges = <0x43000000 0x6 0xa0000000 0x6 0xa0000000 0x0 0x20000000>,
                  <0x02000000 0x0 0xc0000000 0x6 0xc0000000 0x0 0x40000000>;
 
-        power-domains = <&ps_apcie>, <&ps_apcie_gp>, <&ps_pcie_ref>;
+        power-domains = <&ps_apcie_gp>;
         pinctrl-0 = <&pcie_pins>;
         pinctrl-names = "default";
Signature · 1 line
2.34.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Rob Herring

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.

Quoted 6 lines

The Apple PCIe host schema is missing 'power-domains' in the schema. The example has 3 power domains. However, this is wrong too as actual dts files have a single power domain and Sven confirmed 1 is correct.

Cc Sven Peter <[email protected]>
Signed-off-by Rob Herring <[email protected]>
Reviewed-by Sven Peter <[email protected]>
author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.

The Apple PCIe host schema is missing 'power-domains' in the schema. The example has 3 power domains. However, this is wrong too as actual dts files have a single power domain and Sven confirmed 1 is correct.

Quoted 9 lines
Cc Sven Peter <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
v2:
- Correct the power-domains to be 1 and update the example

---
 Documentation/devicetree/bindings/pci/apple,pcie.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks!