dt-bindings: PCI: apple: Add missing 'power-domains' property
Subsystems (4)
Rob Herring
maintainerPATCH 1/1 dt-bindings: PCI: apple: Add missing 'power-domains' property
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
The Apple PCIe host has 3 power domains at least according to the example. Add the 'power-domains' property to the schema.
---
Ideally, we'd define what each power domain is, but I don't know what they are.
--- Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/pci/apple,pcie.yaml +3 -0
@@ -68,6 +68,9 @@ properties: iommu-map: true iommu-map-mask: true + power-domains: + maxItems: 3 + required: - compatible - reg
Signature · 1 line
2.34.1
Rob Herring
maintainerQuoted 7 lines · Rob Herring
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
The Apple PCIe host has 3 power domains at least according to the example. Add the 'power-domains' property to the schema.
Quoted 8 lines
Signed-off-by Rob Herring <[email protected]>---
Ideally, we'd define what each power domain is, but I don't know what they are.--- Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 +++ 1 file changed, 3 insertions(+)
Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
pcie@690000000: power-domains: [[59]] is too short
arch/arm64/boot/dts/apple/t8103-j274.dtb arch/arm64/boot/dts/apple/t8103-j293.dtb arch/arm64/boot/dts/apple/t8103-j313.dtb arch/arm64/boot/dts/apple/t8103-j456.dtb arch/arm64/boot/dts/apple/t8103-j457.dtb
Hi,
Quoted 4 lines · Rob Herring
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
Quoted 8 lines
The Apple PCIe host has 3 power domains at least according to the example. Add the 'power-domains' property to the schema.
Signed-off-by Rob Herring <[email protected]>---
Ideally, we'd define what each power domain is, but I don't know what they are.
---
I think the example is just wrong (or outdated) and we only need a single power-domain for pcie.
The hierarchy is ps_pcie_ref -> ps_apcie -> ps_apcie_gp and the pcie node then only depends on ps_apcie_gp.
Sven
Rob Herring
maintainerQuoted 17 lines · Sven Peter
Hi,
Quoted 4 lines · Rob Herring
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
Quoted 8 lines
The Apple PCIe host has 3 power domains at least according to the example. Add the 'power-domains' property to the schema.
Signed-off-by Rob Herring <[email protected]>---
Ideally, we'd define what each power domain is, but I don't know what they are.
---
Quoted 5 lines
I think the example is just wrong (or outdated) and we only need a single power-domain for pcie.
The hierarchy is
ps_pcie_ref->ps_apcie->ps_apcie_gpand the pcie node then only depends onps_apcie_gp.
Okay, I'll update the example and schema.