Skip to contentSkip to conversation

s390/kvm: avoid hypfs error message

PATCH Superseded Juergen Gross 3 participants 6 messages Jun 7, 2022 – Jun 20, 2022 s390

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390/kvm: avoid hypfs error message

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

While being documented, they can easily be avoided by bailing out of hypfs_init() early in case of running as a KVM guest.

---
 arch/s390/hypfs/inode.c | 3 +++
 1 file changed, 3 insertions(+)
arch/s390/hypfs/inode.c +3 -0
index 5c97f48cea91..bdf078f3c641 100644
@@ -464,6 +464,9 @@ static int __init hypfs_init(void)
 {
 	int rc;
 
+	if (MACHINE_IS_KVM)
+		return -ENODATA;
+
 	hypfs_dbfs_init();
 
 	if (hypfs_diag_init()) {
Signature · 1 line
2.35.3
#1 lore raw

Ping?

Quoted 27 lines · Juergen Gross

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

While being documented, they can easily be avoided by bailing out of hypfs_init() early in case of running as a KVM guest.

---
  arch/s390/hypfs/inode.c | 3 +++
  1 file changed, 3 insertions(+)
arch/s390/hypfs/inode.c +3 -0
index 5c97f48cea91..bdf078f3c641 100644
@@ -464,6 +464,9 @@ static int __init hypfs_init(void)
  {
  	int rc;
 
+	if (MACHINE_IS_KVM)
+		return -ENODATA;
+
  	hypfs_dbfs_init();
 
  	if (hypfs_diag_init()) {
#2 lore raw

Am 20.06.22 um 08:03 schrieb Juergen Gross:

Quoted 16 lines

Ping?

Quoted 13 lines · Juergen Gross

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

While being documented, they can easily be avoided by bailing out of hypfs_init() early in case of running as a KVM guest.

---
  arch/s390/hypfs/inode.c | 3 +++

  1 file changed, 3 insertions(+)
Quoted 12 lines

arch/s390/hypfs/inode.c static int __init hypfs_init(void) · line 470

Quoted 12 lines
arch/s390/hypfs/inode.c +3 -0
index 5c97f48cea91..bdf078f3c641 100644
@@ -464,6 +464,9 @@ static int __init hypfs_init(void)
   {
       int rc;
+    if (MACHINE_IS_KVM)
+        return -ENODATA;
+
       hypfs_dbfs_init();
       if (hypfs_diag_init()) {

In case KVM implements hypfs this check would then be wrong. Question to people on CC/TO.
Would it be an option to still check with KVM but avoid the error message. So basically changing hypfs_diag_init and fail_dbfs_exit to check for KVM on error?
Or is this worse?

maintainer
#3 lore raw
Quoted 28 lines · Christian Borntraeger

Am 20.06.22 um 08:03 schrieb Juergen Gross:

Quoted 27 lines

Ping?

Quoted 24 lines · Juergen Gross

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

While being documented, they can easily be avoided by bailing out of hypfs_init() early in case of running as a KVM guest.

---
  arch/s390/hypfs/inode.c | 3 +++

  1 file changed, 3 insertions(+)
arch/s390/hypfs/inode.c +3 -0
index 5c97f48cea91..bdf078f3c641 100644
@@ -464,6 +464,9 @@ static int __init hypfs_init(void)
   {
       int rc;
+    if (MACHINE_IS_KVM)
+        return -ENODATA;
+
       hypfs_dbfs_init();
Quoted 8 lines
Quoted 1 line

arch/s390/hypfs/inode.c static int __init hypfs_init(void) · line 472

Quoted 1 line
arch/s390/hypfs/inode.c +0 -0
       if (hypfs_diag_init()) {

In case KVM implements hypfs this check would then be wrong. Question to people on CC/TO.
Would it be an option to still check with KVM but avoid the error message. So basically changing hypfs_diag_init and fail_dbfs_exit to check for KVM on error?
Or is this worse?

I'd say just move the pr_err("Initialization of hypfs failed with...") one label above to fail_hypfs_diag_exit. Then we still get the message that the hardware system doesn't support hypfs, which seems to be wanted, and the error message only appears for an error.

Even though I personally dislike printing everything to the console this seems to be what is/was preferred. So let's keep that.

#4 lore raw
Quoted 38 lines · Heiko Carstens
Quoted 28 lines · Christian Borntraeger

Am 20.06.22 um 08:03 schrieb Juergen Gross:

Quoted 27 lines

Ping?

Quoted 24 lines · Juergen Gross

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

While being documented, they can easily be avoided by bailing out of hypfs_init() early in case of running as a KVM guest.

---
   arch/s390/hypfs/inode.c | 3 +++
   1 file changed, 3 insertions(+)
arch/s390/hypfs/inode.c +3 -0
index 5c97f48cea91..bdf078f3c641 100644
@@ -464,6 +464,9 @@ static int __init hypfs_init(void)
   {
       int rc;
+    if (MACHINE_IS_KVM)
+        return -ENODATA;
+
       hypfs_dbfs_init();
Quoted 8 lines
Quoted 1 line

arch/s390/hypfs/inode.c static int __init hypfs_init(void) · line 472

Quoted 1 line
arch/s390/hypfs/inode.c +0 -0
       if (hypfs_diag_init()) {

In case KVM implements hypfs this check would then be wrong. Question to people on CC/TO.
Would it be an option to still check with KVM but avoid the error message. So basically changing hypfs_diag_init and fail_dbfs_exit to check for KVM on error?
Or is this worse?

Quoted 7 lines

I'd say just move the pr_err("Initialization of hypfs failed with...") one label above to fail_hypfs_diag_exit. Then we still get the message that the hardware system doesn't support hypfs, which seems to be wanted, and the error message only appears for an error.

Even though I personally dislike printing everything to the console this seems to be what is/was preferred. So let's keep that.

Works for me.

Would you be fine with additionally:

@@ __init int hypfs_diag_init(void)

         int rc;

         if (diag204_probe()) {
-                pr_err("The hardware system does not support hypfs\n");
+                pr_info("The hardware system does not support hypfs\n");
                 return -ENODATA;
         }

As this not really an error.

Juergen

#5 lore raw

Am 20.06.22 um 11:25 schrieb Juergen Gross:

Quoted 54 lines · Heiko Carstens
Quoted 38 lines · Christian Borntraeger
Quoted 28 lines

Am 20.06.22 um 08:03 schrieb Juergen Gross:

Quoted 27 lines

Ping?

Quoted 24 lines · Juergen Gross

When booting under KVM the following error messages are issued:

hypfs.7f5705: The hardware system does not support hypfs hypfs.7a79f0: Initialization of hypfs failed with rc=-61

While being documented, they can easily be avoided by bailing out of hypfs_init() early in case of running as a KVM guest.

---
   arch/s390/hypfs/inode.c | 3 +++

   1 file changed, 3 insertions(+)
arch/s390/hypfs/inode.c +3 -0
index 5c97f48cea91..bdf078f3c641 100644
@@ -464,6 +464,9 @@ static int __init hypfs_init(void)
    {
        int rc;
+    if (MACHINE_IS_KVM)
+        return -ENODATA;
+
        hypfs_dbfs_init();
Quoted 8 lines
Quoted 1 line

arch/s390/hypfs/inode.c static int __init hypfs_init(void) · line 472

Quoted 1 line
arch/s390/hypfs/inode.c +0 -0
        if (hypfs_diag_init()) {

In case KVM implements hypfs this check would then be wrong. Question to people on CC/TO.
Would it be an option to still check with KVM but avoid the error message. So basically changing hypfs_diag_init and fail_dbfs_exit to check for KVM on error?
Or is this worse?

Quoted 7 lines

I'd say just move the pr_err("Initialization of hypfs failed with...") one label above to fail_hypfs_diag_exit. Then we still get the message that the hardware system doesn't support hypfs, which seems to be wanted, and the error message only appears for an error.

Even though I personally dislike printing everything to the console this seems to be what is/was preferred. So let's keep that.

Works for me.

Would you be fine with additionally:

@@ __init int hypfs_diag_init(void)
         int rc;

Quoted 7 lines

         if (diag204_probe()) {
-                pr_err("The hardware system does not support hypfs\n"); +                pr_info("The hardware system does not support hypfs\n");
                 return -ENODATA;
         }

As this not really an error.

Yes, makes sense.