Skip to contentSkip to conversation

s390x: add migration test for storage keys

PATCH Superseded Nico Boehr 1 participant 2 messages Jun 13, 2022

Subsystems (2)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Nico Boehr

author
#0 lore raw

v5 cover s390x: add migration test for storage keys

v4->v5:
----
* don't print message on every skey tested (thanks Janosch)
* extend some comments (Thanks Janosch)

v3->v4:
----
* remove useless goto (Thanks Thomas)

v2->v3:
----
* remove some useless variables, style suggestions, improve commit description (thanks Janis)
* reverse christmas tree (thanks Claudio)

v1->v2:
----
* As per discussion with Janis and Claudio, remove the actual access check from the test. This also allows us to remove the check_pgm_int_code_xfail() patch.
* Typos/Style suggestions (thanks Janis)

Upon migration, we expect storage keys set by the guest to be preserved, so add a test for it.

We keep 128 pages and set predictable storage keys. Then, we migrate and check they can be read back.

Nico Boehr (1):
s390x: add migration test for storage keys

 s390x/Makefile         |  1 +
 s390x/migration-skey.c | 78 ++++++++++++++++++++++++++++++++++++++++++
 s390x/unittests.cfg    |  4 +++
 3 files changed, 83 insertions(+)
 create mode 100644 s390x/migration-skey.c
Signature · 1 line
2.36.1
author
#1 lore raw

PATCH v5 1/1 s390x: add migration test for storage keys

Upon migration, we expect storage keys set by the guest to be preserved, so add a test for it.

We keep 128 pages and set predictable storage keys. Then, we migrate and check that they can be read back and match the value originally set.

---
 s390x/Makefile         |  1 +
 s390x/migration-skey.c | 78 ++++++++++++++++++++++++++++++++++++++++++
 s390x/unittests.cfg    |  4 +++
 3 files changed, 83 insertions(+)
 create mode 100644 s390x/migration-skey.c
s390x/Makefile +1 -0
index a8e04aa6fe4d..f8ea594b641d 100644
@@ -32,6 +32,7 @@ tests += $(TEST_DIR)/epsw.elf
 tests += $(TEST_DIR)/adtl-status.elf
 tests += $(TEST_DIR)/migration.elf
 tests += $(TEST_DIR)/pv-attest.elf
+tests += $(TEST_DIR)/migration-skey.elf
 
 pv-tests += $(TEST_DIR)/pv-diags.elf
 
s390x/migration-skey.c new file +78 -0

78 lines not on this page · raw message

s390x/unittests.cfg +4 -0
index b456b2881448..1e851d8e3dd8 100644
@@ -176,3 +176,7 @@ extra_params = -cpu qemu,gs=off,vx=off
 file = migration.elf
 groups = migration
 smp = 2
+
+[migration-skey]
+file = migration-skey.elf
+groups = migration
Signature · 1 line
2.36.1