Skip to content

s390x: add migration test for storage keys

Nico Boehr kvm linux-s390 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest1 patch 1 replyIn review
  2. v51 patch 0 repliesSuperseded
  3. v41 patch 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v31 patch3 repliesSuperseded
v21 patch6 repliesSuperseded
v12 patches10 repliesSuperseded

Changes in v6 from the cover letter

----
* add comment to explain why reference bit is ignored (thanks Janosch)

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1s390x: add migration test for storage keyss390x/Makefile s390x/migration-skey.c s390x/unittests.cfg+88 -01 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchClaudio ImbrendaThomas HuthJanosch Frank
1/1R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [kvm-unit-tests PATCH v6 0/1] s390x: add migration test for storage keys

v5->v6:
----
* add comment to explain why reference bit is ignored (thanks Janosch)

v4->v5:
----
* don't print message on every skey tested (thanks Janosch)
* extend some comments (Thanks Janosch)

v3->v4:
----
* remove useless goto (Thanks Thomas)

v2->v3:
----
* remove some useless variables, style suggestions, improve commit description (thanks Janis)
* reverse christmas tree (thanks Claudio)

v1->v2:
----
* As per discussion with Janis and Claudio, remove the actual access check from the test. This also allows us to remove the check_pgm_int_code_xfail() patch.
* Typos/Style suggestions (thanks Janis)

Upon migration, we expect storage keys set by the guest to be preserved, so add a test for it.

We keep 128 pages and set predictable storage keys. Then, we migrate and check they can be read back.

Nico Boehr (1):
s390x: add migration test for storage keys

 s390x/Makefile         |  1 +
 s390x/migration-skey.c | 83 ++++++++++++++++++++++++++++++++++++++++++
 s390x/unittests.cfg    |  4 ++
 3 files changed, 88 insertions(+)
 create mode 100644 s390x/migration-skey.c
Signature · 1 line
2.36.1