spi: nxp_fspi: Fix clock imbalance
PATCH 1/1 spi: nxp_fspi: Fix clock imbalance
The nxp_fspi_default_setup() is only ever called from nxp_fspi_probe(), where the IP clock are initially disabled. Drop the second disabling of clock to prevent clock enable/disable imbalance reported by clock core:
"
clk qspi_root_clk already disabled
"
--- drivers/spi/nxp_fspi.c | 3 --- 1 file changed, 3 deletions(-)
drivers/spi/nxp_fspi.c +0 -3
@@ -866,9 +866,6 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f)u32 reg;#if CONFIG_IS_ENABLED (CLK ) -/* disable and unprepare clock to avoid glitch pass to controller */ -nxp_fspi_clk_disable_unprep (f); -/* the default frequency, we will change it later if necessary. */ ret =clk_set_rate (&f->clk,20000000 );if (ret <0 )
Signature · 1 line
2.35.1
Quoted 4 lines · Marek Vasut
The
nxp_fspi_default_setup()is only ever called fromnxp_fspi_probe(), where the IP clock are initially disabled. Drop the second disabling of clock to prevent clock enable/disable imbalance reported by clock core:
Quoted 8 lines
"
clkqspi_root_clkalready disabled
"Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>
Quoted 18 lines
--- drivers/spi/nxp_fspi.c | 3 --- 1 file changed, 3 deletions(-)drivers/spi/nxp_fspi.c +0
-3@@ -866,9 +866,6 @@ static int nxp_fspi_default_setup(struct nxp_fspi *f)u32 reg;#if CONFIG_IS_ENABLED (CLK ) -/* disable and unprepare clock to avoid glitch pass to controller */ -nxp_fspi_clk_disable_unprep (f); -/* the default frequency, we will change it later if necessary. */ ret =clk_set_rate (&f->clk,20000000 );if (ret <0 )
PATCH 1/1 spi: nxp_fspi: Fix clock imbalance
In reply to Marek VasutQuoted 11 lines
The
nxp_fspi_default_setup()is only ever called fromnxp_fspi_probe(), where the IP clock are initially disabled. Drop the second disabling of clock to prevent clock enable/disable imbalance reported by clock core:
"
clkqspi_root_clkalready disabled
"Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================