Skip to contentSkip to conversation

Add R16 Vista E board from RenewWorldOutreach

PATCH Superseded Suniel Mahesh 3 participants 8 messages Jun 15, 2022 – Jul 11, 2022

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add R16 Vista E board from RenewWorldOutreach

This patch series adds the R16-Vista-E board from RenewWorldOutreach based on allwinner R16(A33).

Patch 1/2 adds the dt-bindings for the board.

Patch 2/2 adds the board with the following below features:

General features:
- 1GB RAM
- microSD slot
- Realtek Wifi
- 1 x USB 2.0
- HDMI IN
- HDMI OUT
- Audio out
- MIPI DSI
- TI DLPC3433

It has also connectors to connect an external mini keypad.

Suniel Mahesh (2):
dt-bindings: arm: sunxi: Add binding for RenewWorldOutReach
R16-Vista-E board
ARM: dts: sun8i: Add R16 Vista E board from RenewWorldOutreach

 .../devicetree/bindings/arm/sunxi.yaml        |   6 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts | 361 ++++++++++++++++++
 3 files changed, 368 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/2 dt-bindings: arm: sunxi: Add binding for RenewWorldOutReach R16-Vista-E board

Add a binding for the RenewWorldOutReach R16-Vista-E board based on allwinner R16.

---
Changes for v2:
- Add missing compatible string
- insert missing signatures of contributors

---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/sunxi.yaml +6 -0
index 95278a6a9a8e..52b8c9aba6f3 100644
@@ -787,6 +787,12 @@ properties:
           - const: allwinner,r7-tv-dongle
           - const: allwinner,sun5i-a10s
 
+      - description: RenewWorldOutreach R16-Vista-E
+        items:
+          - const: renewworldoutreach,r16-vista-e
+          - const: allwinner,sun8i-r16
+          - const: allwinner,sun8i-a33
+
       - description: RerVision H3-DVK
         items:
           - const: rervision,h3-dvk
Signature · 1 line
2.25.1
maintainer Acked-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: sunxi: Add binding for RenewWorldOutReach R16-Vista-E board

Quoted 6 lines · Suniel Mahesh

Add a binding for the RenewWorldOutReach R16-Vista-E board based on allwinner R16.

Quoted 8 lines

---
Changes for v2:
- Add missing compatible string
- insert missing signatures of contributors

---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
maintainer
#3 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: sunxi: Add binding for RenewWorldOutReach R16-Vista-E board

In reply to Suniel Mahesh
Quoted 6 lines · Suniel Mahesh

Add a binding for the RenewWorldOutReach R16-Vista-E board based on allwinner R16.

The primary author of the commit (the From:) should be the first signer, unless you are using Co-developed-by:. See the examples here:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Quoted 13 lines

---
Changes for v2:
- Add missing compatible string
- insert missing signatures of contributors

---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/sunxi.yaml +0 -0
index 95278a6a9a8e..52b8c9aba6f3 100644

Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 792

Quoted 6 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +3 -0
@@ -787,6 +787,12 @@ properties:
           - const: allwinner,r7-tv-dongle
           - const: allwinner,sun5i-a10s
 
+      - description: RenewWorldOutreach R16-Vista-E
+        items:
+          - const: renewworldoutreach,r16-vista-e

This vendor prefix should be documented.

Regards,
Samuel

Quoted 7 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +3 -0
+          - const: allwinner,sun8i-r16
+          - const: allwinner,sun8i-a33
+
       - description: RerVision H3-DVK
         items:
           - const: rervision,h3-dvk
#4 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: sunxi: Add binding for RenewWorldOutReach R16-Vista-E board

Hi Samuel,

Quoted 32 lines · Samuel Holland
Quoted 6 lines · Suniel Mahesh

Add a binding for the RenewWorldOutReach R16-Vista-E board based on allwinner R16.

The primary author of the commit (the From:) should be the first signer, unless
you are using Co-developed-by:. See the examples here:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Review

Quoted 9 lines

---
Changes for v2:
- Add missing compatible string
- insert missing signatures of contributors

---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
(quoted diff) +0 -0

b/Documentation/devicetree/bindings/arm/sunxi.yaml

Quoted 7 lines

index 95278a6a9a8e..52b8c9aba6f3 100644

Documentation/devicetree/bindings/arm/sunxi.yaml +0 -0
@@ -787,6 +787,12 @@ properties:
           - const: allwinner,r7-tv-dongle
           - const: allwinner,sun5i-a10s
 
Quoted 6 lines

Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 792

Quoted 3 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +3 -0
+      - description: RenewWorldOutreach R16-Vista-E
+        items:
+          - const: renewworldoutreach,r16-vista-e

This vendor prefix should be documented.

Thanks for the suggestions, sending a v3.

Quoted 13 lines

Regards,
Samuel

Quoted 7 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +3 -0
+          - const: allwinner,sun8i-r16
+          - const: allwinner,sun8i-a33
+
       - description: RerVision H3-DVK
         items:
           - const: rervision,h3-dvk
#5 lore raw

PATCH v2 2/2 ARM: dts: sun8i: Add R16 Vista E board from RenewWorldOutreach

In reply to Suniel Mahesh

The R16-Vista-E board from RenewWorldOutreach based on allwinner R16(A33).

General features:
- 1GB RAM
- microSD slot
- Realtek Wifi
- 1 x USB 2.0
- HDMI IN
- HDMI OUT
- Audio out
- MIPI DSI
- TI DLPC3433

It has also connectors to connect an external mini keypad.

---
Changes for v2:
- Add missing compatible string
- insert missing signatures of contributors

---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts | 361 ++++++++++++++++++
 2 files changed, 362 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts
arch/arm/boot/dts/Makefile +1 -0
index 184899808ee7..b5966c0742e1 100644
@@ -1353,6 +1353,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-r16-nintendo-nes-classic.dtb \
 	sun8i-r16-nintendo-super-nes-classic.dtb \
 	sun8i-r16-parrot.dtb \
+	sun8i-r16-renew-vista-e.dtb \
 	sun8i-r40-bananapi-m2-ultra.dtb \
 	sun8i-r40-oka40i-c.dtb \
 	sun8i-s3-elimo-initium.dtb \
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +361 -0

361 lines not on this page · raw message

Signature · 1 line
2.25.1
maintainer
#6 lore raw

Re: [PATCH v2 2/2] ARM: dts: sun8i: Add R16 Vista E board from RenewWorldOutreach

Quoted 150 lines · Suniel Mahesh

The R16-Vista-E board from RenewWorldOutreach based on allwinner R16(A33).

General features:
- 1GB RAM
- microSD slot
- Realtek Wifi
- 1 x USB 2.0
- HDMI IN
- HDMI OUT
- Audio out
- MIPI DSI
- TI DLPC3433

It has also connectors to connect an external mini keypad.

---
Changes for v2:
- Add missing compatible string
- insert missing signatures of contributors

---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts | 361 ++++++++++++++++++
 2 files changed, 362 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts
arch/arm/boot/dts/Makefile +1 -0
index 184899808ee7..b5966c0742e1 100644
@@ -1353,6 +1353,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-r16-nintendo-nes-classic.dtb \
 	sun8i-r16-nintendo-super-nes-classic.dtb \
 	sun8i-r16-parrot.dtb \
+	sun8i-r16-renew-vista-e.dtb \
 	sun8i-r40-bananapi-m2-ultra.dtb \
 	sun8i-r40-oka40i-c.dtb \
 	sun8i-s3-elimo-initium.dtb \
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +102 -0
new file mode 100644
index 000000000000..45f620203c33
@@ -0,0 +1,361 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2022 RenewWorldOutreach
+ * Copyright (C) 2022 Amarula Solutions(India)
+ */
+
+/dts-v1/;
+#include "sun8i-a33.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+	model = "RenewWorldOutreach R16-Vista-E";
+	compatible = "renewworldoutreach,r16-vista-e", "allwinner,sun8i-r16", "allwinner,sun8i-a33";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	gpio-keys-polled {
+		compatible = "gpio-keys-polled";
+		poll-interval = <100>;
+
+		ok {
+			label = "ok";
+			linux,code = <KEY_OK>;
+			gpios = <&pio 4 0 GPIO_ACTIVE_LOW>;
+		};
+
+		left {
+			label = "left";
+			linux,code = <KEY_LEFT>;
+			gpios = <&pio 4 1 GPIO_ACTIVE_LOW>;
+		};
+
+		right {
+			label = "right";
+			linux,code = <KEY_RIGHT>;
+			gpios = <&pio 4 2 GPIO_ACTIVE_LOW>;
+		};
+
+		up {
+			label = "up";
+			linux,code = <KEY_UP>;
+			gpios = <&pio 4 3 GPIO_ACTIVE_LOW>;
+		};
+
+		down {
+			label = "down";
+			linux,code = <KEY_DOWN>;
+			gpios = <&pio 4 4 GPIO_ACTIVE_LOW>;
+		};
+
+		back {
+			label = "back";
+			linux,code = <KEY_BACK>;
+			gpios = <&pio 4 5 GPIO_ACTIVE_LOW>;
+		};
+
+		power {
+			label = "power";
+			linux,code = <KEY_POWER>;
+			gpios = <&pio 4 6 GPIO_ACTIVE_LOW>;
+		};
+
+		vol-down {
+			label = "vol-down";
+			linux,code = <KEY_VOLUMEDOWN>;
+			gpios = <&pio 7 3 GPIO_ACTIVE_LOW>;
+		};
+
+		vol-up {
+			label = "vol-up";
+			linux,code = <KEY_VOLUMEUP>;
+			gpios = <&pio 7 9 GPIO_ACTIVE_LOW>;
+		};
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		battery-led0 {
+			label = "renew-e:battery-led0";
+			gpios = <&r_pio 0 2 GPIO_ACTIVE_HIGH>;
+		};
+
+		battery-led1 {
+			label = "renew-e:battery-led1";
+			gpios = <&r_pio 0 3 GPIO_ACTIVE_HIGH>;
+		};
+
+		battery-led2 {
+			label = "renew-e:battery-led2";
+			gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>;
+		};
+

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 112

Quoted 10 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+		battery-led3 {
+			label = "renew-e:battery-led3";
+			gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>;
+		};
+
+		pad-intz {
+			label = "renew-e:pad-intz";
+			gpios = <&pio 4 16 GPIO_ACTIVE_HIGH>;
+			default-state = "on";
+		};

Is this really an LED, or just a generic output?

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 122

Quoted 10 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+
+		battery-led4 {
+			label = "renew-e:battery-led4";
+			gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
+		};
+
+		volume-led0 {
+                        label = "renew-e:volume-led0";
+                        gpios = <&pio 7 2 GPIO_ACTIVE_HIGH>;
+                };

Indent with tabs, please.

Quoted 16 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +16 -0
+
+		volume-led1 {
+			label = "renew-e:volume-led1";
+			gpios = <&pio 6 13 GPIO_ACTIVE_HIGH>;
+		};
+
+		volume-led2 {
+			label = "renew-e:volume-led2";
+			gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>;
+		};
+
+		volume-led3 {
+			label = "renew-e:volume-led3";
+			gpios = <&pio 6 11 GPIO_ACTIVE_HIGH>;
+		};
+

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 148

Quoted 10 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+		volume-led4 {
+			label = "renew-e:volume-led4";
+			gpios = <&pio 6 10 GPIO_ACTIVE_HIGH>;
+		};
+
+		fans-on {
+			label = "renew-e:fans-on";
+			gpios = <&pio 4 14 GPIO_ACTIVE_HIGH>; /* FAN_ON/OFF: PE14 */
+			default-state = "on";
+		};

Does this drive an LED or control a fan? If it controls a fan, it should use the gpio-fan binding, and not pretend to be an LED.

It also does not validate against the gpio-leds binding:

sun8i-r16-renew-vista-e.dtb: leds: 'fans-on', 'pad-intz' do not match any of the
regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Quoted 186 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +186 -0
+	};
+
+	reg_vcc5v0: vcc5v0 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+	};
+};
+
+&codec {
+	status = "okay";
+};
+
+&cpu0 {
+	cpu-supply = <&reg_dcdc3>;
+};
+
+&cpu0_opp_table {
+	opp-1104000000 {
+		opp-hz = /bits/ 64 <1104000000>;
+		opp-microvolt = <1320000>;
+		clock-latency-ns = <244144>; /* 8 32k periods */
+	};
+
+	opp-1200000000 {
+		opp-hz = /bits/ 64 <1200000000>;
+		opp-microvolt = <1320000>;
+		clock-latency-ns = <244144>; /* 8 32k periods */
+	};
+};
+
+&dai {
+	status = "okay";
+};
+
+&de {
+	status = "okay";
+};
+
+&dphy {
+	status = "okay";
+};
+
+&ehci0 {
+	status = "okay";
+};
+
+&mmc0 {
+	vmmc-supply = <&reg_dcdc1>;
+	bus-width = <4>;
+	non-removable;
+	status = "okay";
+};
+
+&mmc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc1_pg_pins>;
+	vmmc-supply = <&reg_dcdc1>;
+	bus-width = <4>;
+	broken-cd;
+	status = "okay";
+};
+
+&ohci0 {
+	status = "okay";
+};
+
+&r_rsb {
+	status = "okay";
+
+	axp22x: pmic@3a3 {
+		compatible = "x-powers,axp223";
+		reg = <0x3a3>;
+		interrupt-parent = <&r_intc>;
+		interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
+		eldoin-supply = <&reg_dcdc1>;
+		x-powers,drive-vbus-en;
+	};
+};
+
+#include "axp223.dtsi"
+
+&ac_power_supply {
+	status = "okay";
+};
+
+&reg_aldo1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "vcc-io";
+};
+
+&reg_aldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <2500000>;
+	regulator-max-microvolt = <2500000>;
+	regulator-name = "vdd-dll";
+};
+
+&reg_aldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "avcc";
+};
+
+&reg_dc1sw {
+	regulator-name = "vcc-lcd";
+};
+
+&reg_dc5ldo {
+	regulator-always-on;
+	regulator-min-microvolt = <900000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-cpus";
+};
+
+&reg_dcdc1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "vcc-3v0";
+};
+
+&reg_dcdc2 {
+	regulator-always-on;
+	regulator-min-microvolt = <900000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-sys";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <900000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc5 {
+	regulator-always-on;
+	regulator-min-microvolt = <1500000>;
+	regulator-max-microvolt = <1500000>;
+	regulator-name = "vcc-dram";
+};
+
+&reg_dldo1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3-main1";
+};
+
+&reg_dldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3-main2";
+};
+
+&reg_dldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3-main3";
+};
+
+&reg_dldo4 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3-main4";
+};
+
+&reg_eldo1 {
+	regulator-always-on;
+	regulator-min-microvolt = <1200000>;
+	regulator-max-microvolt = <1200000>;
+	regulator-name = "vcc-1v2-hdmi";
+};
+
+&reg_drivevbus {
+	regulator-name = "usb0-vbus";
+	status = "okay";
+};

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 344

Quoted 10 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+
+&reg_rtc_ldo {
+	regulator-name = "vcc-rtc";
+};
+
+&sound {
+	status = "okay";
+	simple-audio-card,routing =
+		"Left DAC", "AIF1 Slot 0 Left",
+		"Right DAC", "AIF1 Slot 0 Right";

Please use "DACL" and "DACR" here, instead of the AIF1 Slot 0 widgets. The AIF1 Slot 0 widgets do not accurately describe the audio routing and are only kept for backward compatibility.

Quoted 5 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +5 -0
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_pb_pins>;

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 359

Quoted 10 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+	status = "okay";
+};
+
+&usb_otg {
+	dr_mode = "host";
+	status = "okay";
+};
+
+&usbphy {
+	usb0_vbus-supply = <&reg_vcc5v0>;

You enable drivevbus and label it as "usb0-vbus". But this suggests the VBUS is always on. Which is correct?

Quoted 3 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +2 -0
+	status = "okay";
+};
#7 lore raw

Re: [PATCH v2 2/2] ARM: dts: sun8i: Add R16 Vista E board from RenewWorldOutreach

Hi Samuel,

Quoted 157 lines · Samuel Holland

Review

Quoted 43 lines · Suniel Mahesh

The R16-Vista-E board from RenewWorldOutreach based on allwinner R16(A33).

General features:
- 1GB RAM
- microSD slot
- Realtek Wifi
- 1 x USB 2.0
- HDMI IN
- HDMI OUT
- Audio out
- MIPI DSI
- TI DLPC3433

It has also connectors to connect an external mini keypad.

---
Changes for v2:
- Add missing compatible string
- insert missing signatures of contributors

---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts | 361 ++++++++++++++++++
 2 files changed, 362 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts
arch/arm/boot/dts/Makefile +1 -0
index 184899808ee7..b5966c0742e1 100644
@@ -1353,6 +1353,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
      sun8i-r16-nintendo-nes-classic.dtb \
      sun8i-r16-nintendo-super-nes-classic.dtb \
      sun8i-r16-parrot.dtb \
+     sun8i-r16-renew-vista-e.dtb \
      sun8i-r40-bananapi-m2-ultra.dtb \
      sun8i-r40-oka40i-c.dtb \
      sun8i-s3-elimo-initium.dtb \
(quoted diff) +0 -0

b/arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts

Quoted 11 lines

new file mode 100644
index 000000000000..45f620203c33

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +6 -0
@@ -0,0 +1,361 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2022 RenewWorldOutreach
+ * Copyright (C) 2022 Amarula Solutions(India)
+ */
+

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 16

Quoted 10 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+/dts-v1/;
+#include "sun8i-a33.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+     model = "RenewWorldOutreach R16-Vista-E";
+     compatible = "renewworldoutreach,r16-vista-e",

"allwinner,sun8i-r16", "allwinner,sun8i-a33";

Quoted 90 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +90 -0
+
+     aliases {
+             serial0 = &uart0;
+     };
+
+     chosen {
+             stdout-path = "serial0:115200n8";
+     };
+
+     gpio-keys-polled {
+             compatible = "gpio-keys-polled";
+             poll-interval = <100>;
+
+             ok {
+                     label = "ok";
+                     linux,code = <KEY_OK>;
+                     gpios = <&pio 4 0 GPIO_ACTIVE_LOW>;
+             };
+
+             left {
+                     label = "left";
+                     linux,code = <KEY_LEFT>;
+                     gpios = <&pio 4 1 GPIO_ACTIVE_LOW>;
+             };
+
+             right {
+                     label = "right";
+                     linux,code = <KEY_RIGHT>;
+                     gpios = <&pio 4 2 GPIO_ACTIVE_LOW>;
+             };
+
+             up {
+                     label = "up";
+                     linux,code = <KEY_UP>;
+                     gpios = <&pio 4 3 GPIO_ACTIVE_LOW>;
+             };
+
+             down {
+                     label = "down";
+                     linux,code = <KEY_DOWN>;
+                     gpios = <&pio 4 4 GPIO_ACTIVE_LOW>;
+             };
+
+             back {
+                     label = "back";
+                     linux,code = <KEY_BACK>;
+                     gpios = <&pio 4 5 GPIO_ACTIVE_LOW>;
+             };
+
+             power {
+                     label = "power";
+                     linux,code = <KEY_POWER>;
+                     gpios = <&pio 4 6 GPIO_ACTIVE_LOW>;
+             };
+
+             vol-down {
+                     label = "vol-down";
+                     linux,code = <KEY_VOLUMEDOWN>;
+                     gpios = <&pio 7 3 GPIO_ACTIVE_LOW>;
+             };
+
+             vol-up {
+                     label = "vol-up";
+                     linux,code = <KEY_VOLUMEUP>;
+                     gpios = <&pio 7 9 GPIO_ACTIVE_LOW>;
+             };
+     };
+
+     leds {
+             compatible = "gpio-leds";
+
+             battery-led0 {
+                     label = "renew-e:battery-led0";
+                     gpios = <&r_pio 0 2 GPIO_ACTIVE_HIGH>;
+             };
+
+             battery-led1 {
+                     label = "renew-e:battery-led1";
+                     gpios = <&r_pio 0 3 GPIO_ACTIVE_HIGH>;
+             };
+
+             battery-led2 {
+                     label = "renew-e:battery-led2";
+                     gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>;
+             };
+
+             battery-led3 {
+                     label = "renew-e:battery-led3";
+                     gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>;
+             };
Quoted 9 lines

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 112

Quoted 6 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +6 -0
+
+             pad-intz {
+                     label = "renew-e:pad-intz";
+                     gpios = <&pio 4 16 GPIO_ACTIVE_HIGH>;
+                     default-state = "on";
+             };

Is this really an LED, or just a generic output?

this is an LED

Quoted 14 lines

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 122

Quoted 11 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+
+             battery-led4 {
+                     label = "renew-e:battery-led4";
+                     gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
+             };
+
+             volume-led0 {
+                        label = "renew-e:volume-led0";
+                        gpios = <&pio 7 2 GPIO_ACTIVE_HIGH>;
+                };

Indent with tabs, please.

indenting, sending a v3

Quoted 26 lines
Quoted 15 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +14 -0
+
+             volume-led1 {
+                     label = "renew-e:volume-led1";
+                     gpios = <&pio 6 13 GPIO_ACTIVE_HIGH>;
+             };
+
+             volume-led2 {
+                     label = "renew-e:volume-led2";
+                     gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>;
+             };
+
+             volume-led3 {
+                     label = "renew-e:volume-led3";
+                     gpios = <&pio 6 11 GPIO_ACTIVE_HIGH>;

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts

Quoted 10 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+             };
+
+             volume-led4 {
+                     label = "renew-e:volume-led4";
+                     gpios = <&pio 6 10 GPIO_ACTIVE_HIGH>;
+             };
+
+             fans-on {
+                     label = "renew-e:fans-on";
+                     gpios = <&pio 4 14 GPIO_ACTIVE_HIGH>; /*

FAN_ON/OFF: PE14 */

Quoted 8 lines

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 148

Quoted 2 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +2 -0
+                     default-state = "on";
+             };

Does this drive an LED or control a fan? If it controls a fan, it should use the
gpio-fan binding, and not pretend to be an LED.

it controls a fan

changing the binding to gpio-fan

Quoted 223 lines

It also does not validate against the gpio-leds binding:

sun8i-r16-renew-vista-e.dtb: leds: 'fans-on', 'pad-intz' do not match any of the
regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Quoted 186 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +186 -0
+     };
+
+     reg_vcc5v0: vcc5v0 {
+             compatible = "regulator-fixed";
+             regulator-name = "vcc5v0";
+             regulator-min-microvolt = <5000000>;
+             regulator-max-microvolt = <5000000>;
+     };
+};
+
+&codec {
+     status = "okay";
+};
+
+&cpu0 {
+     cpu-supply = <&reg_dcdc3>;
+};
+
+&cpu0_opp_table {
+     opp-1104000000 {
+             opp-hz = /bits/ 64 <1104000000>;
+             opp-microvolt = <1320000>;
+             clock-latency-ns = <244144>; /* 8 32k periods */
+     };
+
+     opp-1200000000 {
+             opp-hz = /bits/ 64 <1200000000>;
+             opp-microvolt = <1320000>;
+             clock-latency-ns = <244144>; /* 8 32k periods */
+     };
+};
+
+&dai {
+     status = "okay";
+};
+
+&de {
+     status = "okay";
+};
+
+&dphy {
+     status = "okay";
+};
+
+&ehci0 {
+     status = "okay";
+};
+
+&mmc0 {
+     vmmc-supply = <&reg_dcdc1>;
+     bus-width = <4>;
+     non-removable;
+     status = "okay";
+};
+
+&mmc1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&mmc1_pg_pins>;
+     vmmc-supply = <&reg_dcdc1>;
+     bus-width = <4>;
+     broken-cd;
+     status = "okay";
+};
+
+&ohci0 {
+     status = "okay";
+};
+
+&r_rsb {
+     status = "okay";
+
+     axp22x: pmic@3a3 {
+             compatible = "x-powers,axp223";
+             reg = <0x3a3>;
+             interrupt-parent = <&r_intc>;
+             interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
+             eldoin-supply = <&reg_dcdc1>;
+             x-powers,drive-vbus-en;
+     };
+};
+
+#include "axp223.dtsi"
+
+&ac_power_supply {
+     status = "okay";
+};
+
+&reg_aldo1 {
+     regulator-always-on;
+     regulator-min-microvolt = <3000000>;
+     regulator-max-microvolt = <3000000>;
+     regulator-name = "vcc-io";
+};
+
+&reg_aldo2 {
+     regulator-always-on;
+     regulator-min-microvolt = <2500000>;
+     regulator-max-microvolt = <2500000>;
+     regulator-name = "vdd-dll";
+};
+
+&reg_aldo3 {
+     regulator-always-on;
+     regulator-min-microvolt = <3000000>;
+     regulator-max-microvolt = <3000000>;
+     regulator-name = "avcc";
+};
+
+&reg_dc1sw {
+     regulator-name = "vcc-lcd";
+};
+
+&reg_dc5ldo {
+     regulator-always-on;
+     regulator-min-microvolt = <900000>;
+     regulator-max-microvolt = <1400000>;
+     regulator-name = "vdd-cpus";
+};
+
+&reg_dcdc1 {
+     regulator-always-on;
+     regulator-min-microvolt = <3000000>;
+     regulator-max-microvolt = <3000000>;
+     regulator-name = "vcc-3v0";
+};
+
+&reg_dcdc2 {
+     regulator-always-on;
+     regulator-min-microvolt = <900000>;
+     regulator-max-microvolt = <1400000>;
+     regulator-name = "vdd-sys";
+};
+
+&reg_dcdc3 {
+     regulator-always-on;
+     regulator-min-microvolt = <900000>;
+     regulator-max-microvolt = <1400000>;
+     regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc5 {
+     regulator-always-on;
+     regulator-min-microvolt = <1500000>;
+     regulator-max-microvolt = <1500000>;
+     regulator-name = "vcc-dram";
+};
+
+&reg_dldo1 {
+     regulator-always-on;
+     regulator-min-microvolt = <3300000>;
+     regulator-max-microvolt = <3300000>;
+     regulator-name = "vcc-3v3-main1";
+};
+
+&reg_dldo2 {
+     regulator-always-on;
+     regulator-min-microvolt = <3300000>;
+     regulator-max-microvolt = <3300000>;
+     regulator-name = "vcc-3v3-main2";
+};
+
+&reg_dldo3 {
+     regulator-always-on;
+     regulator-min-microvolt = <3300000>;
+     regulator-max-microvolt = <3300000>;
+     regulator-name = "vcc-3v3-main3";
+};
+
+&reg_dldo4 {
+     regulator-always-on;
+     regulator-min-microvolt = <3300000>;
+     regulator-max-microvolt = <3300000>;
+     regulator-name = "vcc-3v3-main4";
+};
+
+&reg_eldo1 {
+     regulator-always-on;
+     regulator-min-microvolt = <1200000>;
+     regulator-max-microvolt = <1200000>;
+     regulator-name = "vcc-1v2-hdmi";
+};
+
+&reg_drivevbus {
+     regulator-name = "usb0-vbus";
+     status = "okay";
+};

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 344

Quoted 10 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +10 -0
+
+&reg_rtc_ldo {
+     regulator-name = "vcc-rtc";
+};
+
+&sound {
+     status = "okay";
+     simple-audio-card,routing =
+             "Left DAC", "AIF1 Slot 0 Left",
+             "Right DAC", "AIF1 Slot 0 Right";

Please use "DACL" and "DACR" here, instead of the AIF1 Slot 0 widgets. The AIF1
Slot 0 widgets do not accurately describe the audio routing and are only kept
for backward compatibility.

making the changes as suggested

Quoted 11 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +11 -0
+};
+
+&uart0 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart0_pb_pins>;
+     status = "okay";
+};
+
+&usb_otg {
+     dr_mode = "host";
+     status = "okay";
Quoted 9 lines

arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts line 359

Quoted 4 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +4 -0
+};
+
+&usbphy {
+     usb0_vbus-supply = <&reg_vcc5v0>;

You enable drivevbus and label it as "usb0-vbus". But this suggests the VBUS is
always on. Which is correct?

yes, VBUS is always on

Quoted 6 lines
Quoted 4 lines
arch/arm/boot/dts/sun8i-r16-renew-vista-e.dts new file +2 -0
+     status = "okay";
+};