Skip to contentSkip to conversation

imx8mn_evk: Add the missing spl.bin entry

PATCH In review Fabio Estevam 5 participants 5 messages May 3, 2022 – Jun 15, 2022

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 imx8mn_evk: Add the missing spl.bin entry

From: Fabio Estevam <[email protected]>

The generated flash.bin does not boot the imx8mn evk LPDDR4 variant as it misses the spl.bin description in binman.

Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.

---
 arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/imx8mn-evk-u-boot.dtsi +3 -1
index 3db46d4cbc..593cf06eb9 100644
@@ -58,7 +58,9 @@
 	};
 
 
-	flash {
+	spl {
+		filename = "spl.bin";
+
 		mkimage {
 			args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000";
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 29 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The generated flash.bin does not boot the imx8mn evk LPDDR4 variant as it misses the spl.bin description in binman.

Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.

---
 arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/imx8mn-evk-u-boot.dtsi +3 -2
index 3db46d4cbc..593cf06eb9 100644
@@ -58,7 +58,9 @@
        };
 
 
-       flash {
+       spl {
+               filename = "spl.bin";
+
                mkimage {
                        args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000";
 
--
Quoted 2 lines

2.25.1

Sounds like there should be a Fixes tag here?

Tim

Tested-by on v1 1/1
#2 lore raw
In reply to Fabio Estevam
Quoted 20 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The generated flash.bin does not boot the imx8mn evk LPDDR4 variant as it misses the spl.bin description in binman.

Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.

---
 arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/dts/imx8mn-evk-u-boot.dtsi +0 -0
index 3db46d4cbc..593cf06eb9 100644
@@ -58,7 +58,9 @@
         };

Quoted 8 lines


-       flash {
+       spl {
+               filename = "spl.bin";
+
                mkimage {
                        args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000";

This works on my 8MNANOLPD4-EVK board.

Btw, it looks like you can also just delete the spl and itb entries because those are already included from the imx8mn-ddr4-evk-u-boot.dtsi file.

Fixes d6afc6b3a04a ("imx8mn-evk: switch to use binman")
Reviewed-by on v1 1/1
#3 lore raw
In reply to Fabio Estevam
Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The generated flash.bin does not boot the imx8mn evk LPDDR4 variant as it misses the spl.bin description in binman.

The dtsi file #includes "imx8mn-ddr4-evk-u-boot.dtsi", which provides an 'spl' description. It also provides a 'imx-boot' description for a working 'flash.bin' file. The issue here is the 'flash' description here is overwriting the same file with its own broken definition. You're removing it, so things work fine.

Quoted 6 lines

Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.

---
 arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 5 lines
arch/arm/dts/imx8mn-evk-u-boot.dtsi +0 -0
index 3db46d4cbc..593cf06eb9 100644

arch/arm/dts/imx8mn-evk-u-boot.dtsi line 66

Quoted 10 lines
arch/arm/dts/imx8mn-evk-u-boot.dtsi +3 -1
@@ -58,7 +58,9 @@
 	};
 
 
-	flash {
+	spl {
+		filename = "spl.bin";
+
 		mkimage {
 			args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000";
 

You might want to copy 'imx-boot' from "imx8mn-ddr4-evk-u-boot.dtsi" for completeness. But it doesn't really matter.

#4 lore raw

PATCH 1/1 imx8mn_evk: Add the missing spl.bin entry

In reply to Fabio Estevam
Quoted 7 lines

From: Fabio Estevam <[email protected]>
The generated flash.bin does not boot the imx8mn evk LPDDR4 variant as it misses the spl.bin description in binman.
Add its entry to fix the boot on the imx8mn evk LPDDR4 variant.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================