ASoC: Intel: haswell and broadwell boards update
Subsystems (3)
Cezary Rojewski
maintainerv4 cover ASoC: Intel: haswell and broadwell boards update
A number of patches improving overall quality and readability of haswell.c and broadwell.c source files found in sound/soc/intel/boards. Both files are first renamed and only then actual changes are being incrementally added. The respective names are: hsw_rt5640 and bdw_rt286 to match the pattern found in more recent boards.
Most patches bring no functional change - the more impactful patches at are placed the end:
Refactor of suspend/resume flow for the bdw_rt286 board by dropping dev->remove() in favour of card->remove() and adjust jack handling to reduce code size slightly by implementing card_set_jack().
The last patch is removing of FE DAI ops. Given the existence of platform FE DAI capabilities (either static declaration or through topology file), this code is redundant.
Changes in v4:
- just a rebase to fix missed conflicts with for-next
Changes in v3:
- Patch 16/17 refactoring suspend/resume has been renamed to "Refactor jack handling". Dropped the usage of card->remove() in favor of link->exit() in that very patch
Changes in v2:
- fixed wording error in patch 02/17 so it correctly mentions 'haswell_rt5640', not 'broadwell_rt286'
- decided not to add kernel module names changes to this patchset so the review is not complicated unnecessarily. Will send them separately instead
Cezary Rojewski (17):
ASoC: Intel: Rename haswell source file to hsw_rt5640
ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members
ASoC: Intel: hsw_rt5640: Reword driver name
ASoC: Intel: hsw_rt5640: Update code indentation
ASoC: Intel: hsw_rt5640: Update file comments
ASoC: Intel: hsw_rt5640: Improve probe() function quality
ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability
ASoC: Intel: Rename broadwell source file to bdw_rt286
ASoC: Intel: bdw_rt286: Reword prefixes of all driver members
ASoC: Intel: bdw_rt286: Reword driver name
ASoC: Intel: bdw_rt286: Update code indentation
ASoC: Intel: bdw_rt286: Update file comments
ASoC: Intel: bdw_rt286: Improve probe() function quality
ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability
ASoC: Intel: bdw_rt286: Improve codec_init() quality
ASoC: Intel: bdw_rt286: Refactor jack handling
ASoC: Intel: bdw_rt286: Remove FE DAI ops
sound/soc/intel/boards/Kconfig | 4 +- sound/soc/intel/boards/Makefile | 4 +- sound/soc/intel/boards/bdw_rt286.c | 256 +++++++++++++ sound/soc/intel/boards/broadwell.c | 338 ------------------ sound/soc/intel/boards/haswell.c | 202 ----------- sound/soc/intel/boards/hsw_rt5640.c | 176 +++++++++ .../common/soc-acpi-intel-hsw-bdw-match.c | 6 +- 7 files changed, 439 insertions(+), 547 deletions(-) create mode 100644 sound/soc/intel/boards/bdw_rt286.c delete mode 100644 sound/soc/intel/boards/broadwell.c delete mode 100644 sound/soc/intel/boards/haswell.c create mode 100644 sound/soc/intel/boards/hsw_rt5640.c
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 1/17 ASoC: Intel: Rename haswell source file to hsw_rt5640
Rename source file to drop any ambiguity.
---
sound/soc/intel/boards/Makefile | 2 +-
sound/soc/intel/boards/{haswell.c => hsw_rt5640.c} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename sound/soc/intel/boards/{haswell.c => hsw_rt5640.c} (100%)sound/soc/intel/boards/Makefile +1 -1
@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only -snd-soc-sst-haswell-objs := haswell.o +snd-soc-sst-haswell-objs := hsw_rt5640.o snd-soc-sst-bdw-rt5650-mach-objs := bdw-rt5650.o snd-soc-sst-bdw-rt5677-mach-objs := bdw-rt5677.o snd-soc-sst-broadwell-objs := broadwell.o
sound/soc/intel/boards/hsw_rt5640.c renamed from sound/soc/intel/boards/haswell.c +0 -0
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 2/17 ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members
In reply to Cezary RojewskiReplace ambiguous 'haswell_rt5640_' prefixes in favour of 'card_', 'link_' and other similar strings to clearly state which object given member implements behavior for.
--- sound/soc/intel/boards/hsw_rt5640.c | 46 ++++++++++++++--------------- 1 file changed, 23 insertions(+), 23 deletions(-)
sound/soc/intel/boards/hsw_rt5640.c +23 -23
@@ -16,12 +16,12 @@#include "../../codecs/rt5640.h" /* Haswell ULT platforms have a Headphone and Mic jack */ -static const struct snd_soc_dapm_widget haswell_widgets[] = { +static const struct snd_soc_dapm_widget card_widgets[] = {SND_SOC_DAPM_HP ("Headphones" ,NULL ),SND_SOC_DAPM_MIC ("Mic" ,NULL ), }; -static const struct snd_soc_dapm_route haswell_rt5640_map[] = { +static const struct snd_soc_dapm_route card_routes[] = { {"Headphones" ,NULL ,"HPOR" }, {"Headphones" ,NULL ,"HPOL" },
@@ -32,7 +32,7 @@ static const struct snd_soc_dapm_route haswell_rt5640_map[] = { {"AIF1 Playback", NULL, "SSP0 CODEC OUT"}, }; -static int haswell_ssp0_fixup (struct snd_soc_pcm_runtime *rtd, +static int codec_link_hw_params_fixup (struct snd_soc_pcm_runtime *rtd,struct snd_pcm_hw_params *params) { struct snd_interval *rate = hw_param_interval(params,
@@ -49,7 +49,7 @@ static int haswell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,return 0 ; } -static int haswell_rt5640_hw_params (struct snd_pcm_substream *substream, +static int codec_link_hw_params (struct snd_pcm_substream *substream,struct snd_pcm_hw_params *params) {struct snd_soc_pcm_runtime *rtd =asoc_substream_to_rtd (substream);
@@ -70,8 +70,8 @@ static int haswell_rt5640_hw_params(struct snd_pcm_substream *substream,return ret; } -static const struct snd_soc_ops haswell_rt5640_ops = { - .hw_params = haswell_rt5640_hw_params, +static const struct snd_soc_ops codec_link_ops = { + .hw_params = codec_link_hw_params, }; SND_SOC_DAILINK_DEF(dummy,
@@ -98,7 +98,7 @@ SND_SOC_DAILINK_DEF(platform,SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); -static struct snd_soc_dai_link haswell_rt5640_dais[] = { +static struct snd_soc_dai_link card_dai_links[] = {/* Front End DAI links */ { .name ="System" ,
@@ -147,8 +147,8 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = { .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC, .ignore_pmdown_time = 1, - .be_hw_params_fixup = haswell_ssp0_fixup, - .ops = &haswell_rt5640_ops, + .be_hw_params_fixup = codec_link_hw_params_fixup, + .ops = &codec_link_ops, .dpcm_playback = 1, .dpcm_capture =1 , SND_SOC_DAILINK_REG(ssp0_port, codec, platform),
@@ -156,44 +156,44 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = { };/* audio machine driver for Haswell Lynxpoint DSP + RT5640 */ -static struct snd_soc_card haswell_rt5640 = { +static struct snd_soc_card hsw_rt5640_card = { .name ="haswell-rt5640" , .owner =THIS_MODULE , - .dai_link = haswell_rt5640_dais, - .num_links =ARRAY_SIZE (haswell_rt5640_dais), - .dapm_widgets = haswell_widgets, - .num_dapm_widgets =ARRAY_SIZE (haswell_widgets), - .dapm_routes = haswell_rt5640_map, - .num_dapm_routes =ARRAY_SIZE (haswell_rt5640_map), + .dai_link = card_dai_links, + .num_links =ARRAY_SIZE (card_dai_links), + .dapm_widgets = card_widgets, + .num_dapm_widgets =ARRAY_SIZE (card_widgets), + .dapm_routes = card_routes, + .num_dapm_routes =ARRAY_SIZE (card_routes), .fully_routed = true, }; -static int haswell_audio_probe (struct platform_device *pdev) +static int hsw_rt5640_probe (struct platform_device *pdev) {struct snd_soc_acpi_mach *mach;int ret; - haswell_rt5640.dev = &pdev->dev; + hsw_rt5640_card.dev = &pdev->dev;/* override platform name, if required */ mach = pdev->dev.platform_data; - ret =snd_soc_fixup_dai_links_platform_name (&haswell_rt5640, + ret =snd_soc_fixup_dai_links_platform_name (&hsw_rt5640_card, mach->mach_params.platform);if (ret)return ret; -return devm_snd_soc_register_card (&pdev->dev, &haswell_rt5640); +return devm_snd_soc_register_card (&pdev->dev, &hsw_rt5640_card); } -static struct platform_driver haswell_audio = { - .probe = haswell_audio_probe, +static struct platform_driver hsw_rt5640_driver = { + .probe = hsw_rt5640_probe, .driver = { .name ="haswell-audio" , .pm = &snd_soc_pm_ops, }, }; -module_platform_driver (haswell_audio) +module_platform_driver (hsw_rt5640_driver)/* Module information */ MODULE_AUTHOR("Liam Girdwood, Xingchao Wang");
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 3/17 ASoC: Intel: hsw_rt5640: Reword driver name
In reply to Cezary RojewskiAlign with other Intel boards naming convention and let the name explicitly state which components are being connected.
--- sound/soc/intel/boards/hsw_rt5640.c | 4 ++-- sound/soc/intel/common/soc-acpi-intel-hsw-bdw-match.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
sound/soc/intel/boards/hsw_rt5640.c +2 -2
@@ -188,7 +188,7 @@ static int hsw_rt5640_probe(struct platform_device *pdev)static struct platform_driver hsw_rt5640_driver = { .probe = hsw_rt5640_probe, .driver = { - .name ="haswell-audio" , + .name ="hsw_rt5640" , .pm = &snd_soc_pm_ops, }, };
@@ -199,4 +199,4 @@ module_platform_driver(hsw_rt5640_driver)MODULE_AUTHOR ("Liam Girdwood, Xingchao Wang" );MODULE_DESCRIPTION ("Intel SST Audio for Haswell Lynxpoint" );MODULE_LICENSE ("GPL v2" ); -MODULE_ALIAS ("platform:haswell-audio" ); +MODULE_ALIAS ("platform:hsw_rt5640" );
sound/soc/intel/common/soc-acpi-intel-hsw-bdw-match.c +2 -2
@@ -12,7 +12,7 @@struct snd_soc_acpi_mach snd_soc_acpi_intel_haswell_machines[] = { { .id ="INT33CA" , - .drv_name ="haswell-audio" , + .drv_name ="hsw_rt5640" , .fw_filename ="intel/IntcSST1.bin" , .sof_tplg_filename ="sof-hsw.tplg" , },
@@ -41,7 +41,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_broadwell_machines[] = { }, { .id = "INT33CA", - .drv_name = "haswell-audio", + .drv_name = "hsw_rt5640", .fw_filename = "intel/IntcSST2.bin", .sof_tplg_filename = "sof-bdw-rt5640.tplg", },
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 4/17 ASoC: Intel: hsw_rt5640: Update code indentation
In reply to Cezary RojewskiMake use of 100 character limit and modify indentation so code is easier to read. While at it, sort includes in alphabetical order.
--- sound/soc/intel/boards/hsw_rt5640.c | 59 +++++++++-------------------- 1 file changed, 18 insertions(+), 41 deletions(-)
sound/soc/intel/boards/hsw_rt5640.c +18 -41
@@ -9,10 +9,9 @@#include <linux/platform_device.h> #include <sound/core.h> #include <sound/pcm.h> +#include <sound/pcm_params.h> #include <sound/soc.h> #include <sound/soc-acpi.h> -#include <sound/pcm_params.h> -#include "../../codecs/rt5640.h" /* Haswell ULT platforms have a Headphone and Mic jack */
@@ -22,7 +21,6 @@ static const struct snd_soc_dapm_widget card_widgets[] = { };static const struct snd_soc_dapm_route card_routes[] = { - {"Headphones" ,NULL ,"HPOR" }, {"Headphones" ,NULL ,"HPOL" }, {"IN2P" ,NULL ,"Mic" },
@@ -33,32 +31,28 @@ static const struct snd_soc_dapm_route card_routes[] = { };static int codec_link_hw_params_fixup (struct snd_soc_pcm_runtime *rtd, -struct snd_pcm_hw_params *params) +struct snd_pcm_hw_params *params) { -struct snd_interval *rate =hw_param_interval (params, -SNDRV_PCM_HW_PARAM_RATE ); -struct snd_interval *channels =hw_param_interval (params, -SNDRV_PCM_HW_PARAM_CHANNELS ); +struct snd_interval *channels =hw_param_interval (params,SNDRV_PCM_HW_PARAM_CHANNELS ); +struct snd_interval *rate =hw_param_interval (params,SNDRV_PCM_HW_PARAM_RATE );/* The ADSP will covert the FE rate to 48k, stereo */ rate->min = rate->max =48000 ; channels->min = channels->max =2 ; -/* set SSP0 to 16 bit */ params_set_format (params,SNDRV_PCM_FORMAT_S16_LE ); +return 0 ; }static int codec_link_hw_params (struct snd_pcm_substream *substream, -struct snd_pcm_hw_params *params) +struct snd_pcm_hw_params *params) {struct snd_soc_pcm_runtime *rtd =asoc_substream_to_rtd (substream);struct snd_soc_dai *codec_dai =asoc_rtd_to_codec (rtd,0 );int ret; - ret =snd_soc_dai_set_sysclk (codec_dai,RT5640_SCLK_S_MCLK ,12288000 , -SND_SOC_CLOCK_IN ); - + ret =snd_soc_dai_set_sysclk (codec_dai,RT5640_SCLK_S_MCLK ,12288000 ,SND_SOC_CLOCK_IN );if (ret <0 ) {dev_err (rtd->dev,"can't set codec sysclk configuration\n" );return ret;
@@ -74,29 +68,15 @@ static const struct snd_soc_ops codec_link_ops = { .hw_params = codec_link_hw_params, }; -SND_SOC_DAILINK_DEF (dummy, -DAILINK_COMP_ARRAY (COMP_DUMMY ())); - -SND_SOC_DAILINK_DEF (system, -DAILINK_COMP_ARRAY (COMP_CPU ("System Pin" ))); +SND_SOC_DAILINK_DEF (system,DAILINK_COMP_ARRAY (COMP_CPU ("System Pin" ))); +SND_SOC_DAILINK_DEF (offload0,DAILINK_COMP_ARRAY (COMP_CPU ("Offload0 Pin" ))); +SND_SOC_DAILINK_DEF (offload1,DAILINK_COMP_ARRAY (COMP_CPU ("Offload1 Pin" ))); +SND_SOC_DAILINK_DEF (loopback,DAILINK_COMP_ARRAY (COMP_CPU ("Loopback Pin" ))); -SND_SOC_DAILINK_DEF (offload0, -DAILINK_COMP_ARRAY (COMP_CPU ("Offload0 Pin" ))); - -SND_SOC_DAILINK_DEF (offload1, -DAILINK_COMP_ARRAY (COMP_CPU ("Offload1 Pin" ))); - -SND_SOC_DAILINK_DEF (loopback, -DAILINK_COMP_ARRAY (COMP_CPU ("Loopback Pin" ))); - -SND_SOC_DAILINK_DEF (codec, -DAILINK_COMP_ARRAY (COMP_CODEC ("i2c-INT33CA:00" ,"rt5640-aif1" ))); - -SND_SOC_DAILINK_DEF (platform, -DAILINK_COMP_ARRAY (COMP_PLATFORM ("haswell-pcm-audio" ))); - -SND_SOC_DAILINK_DEF (ssp0_port, -DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); +SND_SOC_DAILINK_DEF (dummy,DAILINK_COMP_ARRAY (COMP_DUMMY ())); +SND_SOC_DAILINK_DEF (codec,DAILINK_COMP_ARRAY (COMP_CODEC ("i2c-INT33CA:00" ,"rt5640-aif1" ))); +SND_SOC_DAILINK_DEF (platform,DAILINK_COMP_ARRAY (COMP_PLATFORM ("haswell-pcm-audio" ))); +SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" )));static struct snd_soc_dai_link card_dai_links[] = {/* Front End DAI links */
@@ -137,15 +117,13 @@ static struct snd_soc_dai_link card_dai_links[] = { .dpcm_capture = 1, SND_SOC_DAILINK_REG(loopback, dummy, platform), }, -/* Back End DAI links */ {/* SSP0 - Codec */ .name = "Codec", .id = 0, .no_pcm = 1, - .dai_fmt =SND_SOC_DAIFMT_I2S |SND_SOC_DAIFMT_NB_NF | - SND_SOC_DAIFMT_CBC_CFC, + .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC, .ignore_pmdown_time = 1, .be_hw_params_fixup = codec_link_hw_params_fixup, .ops = &codec_link_ops,
@@ -174,11 +152,10 @@ static int hsw_rt5640_probe(struct platform_device *pdev)int ret; hsw_rt5640_card.dev = &pdev->dev; -/* override platform name, if required */ mach = pdev->dev.platform_data; - ret =snd_soc_fixup_dai_links_platform_name (&hsw_rt5640_card, - mach->mach_params.platform); + + ret =snd_soc_fixup_dai_links_platform_name (&hsw_rt5640_card, mach->mach_params.platform);if (ret)return ret;
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 5/17 ASoC: Intel: hsw_rt5640: Update file comments
In reply to Cezary RojewskiDrop redundant and update valuable comments within the file to increase readability. This patch also revisits module information and kconfig help strings.
--- sound/soc/intel/boards/Kconfig | 2 +- sound/soc/intel/boards/hsw_rt5640.c | 16 ++++++---------- 2 files changed, 7 insertions(+), 11 deletions(-)
sound/soc/intel/boards/Kconfig +1 -1
@@ -41,7 +41,7 @@ config SND_SOC_INTEL_SOF_CIRRUS_COMMON if SND_SOC_INTEL_CATPT config SND_SOC_INTEL_HASWELL_MACH - tristate "Haswell Lynxpoint" + tristate "Haswell with RT5640 I2S codec" depends on I2C depends on I2C_DESIGNWARE_PLATFORM || COMPILE_TEST depends on X86_INTEL_LPSS || COMPILE_TEST
sound/soc/intel/boards/hsw_rt5640.c +6 -10
@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0-only /* -* Intel Haswell Lynxpoint SST Audio +* Sound card driver for Intel Haswell Lynx Point with Realtek 5640 * * Copyright (C) 2013, Intel Corporation. All rights reserved. */
@@ -14,7 +14,6 @@#include <sound/soc-acpi.h> #include "../../codecs/rt5640.h" -/* Haswell ULT platforms have a Headphone and Mic jack */ static const struct snd_soc_dapm_widget card_widgets[] = {SND_SOC_DAPM_HP ("Headphones" ,NULL ),SND_SOC_DAPM_MIC ("Mic" ,NULL ),
@@ -36,10 +35,10 @@ static int codec_link_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,struct snd_interval *channels =hw_param_interval (params,SNDRV_PCM_HW_PARAM_CHANNELS );struct snd_interval *rate =hw_param_interval (params,SNDRV_PCM_HW_PARAM_RATE ); -/* The ADSP will covert the FE rate to 48k, stereo */ +/* The ADSP will convert the FE rate to 48k, stereo. */ rate->min = rate->max =48000 ; channels->min = channels->max =2 ; -/* set SSP0 to 16 bit */ +/* Set SSP0 to 16 bit. */ params_set_format (params,SNDRV_PCM_FORMAT_S16_LE );return 0 ;
@@ -58,7 +57,7 @@ static int codec_link_hw_params(struct snd_pcm_substream *substream,return ret; } -/* set correct codec filter for DAI format and clock config */ +/* Set correct codec filter for DAI format and clock config. */ snd_soc_component_update_bits (codec_dai->component,0x83 ,0xffff ,0x8000 );return ret;
@@ -133,7 +132,6 @@ static struct snd_soc_dai_link card_dai_links[] = { }, }; -/* audio machine driver for Haswell Lynxpoint DSP + RT5640 */ static struct snd_soc_card hsw_rt5640_card = { .name ="haswell-rt5640" , .owner =THIS_MODULE ,
@@ -152,7 +150,6 @@ static int hsw_rt5640_probe(struct platform_device *pdev)int ret; hsw_rt5640_card.dev = &pdev->dev; -/* override platform name, if required */ mach = pdev->dev.platform_data; ret =snd_soc_fixup_dai_links_platform_name (&hsw_rt5640_card, mach->mach_params.platform);
@@ -172,8 +169,7 @@ static struct platform_driver hsw_rt5640_driver = {module_platform_driver (hsw_rt5640_driver) -/* Module information */ MODULE_AUTHOR("Liam Girdwood, Xingchao Wang"); -MODULE_DESCRIPTION ("Intel SST Audio for Haswell Lynxpoint" ); -MODULE_LICENSE ("GPL v2" ); +MODULE_DESCRIPTION ("Sound card driver for Intel Haswell Lynx Point with Realtek 5640" ); +MODULE_LICENSE ("GPL" );MODULE_ALIAS ("platform:hsw_rt5640" );
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 6/17 ASoC: Intel: hsw_rt5640: Improve probe() function quality
In reply to Cezary RojewskiDeclare local 'dev' and make use of it plus dev_get_platdata() to improve code readability.
--- sound/soc/intel/boards/hsw_rt5640.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/intel/boards/hsw_rt5640.c +4 -3
@@ -147,16 +147,17 @@ static struct snd_soc_card hsw_rt5640_card = {static int hsw_rt5640_probe (struct platform_device *pdev) {struct snd_soc_acpi_mach *mach; +struct device *dev = &pdev->dev;int ret; - hsw_rt5640_card.dev = &pdev->dev; - mach = pdev->dev.platform_data; + hsw_rt5640_card.dev = dev; + mach =dev_get_platdata (dev); ret =snd_soc_fixup_dai_links_platform_name (&hsw_rt5640_card, mach->mach_params.platform);if (ret)return ret; -return devm_snd_soc_register_card (&pdev->dev, &hsw_rt5640_card); +return devm_snd_soc_register_card (dev, &hsw_rt5640_card); }static struct platform_driver hsw_rt5640_driver = {
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 7/17 ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability
In reply to Cezary RojewskiPrint status if setting sysclk fails.
--- sound/soc/intel/boards/hsw_rt5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/hsw_rt5640.c +1 -1
@@ -53,7 +53,7 @@ static int codec_link_hw_params(struct snd_pcm_substream *substream, ret =snd_soc_dai_set_sysclk (codec_dai,RT5640_SCLK_S_MCLK ,12288000 ,SND_SOC_CLOCK_IN );if (ret <0 ) { -dev_err (rtd->dev,"can't set codec sysclk configuration\n" ); +dev_err (rtd->dev,"set codec sysclk failed: %d\n" , ret);return ret; }
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 8/17 ASoC: Intel: Rename broadwell source file to bdw_rt286
In reply to Cezary RojewskiRename source file to drop any ambiguity.
---
sound/soc/intel/boards/Makefile | 2 +-
sound/soc/intel/boards/{broadwell.c => bdw_rt286.c} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename sound/soc/intel/boards/{broadwell.c => bdw_rt286.c} (100%)sound/soc/intel/boards/Makefile +1 -1
@@ -2,7 +2,7 @@ snd-soc-sst-haswell-objs := hsw_rt5640.o snd-soc-sst-bdw-rt5650-mach-objs := bdw-rt5650.o snd-soc-sst-bdw-rt5677-mach-objs := bdw-rt5677.o -snd-soc-sst-broadwell-objs := broadwell.o +snd-soc-sst-broadwell-objs := bdw_rt286.o snd-soc-sst-bxt-da7219_max98357a-objs := bxt_da7219_max98357a.o snd-soc-sst-bxt-rt298-objs := bxt_rt298.o snd-soc-sst-sof-pcm512x-objs := sof_pcm512x.o
sound/soc/intel/boards/bdw_rt286.c renamed from sound/soc/intel/boards/broadwell.c +0 -0
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 9/17 ASoC: Intel: bdw_rt286: Reword prefixes of all driver members
In reply to Cezary RojewskiReplace ambiguous 'broadwell_rt286_' prefixes in favour of 'card_', 'link_' and other similar strings to clearly state which object given member implements behavior for.
--- sound/soc/intel/boards/bdw_rt286.c | 102 ++++++++++++++--------------- 1 file changed, 51 insertions(+), 51 deletions(-)
sound/soc/intel/boards/bdw_rt286.c +51 -51
@@ -16,9 +16,9 @@#include "../../codecs/rt286.h" -static struct snd_soc_jack broadwell_headset; +static struct snd_soc_jack card_headset;/* Headset jack detection DAPM pins */ -static struct snd_soc_jack_pin broadwell_headset_pins[] = { +static struct snd_soc_jack_pin card_headset_pins[] = { { .pin ="Mic Jack" , .mask =SND_JACK_MICROPHONE ,
@@ -29,12 +29,12 @@ static struct snd_soc_jack_pin broadwell_headset_pins[] = { }, }; -static const struct snd_kcontrol_new broadwell_controls[] = { +static const struct snd_kcontrol_new card_controls[] = {SOC_DAPM_PIN_SWITCH ("Speaker" ),SOC_DAPM_PIN_SWITCH ("Headphone Jack" ), }; -static const struct snd_soc_dapm_widget broadwell_widgets[] = { +static const struct snd_soc_dapm_widget card_widgets[] = {SND_SOC_DAPM_HP ("Headphone Jack" ,NULL ),SND_SOC_DAPM_SPK ("Speaker" ,NULL ),SND_SOC_DAPM_MIC ("Mic Jack" ,NULL ),
@@ -43,7 +43,7 @@ static const struct snd_soc_dapm_widget broadwell_widgets[] = { SND_SOC_DAPM_LINE("Line Jack", NULL), }; -static const struct snd_soc_dapm_route broadwell_rt286_map[] = { +static const struct snd_soc_dapm_route card_routes[] = {/* speaker */ {"Speaker" ,NULL ,"SPOR" },
@@ -65,22 +65,22 @@ static const struct snd_soc_dapm_route broadwell_rt286_map[] = { {"AIF1 Playback", NULL, "SSP0 CODEC OUT"}, }; -static int broadwell_rt286_codec_init (struct snd_soc_pcm_runtime *rtd) +static int codec_link_init (struct snd_soc_pcm_runtime *rtd) {struct snd_soc_component *component =asoc_rtd_to_codec (rtd,0 )->component;int ret =0 ; ret =snd_soc_card_jack_new_pins (rtd->card,"Headset" , -SND_JACK_HEADSET |SND_JACK_BTN_0 , &broadwell_headset, - broadwell_headset_pins,ARRAY_SIZE (broadwell_headset_pins)); +SND_JACK_HEADSET |SND_JACK_BTN_0 , &card_headset, + card_headset_pins,ARRAY_SIZE (card_headset_pins));if (ret)return ret; -snd_soc_component_set_jack (component, &broadwell_headset,NULL ); +snd_soc_component_set_jack (component, &card_headset,NULL );return 0 ; } -static int broadwell_ssp0_fixup (struct snd_soc_pcm_runtime *rtd, +static int codec_link_hw_params_fixup (struct snd_soc_pcm_runtime *rtd,struct snd_pcm_hw_params *params) { struct snd_interval *rate = hw_param_interval(params,
@@ -97,7 +97,7 @@ static int broadwell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,return 0 ; } -static int broadwell_rt286_hw_params (struct snd_pcm_substream *substream, +static int codec_link_hw_params (struct snd_pcm_substream *substream,struct snd_pcm_hw_params *params) {struct snd_soc_pcm_runtime *rtd =asoc_substream_to_rtd (substream);
@@ -115,8 +115,8 @@ static int broadwell_rt286_hw_params(struct snd_pcm_substream *substream,return ret; } -static const struct snd_soc_ops broadwell_rt286_ops = { - .hw_params = broadwell_rt286_hw_params, +static const struct snd_soc_ops codec_link_ops = { + .hw_params = codec_link_hw_params, };static const unsigned int channels[] = {
@@ -129,7 +129,7 @@ static const struct snd_pcm_hw_constraint_list constraints_channels = { .mask = 0, }; -static int broadwell_fe_startup (struct snd_pcm_substream *substream) +static int bdw_rt286_fe_startup (struct snd_pcm_substream *substream) {struct snd_pcm_runtime *runtime = substream->runtime;
@@ -140,8 +140,8 @@ static int broadwell_fe_startup(struct snd_pcm_substream *substream) &constraints_channels); } -static const struct snd_soc_ops broadwell_fe_ops = { - .startup = broadwell_fe_startup, +static const struct snd_soc_ops bdw_rt286_fe_ops = { + .startup = bdw_rt286_fe_startup, }; SND_SOC_DAILINK_DEF(system,
@@ -169,7 +169,7 @@ SND_SOC_DAILINK_DEF(ssp0_port, DAILINK_COMP_ARRAY(COMP_CPU("ssp0-port")));/* broadwell digital audio interface glue - connects codec <--> CPU */ -static struct snd_soc_dai_link broadwell_rt286_dais[] = { +static struct snd_soc_dai_link card_dai_links[] = {/* Front End DAI links */ { .name ="System PCM" ,
@@ -177,7 +177,7 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = { .nonatomic = 1, .dynamic = 1, .trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST}, - .ops = &broadwell_fe_ops, + .ops = &bdw_rt286_fe_ops, .dpcm_playback = 1, .dpcm_capture = 1, SND_SOC_DAILINK_REG(system, dummy, platform),
@@ -215,19 +215,19 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = { .name = "Codec", .id = 0, .no_pcm = 1, - .init = broadwell_rt286_codec_init, + .init = codec_link_init, .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC, .ignore_pmdown_time = 1, - .be_hw_params_fixup = broadwell_ssp0_fixup, - .ops = &broadwell_rt286_ops, + .be_hw_params_fixup = codec_link_hw_params_fixup, + .ops = &codec_link_ops, .dpcm_playback = 1, .dpcm_capture = 1, SND_SOC_DAILINK_REG(ssp0_port, codec, platform), }, }; -static void broadwell_disable_jack (struct snd_soc_card *card) +static void bdw_rt286_disable_jack (struct snd_soc_card *card) {struct snd_soc_component *component;
@@ -241,21 +241,21 @@ static void broadwell_disable_jack(struct snd_soc_card *card) } } -static int broadwell_suspend (struct snd_soc_card *card) +static int bdw_rt286_suspend (struct snd_soc_card *card) { -broadwell_disable_jack (card); +bdw_rt286_disable_jack (card);return 0 ; } -static int broadwell_resume (struct snd_soc_card *card){ +static int bdw_rt286_resume (struct snd_soc_card *card){struct snd_soc_component *component;for_each_card_components (card, component) {if (!strcmp (component->name,"i2c-INT343A:00" )) {dev_dbg (component->dev,"enabling jack detect for resume.\n" ); -snd_soc_component_set_jack (component, &broadwell_headset,NULL ); +snd_soc_component_set_jack (component, &card_headset,NULL );break ; } }
@@ -270,66 +270,66 @@ static int broadwell_resume(struct snd_soc_card *card){#define DRIVER_NAME NULL/* card name will be used for driver name */ /* broadwell audio machine driver for WPT + RT286S */ -static struct snd_soc_card broadwell_rt286 = { +static struct snd_soc_card bdw_rt286_card = { .owner =THIS_MODULE , - .dai_link = broadwell_rt286_dais, - .num_links =ARRAY_SIZE (broadwell_rt286_dais), - .controls = broadwell_controls, - .num_controls =ARRAY_SIZE (broadwell_controls), - .dapm_widgets = broadwell_widgets, - .num_dapm_widgets =ARRAY_SIZE (broadwell_widgets), - .dapm_routes = broadwell_rt286_map, - .num_dapm_routes =ARRAY_SIZE (broadwell_rt286_map), + .dai_link = card_dai_links, + .num_links =ARRAY_SIZE (card_dai_links), + .controls = card_controls, + .num_controls =ARRAY_SIZE (card_controls), + .dapm_widgets = card_widgets, + .num_dapm_widgets =ARRAY_SIZE (card_widgets), + .dapm_routes = card_routes, + .num_dapm_routes =ARRAY_SIZE (card_routes), .fully_routed = true, - .suspend_pre = broadwell_suspend, - .resume_post = broadwell_resume, + .suspend_pre = bdw_rt286_suspend, + .resume_post = bdw_rt286_resume, }; -static int broadwell_audio_probe (struct platform_device *pdev) +static int bdw_rt286_probe (struct platform_device *pdev) {struct snd_soc_acpi_mach *mach;int ret; - broadwell_rt286.dev = &pdev->dev; + bdw_rt286_card.dev = &pdev->dev;/* override platform name, if required */ mach = pdev->dev.platform_data; - ret =snd_soc_fixup_dai_links_platform_name (&broadwell_rt286, + ret =snd_soc_fixup_dai_links_platform_name (&bdw_rt286_card, mach->mach_params.platform);if (ret)return ret;/* set card and driver name */ if (snd_soc_acpi_sof_parent (&pdev->dev)) { - broadwell_rt286.name =SOF_CARD_NAME ; - broadwell_rt286.driver_name =SOF_DRIVER_NAME ; + bdw_rt286_card.name =SOF_CARD_NAME ; + bdw_rt286_card.driver_name =SOF_DRIVER_NAME ; }else { - broadwell_rt286.name =CARD_NAME ; - broadwell_rt286.driver_name =DRIVER_NAME ; + bdw_rt286_card.name =CARD_NAME ; + bdw_rt286_card.driver_name =DRIVER_NAME ; } -return devm_snd_soc_register_card (&pdev->dev, &broadwell_rt286); +return devm_snd_soc_register_card (&pdev->dev, &bdw_rt286_card); } -static int broadwell_audio_remove (struct platform_device *pdev) +static int bdw_rt286_remove (struct platform_device *pdev) {struct snd_soc_card *card =platform_get_drvdata (pdev); -broadwell_disable_jack (card); +bdw_rt286_disable_jack (card);return 0 ; } -static struct platform_driver broadwell_audio = { - .probe = broadwell_audio_probe, - .remove = broadwell_audio_remove, +static struct platform_driver bdw_rt286_driver = { + .probe = bdw_rt286_probe, + .remove = bdw_rt286_remove, .driver = { .name ="broadwell-audio" , .pm = &snd_soc_pm_ops }, }; -module_platform_driver (broadwell_audio) +module_platform_driver (bdw_rt286_driver)/* Module information */ MODULE_AUTHOR("Liam Girdwood, Xingchao Wang");
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 10/17 ASoC: Intel: bdw_rt286: Reword driver name
In reply to Cezary RojewskiAlign with other Intel boards naming convention and let the name explicitly state which components are being connected.
--- sound/soc/intel/boards/bdw_rt286.c | 4 ++-- sound/soc/intel/common/soc-acpi-intel-hsw-bdw-match.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
sound/soc/intel/boards/bdw_rt286.c +2 -2
@@ -324,7 +324,7 @@ static struct platform_driver bdw_rt286_driver = { .probe = bdw_rt286_probe, .remove = bdw_rt286_remove, .driver = { - .name = "broadwell-audio", + .name = "bdw_rt286", .pm = &snd_soc_pm_ops }, };
@@ -335,4 +335,4 @@ module_platform_driver(bdw_rt286_driver)MODULE_AUTHOR ("Liam Girdwood, Xingchao Wang" );MODULE_DESCRIPTION ("Intel SST Audio for WPT/Broadwell" );MODULE_LICENSE ("GPL v2" ); -MODULE_ALIAS ("platform:broadwell-audio" ); +MODULE_ALIAS ("platform:bdw_rt286" );
sound/soc/intel/common/soc-acpi-intel-hsw-bdw-match.c +1 -1
@@ -23,7 +23,7 @@ EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_haswell_machines);struct snd_soc_acpi_mach snd_soc_acpi_intel_broadwell_machines[] = { { .id ="INT343A" , - .drv_name ="broadwell-audio" , + .drv_name ="bdw_rt286" , .fw_filename ="intel/IntcSST2.bin" , .sof_tplg_filename ="sof-bdw-rt286.tplg" , },
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 11/17 ASoC: Intel: bdw_rt286: Update code indentation
In reply to Cezary RojewskiMake use of 100 character limit and modify indentation so code is easier to read. While at it, sort includes in alphabetical order.
While at it, rename local variable 'chan' to 'channels' to match hsw_rt5640 board's equivalent.
--- sound/soc/intel/boards/bdw_rt286.c | 79 +++++++++++------------------- 1 file changed, 28 insertions(+), 51 deletions(-)
sound/soc/intel/boards/bdw_rt286.c +28 -51
@@ -8,12 +8,11 @@#include <linux/module.h> #include <linux/platform_device.h> #include <sound/core.h> -#include <sound/pcm.h> -#include <sound/soc.h> #include <sound/jack.h> +#include <sound/pcm.h> #include <sound/pcm_params.h> +#include <sound/soc.h> #include <sound/soc-acpi.h> -#include "../../codecs/rt286.h" static struct snd_soc_jack card_headset;
@@ -44,7 +43,6 @@ static const struct snd_soc_dapm_widget card_widgets[] = { };static const struct snd_soc_dapm_route card_routes[] = { -/* speaker */ {"Speaker" ,NULL ,"SPOR" }, {"Speaker" ,NULL ,"SPOL" },
@@ -69,9 +67,10 @@ static int codec_link_init(struct snd_soc_pcm_runtime *rtd) {struct snd_soc_component *component =asoc_rtd_to_codec (rtd,0 )->component;int ret =0 ; - ret =snd_soc_card_jack_new_pins (rtd->card,"Headset" , -SND_JACK_HEADSET |SND_JACK_BTN_0 , &card_headset, - card_headset_pins,ARRAY_SIZE (card_headset_pins)); + + ret =snd_soc_card_jack_new_pins (rtd->card,"Headset" ,SND_JACK_HEADSET |SND_JACK_BTN_0 , + &card_headset, card_headset_pins, +ARRAY_SIZE (card_headset_pins));if (ret)return ret;
@@ -79,34 +78,29 @@ static int codec_link_init(struct snd_soc_pcm_runtime *rtd)return 0 ; } -static int codec_link_hw_params_fixup (struct snd_soc_pcm_runtime *rtd, -struct snd_pcm_hw_params *params) +struct snd_pcm_hw_params *params) { -struct snd_interval *rate =hw_param_interval (params, -SNDRV_PCM_HW_PARAM_RATE ); -struct snd_interval *chan =hw_param_interval (params, -SNDRV_PCM_HW_PARAM_CHANNELS ); +struct snd_interval *channels =hw_param_interval (params,SNDRV_PCM_HW_PARAM_CHANNELS ); +struct snd_interval *rate =hw_param_interval (params,SNDRV_PCM_HW_PARAM_RATE );/* The ADSP will covert the FE rate to 48k, stereo */ rate->min = rate->max =48000 ; - chan->min = chan->max =2 ; - + channels->min = channels->max =2 ;/* set SSP0 to 16 bit */ params_set_format (params,SNDRV_PCM_FORMAT_S16_LE ); +return 0 ; }static int codec_link_hw_params (struct snd_pcm_substream *substream, -struct snd_pcm_hw_params *params) +struct snd_pcm_hw_params *params) {struct snd_soc_pcm_runtime *rtd =asoc_substream_to_rtd (substream);struct snd_soc_dai *codec_dai =asoc_rtd_to_codec (rtd,0 );int ret; - ret =snd_soc_dai_set_sysclk (codec_dai,RT286_SCLK_S_PLL ,24000000 , -SND_SOC_CLOCK_IN ); - + ret =snd_soc_dai_set_sysclk (codec_dai,RT286_SCLK_S_PLL ,24000000 ,SND_SOC_CLOCK_IN );if (ret <0 ) {dev_err (rtd->dev,"can't set codec sysclk configuration\n" );return ret;
@@ -135,8 +129,7 @@ static int bdw_rt286_fe_startup(struct snd_pcm_substream *substream)/* Board supports stereo configuration only */ runtime->hw.channels_max =2 ; -return snd_pcm_hw_constraint_list (runtime,0 , -SNDRV_PCM_HW_PARAM_CHANNELS , +return snd_pcm_hw_constraint_list (runtime,0 ,SNDRV_PCM_HW_PARAM_CHANNELS , &constraints_channels); }
@@ -144,29 +137,15 @@ static const struct snd_soc_ops bdw_rt286_fe_ops = { .startup = bdw_rt286_fe_startup, }; -SND_SOC_DAILINK_DEF (system, -DAILINK_COMP_ARRAY (COMP_CPU ("System Pin" ))); - -SND_SOC_DAILINK_DEF (offload0, -DAILINK_COMP_ARRAY (COMP_CPU ("Offload0 Pin" ))); +SND_SOC_DAILINK_DEF (system,DAILINK_COMP_ARRAY (COMP_CPU ("System Pin" ))); +SND_SOC_DAILINK_DEF (offload0,DAILINK_COMP_ARRAY (COMP_CPU ("Offload0 Pin" ))); +SND_SOC_DAILINK_DEF (offload1,DAILINK_COMP_ARRAY (COMP_CPU ("Offload1 Pin" ))); +SND_SOC_DAILINK_DEF (loopback,DAILINK_COMP_ARRAY (COMP_CPU ("Loopback Pin" ))); -SND_SOC_DAILINK_DEF (offload1, -DAILINK_COMP_ARRAY (COMP_CPU ("Offload1 Pin" ))); - -SND_SOC_DAILINK_DEF (loopback, -DAILINK_COMP_ARRAY (COMP_CPU ("Loopback Pin" ))); - -SND_SOC_DAILINK_DEF (dummy, -DAILINK_COMP_ARRAY (COMP_DUMMY ())); - -SND_SOC_DAILINK_DEF (platform, -DAILINK_COMP_ARRAY (COMP_PLATFORM ("haswell-pcm-audio" ))); - -SND_SOC_DAILINK_DEF (codec, -DAILINK_COMP_ARRAY (COMP_CODEC ("i2c-INT343A:00" ,"rt286-aif1" ))); - -SND_SOC_DAILINK_DEF (ssp0_port, -DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); +SND_SOC_DAILINK_DEF (dummy,DAILINK_COMP_ARRAY (COMP_DUMMY ())); +SND_SOC_DAILINK_DEF (platform,DAILINK_COMP_ARRAY (COMP_PLATFORM ("haswell-pcm-audio" ))); +SND_SOC_DAILINK_DEF (codec,DAILINK_COMP_ARRAY (COMP_CODEC ("i2c-INT343A:00" ,"rt286-aif1" ))); +SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" )));/* broadwell digital audio interface glue - connects codec <--> CPU */ static struct snd_soc_dai_link card_dai_links[] = {
@@ -216,8 +195,7 @@ static struct snd_soc_dai_link card_dai_links[] = { .id = 0, .no_pcm = 1, .init = codec_link_init, - .dai_fmt =SND_SOC_DAIFMT_I2S |SND_SOC_DAIFMT_NB_NF | - SND_SOC_DAIFMT_CBC_CFC, + .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC, .ignore_pmdown_time = 1, .be_hw_params_fixup = codec_link_hw_params_fixup, .ops = &codec_link_ops,
@@ -233,7 +211,6 @@ static void bdw_rt286_disable_jack(struct snd_soc_card *card)for_each_card_components (card, component) {if (!strcmp (component->name,"i2c-INT343A:00" )) { -dev_dbg (component->dev,"disabling jack detect before going to suspend.\n" );snd_soc_component_set_jack (component,NULL ,NULL );break ;
@@ -248,17 +225,18 @@ static int bdw_rt286_suspend(struct snd_soc_card *card)return 0 ; } -static int bdw_rt286_resume (struct snd_soc_card *card){ +static int bdw_rt286_resume (struct snd_soc_card *card) +{struct snd_soc_component *component;for_each_card_components (card, component) {if (!strcmp (component->name,"i2c-INT343A:00" )) { -dev_dbg (component->dev,"enabling jack detect for resume.\n" );snd_soc_component_set_jack (component, &card_headset,NULL );break ; } } +return 0 ; }
@@ -291,11 +269,10 @@ static int bdw_rt286_probe(struct platform_device *pdev)int ret; bdw_rt286_card.dev = &pdev->dev; -/* override platform name, if required */ mach = pdev->dev.platform_data; - ret =snd_soc_fixup_dai_links_platform_name (&bdw_rt286_card, - mach->mach_params.platform); + + ret =snd_soc_fixup_dai_links_platform_name (&bdw_rt286_card, mach->mach_params.platform);if (ret)return ret;
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 12/17 ASoC: Intel: bdw_rt286: Update file comments
In reply to Cezary RojewskiDrop redundant and update valuable comments within the file to increase readability. This patch also revisits module information and kconfig help strings.
--- sound/soc/intel/boards/Kconfig | 2 +- sound/soc/intel/boards/bdw_rt286.c | 23 +++++++---------------- 2 files changed, 8 insertions(+), 17 deletions(-)
sound/soc/intel/boards/Kconfig +1 -1
@@ -85,7 +85,7 @@ config SND_SOC_INTEL_BDW_RT5677_MACH If unsure select "N". config SND_SOC_INTEL_BROADWELL_MACH - tristate "Broadwell Wildcatpoint" + tristate "Broadwell with RT286 I2S codec" depends on I2C depends on I2C_DESIGNWARE_PLATFORM || COMPILE_TEST depends on X86_INTEL_LPSS || COMPILE_TEST
sound/soc/intel/boards/bdw_rt286.c +7 -16
@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0-only /* -* Intel Broadwell Wildcatpoint SST Audio +* Sound card driver for Intel Broadwell Wildcat Point with Realtek 286 * * Copyright (C) 2013, Intel Corporation. All rights reserved. */
@@ -16,7 +16,7 @@#include "../../codecs/rt286.h" static struct snd_soc_jack card_headset; -/* Headset jack detection DAPM pins */ +static struct snd_soc_jack_pin card_headset_pins[] = { { .pin ="Mic Jack" ,
@@ -43,18 +43,14 @@ static const struct snd_soc_dapm_widget card_widgets[] = { };static const struct snd_soc_dapm_route card_routes[] = { -/* speaker */ {"Speaker" ,NULL ,"SPOR" }, {"Speaker" ,NULL ,"SPOL" }, -/* HP jack connectors - unknown if we have jack deteck */ {"Headphone Jack" ,NULL ,"HPO Pin" }, -/* other jacks */ {"MIC1" ,NULL ,"Mic Jack" }, {"LINE1" ,NULL ,"Line Jack" }, -/* digital mics */ {"DMIC1 Pin" ,NULL ,"DMIC1" }, {"DMIC2 Pin" ,NULL ,"DMIC2" },
@@ -84,10 +80,10 @@ static int codec_link_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,struct snd_interval *channels =hw_param_interval (params,SNDRV_PCM_HW_PARAM_CHANNELS );struct snd_interval *rate =hw_param_interval (params,SNDRV_PCM_HW_PARAM_RATE ); -/* The ADSP will covert the FE rate to 48k, stereo */ +/* The ADSP will convert the FE rate to 48kHz, stereo. */ rate->min = rate->max =48000 ; channels->min = channels->max =2 ; -/* set SSP0 to 16 bit */ +/* Set SSP0 to 16 bit. */ params_set_format (params,SNDRV_PCM_FORMAT_S16_LE );return 0 ;
@@ -147,7 +143,6 @@ SND_SOC_DAILINK_DEF(platform, DAILINK_COMP_ARRAY(COMP_PLATFORM("haswell-pcm-audiSND_SOC_DAILINK_DEF (codec,DAILINK_COMP_ARRAY (COMP_CODEC ("i2c-INT343A:00" ,"rt286-aif1" )));SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); -/* broadwell digital audio interface glue - connects codec <--> CPU */ static struct snd_soc_dai_link card_dai_links[] = {/* Front End DAI links */ {
@@ -240,14 +235,13 @@ static int bdw_rt286_resume(struct snd_soc_card *card)return 0 ; } -/* use space before codec name to simplify card ID, and simplify driver name */ +/* Use space before codec name to simplify card ID, and simplify driver name. */ #define SOF_CARD_NAME "bdw rt286"/* card name will be 'sof-bdw rt286' */ #define SOF_DRIVER_NAME "SOF"#define CARD_NAME "broadwell-rt286"#define DRIVER_NAME NULL/* card name will be used for driver name */ -/* broadwell audio machine driver for WPT + RT286S */ static struct snd_soc_card bdw_rt286_card = { .owner =THIS_MODULE , .dai_link = card_dai_links,
@@ -269,14 +263,12 @@ static int bdw_rt286_probe(struct platform_device *pdev)int ret; bdw_rt286_card.dev = &pdev->dev; -/* override platform name, if required */ mach = pdev->dev.platform_data; ret =snd_soc_fixup_dai_links_platform_name (&bdw_rt286_card, mach->mach_params.platform);if (ret)return ret; -/* set card and driver name */ if (snd_soc_acpi_sof_parent (&pdev->dev)) { bdw_rt286_card.name =SOF_CARD_NAME ; bdw_rt286_card.driver_name =SOF_DRIVER_NAME ;
@@ -308,8 +300,7 @@ static struct platform_driver bdw_rt286_driver = {module_platform_driver (bdw_rt286_driver) -/* Module information */ MODULE_AUTHOR("Liam Girdwood, Xingchao Wang"); -MODULE_DESCRIPTION ("Intel SST Audio for WPT/Broadwell" ); -MODULE_LICENSE ("GPL v2" ); +MODULE_DESCRIPTION ("Sound card driver for Intel Broadwell Wildcat Point with Realtek 286" ); +MODULE_LICENSE ("GPL" );MODULE_ALIAS ("platform:bdw_rt286" );
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 13/17 ASoC: Intel: bdw_rt286: Improve probe() function quality
In reply to Cezary RojewskiDeclare local 'dev' and make use of it plus dev_get_platdata() to improve code readability. Relocate few relevant to the function macros for the exact same read too.
--- sound/soc/intel/boards/bdw_rt286.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-)
sound/soc/intel/boards/bdw_rt286.c +11 -12
@@ -235,13 +235,6 @@ static int bdw_rt286_resume(struct snd_soc_card *card)return 0 ; } -/* Use space before codec name to simplify card ID, and simplify driver name. */ -#define SOF_CARD_NAME "bdw rt286"/* card name will be 'sof-bdw rt286' */ -#define SOF_DRIVER_NAME "SOF" - -#define CARD_NAME "broadwell-rt286" -#define DRIVER_NAME NULL/* card name will be used for driver name */ -static struct snd_soc_card bdw_rt286_card = { .owner =THIS_MODULE , .dai_link = card_dai_links,
@@ -257,27 +250,33 @@ static struct snd_soc_card bdw_rt286_card = { .resume_post = bdw_rt286_resume, }; +/* Use space before codec name to simplify card ID, and simplify driver name. */ +#define SOF_CARD_NAME "bdw rt286"/* card name will be 'sof-bdw rt286' */ +#define SOF_DRIVER_NAME "SOF" + +#define CARD_NAME "broadwell-rt286" +static int bdw_rt286_probe (struct platform_device *pdev) {struct snd_soc_acpi_mach *mach; +struct device *dev = &pdev->dev;int ret; - bdw_rt286_card.dev = &pdev->dev; - mach = pdev->dev.platform_data; + bdw_rt286_card.dev = dev; + mach =dev_get_platdata (dev); ret =snd_soc_fixup_dai_links_platform_name (&bdw_rt286_card, mach->mach_params.platform);if (ret)return ret; -if (snd_soc_acpi_sof_parent (&pdev->dev)) { +if (snd_soc_acpi_sof_parent (dev)) { bdw_rt286_card.name =SOF_CARD_NAME ; bdw_rt286_card.driver_name =SOF_DRIVER_NAME ; }else { bdw_rt286_card.name =CARD_NAME ; - bdw_rt286_card.driver_name =DRIVER_NAME ; } -return devm_snd_soc_register_card (&pdev->dev, &bdw_rt286_card); +return devm_snd_soc_register_card (dev, &bdw_rt286_card); }static int bdw_rt286_remove (struct platform_device *pdev)
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 14/17 ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability
In reply to Cezary RojewskiPrint status if setting sysclk fails.
--- sound/soc/intel/boards/bdw_rt286.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/bdw_rt286.c +1 -1
@@ -98,7 +98,7 @@ static int codec_link_hw_params(struct snd_pcm_substream *substream, ret =snd_soc_dai_set_sysclk (codec_dai,RT286_SCLK_S_PLL ,24000000 ,SND_SOC_CLOCK_IN );if (ret <0 ) { -dev_err (rtd->dev,"can't set codec sysclk configuration\n" ); +dev_err (rtd->dev,"set codec sysclk failed: %d\n" , ret);return ret; }
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 15/17 ASoC: Intel: bdw_rt286: Improve codec_init() quality
In reply to Cezary RojewskiDrop redundant 'ret' assignemnt, stop ignoring set_jack() return value and reword local 'component' variable to 'codec' to improve readability.
--- sound/soc/intel/boards/bdw_rt286.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
sound/soc/intel/boards/bdw_rt286.c +3 -4
@@ -61,8 +61,8 @@ static const struct snd_soc_dapm_route card_routes[] = {static int codec_link_init (struct snd_soc_pcm_runtime *rtd) { -struct snd_soc_component *component =asoc_rtd_to_codec (rtd,0 )->component; -int ret =0 ; +struct snd_soc_component *codec =asoc_rtd_to_codec (rtd,0 )->component; +int ret; ret = snd_soc_card_jack_new_pins(rtd->card, "Headset", SND_JACK_HEADSET | SND_JACK_BTN_0, &card_headset, card_headset_pins,
@@ -70,8 +70,7 @@ static int codec_link_init(struct snd_soc_pcm_runtime *rtd)if (ret)return ret; -snd_soc_component_set_jack (component, &card_headset,NULL ); -return 0 ; +return snd_soc_component_set_jack (codec, &card_headset,NULL ); } static int codec_link_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 16/17 ASoC: Intel: bdw_rt286: Refactor jack handling
In reply to Cezary RojewskiUse link->exit() rather than pdev->remove() to unassign jack during card unbind procedure so codec link initialization and exit procedures are synergistic.
Also, there is no need to perform search for codec dai in suspend_pre() and resume_post() ourselves. Use snd_soc_card_get_codec_dai() instead.
--- sound/soc/intel/boards/bdw_rt286.c | 55 +++++++++--------------------- 1 file changed, 16 insertions(+), 39 deletions(-)
sound/soc/intel/boards/bdw_rt286.c +16 -39
@@ -73,6 +73,13 @@ static int codec_link_init(struct snd_soc_pcm_runtime *rtd)return snd_soc_component_set_jack (codec, &card_headset,NULL ); } +static void codec_link_exit (struct snd_soc_pcm_runtime *rtd) +{ +struct snd_soc_component *codec =asoc_rtd_to_codec (rtd,0 )->component; + +snd_soc_component_set_jack (codec,NULL ,NULL ); +} +static int codec_link_hw_params_fixup (struct snd_soc_pcm_runtime *rtd,struct snd_pcm_hw_params *params) {
@@ -189,6 +196,7 @@ static struct snd_soc_dai_link card_dai_links[] = { .id = 0, .no_pcm = 1, .init = codec_link_init, + .exit = codec_link_exit, .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC, .ignore_pmdown_time = 1, .be_hw_params_fixup = codec_link_hw_params_fixup,
@@ -199,43 +207,24 @@ static struct snd_soc_dai_link card_dai_links[] = { }, }; -static void bdw_rt286_disable_jack (struct snd_soc_card *card) -{ -struct snd_soc_component *component; - -for_each_card_components (card, component) { -if (!strcmp (component->name,"i2c-INT343A:00" )) { -dev_dbg (component->dev,"disabling jack detect before going to suspend.\n" ); -snd_soc_component_set_jack (component,NULL ,NULL ); -break ; - } - } -} - -static int bdw_rt286_suspend (struct snd_soc_card *card) +static int card_suspend_pre (struct snd_soc_card *card) { -bdw_rt286_disable_jack (card); +struct snd_soc_dai *codec_dai =snd_soc_card_get_codec_dai (card,"rt286-aif1" ); -return 0 ; +return snd_soc_component_set_jack (codec_dai->component,NULL ,NULL ); } -static int bdw_rt286_resume (struct snd_soc_card *card) +static int card_resume_post (struct snd_soc_card *card) { -struct snd_soc_component *component; - -for_each_card_components (card, component) { -if (!strcmp (component->name,"i2c-INT343A:00" )) { -dev_dbg (component->dev,"enabling jack detect for resume.\n" ); -snd_soc_component_set_jack (component, &card_headset,NULL ); -break ; - } - } +struct snd_soc_dai *codec_dai =snd_soc_card_get_codec_dai (card,"rt286-aif1" ); -return 0 ; +return snd_soc_component_set_jack (codec_dai->component, &card_headset,NULL ); }static struct snd_soc_card bdw_rt286_card = { .owner =THIS_MODULE , + .suspend_pre = card_suspend_pre, + .resume_post = card_resume_post, .dai_link = card_dai_links, .num_links =ARRAY_SIZE (card_dai_links), .controls = card_controls,
@@ -245,8 +234,6 @@ static struct snd_soc_card bdw_rt286_card = { .dapm_routes = card_routes, .num_dapm_routes = ARRAY_SIZE(card_routes), .fully_routed = true, - .suspend_pre = bdw_rt286_suspend, - .resume_post = bdw_rt286_resume, };/* Use space before codec name to simplify card ID, and simplify driver name. */
@@ -278,18 +265,8 @@ static int bdw_rt286_probe(struct platform_device *pdev)return devm_snd_soc_register_card (dev, &bdw_rt286_card); } -static int bdw_rt286_remove (struct platform_device *pdev) -{ -struct snd_soc_card *card =platform_get_drvdata (pdev); - -bdw_rt286_disable_jack (card); - -return 0 ; -} -static struct platform_driver bdw_rt286_driver = { .probe = bdw_rt286_probe, - .remove = bdw_rt286_remove, .driver = { .name ="bdw_rt286" , .pm = &snd_soc_pm_ops
Signature · 1 line
2.25.1
Cezary Rojewski
maintainerPATCH v4 17/17 ASoC: Intel: bdw_rt286: Remove FE DAI ops
In reply to Cezary Rojewskibdw_rt286_fe_ops is redundant as platform components already limit the number of channels available for the endpoint.
--- sound/soc/intel/boards/bdw_rt286.c | 25 ------------------------- 1 file changed, 25 deletions(-)
sound/soc/intel/boards/bdw_rt286.c +0 -25
@@ -115,30 +115,6 @@ static const struct snd_soc_ops codec_link_ops = { .hw_params = codec_link_hw_params, }; -static const unsigned int channels[] = { -2 , -}; - -static const struct snd_pcm_hw_constraint_list constraints_channels = { - .count =ARRAY_SIZE (channels), - .list = channels, - .mask =0 , -}; - -static int bdw_rt286_fe_startup (struct snd_pcm_substream *substream) -{ -struct snd_pcm_runtime *runtime = substream->runtime; - -/* Board supports stereo configuration only */ - runtime->hw.channels_max =2 ; -return snd_pcm_hw_constraint_list (runtime,0 ,SNDRV_PCM_HW_PARAM_CHANNELS , - &constraints_channels); -} - -static const struct snd_soc_ops bdw_rt286_fe_ops = { - .startup = bdw_rt286_fe_startup, -}; -SND_SOC_DAILINK_DEF (system,DAILINK_COMP_ARRAY (COMP_CPU ("System Pin" )));SND_SOC_DAILINK_DEF (offload0,DAILINK_COMP_ARRAY (COMP_CPU ("Offload0 Pin" )));SND_SOC_DAILINK_DEF (offload1,DAILINK_COMP_ARRAY (COMP_CPU ("Offload1 Pin" )));
@@ -157,7 +133,6 @@ static struct snd_soc_dai_link card_dai_links[] = { .nonatomic = 1, .dynamic = 1, .trigger = {SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST}, - .ops = &bdw_rt286_fe_ops, .dpcm_playback = 1, .dpcm_capture = 1, SND_SOC_DAILINK_REG(system, dummy, platform),
Signature · 1 line
2.25.1
Quoted 9 lines · Cezary Rojewski
A number of patches improving overall quality and readability of
haswell.candbroadwell.csource files found insound/soc/intel/boards. Both files are first renamed and only then actual changes are being incrementally added. The respective names are:hsw_rt5640andbdw_rt286to match the pattern found in more recent boards.Most patches bring no functional change - the more impactful patches at are placed the end:
Quoted 7 lines
Refactor of suspend/resume flow for the
bdw_rt286board by droppingdev->remove()in favour ofcard->remove()and adjust jack handling to reduce code size slightly by implementingcard_set_jack().The last patch is removing of FE DAI ops. Given the existence of platform FE DAI capabilities (either static declaration or through topology file), this code is redundant.
Possibly a mistake in our tests, but this error seems to be introduced:
[ 107.397637] kernel: rt286 i2c-INT343A:00: ASoC: DAPM unknown pin LDO1
I'll have to re-run the tests, sharing this information as is.
Quoted 47 lines
Changes in v4:
- just a rebase to fix missed conflicts with for-nextChanges in v3:
- Patch 16/17 refactoring suspend/resume has been renamed to "Refactor jack handling". Dropped the usage ofcard->remove()in favor oflink->exit()in that very patchChanges in v2:
- fixed wording error in patch 02/17 so it correctly mentions 'haswell_rt5640', not 'broadwell_rt286'
- decided not to add kernel module names changes to this patchset so the review is not complicated unnecessarily. Will send them separately insteadCezary Rojewski (17):
ASoC: Intel: Rename haswell source file tohsw_rt5640
ASoC: Intel:hsw_rt5640: Reword prefixes of all driver members
ASoC: Intel:hsw_rt5640: Reword driver name
ASoC: Intel:hsw_rt5640: Update code indentation
ASoC: Intel:hsw_rt5640: Update file comments
ASoC: Intel:hsw_rt5640: Improveprobe()function quality
ASoC: Intel:hsw_rt5640: Improvehw_params()debug-ability
ASoC: Intel: Rename broadwell source file tobdw_rt286
ASoC: Intel:bdw_rt286: Reword prefixes of all driver members
ASoC: Intel:bdw_rt286: Reword driver name
ASoC: Intel:bdw_rt286: Update code indentation
ASoC: Intel:bdw_rt286: Update file comments
ASoC: Intel:bdw_rt286: Improveprobe()function quality
ASoC: Intel:bdw_rt286: Improvehw_params()debug-ability
ASoC: Intel:bdw_rt286: Improvecodec_init()quality
ASoC: Intel:bdw_rt286: Refactor jack handling
ASoC: Intel:bdw_rt286: Remove FE DAI opssound/soc/intel/boards/Kconfig | 4 +- sound/soc/intel/boards/Makefile | 4 +- sound/soc/intel/boards/bdw_rt286.c | 256 +++++++++++++ sound/soc/intel/boards/broadwell.c | 338 ------------------ sound/soc/intel/boards/haswell.c | 202 ----------- sound/soc/intel/boards/hsw_rt5640.c | 176 +++++++++ .../common/soc-acpi-intel-hsw-bdw-match.c | 6 +- 7 files changed, 439 insertions(+), 547 deletions(-) create mode 100644 sound/soc/intel/boards/bdw_rt286.c delete mode 100644 sound/soc/intel/boards/broadwell.c delete mode 100644 sound/soc/intel/boards/haswell.c create mode 100644 sound/soc/intel/boards/hsw_rt5640.c
Cezary Rojewski
maintainerQuoted 18 lines · Pierre-Louis Bossart
Quoted 9 lines · Cezary Rojewski
A number of patches improving overall quality and readability of
haswell.candbroadwell.csource files found insound/soc/intel/boards. Both files are first renamed and only then actual changes are being incrementally added. The respective names are:hsw_rt5640andbdw_rt286to match the pattern found in more recent boards.Most patches bring no functional change - the more impactful patches at are placed the end:
Quoted 7 lines
Refactor of suspend/resume flow for the
bdw_rt286board by droppingdev->remove()in favour ofcard->remove()and adjust jack handling to reduce code size slightly by implementingcard_set_jack().The last patch is removing of FE DAI ops. Given the existence of platform FE DAI capabilities (either static declaration or through topology file), this code is redundant.
Quoted 5 lines
Possibly a mistake in our tests, but this error seems to be introduced:
[ 107.397637] kernel: rt286 i2c-INT343A:00: ASoC: DAPM unknown pin LDO1I'll have to re-run the tests, sharing this information as is.
Hello,
Thanks for the report! However, this has been reported earlier during the v2 review [1]. This is also why a fix have been provided [2] earlier today. Notice that shape of link->exit() found here is shared by other Intel boards e.g.: SOF ones. In general, the initial discussion regarding card->remove() revealed some 'probe vs remove' problems within the framework.
[1]: https://lore.kernel.org/alsa-devel/[email protected]/
[2]: https://lore.kernel.org/alsa-devel/[email protected]/T/#t
Regards,
Czarek
Quoted 36 lines · Cezary Rojewski
Quoted 18 lines · Pierre-Louis Bossart
Quoted 9 lines · Cezary Rojewski
A number of patches improving overall quality and readability of
haswell.candbroadwell.csource files found insound/soc/intel/boards. Both files are first renamed and only then actual changes are being incrementally added. The respective names are:hsw_rt5640andbdw_rt286to match the pattern found in more recent boards.Most patches bring no functional change - the more impactful patches at are placed the end:
Quoted 7 lines
Refactor of suspend/resume flow for the
bdw_rt286board by droppingdev->remove()in favour ofcard->remove()and adjust jack handling to reduce code size slightly by implementingcard_set_jack().The last patch is removing of FE DAI ops. Given the existence of platform FE DAI capabilities (either static declaration or through topology file), this code is redundant.
Quoted 5 lines
Possibly a mistake in our tests, but this error seems to be introduced:
[ 107.397637] kernel: rt286 i2c-INT343A:00: ASoC: DAPM unknown pin LDO1
I'll have to re-run the tests, sharing this information as is.
Hello,
Thanks for the report! However, this has been reported earlier during the v2 review [1]. This is also why a fix have been provided [2] earlier today. Notice that shape of
link->exit()found here is shared by other Intel boards e.g.: SOF ones. In general, the initial discussion regardingcard->remove()revealed some 'probe vs remove' problems within the framework.
Quoted 5 lines
[1]:
https://lore.kernel.org/alsa-devel/[email protected]/[2]:
https://lore.kernel.org/alsa-devel/[email protected]/T/#t
It's rather difficult to follow these changes and error reports buried in email report sent on a Sunday of a three-day week-end for me. I also had additional errors not reported,
[ 36.125113] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin HV [ 36.125128] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin VREF [ 36.125130] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin LDO1 [ 36.125921] kernel: rt286 i2c-INT343A:00: ASoC: DAPM unknown pin LDO1
it's unclear to me why a dailink change in a machine driver would cause such codec-side issues.
If the changes in this 17-patch series need to be tied to a framework fix, you have to make the dependencies explicit and better yet provide a self-contained patch series that does not introduce a temporary regression, or introduce the framework change first and clearly describe the dependency in a longer Broadwell-specific patchset. This is an 8-yr old device, it shouldn't be that hard.
Cezary Rojewski
maintainerQuoted 30 lines · Pierre-Louis Bossart
Quoted 10 lines · Cezary Rojewski
Hello,
Thanks for the report! However, this has been reported earlier during the v2 review [1]. This is also why a fix have been provided [2] earlier today. Notice that shape of
link->exit()found here is shared by other Intel boards e.g.: SOF ones. In general, the initial discussion regardingcard->remove()revealed some 'probe vs remove' problems within the framework.Quoted 5 lines
[1]:
https://lore.kernel.org/alsa-devel/[email protected]/[2]:
https://lore.kernel.org/alsa-devel/[email protected]/T/#tIt's rather difficult to follow these changes and error reports buried in email report sent on a Sunday of a three-day week-end for me. I also had additional errors not reported,
[ 36.125113] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin HV [ 36.125128] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin VREF [ 36.125130] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin LDO1 [ 36.125921] kernel: rt286 i2c-INT343A:00: ASoC: DAPM unknown pin LDO1it's unclear to me why a dailink change in a machine driver would cause such codec-side issues.
Quoted 6 lines
If the changes in this 17-patch series need to be tied to a framework fix, you have to make the dependencies explicit and better yet provide a self-contained patch series that does not introduce a temporary regression, or introduce the framework change first and clearly describe the dependency in a longer Broadwell-specific patchset. This is an 8-yr old device, it shouldn't be that hard.
The last part is not helpful in solving the problem.
This reply comments 00/17 whereas in fact you are speaking solely about 16/17. Because of that I'm suggesting: leave that patch (the 16/17 one) out when merging. It will be send later once link->exit() issue is dealt with. All other patches are independent of either of changes.
Simultaneously the link->exit() fix, which is the fruit of this discussion, is still valid and can be send as standalone patch - what is already the case [1].
[1]: https://lore.kernel.org/alsa-devel/[email protected]/
Regards,
Czarek
Pierre-Louis Bossart
Tested-byQuoted 37 lines
Quoted 29 lines
Quoted 9 lines
Thanks for the report! However, this has been reported earlier during the v2 review [1]. This is also why a fix have been provided [2] earlier today. Notice that shape of
link->exit()found here is shared by other Intel boards e.g.: SOF ones. In general, the initial discussion regardingcard->remove()revealed some 'probe vs remove' problems within the framework.Quoted 7 lines
[1]:
https://lore.kernel.org/alsa-devel/[email protected]/[2]:
https://lore.kernel.org/alsa-devel/[email protected]/T/#tIt's rather difficult to follow these changes and error reports buried in email report sent on a Sunday of a three-day week-end for me. I also had additional errors not reported,
[ 36.125113] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin HV [ 36.125128] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin VREF [ 36.125130] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin LDO1 [ 36.125921] kernel: rt286 i2c-INT343A:00: ASoC: DAPM unknown pin LDO1
it's unclear to me why a dailink change in a machine driver would cause such codec-side issues.
Quoted 6 lines
If the changes in this 17-patch series need to be tied to a framework fix, you have to make the dependencies explicit and better yet provide a self-contained patch series that does not introduce a temporary regression, or introduce the framework change first and clearly describe the dependency in a longer Broadwell-specific patchset. This is an 8-yr old device, it shouldn't be that hard.
Quoted 6 lines
The last part is not helpful in solving the problem.
This reply comments 00/17 whereas in fact you are speaking solely about 16/17. Because of that I'm suggesting: leave that patch (the 16/17 one) out when merging. It will be send later once
link->exit()issue is dealt with. All other patches are independent of either of changes.
That's fine with me. It wasn't self-explanatory from this cover letter or your earlier answer that this patch 16 can be dropped for now. If that patch is omitted, feel free to add my
Quoted 3 lines
Simultaneously the
link->exit()fix, which is the fruit of this discussion, is still valid and can be send as standalone patch - what is already the case [1].
That's fine as well. What I was arguing on is the relationship between patchsets and dependencies, what you are suggesting is perfectly acceptable.
Cezary Rojewski
maintainerQuoted 6 lines · Pierre-Louis Bossart
Quoted 6 lines
Quoted 6 lines
I also had additional errors not reported,
[ 36.125113] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin HV [ 36.125128] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin VREF [ 36.125130] kernel: rt286 i2c-INT343A:00: ASoC: unknown pin LDO1 [ 36.125921] kernel: rt286 i2c-INT343A:00: ASoC: DAPM unknown pin LDO1
(save)
Quoted 2 lines
That's fine as well. What I was arguing on is the relationship between patchsets and dependencies, what you are suggesting is perfectly acceptable.
I agree. Frankly I was not aware about the dependencies myself - it wasn't done on purpose. Your report above (notice that there is more than just the LDO1 line) made me analyze our tree once more. Turned out that fixes related to Realtek codecs sent by Amadeo last week [1] address the problem and that's why I had not noticed anything.
Will work on the codec series and see what's needed or not given Mark's review and then come back to the bdw_rt286 jack-handling subject. Thanks!
[1]: https://lore.kernel.org/alsa-devel/[email protected]/
Regards,
Czarek
Mark Brown
maintainerRe: (subset) [PATCH v4 00/17] ASoC: Intel: haswell and broadwell boards update
In reply to Cezary RojewskiQuoted 10 lines · Cezary Rojewski
A number of patches improving overall quality and readability of
haswell.candbroadwell.csource files found insound/soc/intel/boards. Both files are first renamed and only then actual changes are being incrementally added. The respective names are:hsw_rt5640andbdw_rt286to match the pattern found in more recent boards.Most patches bring no functional change - the more impactful patches at are placed the end:
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[01/17] ASoC: Intel: Rename haswell source file to hsw_rt5640
commit: 8b99e24de3fae72ff5ef38832b94b1e41059eeed
[02/17] ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members
commit: 675002b6ca9132445e340bd106297d584e44fc9a
[03/17] ASoC: Intel: hsw_rt5640: Reword driver name
commit: a69615e81709da0ff1f035886e8b3faf6125cd22
[04/17] ASoC: Intel: hsw_rt5640: Update code indentation
commit: 5b66dde4ada531c1a2417d8daf68004067932a19
[05/17] ASoC: Intel: hsw_rt5640: Update file comments
commit: 2c53debbbf04eb40854fa33813514828fa455783
[06/17] ASoC: Intel: hsw_rt5640: Improve probe() function quality
commit: 0439f262a9b39734c1440733850969f0342c50c3
[07/17] ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability
commit: 6c65908251edc637b53bdeb9e79d918a8d081183
[08/17] ASoC: Intel: Rename broadwell source file to bdw_rt286
commit: 6d8758f6afd91cced9c6c5571337a5fbc6955bb2
[09/17] ASoC: Intel: bdw_rt286: Reword prefixes of all driver members
commit: 40b5c9030a87e97c00c84403902481deadd2a57b
[10/17] ASoC: Intel: bdw_rt286: Reword driver name
commit: 86156bcbca08ee32d04ca56c57ff3fce6fc5fc4b
[11/17] ASoC: Intel: bdw_rt286: Update code indentation
commit: 9de833d2dcd43c953f7869f27bffd41896adb425
[12/17] ASoC: Intel: bdw_rt286: Update file comments
commit: 128bb6fb530841348ee4d9b4234b30006c44c803
[13/17] ASoC: Intel: bdw_rt286: Improve probe() function quality
commit: 9177203c209d9137dce52c7f0bc28e54960e5a41
[14/17] ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability
commit: 423cc2d0e8506a0ce6e3ef1806a561de1076e033
[15/17] ASoC: Intel: bdw_rt286: Improve codec_init() quality
commit: 8fe4709962d74a19c0c1dfc877ba600101340c62
[17/17] ASoC: Intel: bdw_rt286: Remove FE DAI ops
commit: e7f68863545163ec75b6bc3cc48fe888c28e0ec6All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark