Skip to content

ASoC: Intel: haswell and broadwell boards update

Cezary Rojewski alsa-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest17 patches 7 repliesIn review
  2. v317 patches 0 repliesSuperseded
  3. v217 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v117 patches6 repliesSuperseded

Changes in v4 from the cover letter

- just a rebase to fix missed conflicts with for-next

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17ASoC: Intel: Rename haswell source file to hsw_rt5640sound/soc/intel/boards/Makefile sound/soc/intel/boards/hsw_rt5640.c+1 -10 replies
2/17ASoC: Intel: hsw_rt5640: Reword prefixes of all driver memberssound/soc/intel/boards/hsw_rt5640.c+23 -230 replies
3/17ASoC: Intel: hsw_rt5640: Reword driver namesound/soc/intel/boards/hsw_rt5640.c sound/soc/intel/common/soc-acpi-intel-hsw-bdw-match.c+4 -40 replies
4/17ASoC: Intel: hsw_rt5640: Update code indentationsound/soc/intel/boards/hsw_rt5640.c+18 -410 replies
5/17ASoC: Intel: hsw_rt5640: Update file commentssound/soc/intel/boards/Kconfig sound/soc/intel/boards/hsw_rt5640.c+7 -110 replies
6/17ASoC: Intel: hsw_rt5640: Improve probe() function qualitysound/soc/intel/boards/hsw_rt5640.c+4 -30 replies
7/17ASoC: Intel: hsw_rt5640: Improve hw_params() debug-abilitysound/soc/intel/boards/hsw_rt5640.c+1 -10 replies
8/17ASoC: Intel: Rename broadwell source file to bdw_rt286sound/soc/intel/boards/Makefile sound/soc/intel/boards/bdw_rt286.c+1 -10 replies
9/17ASoC: Intel: bdw_rt286: Reword prefixes of all driver memberssound/soc/intel/boards/bdw_rt286.c+51 -510 replies
10/17ASoC: Intel: bdw_rt286: Reword driver namesound/soc/intel/boards/bdw_rt286.c sound/soc/intel/common/soc-acpi-intel-hsw-bdw-match.c+3 -30 replies
11/17ASoC: Intel: bdw_rt286: Update code indentationsound/soc/intel/boards/bdw_rt286.c+28 -510 replies
12/17ASoC: Intel: bdw_rt286: Update file commentssound/soc/intel/boards/Kconfig sound/soc/intel/boards/bdw_rt286.c+8 -170 replies
13/17ASoC: Intel: bdw_rt286: Improve probe() function qualitysound/soc/intel/boards/bdw_rt286.c+11 -120 replies
14/17ASoC: Intel: bdw_rt286: Improve hw_params() debug-abilitysound/soc/intel/boards/bdw_rt286.c+1 -10 replies
15/17ASoC: Intel: bdw_rt286: Improve codec_init() qualitysound/soc/intel/boards/bdw_rt286.c+3 -40 replies
16/17ASoC: Intel: bdw_rt286: Refactor jack handlingsound/soc/intel/boards/bdw_rt286.c+16 -390 replies
17/17ASoC: Intel: bdw_rt286: Remove FE DAI opssound/soc/intel/boards/bdw_rt286.c+0 -250 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchAmadeusz SławińskiPierre-Louis Bossart
SeriesT-b
1/17R-b
2/17R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b
8/17R-b
9/17R-b
10/17R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17R-b
17/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/17] ASoC: Intel: haswell and broadwell boards update

A number of patches improving overall quality and readability of haswell.c and broadwell.c source files found in sound/soc/intel/boards. Both files are first renamed and only then actual changes are being incrementally added. The respective names are: hsw_rt5640 and bdw_rt286 to match the pattern found in more recent boards.

Most patches bring no functional change - the more impactful patches at are placed the end:

Refactor of suspend/resume flow for the bdw_rt286 board by dropping dev->remove() in favour of card->remove() and adjust jack handling to reduce code size slightly by implementing card_set_jack().

The last patch is removing of FE DAI ops. Given the existence of platform FE DAI capabilities (either static declaration or through topology file), this code is redundant.

Changes in v4:
- just a rebase to fix missed conflicts with for-next

Changes in v3:
- Patch 16/17 refactoring suspend/resume has been renamed to "Refactor jack handling". Dropped the usage of card->remove() in favor of link->exit() in that very patch

Changes in v2:
- fixed wording error in patch 02/17 so it correctly mentions 'haswell_rt5640', not 'broadwell_rt286'
- decided not to add kernel module names changes to this patchset so the review is not complicated unnecessarily. Will send them separately instead

Cezary Rojewski (17):
ASoC: Intel: Rename haswell source file to hsw_rt5640
ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members
ASoC: Intel: hsw_rt5640: Reword driver name
ASoC: Intel: hsw_rt5640: Update code indentation
ASoC: Intel: hsw_rt5640: Update file comments
ASoC: Intel: hsw_rt5640: Improve probe() function quality
ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability
ASoC: Intel: Rename broadwell source file to bdw_rt286
ASoC: Intel: bdw_rt286: Reword prefixes of all driver members
ASoC: Intel: bdw_rt286: Reword driver name
ASoC: Intel: bdw_rt286: Update code indentation
ASoC: Intel: bdw_rt286: Update file comments
ASoC: Intel: bdw_rt286: Improve probe() function quality
ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability
ASoC: Intel: bdw_rt286: Improve codec_init() quality
ASoC: Intel: bdw_rt286: Refactor jack handling
ASoC: Intel: bdw_rt286: Remove FE DAI ops

 sound/soc/intel/boards/Kconfig                |   4 +-
 sound/soc/intel/boards/Makefile               |   4 +-
 sound/soc/intel/boards/bdw_rt286.c            | 256 +++++++++++++
 sound/soc/intel/boards/broadwell.c            | 338 ------------------
 sound/soc/intel/boards/haswell.c              | 202 -----------
 sound/soc/intel/boards/hsw_rt5640.c           | 176 +++++++++
 .../common/soc-acpi-intel-hsw-bdw-match.c     |   6 +-
 7 files changed, 439 insertions(+), 547 deletions(-)
 create mode 100644 sound/soc/intel/boards/bdw_rt286.c
 delete mode 100644 sound/soc/intel/boards/broadwell.c
 delete mode 100644 sound/soc/intel/boards/haswell.c
 create mode 100644 sound/soc/intel/boards/hsw_rt5640.c
Signature · 1 line
2.25.1