net: dsa: qca8k: reduce mgmt ethernet timeout
Subsystems (3)
PATCH v2 1/1 net: dsa: qca8k: reduce mgmt ethernet timeout
The current mgmt ethernet timeout is set to 100ms. This value is too big and would slow down any mdio command in case the mgmt ethernet packet have some problems on the receiving part.
Reduce it to just 5ms to handle case when some operation are done on the master port that would cause the mgmt ethernet to not work temporarily.
---
v2:
- Split from the original series to prose it as single to net-next while the stable mtu patch gets accepted.
- Add fixes tag
drivers/net/dsa/qca8k.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/qca8k.h +1 -1
@@ -15,7 +15,7 @@#define QCA8K_ETHERNET_MDIO_PRIORITY 7#define QCA8K_ETHERNET_PHY_PRIORITY 6 -#define QCA8K_ETHERNET_TIMEOUT 100 +#define QCA8K_ETHERNET_TIMEOUT 5#define QCA8K_NUM_PORTS 7#define QCA8K_NUM_CPU_PORTS 2
Signature · 1 line
2.36.1
Jakub Kicinski
maintainerQuoted 8 lines · On Tue, 21 Jun 2022 17:16:33 +0200 Christian Marangi wrote:
The current mgmt ethernet timeout is set to 100ms. This value is too big and would slow down any mdio command in case the mgmt ethernet packet have some problems on the receiving part.
Reduce it to just 5ms to handle case when some operation are done on the master port that would cause the mgmt ethernet to not work temporarily.Fixes 5950c7c0a68c ("net: dsa: qca8k: add support for mgmt read/write in Ethernet packet")Signed-off-by Christian Marangi <[email protected]>
If it's a fix it should go to net as well. But no need to repost, we'll just apply it there since the fix is simple.
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Tue, 21 Jun 2022 17:16:33 +0200 you wrote:
The current mgmt ethernet timeout is set to 100ms. This value is too big and would slow down any mdio command in case the mgmt ethernet packet have some problems on the receiving part.
Reduce it to just 5ms to handle case when some operation are done on the master port that would cause the mgmt ethernet to not work temporarily.Fixes 5950c7c0a68c ("net: dsa: qca8k: add support for mgmt read/write in Ethernet packet")Signed-off-by Christian Marangi <[email protected]>[...]
Here is the summary with links:
- [net-next,v2] net: dsa: qca8k: reduce mgmt ethernet timeout
https://git.kernel.org/netdev/net/c/85467f7da189
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html