drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static
Subsystems (3)
PATCH 1/1 drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static
sparse reportsdrivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its storage class specifier to static.
--- drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +1 -1
@@ -36,7 +36,7 @@#define DCN_BASE__INST0_SEG2 0x000034C0 -enum dc_irq_source to_dal_irq_source_dcn32 ( +static enum dc_irq_source to_dal_irq_source_dcn32 (struct irq_service *irq_service,uint32_t src_id,uint32_t ext_id)
Signature · 1 line
2.27.0
Quoted 17 lines · Tom Rix
sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
to_dal_irq_source_dnc32()is only referenced inirq_service_dnc32.c, so change its storage class specifier to static.Fixes 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +0
-0
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c line 42
Quoted 8 lines
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +1
-1@@ -36,7 +36,7 @@#define DCN_BASE__INST0_SEG2 0x000034C0 -enum dc_irq_source to_dal_irq_source_dcn32 ( +static enum dc_irq_source to_dal_irq_source_dcn32 (struct irq_service *irq_service,uint32_t src_id,uint32_t ext_id)
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 31 lines · Aurabindo Pillai
Quoted 17 lines · Tom Rix
sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
to_dal_irq_source_dnc32()is only referenced inirq_service_dnc32.c, so change its storage class specifier to static.Fixes 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +0
-0drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c line 42
Quoted 8 lines
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +1
-1@@ -36,7 +36,7 @@#define DCN_BASE__INST0_SEG2 0x000034C0 -enum dc_irq_source to_dal_irq_source_dcn32 ( +static enum dc_irq_source to_dal_irq_source_dcn32 (struct irq_service *irq_service,uint32_t src_id,uint32_t ext_id)Reviewed-by Aurabindo Pillai <[email protected]>