Skip to contentSkip to conversation

drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static

PATCH Applied Tom Rix 3 participants 3 messages Jun 26, 2022 – Jun 27, 2022

Subsystems (3)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static

sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?

to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its storage class specifier to static.

Fixes 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
---
 drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +1 -1
index 3a213ca2f077..b1012fa1977b 100644
@@ -36,7 +36,7 @@
 
 #define DCN_BASE__INST0_SEG2                       0x000034C0
 
-enum dc_irq_source to_dal_irq_source_dcn32(
+static enum dc_irq_source to_dal_irq_source_dcn32(
 		struct irq_service *irq_service,
 		uint32_t src_id,
 		uint32_t ext_id)
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Tom Rix

sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?

to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its storage class specifier to static.

Fixes 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
---
  drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +0 -0
index 3a213ca2f077..b1012fa1977b 100644

drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c line 42

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +1 -1
@@ -36,7 +36,7 @@
 
  #define DCN_BASE__INST0_SEG2                       0x000034C0
 
-enum dc_irq_source to_dal_irq_source_dcn32(
+static enum dc_irq_source to_dal_irq_source_dcn32(
  		struct irq_service *irq_service,
  		uint32_t src_id,
  		uint32_t ext_id)
Applied
#2 lore raw

Applied. Thanks!

Alex

Quoted 31 lines · Aurabindo Pillai
Quoted 17 lines · Tom Rix

sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?

to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its storage class specifier to static.

Fixes 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
---
  drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +0 -0
index 3a213ca2f077..b1012fa1977b 100644

drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c line 42

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c +1 -1
@@ -36,7 +36,7 @@
 
  #define DCN_BASE__INST0_SEG2                       0x000034C0
 
-enum dc_irq_source to_dal_irq_source_dcn32(
+static enum dc_irq_source to_dal_irq_source_dcn32(
              struct irq_service *irq_service,
              uint32_t src_id,
              uint32_t ext_id)