Skip to contentSkip to conversation

dt-bindings: mmc: sdhci-msm: document resets

PATCH Applied Robert Marko 5 participants 7 messages Jul 4, 2022 – Jul 12, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: mmc: sdhci-msm: document resets

Commit "mmc: sdhci-msm: Reset GCC_SDCC_BCR register for SDHC" added support for utilizing a hardware reset and parsing it from DT, however the bindings were not updated along with it.

So, document the usage of "resets" property with the limit of only one item.

---
 Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml +3 -0
index 31a3ce208e1a..ca8814a80443 100644
@@ -116,6 +116,9 @@ properties:
     description:
       Should specify pin control groups used for this controller.
 
+  resets:
+    maxItems: 1
+
   qcom,ddr-config:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: platform specific settings for DDR_CONFIG reg.
Signature · 1 line
2.36.1
#1 lore raw

PATCH v2 2/2 arm64: dts: ipq8074: add reset to SDHCI

Add reset to SDHCI controller so it can be reset to avoid timeout issues after software reset due to bootloader set configuration.

---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/ipq8074.dtsi +1 -0
index ddafc7de6c5f..d685ca1969a3 100644
@@ -482,6 +482,7 @@ sdhc_1: mmc@7824900 {
 				 <&gcc GCC_SDCC1_APPS_CLK>,
 				 <&xo>;
 			clock-names = "iface", "core", "xo";
+			resets = <&gcc GCC_SDCC1_BCR>;
 			max-frequency = <384000000>;
 			mmc-ddr-1_8v;
 			mmc-hs200-1_8v;
Signature · 1 line
2.36.1
#4 lore raw

Re: (subset) [PATCH v2 2/2] arm64: dts: ipq8074: add reset to SDHCI

In reply to Robert Marko
Quoted 4 lines · Robert Marko

Add reset to SDHCI controller so it can be reset to avoid timeout issues after software reset due to bootloader set configuration.

Applied, thanks!

[2/2] arm64: dts: ipq8074: add reset to SDHCI

      commit: 730d55d861c63647df3cc9f77904a01c6719201b

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>
Acked-by on v2 1/2
#5 lore raw
In reply to Robert Marko
Quoted 8 lines · Robert Marko

Commit "mmc: sdhci-msm: Reset GCC_SDCC_BCR register for SDHC" added support for utilizing a hardware reset and parsing it from DT, however the bindings were not updated along with it.

So, document the usage of "resets" property with the limit of only one item.

Best regards,
Krzysztof

#6 lore raw
In reply to Robert Marko
Quoted 9 lines · Robert Marko

Commit "mmc: sdhci-msm: Reset GCC_SDCC_BCR register for SDHC" added support for utilizing a hardware reset and parsing it from DT, however the bindings were not updated along with it.

So, document the usage of "resets" property with the limit of only one item.

Applied for next, thanks!

Kind regards
Uffe

Quoted 21 lines
---
 Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml +3 -1
index 31a3ce208e1a..ca8814a80443 100644
@@ -116,6 +116,9 @@ properties:
     description:
       Should specify pin control groups used for this controller.
 
+  resets:
+    maxItems: 1
+
   qcom,ddr-config:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: platform specific settings for DDR_CONFIG reg.
--

2.36.1