drm/syncobj: Fix sync syncobj issue
Subsystems (2)
PATCH v2 1/1 drm/syncobj: Fix sync syncobj issue
enable signaling after flatten dma_fence_chains on transfer
--- drivers/gpu/drm/drm_syncobj.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_syncobj.c +1 -0
@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,if (ret) goto err_free_fence; +dma_fence_enable_sw_signaling (fence); chain =dma_fence_chain_alloc ();if (!chain) { ret = -ENOMEM ;
Signature · 1 line
2.25.1
Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.
IIRC you stumbled over that problem as well, have you found any solution?
Regards,
Christian.
Am 07.07.22 um 12:29 schrieb jie1zhan:
Quoted 19 lines
enable signaling after flatten
dma_fence_chainson transferSigned-off-by jie1zhan <[email protected]>--- drivers/gpu/drm/drm_syncobj.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/drm_syncobj.c +1
-0@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,if (ret) goto err_free_fence; +dma_fence_enable_sw_signaling (fence); chain =dma_fence_chain_alloc ();if (!chain) { ret = -ENOMEM ;
I'll let Lucas comment. I've only looked a little at it.
From what I remember just enabling sw_signaling was enough to fix the issue.
-Lionel
Quoted 28 lines · Christian König
Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.
IIRC you stumbled over that problem as well, have you found any solution?
Regards,
Christian.Am 07.07.22 um 12:29 schrieb jie1zhan:
Quoted 19 lines
enable signaling after flatten
dma_fence_chainson transferSigned-off-by jie1zhan <[email protected]>---
drivers/gpu/drm/drm_syncobj.c| 1 +1 file changed, 1 insertion(+)drivers/gpu/drm/drm_syncobj.c +0
-0@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private, if (ret) goto err_free_fence; + dma_fence_enable_sw_signaling(fence); chain = dma_fence_chain_alloc(); if (!chain) {ret =
-ENOMEM;
Yeah, adding dma_fence_enable_sw_signaling() is the right thing to do.
The question is where to add that? Usually right before the fence is returned from the object or queried from userspace would probably be the right place.
Regards,
Christian.
Am 12.07.22 um 16:22 schrieb Lionel Landwerlin:
Quoted 35 lines
I'll let Lucas comment. I've only looked a little at it.
From what I remember just enablingsw_signalingwas enough to fix the issue.-Lionel
Quoted 28 lines · Christian König
Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.
IIRC you stumbled over that problem as well, have you found any solution?
Regards,
Christian.Am 07.07.22 um 12:29 schrieb jie1zhan:
Quoted 19 lines
enable signaling after flatten
dma_fence_chainson transferSigned-off-by jie1zhan <[email protected]>---
drivers/gpu/drm/drm_syncobj.c| 1 +1 file changed, 1 insertion(+)drivers/gpu/drm/drm_syncobj.c +0
-0@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private, if (ret) goto err_free_fence; + dma_fence_enable_sw_signaling(fence); chain = dma_fence_chain_alloc(); if (!chain) {ret =
-ENOMEM;
Hi Christian,
Quoted 3 lines · Christian König
Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.
IIRC you stumbled over that problem as well, have you found any solution?
I might be wrong but I think you are talking about igt@syncobj_timeline@transfer-timeline-point testcase which seems to be
green in CI now https://intel-gfx-ci.01.org/tree/drm-tip/igt@[email protected]
Lucas found out that the issues got fixed after ec8d985ff26f ("drm: use dma_fence_unwrap_merge() in drm_syncobj")
Regards,
Nirmoy
Quoted 25 lines
Regards,
Christian.Am 07.07.22 um 12:29 schrieb jie1zhan:
Quoted 19 lines
enable signaling after flatten
dma_fence_chainson transferSigned-off-by jie1zhan <[email protected]>---
drivers/gpu/drm/drm_syncobj.c| 1 +1 file changed, 1 insertion(+)drivers/gpu/drm/drm_syncobj.c +0
-0@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private, if (ret) goto err_free_fence; + dma_fence_enable_sw_signaling(fence); chain = dma_fence_chain_alloc(); if (!chain) {ret =
-ENOMEM;
Am 13.07.22 um 10:42 schrieb Das, Nirmoy:
Quoted 5 lines
Hi Christian,
Quoted 2 lines · Christian König
Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.
Quoted 7 lines
Quoted 1 line
IIRC you stumbled over that problem as well, have you found any solution?
I might be wrong but I think you are talking about igt@syncobj_timeline@transfer-timeline-point testcase which seems to be
Lucas found out that the issues got fixed after
ec8d985ff26f("drm: usedma_fence_unwrap_merge()indrm_syncobj")
Yeah, but that's just coincident. The original bug that we fail to enable signaling in the syncobj is still there.
No that this is any major problem, but it would still be nice to have that fixed.
Regards,
Christian.
Quoted 31 lines
Regards,
Nirmoy
Quoted 25 lines
Regards,
Christian.Am 07.07.22 um 12:29 schrieb jie1zhan:
Quoted 19 lines
enable signaling after flatten
dma_fence_chainson transferSigned-off-by jie1zhan <[email protected]>---
drivers/gpu/drm/drm_syncobj.c| 1 +1 file changed, 1 insertion(+)drivers/gpu/drm/drm_syncobj.c +0
-0@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private, if (ret) goto err_free_fence; + dma_fence_enable_sw_signaling(fence); chain = dma_fence_chain_alloc(); if (!chain) {ret =
-ENOMEM;