drm/syncobj: Fix sync syncobj issue
Subsystems (2)
PATCH 1/1 drm/syncobj: Fix sync syncobj issue
enable signaling after flatten dma_fence_chains on transfer
Signed-off-by jie1zhan <[email protected]>
Reviewed-by Christian König <[email protected]>
Reviewed-by Nirmoy Das <[email protected]>
--- drivers/gpu/drm/drm_syncobj.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_syncobj.c +1 -0
@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,if (ret) goto err_free_fence; +dma_fence_enable_sw_signaling (fence); chain =dma_fence_chain_alloc ();if (!chain) { ret = -ENOMEM ;
Signature · 1 line
2.25.1
Am 07.07.22 um 05:08 schrieb jie1zhan:
Quoted 7 lines
enable signaling after flatten
dma_fence_chainson transferSigned-off-by jie1zhan <[email protected]>Reviewed-by Christian König <[email protected]>Reviewed-by Nirmoy Das <[email protected]>
Well please drop those Reviewed-by lines immediately! Neither Nirmoy nor me gave you the permission to add an rb to this patch. It looks like you have a major misunderstanding when to add that.
drivers/gpu/drm/drm_syncobj.c static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private, · line 923
Quoted 13 lines
--- drivers/gpu/drm/drm_syncobj.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/drm_syncobj.c +1
-0@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,if (ret) goto err_free_fence; +dma_fence_enable_sw_signaling (fence);
That looks better, but ideally we would enable signaling when the fence is retrieved from the drm_syncobj and queried for it's signaled state.
Regards,
Christian.
Quoted 3 lines
drivers/gpu/drm/drm_syncobj.c +0
-0chain =dma_fence_chain_alloc ();if (!chain) { ret = -ENOMEM ;