Skip to contentSkip to conversation

drm/syncobj: Fix sync syncobj issue

PATCH Superseded jie1zhan 2 participants 2 messages Jul 7, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

jie1zhan

author
#0 lore raw

PATCH 1/1 drm/syncobj: Fix sync syncobj issue

enable signaling after flatten dma_fence_chains on transfer

---
 drivers/gpu/drm/drm_syncobj.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_syncobj.c +1 -0
index 7e48dcd1bee4..0d9d3577325f 100644
@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
 	if (ret)
 		goto err_free_fence;
 
+	dma_fence_enable_sw_signaling(fence);
 	chain = dma_fence_chain_alloc();
 	if (!chain) {
 		ret = -ENOMEM;
Signature · 1 line
2.25.1
#1 lore raw

Am 07.07.22 um 05:08 schrieb jie1zhan:

Quoted 7 lines

enable signaling after flatten dma_fence_chains on transfer

Well please drop those Reviewed-by lines immediately! Neither Nirmoy nor me gave you the permission to add an rb to this patch. It looks like you have a major misunderstanding when to add that.

drivers/gpu/drm/drm_syncobj.c static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private, · line 923

Quoted 13 lines
---
  drivers/gpu/drm/drm_syncobj.c | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_syncobj.c +1 -0
index 7e48dcd1bee4..0d9d3577325f 100644
@@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
  	if (ret)
  		goto err_free_fence;
 
+	dma_fence_enable_sw_signaling(fence);

That looks better, but ideally we would enable signaling when the fence is retrieved from the drm_syncobj and queried for it's signaled state.

Regards,
Christian.

Quoted 3 lines
drivers/gpu/drm/drm_syncobj.c +0 -0
  	chain = dma_fence_chain_alloc();
  	if (!chain) {
  		ret = -ENOMEM;