Skip to contentSkip to conversation

iio: adc: ad7949: Fix error message

PATCH In review Thorsten Scherer 3 participants 4 messages Jul 8, 2022 – Jul 16, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: ad7949: Fix error message

---
 drivers/iio/adc/ad7949.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7949.c +1 -1
index 44bb5fde83de..12fb5f9971db 100644
@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
 
 	ret = ad7949_spi_init(ad7949_adc);
 	if (ret) {
-		dev_err(dev, "enable to init this device: %d\n", ret);
+		dev_err(dev, "fail to init this device: %d\n", ret);
 		return ret;
 	}
 
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Thorsten Scherer
---
 drivers/iio/adc/ad7949.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7949.c +0 -0
index 44bb5fde83de..12fb5f9971db 100644

drivers/iio/adc/ad7949.c static int ad7949_spi_probe(struct spi_device *spi) · line 403

Quoted 5 lines
drivers/iio/adc/ad7949.c +1 -1
@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
 
 	ret = ad7949_spi_init(ad7949_adc);
 	if (ret) {
-		dev_err(dev, "enable to init this device: %d\n", ret);
+		dev_err(dev, "fail to init this device: %d\n", ret);

Maybe 'failed' or 'unable' instead of 'fail'?

otherwise:

Cheers,
Liam

Quoted 6 lines
drivers/iio/adc/ad7949.c +0 -0
 		return ret;
 	}
 
Signature · 1 line
2.30.2
#2 lore raw

Hi,

Quoted 12 lines · Liam Beguin
Quoted 11 lines · Thorsten Scherer
---
 drivers/iio/adc/ad7949.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7949.c +0 -0
index 44bb5fde83de..12fb5f9971db 100644
@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
 
Quoted 6 lines

drivers/iio/adc/ad7949.c static int ad7949_spi_probe(struct spi_device *spi) · line 403

Quoted 4 lines
drivers/iio/adc/ad7949.c +1 -1
 	ret = ad7949_spi_init(ad7949_adc);
 	if (ret) {
-		dev_err(dev, "enable to init this device: %d\n", ret);
+		dev_err(dev, "fail to init this device: %d\n", ret);

Maybe 'failed' or 'unable' instead of 'fail'?

I decided to be consistent with the wording of the other dev_err's. If anyone cares, I'll send a v2 adjusting the others as well.

Quoted 7 lines

otherwise:

Cheers,
Liam

Best regards
Thorsten

maintainer
#3 lore raw
Quoted 22 lines · On Sat, 9 Jul 2022 07:38:10 +0200 Thorsten Scherer <[email protected]>…

Hi,

Quoted 12 lines · Liam Beguin
Quoted 11 lines · Thorsten Scherer
---
 drivers/iio/adc/ad7949.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7949.c +0 -0
index 44bb5fde83de..12fb5f9971db 100644
@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
 
Quoted 6 lines

drivers/iio/adc/ad7949.c static int ad7949_spi_probe(struct spi_device *spi) · line 403

Quoted 4 lines
drivers/iio/adc/ad7949.c +1 -1
 	ret = ad7949_spi_init(ad7949_adc);
 	if (ret) {
-		dev_err(dev, "enable to init this device: %d\n", ret);
+		dev_err(dev, "fail to init this device: %d\n", ret);  

Maybe 'failed' or 'unable' instead of 'fail'?

Quoted 2 lines

I decided to be consistent with the wording of the other dev_err's. If anyone cares, I'll send a v2 adjusting the others as well.

I've taken the view that this is obviously an improvement so applied it to the togreg branch of iio.git (note given timing this will only be pushed out for now as testing, and later rebased on rc1).

If anyone wants to follow up with a grammar improvement patch, that's fine with me, but the meaning is clear enough either way in my view.

Jonathan

Quoted 11 lines
Quoted 8 lines

otherwise:

Cheers,
Liam

Best regards
Thorsten