iio: adc: ad7949: Fix error message
Subsystems (2)
PATCH 1/1 iio: adc: ad7949: Fix error message
--- drivers/iio/adc/ad7949.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7949.c +1 -1
@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi) ret =ad7949_spi_init (ad7949_adc);if (ret) { -dev_err (dev,"enable to init this device: %d\n" , ret); +dev_err (dev,"fail to init this device: %d\n" , ret);return ret; }
Signature · 1 line
2.30.2
Quoted 10 lines · Thorsten Scherer
Signed-off-by Thorsten Scherer <[email protected]>--- drivers/iio/adc/ad7949.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/ad7949.c +0
-0
drivers/iio/adc/ad7949.c static int ad7949_spi_probe(struct spi_device *spi) · line 403
Quoted 5 lines
drivers/iio/adc/ad7949.c +1
-1@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi) ret =ad7949_spi_init (ad7949_adc);if (ret) { -dev_err (dev,"enable to init this device: %d\n" , ret); +dev_err (dev,"fail to init this device: %d\n" , ret);
Maybe 'failed' or 'unable' instead of 'fail'?
otherwise:
Cheers,
Liam
Quoted 6 lines
drivers/iio/adc/ad7949.c +0
-0return ret; }Signature · 1 line
2.30.2
Hi,
Quoted 12 lines · Liam Beguin
Quoted 11 lines · Thorsten Scherer
Signed-off-by Thorsten Scherer <[email protected]>--- drivers/iio/adc/ad7949.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/ad7949.c +0
-0@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
Quoted 6 lines
drivers/iio/adc/ad7949.c static int ad7949_spi_probe(struct spi_device *spi) · line 403
Quoted 4 lines
drivers/iio/adc/ad7949.c +1
-1ret =ad7949_spi_init (ad7949_adc);if (ret) { -dev_err (dev,"enable to init this device: %d\n" , ret); +dev_err (dev,"fail to init this device: %d\n" , ret);Maybe 'failed' or 'unable' instead of 'fail'?
I decided to be consistent with the wording of the other dev_err's. If anyone cares, I'll send a v2 adjusting the others as well.
Quoted 7 lines
otherwise:
Reviewed-by Liam Beguin <[email protected]>Cheers,
Liam
Best regards
Thorsten
Jonathan Cameron
maintainerQuoted 22 lines · On Sat, 9 Jul 2022 07:38:10 +0200 Thorsten Scherer <[email protected]>…
Hi,
Quoted 12 lines · Liam Beguin
Quoted 11 lines · Thorsten Scherer
Signed-off-by Thorsten Scherer <[email protected]>--- drivers/iio/adc/ad7949.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/ad7949.c +0
-0@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)Quoted 6 lines
drivers/iio/adc/ad7949.c static int ad7949_spi_probe(struct spi_device *spi) · line 403
Quoted 4 lines
drivers/iio/adc/ad7949.c +1
-1ret =ad7949_spi_init (ad7949_adc);if (ret) { -dev_err (dev,"enable to init this device: %d\n" , ret); +dev_err (dev,"fail to init this device: %d\n" , ret);Maybe 'failed' or 'unable' instead of 'fail'?
Quoted 2 lines
I decided to be consistent with the wording of the other dev_err's. If anyone cares, I'll send a v2 adjusting the others as well.
I've taken the view that this is obviously an improvement so applied it to the togreg branch of iio.git (note given timing this will only be pushed out for now as testing, and later rebased on rc1).
If anyone wants to follow up with a grammar improvement patch, that's fine with me, but the meaning is clear enough either way in my view.
Jonathan
Quoted 11 lines
Quoted 8 lines
otherwise:
Reviewed-by Liam Beguin <[email protected]>Cheers,
LiamBest regards
Thorsten