dt-bindings: adc-joystick: add poll-interval
Subsystems (5)
v8 cover dt-bindings: adc-joystick: add poll-interval
From: Chris Morgan <[email protected]>
Add support to the existing adc-joystick driver to support polling rather than relying on triggered buffers. This is useful for devices that do not offer triggered buffers in hardware. Code adapted from changes made by Maya Matuszczyk <[email protected]>.
Changes from V7:
- Dropped acks from adc-joystick.c changes, as it has been altered somewhat since v7.
- Improved checking value of poll-interval to ensure explicit error handling in the event of malformed values.
- Adjusted logic to not check for storagebits if polling is in use, which allows adc-joystick to work in polling mode for devices that utilize a mux (such as the Odroid Go Super and the Anbernic RG353).
- Changed error message and channel size comparison logic slightly to ensure code can fit within 80 character column width.
Changes from V6:
- Reverted back to "poll-interval" after mailing list discussion.
- Referenced input.yaml for definition of poll-interval in adc-joystick documentation.
Changes from V5:
- Corrected an error found by yamllint in the documentation.
Changes from V4:
- Added unit property to devicetree attribute making it now "poll-interval-ms".
- Simplified logic for setting polled value and made variable names more clear.
Changes from V3:
- After lengthy discussion decided to support with existing attribute of "poll-interval". If present, the driver will use polling and if not present, it will use triggered buffers (as the driver does today).
- Corrected some lines to honor the 80 character line-limit.
- Check return value from polling method and return early if there is an error reading the data.
Changes from V2:
- Changed parameter from "adc-joystick,polled" to "adc-joystick,no-hardware-trigger" as it is more representative of what the driver and hardware are doing.
Changes from V1:
- Removed driver compatible string of "adc-joystick-polled".
- Added new optional boolean value of "adc-joystick,polled".
- Cleaned up if statements regarding polling behavior.
Chris Morgan (3):
dt-bindings: adc-joystick: add poll-interval
Input: adc-joystick - Add polled input device support
arm64: dts: rockchip: Update joystick to polled for OG2
.../bindings/input/adc-joystick.yaml | 5 ++ .../boot/dts/rockchip/rk3326-odroid-go2.dts | 1 + drivers/input/joystick/adc-joystick.c | 82 ++++++++++++++----- 3 files changed, 68 insertions(+), 20 deletions(-)
Signature · 1 line
2.25.1
PATCH v8 1/3 dt-bindings: adc-joystick: add poll-interval
From: Chris Morgan <[email protected]>
Add poll-interval support for the adc-joystick documentation. This is an optional value and if not provided the adc-joystick works as it does today (with buffers). If this value is provided, the adc-joystick driver is polled at the specified interval. The existing attribute of "poll-interval" was used instead of complying with property-units.yaml after discussion of the issue on the mailing list.
--- Documentation/devicetree/bindings/input/adc-joystick.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/input/adc-joystick.yaml +5 -0
@@ -14,6 +14,9 @@ description: > Bindings for joystick devices connected to ADC controllers supporting the Industrial I/O subsystem. +allOf: + - $ref: input.yaml# + properties: compatible: const: adc-joystick
@@ -28,6 +31,8 @@ properties: https://github.com/devicetree-org/dt-schema/blob/master/schemas/iio/iio-consumer.yaml for details. + poll-interval: true + '#address-cells': const: 1
Signature · 1 line
2.25.1
PATCH v8 2/3 Input: adc-joystick - Add polled input device support
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk.
--- drivers/input/joystick/adc-joystick.c | 82 ++++++++++++++++++++------- 1 file changed, 62 insertions(+), 20 deletions(-)
drivers/input/joystick/adc-joystick.c +62 -20
@@ -26,8 +26,23 @@ struct adc_joystick {struct adc_joystick_axis *axes;struct iio_channel *chans;int num_chans; +bool polled; }; +static void adc_joystick_poll (struct input_dev *input) +{ +struct adc_joystick *joy =input_get_drvdata (input); +int i, val, ret; + +for (i =0 ; i < joy->num_chans; i++) { + ret =iio_read_channel_raw (&joy->chans[i], &val); +if (ret <0 ) +return ; +input_report_abs (input, joy->axes[i].code, val); + } +input_sync (input); +} +static int adc_joystick_handle (const void *data,void *private) {struct adc_joystick *joy = private;
@@ -178,7 +193,9 @@ static int adc_joystick_probe(struct platform_device *pdev)struct input_dev *input;int error;int bits; +int chan_storage;int i; +unsigned int poll_interval; joy =devm_kzalloc (dev,sizeof (*joy),GFP_KERNEL );if (!joy)
@@ -192,16 +209,31 @@ static int adc_joystick_probe(struct platform_device *pdev)return error; } -/* Count how many channels we got. NULL terminated. */ +if (device_property_present (dev,"poll-interval" )) { + error =device_property_read_u32 (dev,"poll-interval" , + &poll_interval); +if (error) +return error; + joy->polled = true; + } + +/* Count how many channels we got. NULL terminated. Do not check the +* storage size if using polling. +*/ + chan_storage = joy->chans[0 ].channel->scan_type.storagebits;for (i =0 ; joy->chans[i].indio_dev; i++) { - bits = joy->chans[i].channel->scan_type.storagebits; -if (!bits || bits >16 ) { -dev_err (dev,"Unsupported channel storage size\n" ); -return -EINVAL ; - } -if (bits != joy->chans[0 ].channel->scan_type.storagebits) { -dev_err (dev,"Channels must have equal storage size\n" ); -return -EINVAL ; +if (!joy->polled) { + bits = joy->chans[i].channel->scan_type.storagebits; +if (!bits || bits >16 ) { +dev_err (dev, +"Unsupported channel storage size\n" ); +return -EINVAL ; + } +if (bits != chan_storage) { +dev_err (dev, +"Channels must be equal size\n" ); +return -EINVAL ; + } } } joy->num_chans = i;
@@ -215,8 +247,14 @@ static int adc_joystick_probe(struct platform_device *pdev) joy->input = input; input->name = pdev->name; input->id.bustype =BUS_HOST ; - input->open = adc_joystick_open; - input->close = adc_joystick_close; + +if (joy->polled) { +input_setup_polling (input, adc_joystick_poll); +input_set_poll_interval (input, poll_interval); + }else { + input->open = adc_joystick_open; + input->close = adc_joystick_close; + } error =adc_joystick_set_axes (dev, joy);if (error)
@@ -229,16 +267,20 @@ static int adc_joystick_probe(struct platform_device *pdev)return error; } - joy->buffer =iio_channel_get_all_cb (dev, adc_joystick_handle, joy); -if (IS_ERR (joy->buffer)) { -dev_err (dev,"Unable to allocate callback buffer\n" ); -return PTR_ERR (joy->buffer); - } +if (!joy->polled) { + joy->buffer =iio_channel_get_all_cb (dev, adc_joystick_handle, + joy); +if (IS_ERR (joy->buffer)) { +dev_err (dev,"Unable to allocate callback buffer\n" ); +return PTR_ERR (joy->buffer); + } - error =devm_add_action_or_reset (dev, adc_joystick_cleanup, joy->buffer); -if (error) { -dev_err (dev,"Unable to add action\n" ); -return error; + error =devm_add_action_or_reset (dev, adc_joystick_cleanup, + joy->buffer); +if (error) { +dev_err (dev,"Unable to add action\n" ); +return error; + } }return 0 ;
Signature · 1 line
2.25.1
Re: [PATCH v8 2/3] Input: adc-joystick - Add polled input device support
Quoted 10 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from
adc-joystick.cchanges made by Maya Matuszczyk.Signed-off-by Maya Matuszczyk <[email protected]>Signed-off-by Chris Morgan <[email protected]>---
Hey Chris,
sorry for the late response. Comments in-line.
Cheers,
Artur
Quoted 50 lines
drivers/input/joystick/adc-joystick.c | 82 ++++++++++++++++++++------- 1 file changed, 62 insertions(+), 20 deletions(-)drivers/input/joystick/adc-joystick.c +17
-0@@ -26,8 +26,23 @@ struct adc_joystick {struct adc_joystick_axis *axes;struct iio_channel *chans;int num_chans; +bool polled; }; +static void adc_joystick_poll (struct input_dev *input) +{ +struct adc_joystick *joy =input_get_drvdata (input); +int i, val, ret; + +for (i =0 ; i < joy->num_chans; i++) { + ret =iio_read_channel_raw (&joy->chans[i], &val); +if (ret <0 ) +return ; +input_report_abs (input, joy->axes[i].code, val); + } +input_sync (input); +} +static int adc_joystick_handle (const void *data,void *private) {struct adc_joystick *joy = private;@@ -178,7 +193,9 @@ static int adc_joystick_probe(struct platform_device *pdev)struct input_dev *input;int error;int bits; +int chan_storage;int i; +unsigned int poll_interval; joy =devm_kzalloc (dev,sizeof (*joy),GFP_KERNEL );drivers/input/joystick/adc-joystick.c +1
-1if (!joy)@@ -192,16 +209,31 @@ static int adc_joystick_probe(struct platform_device *pdev)return error; } -/* Count how many channels we got. NULL terminated. */ +if (device_property_present (dev,"poll-interval" )) {
drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct · line 223
Quoted 10 lines
drivers/input/joystick/adc-joystick.c +10
-0+ error =device_property_read_u32 (dev,"poll-interval" , + &poll_interval); +if (error) +return error; + joy->polled = true; + } + +/* Count how many channels we got. NULL terminated. Do not check the +* storage size if using polling. +*/
As per Linux coding style, the multi-line comment opens with a lone /* line. Also, move the second sentence into a new line for readability.
Quoted 12 lines
drivers/input/joystick/adc-joystick.c +3
-8+ chan_storage = joy->chans[0 ].channel->scan_type.storagebits;for (i =0 ; joy->chans[i].indio_dev; i++) { - bits = joy->chans[i].channel->scan_type.storagebits; -if (!bits || bits >16 ) { -dev_err (dev,"Unsupported channel storage size\n" ); -return -EINVAL ; - } -if (bits != joy->chans[0 ].channel->scan_type.storagebits) { -dev_err (dev,"Channels must have equal storage size\n" ); -return -EINVAL ; +if (!joy->polled) { + bits = joy->chans[i].channel->scan_type.storagebits;
drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 236
Quoted 10 lines
drivers/input/joystick/adc-joystick.c +10
-0+if (!bits || bits >16 ) { +dev_err (dev, +"Unsupported channel storage size\n" ); +return -EINVAL ; + } +if (bits != chan_storage) { +dev_err (dev, +"Channels must be equal size\n" ); +return -EINVAL ; + }
Just do for (i = 0; !joy->polled && joy->chans[i].indio_dev; i++), as this will terminate early if we're polling.
Then we'll also be able to restore the loop body to its original code and get rid of that chan_storage helper.
Quoted 53 lines
drivers/input/joystick/adc-joystick.c +0
-0} }drivers/input/joystick/adc-joystick.c +8
-2joy->num_chans = i;@@ -215,8 +247,14 @@ static int adc_joystick_probe(struct platform_device *pdev) joy->input = input; input->name = pdev->name; input->id.bustype =BUS_HOST ; - input->open = adc_joystick_open; - input->close = adc_joystick_close; + +if (joy->polled) { +input_setup_polling (input, adc_joystick_poll); +input_set_poll_interval (input, poll_interval); + }else { + input->open = adc_joystick_open; + input->close = adc_joystick_close; + } error =adc_joystick_set_axes (dev, joy);drivers/input/joystick/adc-joystick.c +13
-9if (error)@@ -229,16 +267,20 @@ static int adc_joystick_probe(struct platform_device *pdev)return error; } - joy->buffer =iio_channel_get_all_cb (dev, adc_joystick_handle, joy); -if (IS_ERR (joy->buffer)) { -dev_err (dev,"Unable to allocate callback buffer\n" ); -return PTR_ERR (joy->buffer); - } +if (!joy->polled) { + joy->buffer =iio_channel_get_all_cb (dev, adc_joystick_handle, + joy); +if (IS_ERR (joy->buffer)) { +dev_err (dev,"Unable to allocate callback buffer\n" ); +return PTR_ERR (joy->buffer); + } - error =devm_add_action_or_reset (dev, adc_joystick_cleanup, joy->buffer); -if (error) { -dev_err (dev,"Unable to add action\n" ); -return error; + error =devm_add_action_or_reset (dev, adc_joystick_cleanup, + joy->buffer); +if (error) { +dev_err (dev,"Unable to add action\n" ); +return error; + } }return 0;
Re: [PATCH v8 2/3] Input: adc-joystick - Add polled input device support
Quoted 65 lines · Artur Rojek
Quoted 10 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from
adc-joystick.cchanges made by Maya Matuszczyk.Signed-off-by Maya Matuszczyk <[email protected]>Signed-off-by Chris Morgan <[email protected]>---
Hey Chris,
sorry for the late response. Comments in-line.
Cheers,
ArturQuoted 48 lines
drivers/input/joystick/adc-joystick.c | 82 ++++++++++++++++++++------- 1 file changed, 62 insertions(+), 20 deletions(-)drivers/input/joystick/adc-joystick.c +17
-0@@ -26,8 +26,23 @@ struct adc_joystick {struct adc_joystick_axis *axes;struct iio_channel *chans;int num_chans; +bool polled; }; +static void adc_joystick_poll (struct input_dev *input) +{ +struct adc_joystick *joy =input_get_drvdata (input); +int i, val, ret; + +for (i =0 ; i < joy->num_chans; i++) { + ret =iio_read_channel_raw (&joy->chans[i], &val); +if (ret <0 ) +return ; +input_report_abs (input, joy->axes[i].code, val); + } +input_sync (input); +} +static int adc_joystick_handle (const void *data,void *private) {struct adc_joystick *joy = private;@@ -178,7 +193,9 @@ static int adc_joystick_probe(struct platform_device *pdev)struct input_dev *input;int error;int bits; +int chan_storage;int i; +unsigned int poll_interval; joy =devm_kzalloc (dev,sizeof (*joy),GFP_KERNEL );drivers/input/joystick/adc-joystick.c +0
-0if (!joy)@@ -192,16 +209,31 @@ static int adc_joystick_probe(struct platform_device *pdev)return error; }
Quoted 14 lines
drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 222
Quoted 12 lines
drivers/input/joystick/adc-joystick.c +11
-1-/* Count how many channels we got. NULL terminated. */ +if (device_property_present (dev,"poll-interval" )) { + error =device_property_read_u32 (dev,"poll-interval" , + &poll_interval); +if (error) +return error; + joy->polled = true; + } + +/* Count how many channels we got. NULL terminated. Do not check the +* storage size if using polling. +*/ As per Linux coding style, the multi-line comment opens with a lone
/*line. Also, move the second sentence into a new line for readability.
Gotcha, I always thought it could start this way but had to end with an empty line. I guess I learned something new.
Quoted 19 lines
Quoted 19 lines
drivers/input/joystick/adc-joystick.c +9
-8+ chan_storage = joy->chans[0 ].channel->scan_type.storagebits;for (i =0 ; joy->chans[i].indio_dev; i++) { - bits = joy->chans[i].channel->scan_type.storagebits; -if (!bits || bits >16 ) { -dev_err (dev,"Unsupported channel storage size\n" ); -return -EINVAL ; - } -if (bits != joy->chans[0 ].channel->scan_type.storagebits) { -dev_err (dev,"Channels must have equal storage size\n" ); -return -EINVAL ; +if (!joy->polled) { + bits = joy->chans[i].channel->scan_type.storagebits; +if (!bits || bits >16 ) { +dev_err (dev, +"Unsupported channel storage size\n" ); +return -EINVAL ; + } +if (bits != chan_storage) {
Quoted 9 lines
drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 236
Quoted 4 lines
drivers/input/joystick/adc-joystick.c +4
-0+dev_err (dev, +"Channels must be equal size\n" ); +return -EINVAL ; + }Just do
for (i = 0; !joy->polled && joy->chans[i].indio_dev; i++), as this will terminate early if we're polling.
Then we'll also be able to restore the loop body to its original code and get rid of thatchan_storagehelper.
Thank you, I was struggling to figure out how to get the code to do what I wanted while keeping it below 80 columns, this is perfect.
Quoted 54 lines
Quoted 53 lines
drivers/input/joystick/adc-joystick.c +0
-0} }drivers/input/joystick/adc-joystick.c +8
-2joy->num_chans = i;@@ -215,8 +247,14 @@ static int adc_joystick_probe(struct platform_device *pdev) joy->input = input; input->name = pdev->name; input->id.bustype =BUS_HOST ; - input->open = adc_joystick_open; - input->close = adc_joystick_close; + +if (joy->polled) { +input_setup_polling (input, adc_joystick_poll); +input_set_poll_interval (input, poll_interval); + }else { + input->open = adc_joystick_open; + input->close = adc_joystick_close; + } error =adc_joystick_set_axes (dev, joy);drivers/input/joystick/adc-joystick.c +13
-9if (error)@@ -229,16 +267,20 @@ static int adc_joystick_probe(struct platform_device *pdev)return error; } - joy->buffer =iio_channel_get_all_cb (dev, adc_joystick_handle, joy); -if (IS_ERR (joy->buffer)) { -dev_err (dev,"Unable to allocate callback buffer\n" ); -return PTR_ERR (joy->buffer); - } +if (!joy->polled) { + joy->buffer =iio_channel_get_all_cb (dev, adc_joystick_handle, + joy); +if (IS_ERR (joy->buffer)) { +dev_err (dev,"Unable to allocate callback buffer\n" ); +return PTR_ERR (joy->buffer); + } - error =devm_add_action_or_reset (dev, adc_joystick_cleanup, joy->buffer); -if (error) { -dev_err (dev,"Unable to add action\n" ); -return error; + error =devm_add_action_or_reset (dev, adc_joystick_cleanup, + joy->buffer); +if (error) { +dev_err (dev,"Unable to add action\n" ); +return error; + } }return 0;
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH v8 2/3] Input: adc-joystick - Add polled input device support
Quoted 113 lines · Chris Morgan
Quoted 65 lines · Artur Rojek
Quoted 10 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from
adc-joystick.cchanges made by Maya Matuszczyk.Signed-off-by Maya Matuszczyk <[email protected]>Signed-off-by Chris Morgan <[email protected]>---
Hey Chris,
sorry for the late response. Comments in-line.
Cheers,
ArturQuoted 48 lines
drivers/input/joystick/adc-joystick.c | 82 ++++++++++++++++++++------- 1 file changed, 62 insertions(+), 20 deletions(-)drivers/input/joystick/adc-joystick.c +17
-0@@ -26,8 +26,23 @@ struct adc_joystick {struct adc_joystick_axis *axes;struct iio_channel *chans;int num_chans; +bool polled; }; +static void adc_joystick_poll (struct input_dev *input) +{ +struct adc_joystick *joy =input_get_drvdata (input); +int i, val, ret; + +for (i =0 ; i < joy->num_chans; i++) { + ret =iio_read_channel_raw (&joy->chans[i], &val); +if (ret <0 ) +return ; +input_report_abs (input, joy->axes[i].code, val); + } +input_sync (input); +} +static int adc_joystick_handle (const void *data,void *private) {struct adc_joystick *joy = private;@@ -178,7 +193,9 @@ static int adc_joystick_probe(struct platform_device *pdev)struct input_dev *input;int error;int bits; +int chan_storage;int i; +unsigned int poll_interval; joy =devm_kzalloc (dev,sizeof (*joy),GFP_KERNEL );drivers/input/joystick/adc-joystick.c +0
-0if (!joy)@@ -192,16 +209,31 @@ static int adc_joystick_probe(struct platform_device *pdev)return error; }Quoted 14 lines
drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 222
Quoted 12 lines
drivers/input/joystick/adc-joystick.c +11
-1-/* Count how many channels we got. NULL terminated. */ +if (device_property_present (dev,"poll-interval" )) { + error =device_property_read_u32 (dev,"poll-interval" , + &poll_interval); +if (error) +return error; + joy->polled = true; + } + +/* Count how many channels we got. NULL terminated. Do not check the +* storage size if using polling. +*/ As per Linux coding style, the multi-line comment opens with a lone
/*line. Also, move the second sentence into a new line for readability.Gotcha, I always thought it could start this way but had to end with an empty line. I guess I learned something new.
Quoted 19 lines
Quoted 19 lines
drivers/input/joystick/adc-joystick.c +9
-8+ chan_storage = joy->chans[0 ].channel->scan_type.storagebits;for (i =0 ; joy->chans[i].indio_dev; i++) { - bits = joy->chans[i].channel->scan_type.storagebits; -if (!bits || bits >16 ) { -dev_err (dev,"Unsupported channel storage size\n" ); -return -EINVAL ; - } -if (bits != joy->chans[0 ].channel->scan_type.storagebits) { -dev_err (dev,"Channels must have equal storage size\n" ); -return -EINVAL ; +if (!joy->polled) { + bits = joy->chans[i].channel->scan_type.storagebits; +if (!bits || bits >16 ) { +dev_err (dev, +"Unsupported channel storage size\n" ); +return -EINVAL ; + } +if (bits != chan_storage) {Quoted 9 lines
drivers/input/joystick/adc-joystick.c static int adc_joystick_probe(struct platform_device *pdev) · line 236
Quoted 4 lines
drivers/input/joystick/adc-joystick.c +4
-0+dev_err (dev, +"Channels must be equal size\n" ); +return -EINVAL ; + }Just do
for (i = 0; !joy->polled && joy->chans[i].indio_dev; i++), as this will terminate early if we're polling.
Then we'll also be able to restore the loop body to its original code and get rid of thatchan_storagehelper.
Quoted 2 lines
Thank you, I was struggling to figure out how to get the code to do what I wanted while keeping it below 80 columns, this is perfect.
The suggested code doesn't work (because it doesn't count the channels, however it gave me an idea to include a check in each of the if conditions below it to look for joy->polled, and I think that works. I'll send v9 shortly. Thank you for all your help.
Quoted 55 lines
Quoted 55 lines
Quoted 54 lines
drivers/input/joystick/adc-joystick.c +0
-0} }drivers/input/joystick/adc-joystick.c +8
-2joy->num_chans = i;@@ -215,8 +247,14 @@ static int adc_joystick_probe(struct platform_device *pdev) joy->input = input; input->name = pdev->name; input->id.bustype =BUS_HOST ; - input->open = adc_joystick_open; - input->close = adc_joystick_close; + +if (joy->polled) { +input_setup_polling (input, adc_joystick_poll); +input_set_poll_interval (input, poll_interval); + }else { + input->open = adc_joystick_open; + input->close = adc_joystick_close; + } error =adc_joystick_set_axes (dev, joy);drivers/input/joystick/adc-joystick.c +13
-9if (error)@@ -229,16 +267,20 @@ static int adc_joystick_probe(struct platform_device *pdev)return error; } - joy->buffer =iio_channel_get_all_cb (dev, adc_joystick_handle, joy); -if (IS_ERR (joy->buffer)) { -dev_err (dev,"Unable to allocate callback buffer\n" ); -return PTR_ERR (joy->buffer); - } +if (!joy->polled) { + joy->buffer =iio_channel_get_all_cb (dev, adc_joystick_handle, + joy); +if (IS_ERR (joy->buffer)) { +dev_err (dev,"Unable to allocate callback buffer\n" ); +return PTR_ERR (joy->buffer); + } - error =devm_add_action_or_reset (dev, adc_joystick_cleanup, joy->buffer); -if (error) { -dev_err (dev,"Unable to add action\n" ); -return error; + error =devm_add_action_or_reset (dev, adc_joystick_cleanup, + joy->buffer); +if (error) { +dev_err (dev,"Unable to add action\n" ); +return error; + } }return 0;
PATCH v8 3/3 arm64: dts: rockchip: Update joystick to polled for OG2
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Update the Odroid Go Advance to use "poll-interval" from the adc-joystick driver.
--- arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +1 -0
@@ -26,6 +26,7 @@ adc-joystick { compatible = "adc-joystick"; io-channels = <&saradc 1>, <&saradc 2>; + poll-interval = <60>; #address-cells = <1>; #size-cells = <0>;
Signature · 1 line
2.25.1