Skip to contentSkip to conversation

dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties'

PATCH Applied Rob Herring 4 participants 5 messages Jul 6, 2022 – Jul 22, 2022

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties'

Fixed string node names should be under 'properties' rather than 'patternProperties'. Additionally, without beginning and end of line anchors, any prefix or suffix is allowed on the specified node name.

Move the stm32 timers 'counter' and 'timer' nodes to the 'properties' section.

---
 .../bindings/mfd/st,stm32-lptimer.yaml        | 28 +++++++++----------
 .../bindings/mfd/st,stm32-timers.yaml         | 20 ++++++-------
 2 files changed, 24 insertions(+), 24 deletions(-)
Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml +14 -14
index ec7f0190f46e..a58f08aa430d 100644
@@ -58,43 +58,43 @@ properties:
       - "#pwm-cells"
       - compatible
 
-patternProperties:
-  "^trigger@[0-9]+$":
+  counter:
     type: object
 
     properties:
       compatible:
-        const: st,stm32-lptimer-trigger
-
-      reg:
-        description: Identify trigger hardware block.
-        items:
-          minimum: 0
-          maximum: 2
+        const: st,stm32-lptimer-counter
 
     required:
       - compatible
-      - reg
 
-  counter:
+  timer:
     type: object
 
     properties:
       compatible:
-        const: st,stm32-lptimer-counter
+        const: st,stm32-lptimer-timer
 
     required:
       - compatible
 
-  timer:
+patternProperties:
+  "^trigger@[0-9]+$":
     type: object
 
     properties:
       compatible:
-        const: st,stm32-lptimer-timer
+        const: st,stm32-lptimer-trigger
+
+      reg:
+        description: Identify trigger hardware block.
+        items:
+          minimum: 0
+          maximum: 2
 
     required:
       - compatible
+      - reg
 
 required:
   - "#address-cells"
Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml +10 -10
index 10b330d42901..1bd663f886dc 100644
@@ -87,6 +87,16 @@ properties:
       - "#pwm-cells"
       - compatible
 
+  counter:
+    type: object
+
+    properties:
+      compatible:
+        const: st,stm32-timer-counter
+
+    required:
+      - compatible
+
 patternProperties:
   "^timer@[0-9]+$":
     type: object
@@ -107,16 +117,6 @@ patternProperties:
       - compatible
       - reg
 
-  counter:
-    type: object
-
-    properties:
-      compatible:
-        const: st,stm32-timer-counter
-
-    required:
-      - compatible
-
 required:
   - compatible
   - reg
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Rob Herring

Fixed string node names should be under 'properties' rather than 'patternProperties'. Additionally, without beginning and end of line anchors, any prefix or suffix is allowed on the specified node name.

Move the stm32 timers 'counter' and 'timer' nodes to the 'properties' section.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

Fixed string node names should be under 'properties' rather than 'patternProperties'. Additionally, without beginning and end of line anchors, any prefix or suffix is allowed on the specified node name.

Move the stm32 timers 'counter' and 'timer' nodes to the 'properties' section.

Hi Rob,

You can add my:

Thanks and Best Regards,
Fabrice

Quoted 105 lines
---
 .../bindings/mfd/st,stm32-lptimer.yaml        | 28 +++++++++----------
 .../bindings/mfd/st,stm32-timers.yaml         | 20 ++++++-------
 2 files changed, 24 insertions(+), 24 deletions(-)
Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml +14 -14
index ec7f0190f46e..a58f08aa430d 100644
@@ -58,43 +58,43 @@ properties:
       - "#pwm-cells"
       - compatible
 
-patternProperties:
-  "^trigger@[0-9]+$":
+  counter:
     type: object
 
     properties:
       compatible:
-        const: st,stm32-lptimer-trigger
-
-      reg:
-        description: Identify trigger hardware block.
-        items:
-          minimum: 0
-          maximum: 2
+        const: st,stm32-lptimer-counter
 
     required:
       - compatible
-      - reg
 
-  counter:
+  timer:
     type: object
 
     properties:
       compatible:
-        const: st,stm32-lptimer-counter
+        const: st,stm32-lptimer-timer
 
     required:
       - compatible
 
-  timer:
+patternProperties:
+  "^trigger@[0-9]+$":
     type: object
 
     properties:
       compatible:
-        const: st,stm32-lptimer-timer
+        const: st,stm32-lptimer-trigger
+
+      reg:
+        description: Identify trigger hardware block.
+        items:
+          minimum: 0
+          maximum: 2
 
     required:
       - compatible
+      - reg
 
 required:
   - "#address-cells"
Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml +10 -10
index 10b330d42901..1bd663f886dc 100644
@@ -87,6 +87,16 @@ properties:
       - "#pwm-cells"
       - compatible
 
+  counter:
+    type: object
+
+    properties:
+      compatible:
+        const: st,stm32-timer-counter
+
+    required:
+      - compatible
+
 patternProperties:
   "^timer@[0-9]+$":
     type: object
@@ -107,16 +117,6 @@ patternProperties:
       - compatible
       - reg
 
-  counter:
-    type: object
-
-    properties:
-      compatible:
-        const: st,stm32-timer-counter
-
-    required:
-      - compatible
-
 required:
   - compatible
   - reg
author maintainer
#3 lore raw
In reply to Rob Herring
Quoted 4 lines · Rob Herring

Fixed string node names should be under 'properties' rather than 'patternProperties'. Additionally, without beginning and end of line anchors, any prefix or suffix is allowed on the specified node name.

Quoted 8 lines

Move the stm32 timers 'counter' and 'timer' nodes to the 'properties' section.

---
 .../bindings/mfd/st,stm32-lptimer.yaml        | 28 +++++++++----------
 .../bindings/mfd/st,stm32-timers.yaml         | 20 ++++++-------
 2 files changed, 24 insertions(+), 24 deletions(-)

Lee, going to pick this one up?

Rob

Applied
#4 lore raw
In reply to Rob Herring
Quoted 4 lines · Rob Herring

Fixed string node names should be under 'properties' rather than 'patternProperties'. Additionally, without beginning and end of line anchors, any prefix or suffix is allowed on the specified node name.

Quoted 8 lines

Move the stm32 timers 'counter' and 'timer' nodes to the 'properties' section.

---
 .../bindings/mfd/st,stm32-lptimer.yaml        | 28 +++++++++----------
 .../bindings/mfd/st,stm32-timers.yaml         | 20 ++++++-------
 2 files changed, 24 insertions(+), 24 deletions(-)

Applied, thanks.

Signature · 4 lines
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog