Skip to contentSkip to conversation

meta-security: Add recipe for libhoth

PATCH Superseded [email protected] 2 participants 4 messages Jul 21, 2022

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meta-security: Add recipe for libhoth

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
 meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +17 -0
new file mode 100644
index 0000000..59f52ad
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOME_PAGE = https://github.com/google/libhoth
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "b31307b7bf525efda0164e461fb1e0a5c302d306"
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson
+
Signature · 1 line
2.37.1.359.gd136c6c3e2-goog
#1 lore raw
Quoted 24 lines · jebr via lists.yoctoproject.org

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
 meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +6 -0
new file mode 100644
index 0000000..59f52ad
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOME_PAGE = https://github.com/google/libhoth
+
+LICENSE = "Apache-2.0"

meta-tpm/recipes-tpm/hoth/libhoth_git.bb line 16

Quoted 10 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +10 -0
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "b31307b7bf525efda0164e461fb1e0a5c302d306"
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson

Dont we want to package the examples too ? perhaps in a ${PN}-examples or something ?

Quoted 14 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +1 -1
+
--

2.37.1.359.gd136c6c3e2-goog

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
You automatically follow any topics you start or reply to. View/Reply Online (#57610): https://lists.yoctoproject.org/g/yocto/message/57610
Mute This Topic: https://lists.yoctoproject.org/mt/92537492/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

The examples are not separately buildable, and not installed. So there is currently no way to make a sperate ${PN}-examples.
We don't need the examples now, but we are interested to know what you think.

Thanks for the speedy review.
Joh Broadbent

Quoted 55 lines · Khem Raj
Quoted 24 lines · jebr via lists.yoctoproject.org

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
 meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +6 -0
new file mode 100644
index 0000000..59f52ad
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOME_PAGE = https://github.com/google/libhoth
+
+LICENSE = "Apache-2.0"

meta-tpm/recipes-tpm/hoth/libhoth_git.bb line 16

Quoted 10 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +10 -0
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "b31307b7bf525efda0164e461fb1e0a5c302d306"
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson

Dont we want to package the examples too ? perhaps in a ${PN}-examples or something ?

Quoted 14 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +1 -1
+
--

2.37.1.359.gd136c6c3e2-goog

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
You automatically follow any topics you start or reply to. View/Reply Online (#57610): https://lists.yoctoproject.org/g/yocto/message/57610
Mute This Topic: https://lists.yoctoproject.org/mt/92537492/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
Quoted 5 lines · John Broadbent

The examples are not separately buildable, and not installed. So there is currently no way to make a sperate ${PN}-examples.
We don't need the examples now, but we are interested to know what you think.

I see, that should be ok. I do see a few issues with the patch see below.

Quoted 20 lines

Thanks for the speedy review.
Joh Broadbent

Quoted 15 lines · Khem Raj
Quoted 12 lines · jebr via lists.yoctoproject.org

From: John Edward Broadbent <[email protected]>

Libhoth is usb protocol implementation which is required for hoth class devices

---
 meta-tpm/recipes-tpm/hoth/libhoth_git.bb | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 meta-tpm/recipes-tpm/hoth/libhoth_git.bb
Quoted 10 lines
Quoted 10 lines

meta-tpm/recipes-tpm/hoth/libhoth_git.bb line 4

Quoted 10 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +4 -0
new file mode 100644
index 0000000..59f52ad
@@ -0,0 +1,17 @@
+SUMMARY = "Google Hoth USB library"
+DESCRIPTION = "Libraries and example programs for interacting with a \
+               hoth-class root of trust."
+HOME_PAGE = https://github.com/google/libhoth

This should be

HOMEPAGE = "https://github.com/google/libhoth"

Quoted 6 lines
Quoted 6 lines

meta-tpm/recipes-tpm/hoth/libhoth_git.bb line 10

Quoted 6 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +6 -0
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = "git://github.com/google/libhoth;protocol=https;branch=main"
+SRCREV = "b31307b7bf525efda0164e461fb1e0a5c302d306"

This revision does not build with musl/clang atleast since there is a shadowing of a macro going on. You need to avoid that
I cooked a quick patch here

http://sprunge.us/LT8yuB

You might want to take a look.

Quoted 24 lines
Quoted 24 lines

meta-tpm/recipes-tpm/hoth/libhoth_git.bb line 16

Quoted 6 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +6 -0
+
+DEPENDS += "libusb1"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson

Dont we want to package the examples too ? perhaps in a ${PN}-examples or something ?

Quoted 14 lines
meta-tpm/recipes-tpm/hoth/libhoth_git.bb new file +1 -1
+
--

2.37.1.359.gd136c6c3e2-goog

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
You automatically follow any topics you start or reply to. View/Reply Online (#57610): https://lists.yoctoproject.org/g/yocto/message/57610
Mute This Topic: https://lists.yoctoproject.org/mt/92537492/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/yocto/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-