Skip to contentSkip to conversation

package/libdill: new package

PATCH Superseded Angelo Compagnucci 3 participants 5 messages Jul 28, 2022 – Jul 29, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/libdill: new package

Libdill is a C library that makes writing structured concurrent programs easy.

---
Changelog

v1->v2:
* Added comment to autoreconf (Romain)

 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libdill/Config.in    |  7 +++++++
 package/libdill/libdill.hash |  3 +++
 package/libdill/libdill.mk   | 26 ++++++++++++++++++++++++++
 5 files changed, 38 insertions(+)
 create mode 100644 package/libdill/Config.in
 create mode 100644 package/libdill/libdill.hash
 create mode 100644 package/libdill/libdill.mk
DEVELOPERS +1 -0
index cb98c3883d..f32eb6babf 100644
@@ -164,6 +164,7 @@ F:	package/i2c-tools/
 F:	package/jq/
 F:	package/libapparmor/
 F:	package/libb64/
+F:	package/libdill/
 F:	package/mender/
 F:	package/mender-artifact/
 F:	package/mono/
package/Config.in +1 -0
index 4ff1fb2f3c..fd0598c537 100644
@@ -1999,6 +1999,7 @@ menu "Other"
 	source "package/libcrossguid/Config.in"
 	source "package/libcsv/Config.in"
 	source "package/libdaemon/Config.in"
+	source "package/libdill/Config.in"
 	source "package/libeastl/Config.in"
 	source "package/libee/Config.in"
 	source "package/libev/Config.in"
package/libdill/Config.in new file +7 -0
new file mode 100644
index 0000000000..0e6757b809
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDILL
+	bool "libdill"
+	help
+	  Libdill is a C library that makes writing structured concurrent
+	  programs easy.
+
+	  http://libdill.org
package/libdill/libdill.hash new file +3 -0
new file mode 100644
index 0000000000..4a1fb91a57
@@ -0,0 +1,3 @@
+# sha256 locally computed
+sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
+sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
package/libdill/libdill.mk new file +26 -0
new file mode 100644
index 0000000000..822f07b939
@@ -0,0 +1,26 @@
+################################################################################
+#
+# libdill
+#
+################################################################################
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill
+LIBDILL_INSTALL_STAGING = YES
+# Fetched from Github, with no configure script
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls
+endif
+
+$(eval $(autotools-package))
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Angelo,

Quoted 4 lines · On Thu, 28 Jul 2022 23:12:59 +0200 Angelo Compagnucci…

Libdill is a C library that makes writing structured concurrent programs easy.

Looks good. A few comments/questions.

package/libdill/Config.in line 2

Quoted 8 lines
package/libdill/Config.in new file +2 -0
new file mode 100644
index 0000000000..0e6757b809
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDILL
+	bool "libdill"

No dependencies at all? Tested with test-pkg?

Quoted 8 lines
package/libdill/libdill.mk new file +2 -0
new file mode 100644
index 0000000000..822f07b939
@@ -0,0 +1,26 @@
+################################################################################
+#

package/libdill/libdill.mk line 12

Quoted 10 lines
package/libdill/libdill.mk new file +10 -0
+# libdill
+#
+################################################################################
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill

Could you add a link in the commit log that shows you have verified these?

package/libdill/libdill.mk line 17

Quoted 5 lines
package/libdill/libdill.mk new file +5 -0
+LIBDILL_INSTALL_STAGING = YES
+# Fetched from Github, with no configure script
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)

ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)

package/libdill/libdill.mk line 23

Quoted 6 lines
package/libdill/libdill.mk new file +6 -0
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls

No "else" clause to explicitly disable?

package/libdill/libdill.mk line 24

Quoted 1 line
package/libdill/libdill.mk new file +1 -0
+endif

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
Quoted 9 lines · Thomas Petazzoni via buildroot

Hello Angelo,

Quoted 4 lines · On Thu, 28 Jul 2022 23:12:59 +0200 Angelo Compagnucci…

Libdill is a C library that makes writing structured concurrent programs easy.

[snip]

Quoted 12 lines
Quoted 12 lines
package/libdill/libdill.mk new file +6 -0
new file mode 100644
index 0000000000..822f07b939
@@ -0,0 +1,26 @@
+################################################################################
+#
+# libdill
+#
+################################################################################
+
Quoted 8 lines

package/libdill/libdill.mk line 12

Quoted 6 lines
package/libdill/libdill.mk new file +6 -0
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill

Could you add a link in the commit log that shows you have verified these?

See for example how Fabrice does it:

cpe:2.3:a:osgeo:gdal is a valid CPE identifier for this package:

https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Aosgeo%3Agdal

(We should add this to the manual as well.)

Quoted 9 lines

package/libdill/libdill.mk line 17

Quoted 5 lines
package/libdill/libdill.mk new file +5 -0
+LIBDILL_INSTALL_STAGING = YES
+# Fetched from Github, with no configure script
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)

ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)

Quoted 1 line
package/libdill/libdill.mk new file +1 -0
+LIBDILL_CONF_OPTS += --disable-threads

What kind of concurrent programming can you do without threads?

Regards,
Arnout

Quoted 8 lines

package/libdill/libdill.mk line 23

Quoted 5 lines
package/libdill/libdill.mk new file +5 -0
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls

No "else" clause to explicitly disable?

Quoted 5 lines

package/libdill/libdill.mk line 24

Quoted 1 line
package/libdill/libdill.mk new file +1 -0
+endif

Thanks!

Thomas

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
Quoted 39 lines · Arnout Vandecappelle
Quoted 9 lines · Thomas Petazzoni via buildroot

Hello Angelo,

Quoted 4 lines · On Thu, 28 Jul 2022 23:12:59 +0200 Angelo Compagnucci…

Libdill is a C library that makes writing structured concurrent programs easy.

[snip]

Quoted 7 lines

package/libdill/libdill.mk

Quoted 7 lines
package/libdill/libdill.mk new file +0 -0
new file mode 100644
index 0000000000..822f07b939
@@ -0,0 +1,26 @@

+################################################################################

Quoted 4 lines

package/libdill/libdill.mk line 4

Quoted 4 lines
package/libdill/libdill.mk new file +3 -0
+#
+# libdill
+#

+################################################################################

Quoted 9 lines

package/libdill/libdill.mk line 12

Quoted 7 lines
package/libdill/libdill.mk new file +7 -0
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill

Could you add a link in the commit log that shows you have verified

these?

See for example how Fabrice does it:

Quoted 9 lines

cpe:2.3:a:osgeo:gdal is a valid CPE identifier for this package:

https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Aosgeo%3Agdal

(We should add this to the manual as well.)

Indeed. I did a research and I was unable to find a proper CPE id so I removed the CPE info from the package.

Quoted 9 lines
Quoted 9 lines

package/libdill/libdill.mk line 17

Quoted 6 lines
package/libdill/libdill.mk new file +5 -0
+LIBDILL_INSTALL_STAGING = YES
+# Fetched from Github, with no configure script
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)

ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)

Quoted 4 lines
Quoted 1 line

package/libdill/libdill.mk line 18

Quoted 1 line
package/libdill/libdill.mk new file +1 -0
+LIBDILL_CONF_OPTS += --disable-threads

What kind of concurrent programming can you do without threads?

Async coroutines with cooperative scheduling. Extremely fast indeed!

Quoted 18 lines

Regards,
Arnout

Quoted 13 lines

package/libdill/libdill.mk line 23

Quoted 5 lines
package/libdill/libdill.mk new file +5 -0
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls

No "else" clause to explicitly disable?

package/libdill/libdill.mk line 22

Quoted 1 line
package/libdill/libdill.mk new file +1 -0
+endif

Thanks!

Thomas

Signature · 15 lines
Angelo Compagnucci

Software Engineer

[email protected]
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
[email protected]

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
In reply to Thomas Petazzoni via buildroot
Quoted 13 lines · Thomas Petazzoni

Hello Angelo,

Quoted 4 lines · On Thu, 28 Jul 2022 23:12:59 +0200 Angelo Compagnucci…

Libdill is a C library that makes writing structured concurrent programs easy.

Looks good. A few comments/questions.

Quoted 11 lines

package/libdill/Config.in line 2

Quoted 8 lines
package/libdill/Config.in new file +2 -0
new file mode 100644
index 0000000000..0e6757b809
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDILL
+     bool "libdill"

No dependencies at all? Tested with test-pkg?

Yes. tested with

BR2_PACKAGE_OPENSSL=y
BR2_PACKAGE_LIBDILL=y

Quoted 14 lines

package/libdill/libdill.mk

Quoted 8 lines
package/libdill/libdill.mk new file +0 -0
new file mode 100644
index 0000000000..822f07b939
@@ -0,0 +1,26 @@

+################################################################################

package/libdill/libdill.mk line 4

Quoted 4 lines
package/libdill/libdill.mk new file +3 -0
+#
+# libdill
+#

+################################################################################

Quoted 10 lines

package/libdill/libdill.mk line 12

Quoted 7 lines
package/libdill/libdill.mk new file +7 -0
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill

Could you add a link in the commit log that shows you have verified these?

I removed those in V3 because I was unable to find proper CPE id.

Quoted 9 lines

package/libdill/libdill.mk line 17

Quoted 6 lines
package/libdill/libdill.mk new file +5 -0
+LIBDILL_INSTALL_STAGING = YES
+# Fetched from Github, with no configure script
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)

ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)

Quoted 9 lines

package/libdill/libdill.mk line 23

Quoted 6 lines
package/libdill/libdill.mk new file +6 -0
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls

No "else" clause to explicitly disable?

Done.

Quoted 10 lines

package/libdill/libdill.mk line 22

Quoted 1 line
package/libdill/libdill.mk new file +1 -0
+endif

Thanks!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com

Signature · 15 lines
Angelo Compagnucci

Software Engineer

[email protected]
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
[email protected]

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot