Skip to contentSkip to conversation

drm/msm: Move hangcheck timer restart

PATCH New Rob Clark 1 participant 2 messages Aug 7, 2022

Subsystems (4)
DRM drivers Arm Qualcomm mailing list DRM driver for Qualcomm display hardware DRM driver for Qualcomm Adreno GPUs
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH v2 1/2 drm/msm: Move hangcheck timer restart

From: Rob Clark <[email protected]>

Don't directly restart the hangcheck timer from the timer handler, but instead start it after the recover_worker replays remaining jobs.

If the kthread is blocked for other reasons, there is no point to immediately restart the timer. Fixes a random symptom of the problem fixed in the next patch.

v2: Keep the hangcheck timer restart in the timer handler in the case
where we aren't scheduling recover_worker

Signed-off-by Rob Clark <[email protected]>
---
 drivers/gpu/drm/msm/msm_gpu.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gpu.c +17 -2
index fba85f894314..6762001d9945 100644
@@ -328,6 +328,7 @@ find_submit(struct msm_ringbuffer *ring, uint32_t fence)
 }
 
 static void retire_submits(struct msm_gpu *gpu);
+static void hangcheck_timer_reset(struct msm_gpu *gpu);
 
 static void get_comm_cmdline(struct msm_gem_submit *submit, char **comm, char **cmd)
 {

@@ -420,6 +421,8 @@ static void recover_worker(struct kthread_work *work)
 	}
 
 	if (msm_gpu_active(gpu)) {
+		bool restart_hangcheck = false;
+
 		/* retire completed submits, plus the one that hung: */
 		retire_submits(gpu);
 

@@ -436,10 +439,15 @@ static void recover_worker(struct kthread_work *work)
 			unsigned long flags;
 
 			spin_lock_irqsave(&ring->submit_lock, flags);
-			list_for_each_entry(submit, &ring->submits, node)
+			list_for_each_entry(submit, &ring->submits, node) {
 				gpu->funcs->submit(gpu, submit);
+				restart_hangcheck = true;
+			}
 			spin_unlock_irqrestore(&ring->submit_lock, flags);
 		}
+
+		if (restart_hangcheck)
+			hangcheck_timer_reset(gpu);
 	}
 
 	mutex_unlock(&gpu->lock);

@@ -498,6 +506,7 @@ static void hangcheck_handler(struct timer_list *t)
 	struct drm_device *dev = gpu->dev;
 	struct msm_ringbuffer *ring = gpu->funcs->active_ring(gpu);
 	uint32_t fence = ring->memptrs->fence;
+	bool restart_hangcheck = true;
 
 	if (fence != ring->hangcheck_fence) {
 		/* some progress has been made.. ya! */

@@ -513,10 +522,16 @@ static void hangcheck_handler(struct timer_list *t)
 				gpu->name, ring->fctx->last_fence);
 
 		kthread_queue_work(gpu->worker, &gpu->recover_work);
+
+		/* If we do recovery, we want to defer restarting the hangcheck
+		 * timer until recovery completes and the remaining non-guilty
+		 * jobs are re-played.
+		 */
+		restart_hangcheck = false;
 	}
 
 	/* if still more pending work, reset the hangcheck timer: */
-	if (fence_after(ring->fctx->last_fence, ring->hangcheck_fence))
+	if (restart_hangcheck && fence_after(ring->fctx->last_fence, ring->hangcheck_fence))
 		hangcheck_timer_reset(gpu);
 
 	/* workaround for missing irq: */
Signature · 1 line
2.36.1
author
#1 lore raw

PATCH v2 2/2 drm/msm/rd: Fix FIFO-full deadlock

From: Rob Clark <[email protected]>

If the previous thing cat'ing $debugfs/rd left the FIFO full, then subsequent open could deadlock in rd_write() (because open is blocked, not giving a chance for read() to consume any data in the FIFO). Also it is generally a good idea to clear out old data from the FIFO.

Signed-off-by Rob Clark <[email protected]>
---
 drivers/gpu/drm/msm/msm_rd.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/msm/msm_rd.c +3 -0
index a92ffde53f0b..db2f847c8535 100644
@@ -196,6 +196,9 @@ static int rd_open(struct inode *inode, struct file *file)
 	file->private_data = rd;
 	rd->open = true;
 
+	/* Reset fifo to clear any previously unread data: */
+	rd->fifo.head = rd->fifo.tail = 0;
+
 	/* the parsing tools need to know gpu-id to know which
 	 * register database to load.
 	 *
Signature · 1 line
2.36.1