Skip to contentSkip to conversation

clk: mediatek: Add mt8365 support

PATCH Superseded Markus Schneider-Pargmann 2 participants 9 messages Aug 11, 2022

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover clk: mediatek: Add mt8365 support

Hi,

This series adds a clock driver for the mt8365 SoC. I took over the series from Fabien who posted v1 and v2.

Thanks you Angelo for the feedback on v2. I think I fixed everything you mentioned.

Changes are listed in the individual patches.

Best,
Markus

v2 - https://lore.kernel.org/linux-mediatek/[email protected]/

Fabien Parent (2):
dt-bindings: clock: mediatek: add bindings for MT8365 SoC
clk: mediatek: add driver for MT8365 SoC

Markus Schneider-Pargmann (2):
clk: mediatek: Provide mtk_devm_alloc_clk_data
clk: mediatek: Export required common code symbols

 .../bindings/clock/mediatek,mt8365-clock.yaml |   42 +
 .../clock/mediatek,mt8365-sys-clock.yaml      |   47 +
 drivers/clk/mediatek/Kconfig                  |   50 +
 drivers/clk/mediatek/Makefile                 |    7 +
 drivers/clk/mediatek/clk-gate.c               |    1 +
 drivers/clk/mediatek/clk-mt8365-apu.c         |   55 +
 drivers/clk/mediatek/clk-mt8365-cam.c         |   57 +
 drivers/clk/mediatek/clk-mt8365-mfg.c         |   63 +
 drivers/clk/mediatek/clk-mt8365-mm.c          |  112 ++
 drivers/clk/mediatek/clk-mt8365-vdec.c        |   63 +
 drivers/clk/mediatek/clk-mt8365-venc.c        |   52 +
 drivers/clk/mediatek/clk-mt8365.c             | 1155 +++++++++++++++++
 drivers/clk/mediatek/clk-mtk.c                |   37 +-
 drivers/clk/mediatek/clk-mtk.h                |    2 +
 .../dt-bindings/clock/mediatek,mt8365-clk.h   |  373 ++++++
 15 files changed, 2111 insertions(+), 5 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml
 create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml
 create mode 100644 drivers/clk/mediatek/clk-mt8365-apu.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-cam.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-mfg.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-mm.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-vdec.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-venc.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365.c
 create mode 100644 include/dt-bindings/clock/mediatek,mt8365-clk.h
Signature · 1 line
2.36.1
#1 lore raw

PATCH v3 1/4 dt-bindings: clock: mediatek: add bindings for MT8365 SoC

From: Fabien Parent <[email protected]>

Add the clock bindings for the MediaTek MT8365 SoC.

---
 .../bindings/clock/mediatek,mt8365-clock.yaml |  42 ++
 .../clock/mediatek,mt8365-sys-clock.yaml      |  47 +++
 .../dt-bindings/clock/mediatek,mt8365-clk.h   | 374 ++++++++++++++++++
 3 files changed, 463 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml
 create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml
 create mode 100644 include/dt-bindings/clock/mediatek,mt8365-clk.h
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +42 -0
new file mode 100644
index 000000000000..31cd248e772b
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/clock/mediatek,mt8365-clock.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: MediaTek Functional Clock Controller for MT8365
+
+maintainers:
+  - Fabien Parent <[email protected]>
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - mediatek,mt8365-apu
+          - mediatek,mt8365-imgsys
+          - mediatek,mt8365-mfgcfg
+          - mediatek,mt8365-vdecsys
+          - mediatek,mt8365-vencsys
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  '#clock-cells':
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    apu: clock-controller@19020000 {
+        compatible = "mediatek,mt8365-apu", "syscon";
+        reg = <0x19020000 0x1000>;
+        #clock-cells = <1>;
+    };
Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml new file +47 -0

47 lines not on this page · raw message

include/dt-bindings/clock/mediatek,mt8365-clk.h new file +374 -0

374 lines not on this page · raw message

Signature · 1 line
2.36.1
#2 lore raw

Re: [PATCH v3 1/4] dt-bindings: clock: mediatek: add bindings for MT8365 SoC

Quoted 22 lines · Markus Schneider-Pargmann

From: Fabien Parent <[email protected]>

Add the clock bindings for the MediaTek MT8365 SoC.

---
 .../bindings/clock/mediatek,mt8365-clock.yaml |  42 ++
 .../clock/mediatek,mt8365-sys-clock.yaml      |  47 +++
 .../dt-bindings/clock/mediatek,mt8365-clk.h   | 374 ++++++++++++++++++
 3 files changed, 463 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml
 create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml
 create mode 100644 include/dt-bindings/clock/mediatek,mt8365-clk.h
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +0 -0
new file mode 100644
index 000000000000..31cd248e772b

Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml line 5

Quoted 5 lines
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +5 -0
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/clock/mediatek,mt8365-clock.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"

No quotes needed in both lines.

Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml line 10

Quoted 5 lines
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +5 -0
+
+title: MediaTek Functional Clock Controller for MT8365
+
+maintainers:
+  - Fabien Parent <[email protected]>

Are you sure this is correct and working email? Let's try not to add non-existing emails to Git maintainers. It's a bit of pain to fix it later. :/

Quoted 38 lines
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +32 -0
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - mediatek,mt8365-apu
+          - mediatek,mt8365-imgsys
+          - mediatek,mt8365-mfgcfg
+          - mediatek,mt8365-vdecsys
+          - mediatek,mt8365-vencsys
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  '#clock-cells':
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    apu: clock-controller@19020000 {
+        compatible = "mediatek,mt8365-apu", "syscon";
+        reg = <0x19020000 0x1000>;
+        #clock-cells = <1>;
+    };
Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml new file +0 -0
new file mode 100644
index 000000000000..4292a2fd1489

Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml line 5

Quoted 5 lines
Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml new file +5 -0
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/clock/mediatek,mt8365-sys-clock.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"

No quotes.

Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml line 10

Quoted 5 lines
Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml new file +5 -0
+
+title: MediaTek System Clock Controller for MT8365
+
+maintainers:
+  - Fabien Parent <[email protected]>

Ekh...

Quoted 43 lines
Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml new file +37 -0
+
+description:
+  The apmixedsys module provides most of PLLs which generated from SoC 26m.
+  The topckgen provides dividers and muxes which provides the clock source to other IP blocks.
+  The infracfg_ao and pericfg_ao provides clock gate in peripheral and infrastructure IP blocks.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - mediatek,mt8365-topckgen
+          - mediatek,mt8365-infracfg
+          - mediatek,mt8365-apmixedsys
+          - mediatek,mt8365-pericfg
+          - mediatek,mt8365-mcucfg
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+  '#clock-cells':
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    topckgen: clock-controller@10000000 {
+        compatible = "mediatek,mt8365-topckgen", "syscon";
+        reg = <0x10000000 0x1000>;
+        #clock-cells = <1>;
+    };
include/dt-bindings/clock/mediatek,mt8365-clk.h new file +0 -0
new file mode 100644
index 000000000000..aa8a0366caae

include/dt-bindings/clock/mediatek,mt8365-clk.h line 1

Quoted 1 line
include/dt-bindings/clock/mediatek,mt8365-clk.h new file +1 -0
@@ -0,0 +1,374 @@
+/* SPDX-License-Identifier: GPL-2.0

Can you dual-license it?

include/dt-bindings/clock/mediatek,mt8365-clk.h line 3

Quoted 2 lines
include/dt-bindings/clock/mediatek,mt8365-clk.h new file +2 -0
+ *
+ * Copyright (c) 2022 MediaTek Inc.

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH v3 1/4] dt-bindings: clock: mediatek: add bindings for MT8365 SoC

Hi Krzysztof,

Quoted 31 lines · Krzysztof Kozlowski
Quoted 22 lines · Markus Schneider-Pargmann

From: Fabien Parent <[email protected]>

Add the clock bindings for the MediaTek MT8365 SoC.

---
 .../bindings/clock/mediatek,mt8365-clock.yaml |  42 ++
 .../clock/mediatek,mt8365-sys-clock.yaml      |  47 +++
 .../dt-bindings/clock/mediatek,mt8365-clk.h   | 374 ++++++++++++++++++
 3 files changed, 463 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml
 create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml
 create mode 100644 include/dt-bindings/clock/mediatek,mt8365-clk.h
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +0 -0
new file mode 100644
index 000000000000..31cd248e772b

Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml line 5

Quoted 5 lines
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +5 -0
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/clock/mediatek,mt8365-clock.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"

No quotes needed in both lines.

Quoted 9 lines

Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml line 10

Quoted 5 lines
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +5 -0
+
+title: MediaTek Functional Clock Controller for MT8365
+
+maintainers:
+  - Fabien Parent <[email protected]>

Are you sure this is correct and working email? Let's try not to add non-existing emails to Git maintainers. It's a bit of pain to fix it later. :/

thank you, good point. I will fix everything you mentioned here and above and below for v4.

Best,
Markus

#4 lore raw

PATCH v3 2/4 clk: mediatek: Provide mtk_devm_alloc_clk_data

In reply to Markus Schneider-Pargmann

Provide a helper that replaces the kzalloc with devm_kzalloc so error handling gets easier.

---

Notes:
Changes in v3:
- New patch

 drivers/clk/mediatek/clk-mtk.c | 33 ++++++++++++++++++++++++++++-----
 drivers/clk/mediatek/clk-mtk.h |  2 ++
 2 files changed, 30 insertions(+), 5 deletions(-)
drivers/clk/mediatek/clk-mtk.c +28 -5
index b9188000ab3c..a317e69cf298 100644
@@ -18,19 +18,42 @@
 #include "clk-mtk.h"
 #include "clk-gate.h"
 
-struct clk_hw_onecell_data *mtk_alloc_clk_data(unsigned int clk_num)
+static void mtk_init_clk_data(struct clk_hw_onecell_data *clk_data,
+			      unsigned int clk_num)
 {
 	int i;
+
+	clk_data->num = clk_num;
+
+	for (i = 0; i < clk_num; i++)
+		clk_data->hws[i] = ERR_PTR(-ENOENT);
+}
+
+struct clk_hw_onecell_data *mtk_devm_alloc_clk_data(struct device *dev,
+						    unsigned int clk_num)
+{
 	struct clk_hw_onecell_data *clk_data;
 
-	clk_data = kzalloc(struct_size(clk_data, hws, clk_num), GFP_KERNEL);
+	clk_data = devm_kzalloc(dev, struct_size(clk_data, hws, clk_num),
+				GFP_KERNEL);
 	if (!clk_data)
 		return NULL;
 
-	clk_data->num = clk_num;
+	mtk_init_clk_data(clk_data, clk_num);
 
-	for (i = 0; i < clk_num; i++)
-		clk_data->hws[i] = ERR_PTR(-ENOENT);
+	return clk_data;
+}
+EXPORT_SYMBOL_GPL(mtk_devm_alloc_clk_data);
+
+struct clk_hw_onecell_data *mtk_alloc_clk_data(unsigned int clk_num)
+{
+	struct clk_hw_onecell_data *clk_data;
+
+	clk_data = kzalloc(struct_size(clk_data, hws, clk_num), GFP_KERNEL);
+	if (!clk_data)
+		return NULL;
+
+	mtk_init_clk_data(clk_data, clk_num);
 
 	return clk_data;
 }
drivers/clk/mediatek/clk-mtk.h +2 -0
index adb1304d35d4..4390058d172c 100644
@@ -182,6 +182,8 @@ void mtk_clk_unregister_dividers(const struct mtk_clk_divider *mcds, int num,
 				 struct clk_hw_onecell_data *clk_data);
 
 struct clk_hw_onecell_data *mtk_alloc_clk_data(unsigned int clk_num);
+struct clk_hw_onecell_data *mtk_devm_alloc_clk_data(struct device *dev,
+						    unsigned int clk_num);
 void mtk_free_clk_data(struct clk_hw_onecell_data *clk_data);
 
 struct clk_hw *mtk_clk_register_ref2usb_tx(const char *name,
Signature · 1 line
2.36.1
#5 lore raw

PATCH v3 3/4 clk: mediatek: Export required common code symbols

In reply to Markus Schneider-Pargmann

To make clk-mt8365 compilable as a module there are a few function symbols missing. This patch adds the required EXPORT_SYMBOL_GPL to the functions.

---

Notes:
Changes in v3:
- New patch

 drivers/clk/mediatek/clk-gate.c | 1 +
 drivers/clk/mediatek/clk-mtk.c  | 4 ++++
 2 files changed, 5 insertions(+)
drivers/clk/mediatek/clk-gate.c +1 -0
index 421806236228..0c867136e49d 100644
@@ -261,6 +261,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
 
 	return PTR_ERR(hw);
 }
+EXPORT_SYMBOL_GPL(mtk_clk_register_gates_with_dev);
 
 int mtk_clk_register_gates(struct device_node *node,
 			   const struct mtk_gate *clks, int num,
drivers/clk/mediatek/clk-mtk.c +4 -0
index a317e69cf298..22519e7ea74f 100644
@@ -422,6 +422,7 @@ int mtk_clk_register_dividers(const struct mtk_clk_divider *mcds, int num,
 
 	return PTR_ERR(hw);
 }
+EXPORT_SYMBOL_GPL(mtk_clk_register_dividers);
 
 void mtk_clk_unregister_dividers(const struct mtk_clk_divider *mcds, int num,
 				 struct clk_hw_onecell_data *clk_data)
@@ -441,6 +442,7 @@ void mtk_clk_unregister_dividers(const struct mtk_clk_divider *mcds, int num,
 		clk_data->hws[mcd->id] = ERR_PTR(-ENOENT);
 	}
 }
+EXPORT_SYMBOL_GPL(mtk_clk_unregister_dividers);
 
 int mtk_clk_simple_probe(struct platform_device *pdev)
 {
@@ -475,6 +477,7 @@ int mtk_clk_simple_probe(struct platform_device *pdev)
 	mtk_free_clk_data(clk_data);
 	return r;
 }
+EXPORT_SYMBOL_GPL(mtk_clk_simple_probe);
 
 int mtk_clk_simple_remove(struct platform_device *pdev)
 {
@@ -488,5 +491,6 @@ int mtk_clk_simple_remove(struct platform_device *pdev)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(mtk_clk_simple_remove);
 
 MODULE_LICENSE("GPL");
Signature · 1 line
2.36.1
#6 lore raw

PATCH v3 4/4 clk: mediatek: add driver for MT8365 SoC

In reply to Markus Schneider-Pargmann

From: Fabien Parent <[email protected]>

Add clock drivers for MT8365 SoC.

---

Notes:
Changes in v3:
- Changed all Kconfig options to be tristate
- Do not depend on ARM64
- Fix order of frees on probe errors.
- Use mtk_clk_register_gates_with_dev
- Fixed null clocks
- Removed clk26m_ck
- Use MUX_GATE_CLR_SET_UPD instead of custom MT8365_MUX_CLR_SET_UPD
- Use devm_clk_hw_register_mux for top_misc_muxes
- Use devm_clk_hw_register_gate for peri_clks and top_clks
- Fix checkpatch warnings
- Add missing MODULE_LICENSEs in all files

 drivers/clk/mediatek/Kconfig                  |   50 +
 drivers/clk/mediatek/Makefile                 |    7 +
 drivers/clk/mediatek/clk-mt8365-apu.c         |   55 +
 drivers/clk/mediatek/clk-mt8365-cam.c         |   57 +
 drivers/clk/mediatek/clk-mt8365-mfg.c         |   63 +
 drivers/clk/mediatek/clk-mt8365-mm.c          |  112 ++
 drivers/clk/mediatek/clk-mt8365-vdec.c        |   63 +
 drivers/clk/mediatek/clk-mt8365-venc.c        |   52 +
 drivers/clk/mediatek/clk-mt8365.c             | 1155 +++++++++++++++++
 .../dt-bindings/clock/mediatek,mt8365-clk.h   |  179 ++-
 10 files changed, 1703 insertions(+), 90 deletions(-)
 create mode 100644 drivers/clk/mediatek/clk-mt8365-apu.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-cam.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-mfg.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-mm.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-vdec.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365-venc.c
 create mode 100644 drivers/clk/mediatek/clk-mt8365.c
drivers/clk/mediatek/Kconfig +50 -0
index d5936cfb3bee..5c817c94046d 100644
@@ -608,6 +608,56 @@ config COMMON_CLK_MT8195
         help
           This driver supports MediaTek MT8195 clocks.
 
+config COMMON_CLK_MT8365
+	tristate "Clock driver for MediaTek MT8365"
+	depends on ARCH_MEDIATEK || COMPILE_TEST
+	select COMMON_CLK_MEDIATEK
+	default ARCH_MEDIATEK && ARM64
+	help
+	  This driver supports MediaTek MT8365 basic clocks.
+
+config COMMON_CLK_MT8365_APU
+	tristate "Clock driver for MediaTek MT8365 apu"
+	depends on COMMON_CLK_MT8365
+	default COMMON_CLK_MT8365
+	help
+	  This driver supports MediaTek MT8365 apu clocks.
+
+config COMMON_CLK_MT8365_CAM
+	tristate "Clock driver for MediaTek MT8365 cam"
+	depends on COMMON_CLK_MT8365
+	default COMMON_CLK_MT8365
+	help
+	  This driver supports MediaTek MT8365 cam clocks.
+
+config COMMON_CLK_MT8365_MFG
+	tristate "Clock driver for MediaTek MT8365 mfg"
+	depends on COMMON_CLK_MT8365
+	default COMMON_CLK_MT8365
+	help
+	  This driver supports MediaTek MT8365 mfg clocks.
+
+config COMMON_CLK_MT8365_MMSYS
+	tristate "Clock driver for MediaTek MT8365 mmsys"
+	depends on COMMON_CLK_MT8365
+	default COMMON_CLK_MT8365
+	help
+	  This driver supports MediaTek MT8365 mmsys clocks.
+
+config COMMON_CLK_MT8365_VDEC
+	tristate "Clock driver for MediaTek MT8365 vdec"
+	depends on COMMON_CLK_MT8365
+	default COMMON_CLK_MT8365
+	help
+	  This driver supports MediaTek MT8365 vdec clocks.
+
+config COMMON_CLK_MT8365_VENC
+	tristate "Clock driver for MediaTek MT8365 venc"
+	depends on COMMON_CLK_MT8365
+	default COMMON_CLK_MT8365
+	help
+	  This driver supports MediaTek MT8365 venc clocks.
+
 config COMMON_CLK_MT8516
 	bool "Clock driver for MediaTek MT8516"
 	depends on ARCH_MEDIATEK || COMPILE_TEST
drivers/clk/mediatek/Makefile +7 -0
index caf2ce93d666..0321609b197f 100644
@@ -97,5 +97,12 @@ obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o
 				   clk-mt8195-venc.o clk-mt8195-vpp0.o clk-mt8195-vpp1.o \
 				   clk-mt8195-wpe.o clk-mt8195-imp_iic_wrap.o \
 				   clk-mt8195-apusys_pll.o
+obj-$(CONFIG_COMMON_CLK_MT8365) += clk-mt8365.o
+obj-$(CONFIG_COMMON_CLK_MT8365_APU) += clk-mt8365-apu.o
+obj-$(CONFIG_COMMON_CLK_MT8365_CAM) += clk-mt8365-cam.o
+obj-$(CONFIG_COMMON_CLK_MT8365_MFG) += clk-mt8365-mfg.o
+obj-$(CONFIG_COMMON_CLK_MT8365_MMSYS) += clk-mt8365-mm.o
+obj-$(CONFIG_COMMON_CLK_MT8365_VDEC) += clk-mt8365-vdec.o
+obj-$(CONFIG_COMMON_CLK_MT8365_VENC) += clk-mt8365-venc.o
 obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o
 obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o
drivers/clk/mediatek/clk-mt8365-apu.c new file +55 -0

55 lines not on this page · raw message

drivers/clk/mediatek/clk-mt8365-cam.c new file +57 -0

57 lines not on this page · raw message

drivers/clk/mediatek/clk-mt8365-mfg.c new file +63 -0

63 lines not on this page · raw message

drivers/clk/mediatek/clk-mt8365-mm.c new file +112 -0

112 lines not on this page · raw message

drivers/clk/mediatek/clk-mt8365-vdec.c new file +63 -0

63 lines not on this page · raw message

drivers/clk/mediatek/clk-mt8365-venc.c new file +52 -0

52 lines not on this page · raw message

drivers/clk/mediatek/clk-mt8365.c new file +1155 -0

1,155 lines not on this page · raw message

include/dt-bindings/clock/mediatek,mt8365-clk.h +89 -90

185 lines not on this page · raw message

Signature · 1 line
2.36.1
#7 lore raw

Re: [PATCH v3 4/4] clk: mediatek: add driver for MT8365 SoC

Quoted 22 lines · Markus Schneider-Pargmann

From: Fabien Parent <[email protected]>

Add clock drivers for MT8365 SoC.

---

Notes:
Changes in v3:
- Changed all Kconfig options to be tristate
- Do not depend on ARM64
- Fix order of frees on probe errors.
- Use mtk_clk_register_gates_with_dev
- Fixed null clocks
- Removed clk26m_ck
- Use MUX_GATE_CLR_SET_UPD instead of custom MT8365_MUX_CLR_SET_UPD
- Use devm_clk_hw_register_mux for top_misc_muxes
- Use devm_clk_hw_register_gate for peri_clks and top_clks
- Fix checkpatch warnings
- Add missing MODULE_LICENSEs in all files

Quoted 10 lines
 drivers/clk/mediatek/Kconfig                  |   50 +
 drivers/clk/mediatek/Makefile                 |    7 +
 drivers/clk/mediatek/clk-mt8365-apu.c         |   55 +
 drivers/clk/mediatek/clk-mt8365-cam.c         |   57 +
 drivers/clk/mediatek/clk-mt8365-mfg.c         |   63 +
 drivers/clk/mediatek/clk-mt8365-mm.c          |  112 ++
 drivers/clk/mediatek/clk-mt8365-vdec.c        |   63 +
 drivers/clk/mediatek/clk-mt8365-venc.c        |   52 +
 drivers/clk/mediatek/clk-mt8365.c             | 1155 +++++++++++++++++
 .../dt-bindings/clock/mediatek,mt8365-clk.h   |  179 ++-

No, bindings are always separate.

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH v3 4/4] clk: mediatek: add driver for MT8365 SoC

Hi Krzysztof,

Quoted 34 lines · Krzysztof Kozlowski
Quoted 22 lines · Markus Schneider-Pargmann

From: Fabien Parent <[email protected]>

Add clock drivers for MT8365 SoC.

---

Notes:
Changes in v3:
- Changed all Kconfig options to be tristate
- Do not depend on ARM64
- Fix order of frees on probe errors.
- Use mtk_clk_register_gates_with_dev
- Fixed null clocks
- Removed clk26m_ck
- Use MUX_GATE_CLR_SET_UPD instead of custom MT8365_MUX_CLR_SET_UPD
- Use devm_clk_hw_register_mux for top_misc_muxes
- Use devm_clk_hw_register_gate for peri_clks and top_clks
- Fix checkpatch warnings
- Add missing MODULE_LICENSEs in all files

Quoted 10 lines
 drivers/clk/mediatek/Kconfig                  |   50 +
 drivers/clk/mediatek/Makefile                 |    7 +
 drivers/clk/mediatek/clk-mt8365-apu.c         |   55 +
 drivers/clk/mediatek/clk-mt8365-cam.c         |   57 +
 drivers/clk/mediatek/clk-mt8365-mfg.c         |   63 +
 drivers/clk/mediatek/clk-mt8365-mm.c          |  112 ++
 drivers/clk/mediatek/clk-mt8365-vdec.c        |   63 +
 drivers/clk/mediatek/clk-mt8365-venc.c        |   52 +
 drivers/clk/mediatek/clk-mt8365.c             | 1155 +++++++++++++++++
 .../dt-bindings/clock/mediatek,mt8365-clk.h   |  179 ++-
Quoted 1 line

No, bindings are always separate.

Of course, I screwed up my rebasing here, sorry. Fixed for v4.

Best,
Markus