clk: mediatek: Add mt8365 support
Subsystems (3)
v4 cover clk: mediatek: Add mt8365 support
Hi,
This series adds a clock driver for the mt8365 SoC.
Thanks for the feedback so far.
Best,
Markus
Based on https://lore.kernel.org/linux-mediatek/[email protected]/
Changes in v4:
- Rebased onto v6.0-rc1
- Fixed some minor things documented in the patches.
Earlier versions:
v2 - https://lore.kernel.org/linux-mediatek/[email protected]/
v3 - https://lore.kernel.org/linux-mediatek/[email protected]/
Fabien Parent (2):
dt-bindings: clock: mediatek: add bindings for MT8365 SoC
clk: mediatek: add driver for MT8365 SoC
Markus Schneider-Pargmann (2):
clk: mediatek: Provide mtk_devm_alloc_clk_data
clk: mediatek: Export required common code symbols
.../bindings/clock/mediatek,mt8365-clock.yaml | 42 + .../clock/mediatek,mt8365-sys-clock.yaml | 47 + drivers/clk/mediatek/Kconfig | 50 + drivers/clk/mediatek/Makefile | 7 + drivers/clk/mediatek/clk-mt8365-apu.c | 55 + drivers/clk/mediatek/clk-mt8365-cam.c | 57 + drivers/clk/mediatek/clk-mt8365-mfg.c | 63 + drivers/clk/mediatek/clk-mt8365-mm.c | 112 ++ drivers/clk/mediatek/clk-mt8365-vdec.c | 63 + drivers/clk/mediatek/clk-mt8365-venc.c | 52 + drivers/clk/mediatek/clk-mt8365.c | 1155 +++++++++++++++++ drivers/clk/mediatek/clk-mtk.c | 37 +- drivers/clk/mediatek/clk-mtk.h | 2 + .../dt-bindings/clock/mediatek,mt8365-clk.h | 373 ++++++ 14 files changed, 2110 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml create mode 100644 drivers/clk/mediatek/clk-mt8365-apu.c create mode 100644 drivers/clk/mediatek/clk-mt8365-cam.c create mode 100644 drivers/clk/mediatek/clk-mt8365-mfg.c create mode 100644 drivers/clk/mediatek/clk-mt8365-mm.c create mode 100644 drivers/clk/mediatek/clk-mt8365-vdec.c create mode 100644 drivers/clk/mediatek/clk-mt8365-venc.c create mode 100644 drivers/clk/mediatek/clk-mt8365.c create mode 100644 include/dt-bindings/clock/mediatek,mt8365-clk.h
Signature · 1 line
2.37.2
PATCH v4 1/4 dt-bindings: clock: mediatek: add bindings for MT8365 SoC
From: Fabien Parent <[email protected]>
Add the clock bindings for the MediaTek MT8365 SoC.
---
Notes:
Changes in v4:
- Remove unnecessary quotes from $id and $schema
- Add myself as maintainer
- Dual-licensed mediatek,mt8365-clk.h
.../bindings/clock/mediatek,mt8365-clock.yaml | 42 ++ .../clock/mediatek,mt8365-sys-clock.yaml | 47 +++ .../dt-bindings/clock/mediatek,mt8365-clk.h | 373 ++++++++++++++++++ 3 files changed, 462 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml create mode 100644 include/dt-bindings/clock/mediatek,mt8365-clk.h
Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml new file +42 -0
@@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/mediatek,mt8365-clock.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek Functional Clock Controller for MT8365 + +maintainers: + - Markus Schneider-Pargmann <[email protected]> + +properties: + compatible: + items: + - enum: + - mediatek,mt8365-apu + - mediatek,mt8365-imgsys + - mediatek,mt8365-mfgcfg + - mediatek,mt8365-vdecsys + - mediatek,mt8365-vencsys + - const: syscon + + reg: + maxItems: 1 + + '#clock-cells': + const: 1 + +required: + - compatible + - reg + - '#clock-cells' + +additionalProperties: false + +examples: + - | + apu: clock-controller@19020000 { + compatible = "mediatek,mt8365-apu", "syscon"; + reg = <0x19020000 0x1000>; + #clock-cells = <1>; + };
Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml new file +47 -0
47 lines not on this page · raw message
include/dt-bindings/clock/mediatek,mt8365-clk.h new file +373 -0
373 lines not on this page · raw message
Signature · 1 line
2.37.2
Re: [PATCH v4 1/4] dt-bindings: clock: mediatek: add bindings for MT8365 SoC
Quoted 6 lines · Markus Schneider-Pargmann
From: Fabien Parent <[email protected]>
Add the clock bindings for the MediaTek MT8365 SoC.
Signed-off-by Fabien Parent <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>
Hm, when did I review it?
Quoted 8 lines
Signed-off-by Markus Schneider-Pargmann <[email protected]>---
Notes:
Changes in v4:
- Remove unnecessary quotes from $id and $schema
- Add myself as maintainer
- Dual-licensed mediatek,mt8365-clk.h
Best regards,
Krzysztof
Re: [PATCH v4 1/4] dt-bindings: clock: mediatek: add bindings for MT8365 SoC
Quoted 9 lines · Krzysztof Kozlowski
Quoted 6 lines · Markus Schneider-Pargmann
From: Fabien Parent <[email protected]>
Add the clock bindings for the MediaTek MT8365 SoC.
Signed-off-by Fabien Parent <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>Hm, when did I review it?
Ah, I reviewed v2 and still had comments in v3.
I see these fixed, so everything looks fine!
Best regards,
Krzysztof
Re: [PATCH v4 1/4] dt-bindings: clock: mediatek: add bindings for MT8365 SoC
In reply to Markus Schneider-PargmannQuoting Markus Schneider-Pargmann (2022-08-22 08:26:49)
Quoted 8 lines
From: Fabien Parent <[email protected]>
Add the clock bindings for the MediaTek MT8365 SoC.
Signed-off-by Fabien Parent <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by Markus Schneider-Pargmann <[email protected]>---
Applied to clk-next
PATCH v4 2/4 clk: mediatek: Provide mtk_devm_alloc_clk_data
In reply to Markus Schneider-PargmannProvide a helper that replaces the kzalloc with devm_kzalloc so error handling gets easier.
---
Notes:
Changes in v3:
- New patch
drivers/clk/mediatek/clk-mtk.c | 33 ++++++++++++++++++++++++++++----- drivers/clk/mediatek/clk-mtk.h | 2 ++ 2 files changed, 30 insertions(+), 5 deletions(-)
drivers/clk/mediatek/clk-mtk.c +28 -5
@@ -18,19 +18,42 @@#include "clk-mtk.h" #include "clk-gate.h" -struct clk_hw_onecell_data *mtk_alloc_clk_data (unsigned int clk_num) +static void mtk_init_clk_data (struct clk_hw_onecell_data *clk_data, +unsigned int clk_num) {int i; + + clk_data->num = clk_num; + +for (i =0 ; i < clk_num; i++) + clk_data->hws[i] =ERR_PTR (-ENOENT ); +} + +struct clk_hw_onecell_data *mtk_devm_alloc_clk_data (struct device *dev, +unsigned int clk_num) +{struct clk_hw_onecell_data *clk_data; - clk_data =kzalloc (struct_size (clk_data, hws, clk_num),GFP_KERNEL ); + clk_data =devm_kzalloc (dev,struct_size (clk_data, hws, clk_num), +GFP_KERNEL );if (!clk_data)return NULL ; - clk_data->num = clk_num; +mtk_init_clk_data (clk_data, clk_num); -for (i =0 ; i < clk_num; i++) - clk_data->hws[i] =ERR_PTR (-ENOENT ); +return clk_data; +} +EXPORT_SYMBOL_GPL (mtk_devm_alloc_clk_data); + +struct clk_hw_onecell_data *mtk_alloc_clk_data (unsigned int clk_num) +{ +struct clk_hw_onecell_data *clk_data; + + clk_data =kzalloc (struct_size (clk_data, hws, clk_num),GFP_KERNEL ); +if (!clk_data) +return NULL ; + +mtk_init_clk_data (clk_data, clk_num);return clk_data; }
drivers/clk/mediatek/clk-mtk.h +2 -0
@@ -184,6 +184,8 @@ void mtk_clk_unregister_dividers(const struct mtk_clk_divider *mcds, int num, struct clk_hw_onecell_data *clk_data);struct clk_hw_onecell_data *mtk_alloc_clk_data (unsigned int clk_num); +struct clk_hw_onecell_data *mtk_devm_alloc_clk_data (struct device *dev, +unsigned int clk_num);void mtk_free_clk_data (struct clk_hw_onecell_data *clk_data); struct clk_hw *mtk_clk_register_ref2usb_tx(const char *name,
Signature · 1 line
2.37.2
kernel test robot
build botRe: [PATCH v4 2/4] clk: mediatek: Provide mtk_devm_alloc_clk_data
Thank you for the patch! Perhaps something to improve:
Hi Markus,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on clk/clk-next]
[also build test WARNING on robh/for-next linus/master v6.0-rc2 next-20220822] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: loongarch-randconfig-c004-20220821 (https://download.01.org/0day-ci/archive/20220823/[email protected]/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
cocci warnings: (new ones prefixed by >>)
>> drivers/clk/mediatek/clk-mtk.c:64:1-6: WARNING: invalid free of devm_ allocated data
vim +64 drivers/clk/mediatek/clk-mtk.c
9741b1a68035b54 James Liao 2015-04-23 61
609cc5e1a82394e Chen-Yu Tsai 2022-05-19 62 void mtk_free_clk_data(struct clk_hw_onecell_data *clk_data)
300796cad22153f Chun-Jie Chen 2021-09-14 63 {
300796cad22153f Chun-Jie Chen 2021-09-14 @64 kfree(clk_data);
300796cad22153f Chun-Jie Chen 2021-09-14 65 }
609cc5e1a82394e Chen-Yu Tsai 2022-05-19 66 EXPORT_SYMBOL_GPL(mtk_free_clk_data);300796cad22153f Chun-Jie Chen 2021-09-14 67
Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
Re: [PATCH v4 2/4] clk: mediatek: Provide mtk_devm_alloc_clk_data
Hi,
Quoted 21 lines · kernel test robot
Hi Markus,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on clk/clk-next]
[also build test WARNING on robh/for-next linus/master v6.0-rc2 next-20220822] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: loongarch-randconfig-c004-20220821 (https://download.01.org/0day-ci/archive/20220823/202208230714.8DNW6JjZ-lkp(a)intel.com/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0If you fix the issue, kindly add following tag where applicable
Reported-by kernel test robot <[email protected]>cocci warnings: (new ones prefixed by >>)
Quoted 1 line
Quoted 1 line
drivers/clk/mediatek/clk-mtk.c:64:1-6: WARNING: invalid free of
devm_allocated data
Quoted 8 lines
vim +64
drivers/clk/mediatek/clk-mtk.c9741b1a68035b54 James Liao 2015-04-23 61 609cc5e1a82394e Chen-Yu Tsai 2022-05-19 62 void mtk_free_clk_data(struct clk_hw_onecell_data *clk_data) 300796cad22153f Chun-Jie Chen 2021-09-14 63 { 300796cad22153f Chun-Jie Chen 2021-09-14 @64 kfree(clk_data); 300796cad22153f Chun-Jie Chen 2021-09-14 65 } 609cc5e1a82394e Chen-Yu Tsai 2022-05-19 66 EXPORT_SYMBOL_GPL(mtk_free_clk_data);
I don't see how this should be called with clk_data being initialized by devm_*. Maybe I am bit code blind.
Do you have an actual call stack how this is supposed to happen? Also I wasn't able to get the same warning with coccinelle (different compiler).
Best,
Markus
Re: [PATCH v4 2/4] clk: mediatek: Provide mtk_devm_alloc_clk_data
In reply to Markus Schneider-PargmannQuoting Markus Schneider-Pargmann (2022-08-22 08:26:50)
Quoted 5 lines
Provide a helper that replaces the kzalloc with
devm_kzallocso error handling gets easier.Signed-off-by Markus Schneider-Pargmann <[email protected]>---
Applied to clk-next
PATCH v4 3/4 clk: mediatek: Export required common code symbols
In reply to Markus Schneider-PargmannTo make clk-mt8365 compilable as a module there are a few function symbols missing. This patch adds the required EXPORT_SYMBOL_GPL to the functions.
---
Notes:
Changes in v3:
- New patch
drivers/clk/mediatek/clk-mtk.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/clk/mediatek/clk-mtk.c +4 -0
@@ -422,6 +422,7 @@ int mtk_clk_register_dividers(const struct mtk_clk_divider *mcds, int num,return PTR_ERR (hw); } +EXPORT_SYMBOL_GPL (mtk_clk_register_dividers);void mtk_clk_unregister_dividers (const struct mtk_clk_divider *mcds,int num,struct clk_hw_onecell_data *clk_data)
@@ -441,6 +442,7 @@ void mtk_clk_unregister_dividers(const struct mtk_clk_divider *mcds, int num, clk_data->hws[mcd->id] =ERR_PTR (-ENOENT ); } } +EXPORT_SYMBOL_GPL (mtk_clk_unregister_dividers);int mtk_clk_simple_probe (struct platform_device *pdev) {
@@ -482,6 +484,7 @@ int mtk_clk_simple_probe(struct platform_device *pdev)mtk_free_clk_data (clk_data);return r; } +EXPORT_SYMBOL_GPL (mtk_clk_simple_probe);int mtk_clk_simple_remove (struct platform_device *pdev) {
@@ -495,5 +498,6 @@ int mtk_clk_simple_remove(struct platform_device *pdev)return 0 ; } +EXPORT_SYMBOL_GPL (mtk_clk_simple_remove);MODULE_LICENSE ("GPL" );
Signature · 1 line
2.37.2
Re: [PATCH v4 3/4] clk: mediatek: Export required common code symbols
Quoting Markus Schneider-Pargmann (2022-08-22 08:26:51)
Quoted 6 lines
To make clk-mt8365 compilable as a module there are a few function symbols missing. This patch adds the required
EXPORT_SYMBOL_GPLto the functions.Signed-off-by Markus Schneider-Pargmann <[email protected]>---
Applied to clk-next
PATCH v4 4/4 clk: mediatek: add driver for MT8365 SoC
In reply to Markus Schneider-PargmannFrom: Fabien Parent <[email protected]>
Add clock drivers for MT8365 SoC.
---
Notes:
Changes in v4:
- Removed the accidental changes of bindings in this patch
Changes in v3:
- Changed all Kconfig options to be tristate
- Do not depend on ARM64
- Fix order of frees on probe errors.
- Use mtk_clk_register_gates_with_dev
- Fixed null clocks
- Removed clk26m_ck
- Use MUX_GATE_CLR_SET_UPD instead of custom MT8365_MUX_CLR_SET_UPD
- Use devm_clk_hw_register_mux for top_misc_muxes
- Use devm_clk_hw_register_gate for peri_clks and top_clks
- Fix checkpatch warnings
- Add missing MODULE_LICENSEs in all files
drivers/clk/mediatek/Kconfig | 50 + drivers/clk/mediatek/Makefile | 7 + drivers/clk/mediatek/clk-mt8365-apu.c | 55 ++ drivers/clk/mediatek/clk-mt8365-cam.c | 57 ++ drivers/clk/mediatek/clk-mt8365-mfg.c | 63 ++ drivers/clk/mediatek/clk-mt8365-mm.c | 112 +++ drivers/clk/mediatek/clk-mt8365-vdec.c | 63 ++ drivers/clk/mediatek/clk-mt8365-venc.c | 52 ++ drivers/clk/mediatek/clk-mt8365.c | 1155 ++++++++++++++++++++++++ 9 files changed, 1614 insertions(+) create mode 100644 drivers/clk/mediatek/clk-mt8365-apu.c create mode 100644 drivers/clk/mediatek/clk-mt8365-cam.c create mode 100644 drivers/clk/mediatek/clk-mt8365-mfg.c create mode 100644 drivers/clk/mediatek/clk-mt8365-mm.c create mode 100644 drivers/clk/mediatek/clk-mt8365-vdec.c create mode 100644 drivers/clk/mediatek/clk-mt8365-venc.c create mode 100644 drivers/clk/mediatek/clk-mt8365.c
drivers/clk/mediatek/Kconfig +50 -0
@@ -608,6 +608,56 @@ config COMMON_CLK_MT8195 help This driver supports MediaTek MT8195 clocks. +config COMMON_CLK_MT8365 + tristate "Clock driver for MediaTek MT8365" + depends on ARCH_MEDIATEK || COMPILE_TEST + select COMMON_CLK_MEDIATEK + default ARCH_MEDIATEK && ARM64 + help + This driver supports MediaTek MT8365 basic clocks. + +config COMMON_CLK_MT8365_APU + tristate "Clock driver for MediaTek MT8365 apu" + depends on COMMON_CLK_MT8365 + default COMMON_CLK_MT8365 + help + This driver supports MediaTek MT8365 apu clocks. + +config COMMON_CLK_MT8365_CAM + tristate "Clock driver for MediaTek MT8365 cam" + depends on COMMON_CLK_MT8365 + default COMMON_CLK_MT8365 + help + This driver supports MediaTek MT8365 cam clocks. + +config COMMON_CLK_MT8365_MFG + tristate "Clock driver for MediaTek MT8365 mfg" + depends on COMMON_CLK_MT8365 + default COMMON_CLK_MT8365 + help + This driver supports MediaTek MT8365 mfg clocks. + +config COMMON_CLK_MT8365_MMSYS + tristate "Clock driver for MediaTek MT8365 mmsys" + depends on COMMON_CLK_MT8365 + default COMMON_CLK_MT8365 + help + This driver supports MediaTek MT8365 mmsys clocks. + +config COMMON_CLK_MT8365_VDEC + tristate "Clock driver for MediaTek MT8365 vdec" + depends on COMMON_CLK_MT8365 + default COMMON_CLK_MT8365 + help + This driver supports MediaTek MT8365 vdec clocks. + +config COMMON_CLK_MT8365_VENC + tristate "Clock driver for MediaTek MT8365 venc" + depends on COMMON_CLK_MT8365 + default COMMON_CLK_MT8365 + help + This driver supports MediaTek MT8365 venc clocks. + config COMMON_CLK_MT8516 bool "Clock driver for MediaTek MT8516" depends on ARCH_MEDIATEK || COMPILE_TEST
drivers/clk/mediatek/Makefile +7 -0
@@ -97,5 +97,12 @@ obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o clk-mt8195-venc.o clk-mt8195-vpp0.o clk-mt8195-vpp1.o \ clk-mt8195-wpe.o clk-mt8195-imp_iic_wrap.o \ clk-mt8195-apusys_pll.o +obj-$(CONFIG_COMMON_CLK_MT8365) += clk-mt8365.o +obj-$(CONFIG_COMMON_CLK_MT8365_APU) += clk-mt8365-apu.o +obj-$(CONFIG_COMMON_CLK_MT8365_CAM) += clk-mt8365-cam.o +obj-$(CONFIG_COMMON_CLK_MT8365_MFG) += clk-mt8365-mfg.o +obj-$(CONFIG_COMMON_CLK_MT8365_MMSYS) += clk-mt8365-mm.o +obj-$(CONFIG_COMMON_CLK_MT8365_VDEC) += clk-mt8365-vdec.o +obj-$(CONFIG_COMMON_CLK_MT8365_VENC) += clk-mt8365-venc.o obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o
drivers/clk/mediatek/clk-mt8365-apu.c new file +55 -0
55 lines not on this page · raw message
drivers/clk/mediatek/clk-mt8365-cam.c new file +57 -0
57 lines not on this page · raw message
drivers/clk/mediatek/clk-mt8365-mfg.c new file +63 -0
63 lines not on this page · raw message
drivers/clk/mediatek/clk-mt8365-mm.c new file +112 -0
112 lines not on this page · raw message
drivers/clk/mediatek/clk-mt8365-vdec.c new file +63 -0
63 lines not on this page · raw message
drivers/clk/mediatek/clk-mt8365-venc.c new file +52 -0
52 lines not on this page · raw message
drivers/clk/mediatek/clk-mt8365.c new file +1155 -0
1,155 lines not on this page · raw message
Signature · 1 line
2.37.2
kernel test robot
build botRe: [PATCH v4 4/4] clk: mediatek: add driver for MT8365 SoC
Thank you for the patch! Yet something to improve:
Hi Markus,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on clk/clk-next]
[also build test ERROR on robh/for-next linus/master v6.0-rc2 next-20220823] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220824/[email protected]/config) compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/51c1bac1ab0d284ab6c444966eee437c23095a85
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030 git checkout 51c1bac1ab0d284ab6c444966eee437c23095a85
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "mtk_clk_register_gates_with_dev" [drivers/clk/mediatek/clk-mt8365-mm.ko] undefined!
Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
Re: [PATCH v4 4/4] clk: mediatek: add driver for MT8365 SoC
Hi,
Quoted 25 lines · kernel test robot
Hi Markus,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on clk/clk-next]
[also build test ERROR on robh/for-next linus/master v6.0-rc2 next-20220823] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220824/202208241051.Xi9D8DaW-lkp(a)intel.com/config) compiler: m68k-linux-gcc (GCC) 12.1.0reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/51c1bac1ab0d284ab6c444966eee437c23095a85
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030 git checkout51c1bac1ab0d284ab6c444966eee437c23095a85
# save the config file
mkdirbuild_dir&& cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash
Quoted 6 lines
If you fix the issue, kindly add following tag where applicable
Reported-by kernel test robot <[email protected]>All errors (new ones prefixed by >>, old ones prefixed by <<):
Quoted 1 line
Quoted 1 line
ERROR: modpost: "
mtk_clk_register_gates_with_dev" [drivers/clk/mediatek/clk-mt8365-mm.ko] undefined!
This series is based on this patch
https://lore.kernel.org/linux-mediatek/20220813083249.45427-1-y.oudjana(a)protonmail.com/
which is not yet applied but adds the required EXPORT.
Best,
Markus
Re: [PATCH v4 4/4] clk: mediatek: add driver for MT8365 SoC
In reply to Markus Schneider-PargmannQuoting Markus Schneider-Pargmann (2022-08-22 08:26:52)
Quoted 7 lines
From: Fabien Parent <[email protected]>
Add clock drivers for MT8365 SoC.
Signed-off-by Fabien Parent <[email protected]>Signed-off-by Markus Schneider-Pargmann <[email protected]>---
Applied to clk-next