Skip to contentSkip to conversation

dt-bindings: display: simple: Add EDT ETML1010G0DKA panel

PATCH In review Dominik Haller 3 participants 6 messages Aug 18, 2022 – Apr 8

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: display: simple: Add EDT ETML1010G0DKA panel

Add binding for the Emerging Display Technology ETML1010G0DKA panel. It's a 10.1" WXGA (1280 x 800) LVDS panel with backlight and capacitive touch.

---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2 -0
index 18241f4051d2..bd8a7c77e90f 100644
@@ -143,6 +143,8 @@ properties:
       - edt,etm0700g0edh6
         # Emerging Display Technology Corp. LVDS WSVGA TFT Display with capacitive touch
       - edt,etml0700y5dha
+        # Emerging Display Technology Corp. 10.1" LVDS WXGA TFT Display with capacitive touch
+      - edt,etml1010g0dka
         # Emerging Display Technology Corp. 5.7" VGA TFT LCD panel with
         # capacitive touch
       - edt,etmv570g2dhu
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 drm/panel: simple: Add EDT ETML1010G0DKA panel

Add support for the EDT ETML1010G0DKA 10.1" 1280x800 LVDS panel.

---
 drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +29 -0
index f9e1f85daef7..9314db24ab51 100644
@@ -1779,6 +1779,32 @@ static const struct panel_desc edt_etml0700y5dha = {
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct drm_display_mode edt_etml1010g0dka_mode = {
+	.clock = 70000,
+	.hdisplay = 1280,
+	.hsync_start = 1280 + 100,
+	.hsync_end = 1280 + 100 + 19,
+	.htotal = 1280 + 100 + 19 + 41,
+	.vdisplay = 800,
+	.vsync_start = 800 + 4,
+	.vsync_end = 800 + 4 + 4,
+	.vtotal = 800 + 4 + 4 + 15,
+	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc edt_etml1010g0dka = {
+	.modes = &edt_etml1010g0dka_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 216,
+		.height = 135,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct drm_display_mode edt_etmv570g2dhu_mode = {
 	.clock = 25175,
 	.hdisplay = 640,
@@ -4057,6 +4083,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "edt,etml0700y5dha",
 		.data = &edt_etml0700y5dha,
+	}, {
+		.compatible = "edt,etml1010g0dka",
+		.data = &edt_etml1010g0dka,
 	}, {
 		.compatible = "edt,etmv570g2dhu",
 		.data = &edt_etmv570g2dhu,
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH 2/2] drm/panel: simple: Add EDT ETML1010G0DKA panel

Hello,

ping here, this one got forgotten.
It still applies on drm-misc-next and v6.2-rc7

Quoted 54 lines · Dominik Haller

Add support for the EDT ETML1010G0DKA 10.1" 1280x800 LVDS panel.

---
  drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
  1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +29 -0
index f9e1f85daef7..9314db24ab51 100644
@@ -1779,6 +1779,32 @@ static const struct panel_desc edt_etml0700y5dha = {
  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
  };
 
+static const struct drm_display_mode edt_etml1010g0dka_mode = {
+	.clock = 70000,
+	.hdisplay = 1280,
+	.hsync_start = 1280 + 100,
+	.hsync_end = 1280 + 100 + 19,
+	.htotal = 1280 + 100 + 19 + 41,
+	.vdisplay = 800,
+	.vsync_start = 800 + 4,
+	.vsync_end = 800 + 4 + 4,
+	.vtotal = 800 + 4 + 4 + 15,
+	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc edt_etml1010g0dka = {
+	.modes = &edt_etml1010g0dka_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 216,
+		.height = 135,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
  static const struct drm_display_mode edt_etmv570g2dhu_mode = {
  	.clock = 25175,
  	.hdisplay = 640,
@@ -4057,6 +4083,9 @@ static const struct of_device_id platform_of_match[] = {
  	}, {
  		.compatible = "edt,etml0700y5dha",
  		.data = &edt_etml0700y5dha,
+	}, {
+		.compatible = "edt,etml1010g0dka",
+		.data = &edt_etml1010g0dka,
  	}, {
  		.compatible = "edt,etmv570g2dhu",
  		.data = &edt_etmv570g2dhu,
Signature · 5 lines
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz-Mitte | St.Nr.
266500608, DE 149059855
#3 lore raw

Re: [PATCH 2/2] drm/panel: simple: Add EDT ETML1010G0DKA panel

Quoted 1 line · Dominik Haller

Hello,

Neil Armstrong:

It is quite old. Any reason why not pick this patch?

Frank

Quoted 69 lines

ping here, this one got forgotten.
It still applies on drm-misc-next and v6.2-rc7

Quoted 45 lines · Dominik Haller

Add support for the EDT ETML1010G0DKA 10.1" 1280x800 LVDS panel.

---
  drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
  1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +26 -0
index f9e1f85daef7..9314db24ab51 100644
@@ -1779,6 +1779,32 @@ static const struct panel_desc edt_etml0700y5dha = {
  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
  };
 
+static const struct drm_display_mode edt_etml1010g0dka_mode = {
+	.clock = 70000,
+	.hdisplay = 1280,
+	.hsync_start = 1280 + 100,
+	.hsync_end = 1280 + 100 + 19,
+	.htotal = 1280 + 100 + 19 + 41,
+	.vdisplay = 800,
+	.vsync_start = 800 + 4,
+	.vsync_end = 800 + 4 + 4,
+	.vtotal = 800 + 4 + 4 + 15,
+	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc edt_etml1010g0dka = {
+	.modes = &edt_etml1010g0dka_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 216,
+		.height = 135,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
  static const struct drm_display_mode edt_etmv570g2dhu_mode = {
  	.clock = 25175,
  	.hdisplay = 640,

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id platform_of_match[] = { · line 4091

Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -4057,6 +4083,9 @@ static const struct of_device_id platform_of_match[] = {
  	}, {
  		.compatible = "edt,etml0700y5dha",
  		.data = &edt_etml0700y5dha,
+	}, {
+		.compatible = "edt,etml1010g0dka",
+		.data = &edt_etml1010g0dka,
  	}, {
  		.compatible = "edt,etmv570g2dhu",
  		.data = &edt_etmv570g2dhu,

--
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber | Handelsregister Mainz HRB 4656 | Finanzamt Mainz-Mitte | St.Nr. 266500608, DE 149059855

#4 lore raw

Re: [PATCH 2/2] drm/panel: simple: Add EDT ETML1010G0DKA panel

Quoted 6 lines · Frank Li
Quoted 1 line · Dominik Haller

Hello,

Neil Armstrong:

It is quite old. Any reason why not pick this patch?

Hi,

this panel is eol and we've switched to etml1010g3dra and ph128800t006-zhc01 in our kits.

So this patch can be dropped.

Dominik

Quoted 76 lines

Frank

Quoted 74 lines

ping here, this one got forgotten.
It still applies on drm-misc-next and v6.2-rc7

Quoted 57 lines · Dominik Haller

Add support for the EDT ETML1010G0DKA 10.1" 1280x800 LVDS panel.

---
  drivers/gpu/drm/panel/panel-simple.c | 29
++++++++++++++++++++++++++++

  1 file changed, 29 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +26 -0
index f9e1f85daef7..9314db24ab51 100644
@@ -1779,6 +1779,32 @@ static const struct panel_desc
 edt_etml0700y5dha = {
   	.connector_type = DRM_MODE_CONNECTOR_LVDS,
   };
 
+static const struct drm_display_mode edt_etml1010g0dka_mode = {
+	.clock = 70000,
+	.hdisplay = 1280,
+	.hsync_start = 1280 + 100,
+	.hsync_end = 1280 + 100 + 19,
+	.htotal = 1280 + 100 + 19 + 41,
+	.vdisplay = 800,
+	.vsync_start = 800 + 4,
+	.vsync_end = 800 + 4 + 4,
+	.vtotal = 800 + 4 + 4 + 15,
+	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc edt_etml1010g0dka = {
+	.modes = &edt_etml1010g0dka_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 216,
+		.height = 135,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
   static const struct drm_display_mode edt_etmv570g2dhu_mode = {
   	.clock = 25175,

   .hdisplay = 640,

drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -4057,6 +4083,9 @@ static const struct of_device_id
 platform_of_match[] = {
   	}, {
   		.compatible = "edt,etml0700y5dha",
   		.data = &edt_etml0700y5dha,
+	}, {
+		.compatible = "edt,etml1010g0dka",
+		.data = &edt_etml1010g0dka,
   	}, {
   		.compatible = "edt,etmv570g2dhu",
Quoted 1 line

   .data = &edt_etmv570g2dhu,

--
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz-Mitte | St.Nr. 266500608, DE 149059855