Skip to contentSkip to conversation

regulator: core: Remove "ramp_delay not set" debug message

PATCH Superseded Christian Kohlschütter 2 participants 3 messages Aug 20, 2022 – Aug 22, 2022 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: core: Remove "ramp_delay not set" debug message

This message shows up occasionally but in bursts (seen as up 30 times per second on my ODROID N2+).

According to Matthias Kaehlcke's comment in 'regulator: core: silence
warning: "VDD1: ramp_delay not set"', this message should have been removed after restructuring previous code that assumed that ramp_delay being zero in that function was an error.

---
 drivers/regulator/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/regulator/core.c +1 -3
index a5033c6ba01..18fa9206ec2 100644
@@ -3497,10 +3497,8 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev,
 		 (new_uV < old_uV))
 		return rdev->constraints->settling_time_down;
 
-	if (ramp_delay == 0) {
-		rdev_dbg(rdev, "ramp_delay not set\n");
+	if (ramp_delay == 0)
 		return 0;
-	}
 
 	return DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay);
 }
Signature · 1 line
2.36.2
#1 lore raw

PATCH v2 1/1 regulator: core: Remove "ramp_delay not set" debug message

This message shows up occasionally but in bursts (seen up to 30 times per second on my ODROID N2+).

According to Matthias Kaehlcke's comment in 'regulator: core: silence
warning: "VDD1: ramp_delay not set"', this message should have been removed after restructuring previous code that assumed that ramp_delay being zero in that function was an error.

---
 drivers/regulator/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/regulator/core.c +1 -3
index a5033c6ba01..18fa9206ec2 100644
@@ -3497,10 +3497,8 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev,
 		 (new_uV < old_uV))
 		return rdev->constraints->settling_time_down;
 
-	if (ramp_delay == 0) {
-		rdev_dbg(rdev, "ramp_delay not set\n");
+	if (ramp_delay == 0)
 		return 0;
-	}
 
 	return DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay);
 }
Signature · 1 line
2.36.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Christian Kohlschütter
Quoted 10 lines · Christian Kohlschütter

This message shows up occasionally but in bursts (seen as up 30 times per second on my ODROID N2+).

According to Matthias Kaehlcke's comment in 'regulator: core: silence
warning: "VDD1: ramp_delay not set"', this message should have been removed after restructuring previous code that assumed that ramp_delay being zero in that function was an error.