Skip to contentSkip to conversation

leds: pca963x: Add support for PCA962x chips

PATCH In review Mike Looijmans 2 participants 4 messages Aug 22, 2022 – Oct 11, 2022 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 leds: pca963x: Add support for PCA962x chips

The PCA962x family shares the same I2C register layout and functionality. This adds support for the following chips:
PCA9623 4-channel
PCA9624 8-channel
PCA9622 16-channel
PCA9626 24-channel

Tested only the PCA9624. Other devices based on datasheet information.

---

 drivers/leds/Kconfig        |  8 ++++----
 drivers/leds/leds-pca963x.c | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+), 4 deletions(-)
drivers/leds/Kconfig +4 -4
index 499d0f215a8b..9a99190c13af 100644
@@ -497,13 +497,13 @@ config LEDS_PCA955X_GPIO
 
 
 config LEDS_PCA963X
-	tristate "LED support for PCA963x I2C chip"
+	tristate "LED support for PCA962x and PCA963x I2C chips"
 	depends on LEDS_CLASS
 	depends on I2C
 	help
-	  This option enables support for LEDs connected to the PCA963x
-	  LED driver chip accessed via the I2C bus. Supported
-	  devices include PCA9633 and PCA9634
+	  This option enables support for LEDs connected to the PCA96xx
+	  LED driver chip accessed via the I2C bus. Supported devices:
+	  PCA9622, PCA9623, PCA9624, PCA9626, PCA9633, PCA9634, PCA9635.
 
 config LEDS_WM831X_STATUS
 	tristate "LED support for status LEDs on WM831x PMICs"
drivers/leds/leds-pca963x.c +36 -0
index 00aecd67e348..4d589624d192 100644
@@ -48,6 +48,10 @@
 #define PCA963X_PWM_BASE	0x02
 
 enum pca963x_type {
+	pca9622,
+	pca9623,
+	pca9624,
+	pca9626,
 	pca9633,
 	pca9634,
 	pca9635,
@@ -62,6 +66,30 @@ struct pca963x_chipdef {
 };
 
 static struct pca963x_chipdef pca963x_chipdefs[] = {
+	[pca9622] = {
+		.grppwm		= 0x12,
+		.grpfreq	= 0x13,
+		.ledout_base	= 0x14,
+		.n_leds		= 16,
+	},
+	[pca9623] = {
+		.grppwm		= 0x6,
+		.grpfreq	= 0x7,
+		.ledout_base	= 0x8,
+		.n_leds		= 4,
+	},
+	[pca9624] = {
+		.grppwm		= 0xa,
+		.grpfreq	= 0xb,
+		.ledout_base	= 0xc,
+		.n_leds		= 8,
+	},
+	[pca9626] = {
+		.grppwm		= 0x1a,
+		.grpfreq	= 0x1b,
+		.ledout_base	= 0x1d,
+		.n_leds		= 24,
+	},
 	[pca9633] = {
 		.grppwm		= 0x6,
 		.grpfreq	= 0x7,
@@ -87,6 +115,10 @@ static struct pca963x_chipdef pca963x_chipdefs[] = {
 #define PCA963X_BLINK_PERIOD_MAX	10667
 
 static const struct i2c_device_id pca963x_id[] = {
+	{ "pca9622", pca9622 },
+	{ "pca9623", pca9623 },
+	{ "pca9624", pca9624 },
+	{ "pca9626", pca9626 },
 	{ "pca9632", pca9633 },
 	{ "pca9633", pca9633 },
 	{ "pca9634", pca9634 },
@@ -363,6 +395,10 @@ static int pca963x_register_leds(struct i2c_client *client,
 }
 
 static const struct of_device_id of_pca963x_match[] = {
+	{ .compatible = "nxp,pca9622", },
+	{ .compatible = "nxp,pca9623", },
+	{ .compatible = "nxp,pca9624", },
+	{ .compatible = "nxp,pca9626", },
 	{ .compatible = "nxp,pca9632", },
 	{ .compatible = "nxp,pca9633", },
 	{ .compatible = "nxp,pca9634", },
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 dt-bindings: leds: pca963x: Add support for PCA962x chips

The PCA962x family shares the same I2C register layout and functionality. This adds support for the following chips:
PCA9623 4-channel
PCA9624 8-channel
PCA9622 16-channel
PCA9626 24-channel

Tested only the PCA9624. Other devices based on datasheet information.

---

 Documentation/devicetree/bindings/leds/leds-pca9532.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/leds/leds-pca9532.txt +4 -0
index f769c52e3643..50a340cbbb49 100644
@@ -5,6 +5,10 @@ The PWM support 256 steps.
 
 Required properties:
 	- compatible:
+		"nxp,pca9522"
+		"nxp,pca9523"
+		"nxp,pca9524"
+		"nxp,pca9526"
 		"nxp,pca9530"
 		"nxp,pca9531"
 		"nxp,pca9532"
Signature · 1 line
2.17.1
maintainer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] dt-bindings: leds: pca963x: Add support for PCA962x chips

Quoted 7 lines · Mike Looijmans

The PCA962x family shares the same I2C register layout and functionality. This adds support for the following chips:
PCA9623 4-channel
PCA9624 8-channel
PCA9622 16-channel
PCA9626 24-channel

Quoted 9 lines

Tested only the PCA9624. Other devices based on datasheet information.

---

 Documentation/devicetree/bindings/leds/leds-pca9532.txt | 4 ++++
 1 file changed, 4 insertions(+)
#3 lore raw
In reply to Mike Looijmans

Just a gentle "ping", haven't seen any feedback for quite some time. Any issues, comments?

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topic.nl

Please consider the environment before printing this e-mail

Quoted 106 lines · Mike Looijmans

The PCA962x family shares the same I2C register layout and functionality. This adds support for the following chips:
PCA9623 4-channel
PCA9624 8-channel
PCA9622 16-channel
PCA9626 24-channel

Tested only the PCA9624. Other devices based on datasheet information.

---

  drivers/leds/Kconfig        |  8 ++++----
  drivers/leds/leds-pca963x.c | 36 ++++++++++++++++++++++++++++++++++++
  2 files changed, 40 insertions(+), 4 deletions(-)
drivers/leds/Kconfig +4 -4
index 499d0f215a8b..9a99190c13af 100644
@@ -497,13 +497,13 @@ config LEDS_PCA955X_GPIO
 
 
  config LEDS_PCA963X
-	tristate "LED support for PCA963x I2C chip"
+	tristate "LED support for PCA962x and PCA963x I2C chips"
  	depends on LEDS_CLASS
  	depends on I2C
  	help
-	  This option enables support for LEDs connected to the PCA963x
-	  LED driver chip accessed via the I2C bus. Supported
-	  devices include PCA9633 and PCA9634
+	  This option enables support for LEDs connected to the PCA96xx
+	  LED driver chip accessed via the I2C bus. Supported devices:
+	  PCA9622, PCA9623, PCA9624, PCA9626, PCA9633, PCA9634, PCA9635.
 
  config LEDS_WM831X_STATUS
  	tristate "LED support for status LEDs on WM831x PMICs"
drivers/leds/leds-pca963x.c +36 -0
index 00aecd67e348..4d589624d192 100644
@@ -48,6 +48,10 @@
  #define PCA963X_PWM_BASE	0x02
 
  enum pca963x_type {
+	pca9622,
+	pca9623,
+	pca9624,
+	pca9626,
  	pca9633,
  	pca9634,
  	pca9635,
@@ -62,6 +66,30 @@ struct pca963x_chipdef {
  };
 
  static struct pca963x_chipdef pca963x_chipdefs[] = {
+	[pca9622] = {
+		.grppwm		= 0x12,
+		.grpfreq	= 0x13,
+		.ledout_base	= 0x14,
+		.n_leds		= 16,
+	},
+	[pca9623] = {
+		.grppwm		= 0x6,
+		.grpfreq	= 0x7,
+		.ledout_base	= 0x8,
+		.n_leds		= 4,
+	},
+	[pca9624] = {
+		.grppwm		= 0xa,
+		.grpfreq	= 0xb,
+		.ledout_base	= 0xc,
+		.n_leds		= 8,
+	},
+	[pca9626] = {
+		.grppwm		= 0x1a,
+		.grpfreq	= 0x1b,
+		.ledout_base	= 0x1d,
+		.n_leds		= 24,
+	},
  	[pca9633] = {
  		.grppwm		= 0x6,
  		.grpfreq	= 0x7,
@@ -87,6 +115,10 @@ static struct pca963x_chipdef pca963x_chipdefs[] = {
  #define PCA963X_BLINK_PERIOD_MAX	10667
 
  static const struct i2c_device_id pca963x_id[] = {
+	{ "pca9622", pca9622 },
+	{ "pca9623", pca9623 },
+	{ "pca9624", pca9624 },
+	{ "pca9626", pca9626 },
  	{ "pca9632", pca9633 },
  	{ "pca9633", pca9633 },
  	{ "pca9634", pca9634 },
@@ -363,6 +395,10 @@ static int pca963x_register_leds(struct i2c_client *client,
  }
 
  static const struct of_device_id of_pca963x_match[] = {
+	{ .compatible = "nxp,pca9622", },
+	{ .compatible = "nxp,pca9623", },
+	{ .compatible = "nxp,pca9624", },
+	{ .compatible = "nxp,pca9626", },
  	{ .compatible = "nxp,pca9632", },
  	{ .compatible = "nxp,pca9633", },
  	{ .compatible = "nxp,pca9634", },
Signature · 1 line
Mike Looijmans