Skip to contentSkip to conversation

grub-install: set point of no return for powerpc-ieee1275 install

PATCH In review Michael Chang 2 participants 2 messages Aug 25, 2022 – Oct 6, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 grub-install: set point of no return for powerpc-ieee1275 install

The point of no return is used to define a point where no change should be reverted in a wake of fatal error that consequently aborts the process. The powerpc-ieee1275 install apparently missed this point of no return defintion that newly installed modules could be inadvertently reverted after successful image embedding so that boot failure is incurred due to inconsistent state.

---
 util/grub-install.c | 1 +
 1 file changed, 1 insertion(+)
util/grub-install.c +1 -0
index 7b04bd3c53..1c0ece7f19 100644
@@ -1835,6 +1835,7 @@ main (int argc, char *argv[])
 	    {
 	      if (write_to_disk (ins_dev, imgfile))
 		grub_util_error ("%s", _("failed to copy Grub to the PReP partition"));
+	      grub_set_install_backup_ponr ();
 	    }
 	  else
 	    {
Signature · 1 line
2.35.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Michael Chang via Grub-devel

The point of no return is used to define a point where no change should be reverted in a wake of fatal error that consequently aborts the process. The powerpc-ieee1275 install apparently missed this point of no return defintion that newly installed modules could be inadvertently reverted after successful image embedding so that boot failure is incurred due to inconsistent state.

Daniel