Skip to contentSkip to conversation

tests/kms_content_protection: Test Refactoring

PATCH Superseded Karthik B S 3 participants 7 messages Sep 28, 2022

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v5 cover tests/kms_content_protection: Test Refactoring

Series includes patches to:
-Cleanup the test
-Convert the test to dynamic

Karthik B S (2):
tests/kms_content_protection: Test Cleanup tests/kms_content_protection: Convert test to dynamic

 tests/kms_content_protection.c | 395 ++++++++++++++++++---------------
 1 file changed, 216 insertions(+), 179 deletions(-)
Signature · 1 line
2.22.0
#1 lore raw

PATCH v5 1/2 tests/kms_content_protection: Test Cleanup

This patch includes:
1.Add a modeset before checking output is HDCP capable.
Test currently skips on multidisplay MST because we're checking if output is HDCP capable before doing a modeset on the output.
2.Call igt_display_reset before starting the subtest. 3.test_fini function added to prepare test for converting to dynamic. 4.Remove redundant mode override.
5.Try other pipe/output combo for MST if failure is seen on one.

v2: -Update commit style in test_content_protection_cleanup.

v3: -Declare 'pipe' variable in this patch which otherwise causes
failure when patch is compiled individually.

---
 tests/kms_content_protection.c | 182 +++++++++++++++++----------------
 1 file changed, 94 insertions(+), 88 deletions(-)
tests/kms_content_protection.c +94 -88
index 3041f1cd..c32767c8 100644
@@ -170,18 +170,15 @@ static void modeset_with_fb(const enum pipe pipe, igt_output_t *output,
 			    enum igt_commit_style s)
 {
 	igt_display_t *display = &data.display;
-	drmModeModeInfo mode;
+	drmModeModeInfo *mode;
 	igt_plane_t *primary;
 
-	igt_assert(kmstest_get_connector_default_mode(
-			display->drm_fd, output->config.connector, &mode));
-
-	igt_output_override_mode(output, &mode);
+	mode = igt_output_get_mode(output);
 	igt_output_set_pipe(output, pipe);
 
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 	igt_plane_set_fb(primary, &data.red);
-	igt_fb_set_size(&data.red, primary, mode.hdisplay, mode.vdisplay);
+	igt_fb_set_size(&data.red, primary, mode->hdisplay, mode->vdisplay);
 
 	igt_display_commit2(display, s);
 
@@ -317,90 +314,61 @@ static bool write_srm_as_fw(const __u8 *srm, int len)
 }
 
 static void test_content_protection_on_output(igt_output_t *output,
+					      enum pipe pipe,
 					      enum igt_commit_style s,
 					      int content_type)
 {
 	igt_display_t *display = &data.display;
-	igt_plane_t *primary;
-	enum pipe pipe;
 	bool ret;
 
-	for_each_pipe(display, pipe) {
-		if (!igt_pipe_connector_valid(pipe, output))
-			continue;
-
-		/*
-		 * If previous subtest of connector failed, pipe
-		 * attached to that connector is not released.
-		 * Because of that we have to choose the non
-		 * attached pipe for this subtest.
-		 */
-		if (!igt_pipe_is_free(display, pipe))
-			continue;
-
-		modeset_with_fb(pipe, output, s);
-		test_cp_enable_with_retry(output, s, 3, content_type, false,
-					  false);
-
-		if (data.cp_tests & CP_TYPE_CHANGE) {
-			/* Type 1 -> Type 0 */
-			test_cp_enable_with_retry(output, s, 3,
-						  HDCP_CONTENT_TYPE_0, false,
-						  true);
-			/* Type 0 -> Type 1 */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, false,
-						  true);
-		}
-
-		if (data.cp_tests & CP_MEI_RELOAD) {
-			igt_assert_f(!igt_kmod_unload("mei_hdcp", 0),
-				     "mei_hdcp unload failed");
+	test_cp_enable_with_retry(output, s, 3, content_type, false,
+				  false);
+
+	if (data.cp_tests & CP_TYPE_CHANGE) {
+		/* Type 1 -> Type 0 */
+		test_cp_enable_with_retry(output, s, 3,
+					  HDCP_CONTENT_TYPE_0, false,
+					  true);
+		/* Type 0 -> Type 1 */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, false,
+					  true);
+	}
 
-			/* Expected to fail */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, true, false);
+	if (data.cp_tests & CP_MEI_RELOAD) {
+		igt_assert_f(!igt_kmod_unload("mei_hdcp", 0),
+			     "mei_hdcp unload failed");
 
-			igt_assert_f(!igt_kmod_load("mei_hdcp", NULL),
-				     "mei_hdcp load failed");
+		/* Expected to fail */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, true, false);
 
-			/* Expected to pass */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, false, false);
-		}
+		igt_assert_f(!igt_kmod_load("mei_hdcp", NULL),
+			     "mei_hdcp load failed");
 
-		if (data.cp_tests & CP_LIC)
-			test_cp_lic(output);
+		/* Expected to pass */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, false, false);
+	}
 
-		if (data.cp_tests & CP_DPMS) {
-			igt_pipe_set_prop_value(display, pipe,
-						IGT_CRTC_ACTIVE, 0);
-			igt_display_commit2(display, s);
+	if (data.cp_tests & CP_LIC)
+		test_cp_lic(output);
 
-			igt_pipe_set_prop_value(display, pipe,
-						IGT_CRTC_ACTIVE, 1);
-			igt_display_commit2(display, s);
+	if (data.cp_tests & CP_DPMS) {
+		igt_pipe_set_prop_value(display, pipe,
+					IGT_CRTC_ACTIVE, 0);
+		igt_display_commit2(display, s);
 
-			ret = wait_for_prop_value(output, CP_ENABLED,
-						  KERNEL_AUTH_TIME_ALLOWED_MSEC);
-			if (!ret)
-				test_cp_enable_with_retry(output, s, 2,
-							  content_type, false,
-							  false);
-		}
+		igt_pipe_set_prop_value(display, pipe,
+					IGT_CRTC_ACTIVE, 1);
+		igt_display_commit2(display, s);
 
-		test_cp_disable(output, s);
-		primary = igt_output_get_plane_type(output,
-						    DRM_PLANE_TYPE_PRIMARY);
-		igt_plane_set_fb(primary, NULL);
-		igt_output_set_pipe(output, PIPE_NONE);
-
-		/*
-		 * Testing a output with a pipe is enough for HDCP
-		 * testing. No ROI in testing the connector with other
-		 * pipes. So Break the loop on pipe.
-		 */
-		break;
+		ret = wait_for_prop_value(output, CP_ENABLED,
+					  KERNEL_AUTH_TIME_ALLOWED_MSEC);
+		if (!ret)
+			test_cp_enable_with_retry(output, s, 2,
+						  content_type, false,
+						  false);
 	}
 }
 
@@ -458,7 +426,8 @@ static bool sink_hdcp2_capable(igt_output_t *output)
 	return strstr(buf, "HDCP2.2");
 }
 
-static void prepare_modeset_on_mst_output(igt_output_t *output)
+static void
+prepare_modeset_on_mst_output(igt_output_t *output)
 {
 	drmModeModeInfo *mode;
 	igt_plane_t *primary;
@@ -477,7 +446,8 @@ static void prepare_modeset_on_mst_output(igt_output_t *output)
 	igt_plane_set_size(primary, width, height);
 }
 
-static bool output_hdcp_capable(igt_output_t *output, int content_type)
+static bool
+output_hdcp_capable(igt_output_t *output, int content_type)
 {
 		if (!output->props[IGT_CONNECTOR_CONTENT_PROTECTION])
 			return false;
@@ -499,22 +469,53 @@ static bool output_hdcp_capable(igt_output_t *output, int content_type)
 		return true;
 }
 
+static void
+test_fini(igt_output_t *output, enum igt_commit_style s)
+{
+	igt_plane_t *primary;
+
+	test_cp_disable(output, s);
+	primary = igt_output_get_plane_type(output,
+					    DRM_PLANE_TYPE_PRIMARY);
+	igt_plane_set_fb(primary, NULL);
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_display_commit2(&data.display, s);
+}
+
 static void
 test_content_protection(enum igt_commit_style s, int content_type)
 {
 	igt_display_t *display = &data.display;
 	igt_output_t *output;
 	int valid_tests = 0;
+	enum pipe pipe;
 
 	if (data.cp_tests & CP_MEI_RELOAD)
 		igt_require_f(igt_kmod_is_loaded("mei_hdcp"),
 			      "mei_hdcp module is not loaded\n");
 
 	for_each_connected_output(display, output) {
-		if (!output_hdcp_capable(output, content_type))
-			continue;
+		for_each_pipe(display, pipe) {
+			if (!igt_pipe_connector_valid(pipe, output))
+				continue;
+
+			igt_display_reset(display);
+			modeset_with_fb(pipe, output, s);
+
+			if (!output_hdcp_capable(output, content_type))
+				continue;
+
+			test_content_protection_on_output(output, pipe, s, content_type);
+			test_fini(output, s);
+
+			/*
+			 * Testing a output with a pipe is enough for HDCP
+			 * testing. No ROI in testing the connector with other
+			 * pipes. So Break the loop on pipe.
+			 */
+			break;
+		}
 
-		test_content_protection_on_output(output, s, content_type);
 		valid_tests++;
 	}
 
@@ -596,6 +597,7 @@ test_content_protection_mst(int content_type)
 	igt_output_t *output;
 	int valid_outputs = 0, dp_mst_outputs = 0, ret, count, max_pipe = 0, i;
 	enum pipe pipe;
+	bool pipe_found;
 	igt_output_t *mst_output[IGT_MAX_PIPES], *hdcp_mst_output[IGT_MAX_PIPES];
 
 	for_each_pipe(display, pipe)
@@ -607,16 +609,20 @@ test_content_protection_mst(int content_type)
 		if (!output_is_dp_mst(output, dp_mst_outputs))
 			continue;
 
-		igt_assert_f(igt_pipe_connector_valid(pipe, output), "Output-pipe combination invalid\n");
+		pipe_found = false;
+		for_each_pipe(display, pipe) {
+			if (igt_pipe_is_free(display, pipe) &&
+			    igt_pipe_connector_valid(pipe, output)) {
+				pipe_found = true;
+				break;
+			}
+		}
+
+		igt_assert_f(pipe_found, "No valid pipe found for %s\n", output->name);
 
 		igt_output_set_pipe(output, pipe);
 		prepare_modeset_on_mst_output(output);
 		mst_output[dp_mst_outputs++] = output;
-
-		pipe++;
-
-		if (pipe > max_pipe)
-			break;
 	}
 
 	igt_require_f(dp_mst_outputs > 1, "No DP MST set up with >= 2 outputs found in a single topology\n");
@@ -694,7 +700,7 @@ static void test_content_protection_cleanup(void)
 			continue;
 
 		igt_info("CP Prop being UNDESIRED on %s\n", output->name);
-		test_cp_disable(output, COMMIT_ATOMIC);
+		test_cp_disable(output, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 	}
 
 	igt_remove_fb(data.drm_fd, &data.red);
Signature · 1 line
2.22.0
#2 lore raw

Re: [igt-dev] [PATCH i-g-t v5 1/2] tests/kms_content_protection: Test Cleanup

Hi Karthik,

Quoted 8 lines · Karthik B S

This patch includes:
1.Add a modeset before checking output is HDCP capable.
Test currently skips on multidisplay MST because we're checking if output is HDCP capable before doing a modeset on the output.
2.Call igt_display_reset before starting the subtest. 3.test_fini function added to prepare test for converting to dynamic. 4.Remove redundant mode override.
5.Try other pipe/output combo for MST if failure is seen on one.

These looks like fix and cleanup, please split out part 1. and 5. into separate patch.
I will not comment on kms parts, only some things spotted, see below.

Quoted 171 lines

v2: -Update commit style in test_content_protection_cleanup.

v3: -Declare 'pipe' variable in this patch which otherwise causes
failure when patch is compiled individually.

---
 tests/kms_content_protection.c | 182 +++++++++++++++++----------------
 1 file changed, 94 insertions(+), 88 deletions(-)
tests/kms_content_protection.c +44 -76
index 3041f1cd..c32767c8 100644
@@ -170,18 +170,15 @@ static void modeset_with_fb(const enum pipe pipe, igt_output_t *output,
 			    enum igt_commit_style s)
 {
 	igt_display_t *display = &data.display;
-	drmModeModeInfo mode;
+	drmModeModeInfo *mode;
 	igt_plane_t *primary;
 
-	igt_assert(kmstest_get_connector_default_mode(
-			display->drm_fd, output->config.connector, &mode));
-
-	igt_output_override_mode(output, &mode);
+	mode = igt_output_get_mode(output);
 	igt_output_set_pipe(output, pipe);
 
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 	igt_plane_set_fb(primary, &data.red);
-	igt_fb_set_size(&data.red, primary, mode.hdisplay, mode.vdisplay);
+	igt_fb_set_size(&data.red, primary, mode->hdisplay, mode->vdisplay);
 
 	igt_display_commit2(display, s);
 
@@ -317,90 +314,61 @@ static bool write_srm_as_fw(const __u8 *srm, int len)
 }
 
 static void test_content_protection_on_output(igt_output_t *output,
+					      enum pipe pipe,
 					      enum igt_commit_style s,
 					      int content_type)
 {
 	igt_display_t *display = &data.display;
-	igt_plane_t *primary;
-	enum pipe pipe;
 	bool ret;
 
-	for_each_pipe(display, pipe) {
-		if (!igt_pipe_connector_valid(pipe, output))
-			continue;
-
-		/*
-		 * If previous subtest of connector failed, pipe
-		 * attached to that connector is not released.
-		 * Because of that we have to choose the non
-		 * attached pipe for this subtest.
-		 */
-		if (!igt_pipe_is_free(display, pipe))
-			continue;
-
-		modeset_with_fb(pipe, output, s);
-		test_cp_enable_with_retry(output, s, 3, content_type, false,
-					  false);
-
-		if (data.cp_tests & CP_TYPE_CHANGE) {
-			/* Type 1 -> Type 0 */
-			test_cp_enable_with_retry(output, s, 3,
-						  HDCP_CONTENT_TYPE_0, false,
-						  true);
-			/* Type 0 -> Type 1 */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, false,
-						  true);
-		}
-
-		if (data.cp_tests & CP_MEI_RELOAD) {
-			igt_assert_f(!igt_kmod_unload("mei_hdcp", 0),
-				     "mei_hdcp unload failed");
+	test_cp_enable_with_retry(output, s, 3, content_type, false,
+				  false);
+
+	if (data.cp_tests & CP_TYPE_CHANGE) {
+		/* Type 1 -> Type 0 */
+		test_cp_enable_with_retry(output, s, 3,
+					  HDCP_CONTENT_TYPE_0, false,
+					  true);
+		/* Type 0 -> Type 1 */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, false,
+					  true);
+	}
 
-			/* Expected to fail */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, true, false);
+	if (data.cp_tests & CP_MEI_RELOAD) {
+		igt_assert_f(!igt_kmod_unload("mei_hdcp", 0),
+			     "mei_hdcp unload failed");
 
-			igt_assert_f(!igt_kmod_load("mei_hdcp", NULL),
-				     "mei_hdcp load failed");
+		/* Expected to fail */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, true, false);
 
-			/* Expected to pass */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, false, false);
-		}
+		igt_assert_f(!igt_kmod_load("mei_hdcp", NULL),
+			     "mei_hdcp load failed");
 
-		if (data.cp_tests & CP_LIC)
-			test_cp_lic(output);
+		/* Expected to pass */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, false, false);
+	}
 
-		if (data.cp_tests & CP_DPMS) {
-			igt_pipe_set_prop_value(display, pipe,
-						IGT_CRTC_ACTIVE, 0);
-			igt_display_commit2(display, s);
+	if (data.cp_tests & CP_LIC)
+		test_cp_lic(output);
 
-			igt_pipe_set_prop_value(display, pipe,
-						IGT_CRTC_ACTIVE, 1);
-			igt_display_commit2(display, s);
+	if (data.cp_tests & CP_DPMS) {
+		igt_pipe_set_prop_value(display, pipe,
+					IGT_CRTC_ACTIVE, 0);
+		igt_display_commit2(display, s);
 
-			ret = wait_for_prop_value(output, CP_ENABLED,
-						  KERNEL_AUTH_TIME_ALLOWED_MSEC);
-			if (!ret)
-				test_cp_enable_with_retry(output, s, 2,
-							  content_type, false,
-							  false);
-		}
+		igt_pipe_set_prop_value(display, pipe,
+					IGT_CRTC_ACTIVE, 1);
+		igt_display_commit2(display, s);
 
-		test_cp_disable(output, s);
-		primary = igt_output_get_plane_type(output,
-						    DRM_PLANE_TYPE_PRIMARY);
-		igt_plane_set_fb(primary, NULL);
-		igt_output_set_pipe(output, PIPE_NONE);
-
-		/*
-		 * Testing a output with a pipe is enough for HDCP
-		 * testing. No ROI in testing the connector with other
-		 * pipes. So Break the loop on pipe.
-		 */
-		break;
+		ret = wait_for_prop_value(output, CP_ENABLED,
+					  KERNEL_AUTH_TIME_ALLOWED_MSEC);
+		if (!ret)
+			test_cp_enable_with_retry(output, s, 2,
+						  content_type, false,
+						  false);
 	}
 }
 

tests/kms_content_protection.c static bool sink_hdcp2_capable(igt_output_t *output) · line 430

Quoted 6 lines
tests/kms_content_protection.c +2 -1
@@ -458,7 +426,8 @@ static bool sink_hdcp2_capable(igt_output_t *output)
 	return strstr(buf, "HDCP2.2");
 }
 
-static void prepare_modeset_on_mst_output(igt_output_t *output)
+static void
+prepare_modeset_on_mst_output(igt_output_t *output)

Please drop this and keep old line here. Do not mix cosmetic changes with functional cleanup. Smaller patches are easier to review.

tests/kms_content_protection.c static void prepare_modeset_on_mst_output(igt_output_t *output) · line 450

Quoted 10 lines
tests/kms_content_protection.c +2 -1
 {
 	drmModeModeInfo *mode;
 	igt_plane_t *primary;
@@ -477,7 +446,8 @@ static void prepare_modeset_on_mst_output(igt_output_t *output)
 	igt_plane_set_size(primary, width, height);
 }
 
-static bool output_hdcp_capable(igt_output_t *output, int content_type)
+static bool
+output_hdcp_capable(igt_output_t *output, int content_type)

Same here.

tests/kms_content_protection.c static bool output_hdcp_capable(igt_output_t *output, int content_type) · line 473

Quoted 9 lines
tests/kms_content_protection.c +2 -0
 {
 		if (!output->props[IGT_CONNECTOR_CONTENT_PROTECTION])
 			return false;
@@ -499,22 +469,53 @@ static bool output_hdcp_capable(igt_output_t *output, int content_type)
 		return true;
 }
 
+static void
+test_fini(igt_output_t *output, enum igt_commit_style s)

I would prefere to have it in one line but I see that below is used other convention so it may stay.

Quoted 27 lines
tests/kms_content_protection.c +13 -2
+{
+	igt_plane_t *primary;
+
+	test_cp_disable(output, s);
+	primary = igt_output_get_plane_type(output,
+					    DRM_PLANE_TYPE_PRIMARY);
+	igt_plane_set_fb(primary, NULL);
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_display_commit2(&data.display, s);
+}
+
 static void
 test_content_protection(enum igt_commit_style s, int content_type)
 {
 	igt_display_t *display = &data.display;
 	igt_output_t *output;
 	int valid_tests = 0;
+	enum pipe pipe;
 
 	if (data.cp_tests & CP_MEI_RELOAD)
 		igt_require_f(igt_kmod_is_loaded("mei_hdcp"),
 			      "mei_hdcp module is not loaded\n");
 
 	for_each_connected_output(display, output) {
-		if (!output_hdcp_capable(output, content_type))
-			continue;
+		for_each_pipe(display, pipe) {

tests/kms_content_protection.c static bool output_hdcp_capable(igt_output_t *output, int content_type) · line 508

Quoted 10 lines
tests/kms_content_protection.c +10 -0
+			if (!igt_pipe_connector_valid(pipe, output))
+				continue;
+
+			igt_display_reset(display);
+			modeset_with_fb(pipe, output, s);
+
+			if (!output_hdcp_capable(output, content_type))
+				continue;
+
+			test_content_protection_on_output(output, pipe, s, content_type);

Here should be increasing valid_tests var, see below.

tests/kms_content_protection.c static bool output_hdcp_capable(igt_output_t *output, int content_type) · line 519

Quoted 12 lines
tests/kms_content_protection.c +9 -1
+			test_fini(output, s);
+
+			/*
+			 * Testing a output with a pipe is enough for HDCP
+			 * testing. No ROI in testing the connector with other
+			 * pipes. So Break the loop on pipe.
+			 */
+			break;
+		}
 
-		test_content_protection_on_output(output, s, content_type);
 		valid_tests++;

--------------- ^

imho this one also should be moved after call to
test_content_protection_on_output()

Regards,
Kamil

Quoted 49 lines
tests/kms_content_protection.c +12 -7
 	}
 
@@ -596,6 +597,7 @@ test_content_protection_mst(int content_type)
 	igt_output_t *output;
 	int valid_outputs = 0, dp_mst_outputs = 0, ret, count, max_pipe = 0, i;
 	enum pipe pipe;
+	bool pipe_found;
 	igt_output_t *mst_output[IGT_MAX_PIPES], *hdcp_mst_output[IGT_MAX_PIPES];
 
 	for_each_pipe(display, pipe)
@@ -607,16 +609,20 @@ test_content_protection_mst(int content_type)
 		if (!output_is_dp_mst(output, dp_mst_outputs))
 			continue;
 
-		igt_assert_f(igt_pipe_connector_valid(pipe, output), "Output-pipe combination invalid\n");
+		pipe_found = false;
+		for_each_pipe(display, pipe) {
+			if (igt_pipe_is_free(display, pipe) &&
+			    igt_pipe_connector_valid(pipe, output)) {
+				pipe_found = true;
+				break;
+			}
+		}
+
+		igt_assert_f(pipe_found, "No valid pipe found for %s\n", output->name);
 
 		igt_output_set_pipe(output, pipe);
 		prepare_modeset_on_mst_output(output);
 		mst_output[dp_mst_outputs++] = output;
-
-		pipe++;
-
-		if (pipe > max_pipe)
-			break;
 	}
 
 	igt_require_f(dp_mst_outputs > 1, "No DP MST set up with >= 2 outputs found in a single topology\n");
@@ -694,7 +700,7 @@ static void test_content_protection_cleanup(void)
 			continue;
 
 		igt_info("CP Prop being UNDESIRED on %s\n", output->name);
-		test_cp_disable(output, COMMIT_ATOMIC);
+		test_cp_disable(output, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 	}
 
 	igt_remove_fb(data.drm_fd, &data.red);
Signature · 1 line
2.22.0
#3 lore raw

Re: [igt-dev] [PATCH i-g-t v5 1/2] tests/kms_content_protection: Test Cleanup

Quoted 1 line · Kamil Konieczny

Hi Karthik,

Hi Kamil,

Quoted 10 lines · Karthik B S
Quoted 8 lines

This patch includes:
1.Add a modeset before checking output is HDCP capable.
Test currently skips on multidisplay MST because we're checking if output is HDCP capable before doing a modeset on the output.
2.Call igt_display_reset before starting the subtest. 3.test_fini function added to prepare test for converting to dynamic. 4.Remove redundant mode override.
5.Try other pipe/output combo for MST if failure is seen on one.

Quoted 2 lines

These looks like fix and cleanup, please split out part 1. and 5. into separate patch.

Thank you for the review. Sure, will split this patch.

Quoted 176 lines

I will not comment on kms parts, only some things spotted, see below.

Quoted 173 lines

v2: -Update commit style in test_content_protection_cleanup.

v3: -Declare 'pipe' variable in this patch which otherwise causes
failure when patch is compiled individually.

---
  tests/kms_content_protection.c | 182 +++++++++++++++++----------------
  1 file changed, 94 insertions(+), 88 deletions(-)
tests/kms_content_protection.c +44 -76
index 3041f1cd..c32767c8 100644
@@ -170,18 +170,15 @@ static void modeset_with_fb(const enum pipe pipe, igt_output_t *output,
  			    enum igt_commit_style s)
  {
  	igt_display_t *display = &data.display;
-	drmModeModeInfo mode;
+	drmModeModeInfo *mode;
  	igt_plane_t *primary;
 
-	igt_assert(kmstest_get_connector_default_mode(
-			display->drm_fd, output->config.connector, &mode));
-
-	igt_output_override_mode(output, &mode);
+	mode = igt_output_get_mode(output);
  	igt_output_set_pipe(output, pipe);
 
  	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
  	igt_plane_set_fb(primary, &data.red);
-	igt_fb_set_size(&data.red, primary, mode.hdisplay, mode.vdisplay);
+	igt_fb_set_size(&data.red, primary, mode->hdisplay, mode->vdisplay);
 
  	igt_display_commit2(display, s);
 
@@ -317,90 +314,61 @@ static bool write_srm_as_fw(const __u8 *srm, int len)
  }
 
  static void test_content_protection_on_output(igt_output_t *output,
+					      enum pipe pipe,
  					      enum igt_commit_style s,
  					      int content_type)
  {
  	igt_display_t *display = &data.display;
-	igt_plane_t *primary;
-	enum pipe pipe;
  	bool ret;
 
-	for_each_pipe(display, pipe) {
-		if (!igt_pipe_connector_valid(pipe, output))
-			continue;
-
-		/*
-		 * If previous subtest of connector failed, pipe
-		 * attached to that connector is not released.
-		 * Because of that we have to choose the non
-		 * attached pipe for this subtest.
-		 */
-		if (!igt_pipe_is_free(display, pipe))
-			continue;
-
-		modeset_with_fb(pipe, output, s);
-		test_cp_enable_with_retry(output, s, 3, content_type, false,
-					  false);
-
-		if (data.cp_tests & CP_TYPE_CHANGE) {
-			/* Type 1 -> Type 0 */
-			test_cp_enable_with_retry(output, s, 3,
-						  HDCP_CONTENT_TYPE_0, false,
-						  true);
-			/* Type 0 -> Type 1 */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, false,
-						  true);
-		}
-
-		if (data.cp_tests & CP_MEI_RELOAD) {
-			igt_assert_f(!igt_kmod_unload("mei_hdcp", 0),
-				     "mei_hdcp unload failed");
+	test_cp_enable_with_retry(output, s, 3, content_type, false,
+				  false);
+
+	if (data.cp_tests & CP_TYPE_CHANGE) {
+		/* Type 1 -> Type 0 */
+		test_cp_enable_with_retry(output, s, 3,
+					  HDCP_CONTENT_TYPE_0, false,
+					  true);
+		/* Type 0 -> Type 1 */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, false,
+					  true);
+	}
 
-			/* Expected to fail */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, true, false);
+	if (data.cp_tests & CP_MEI_RELOAD) {
+		igt_assert_f(!igt_kmod_unload("mei_hdcp", 0),
+			     "mei_hdcp unload failed");
 
-			igt_assert_f(!igt_kmod_load("mei_hdcp", NULL),
-				     "mei_hdcp load failed");
+		/* Expected to fail */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, true, false);
 
-			/* Expected to pass */
-			test_cp_enable_with_retry(output, s, 3,
-						  content_type, false, false);
-		}
+		igt_assert_f(!igt_kmod_load("mei_hdcp", NULL),
+			     "mei_hdcp load failed");
 
-		if (data.cp_tests & CP_LIC)
-			test_cp_lic(output);
+		/* Expected to pass */
+		test_cp_enable_with_retry(output, s, 3,
+					  content_type, false, false);
+	}
 
-		if (data.cp_tests & CP_DPMS) {
-			igt_pipe_set_prop_value(display, pipe,
-						IGT_CRTC_ACTIVE, 0);
-			igt_display_commit2(display, s);
+	if (data.cp_tests & CP_LIC)
+		test_cp_lic(output);
 
-			igt_pipe_set_prop_value(display, pipe,
-						IGT_CRTC_ACTIVE, 1);
-			igt_display_commit2(display, s);
+	if (data.cp_tests & CP_DPMS) {
+		igt_pipe_set_prop_value(display, pipe,
+					IGT_CRTC_ACTIVE, 0);
+		igt_display_commit2(display, s);
 
-			ret = wait_for_prop_value(output, CP_ENABLED,
-						  KERNEL_AUTH_TIME_ALLOWED_MSEC);
-			if (!ret)
-				test_cp_enable_with_retry(output, s, 2,
-							  content_type, false,
-							  false);
-		}
+		igt_pipe_set_prop_value(display, pipe,
+					IGT_CRTC_ACTIVE, 1);
+		igt_display_commit2(display, s);
 
-		test_cp_disable(output, s);
-		primary = igt_output_get_plane_type(output,
-						    DRM_PLANE_TYPE_PRIMARY);
-		igt_plane_set_fb(primary, NULL);
-		igt_output_set_pipe(output, PIPE_NONE);
-
-		/*
-		 * Testing a output with a pipe is enough for HDCP
-		 * testing. No ROI in testing the connector with other
-		 * pipes. So Break the loop on pipe.
-		 */
-		break;
+		ret = wait_for_prop_value(output, CP_ENABLED,
+					  KERNEL_AUTH_TIME_ALLOWED_MSEC);
+		if (!ret)
+			test_cp_enable_with_retry(output, s, 2,
+						  content_type, false,
+						  false);
  	}
  }
 
@@ -458,7 +426,8 @@ static bool sink_hdcp2_capable(igt_output_t *output)
  	return strstr(buf, "HDCP2.2");
  }
 
Quoted 6 lines

tests/kms_content_protection.c static bool sink_hdcp2_capable(igt_output_t *output) · line 430

Quoted 3 lines
tests/kms_content_protection.c +2 -1
-static void prepare_modeset_on_mst_output(igt_output_t *output)
+static void
+prepare_modeset_on_mst_output(igt_output_t *output)

Please drop this and keep old line here. Do not mix cosmetic changes with functional cleanup. Smaller patches are easier to review.

Sure, will update this.

Quoted 8 lines
Quoted 8 lines
tests/kms_content_protection.c +0 -0
  {
  	drmModeModeInfo *mode;
  	igt_plane_t *primary;
@@ -477,7 +446,8 @@ static void prepare_modeset_on_mst_output(igt_output_t *output)
  	igt_plane_set_size(primary, width, height);
  }
 
Quoted 4 lines

tests/kms_content_protection.c static void prepare_modeset_on_mst_output(igt_output_t *output) · line 450

Quoted 3 lines
tests/kms_content_protection.c +2 -1
-static bool output_hdcp_capable(igt_output_t *output, int content_type)
+static bool
+output_hdcp_capable(igt_output_t *output, int content_type)

Same here.

Sure.

Quoted 8 lines
Quoted 8 lines
tests/kms_content_protection.c +0 -0
  {
  		if (!output->props[IGT_CONNECTOR_CONTENT_PROTECTION])
  			return false;
@@ -499,22 +469,53 @@ static bool output_hdcp_capable(igt_output_t *output, int content_type)
  		return true;
  }
 
Quoted 4 lines

tests/kms_content_protection.c static bool output_hdcp_capable(igt_output_t *output, int content_type) · line 473

Quoted 2 lines
tests/kms_content_protection.c +2 -0
+static void
+test_fini(igt_output_t *output, enum igt_commit_style s)

I would prefere to have it in one line but I see that below is used other convention so it may stay.

Okay.

Quoted 50 lines
Quoted 28 lines
tests/kms_content_protection.c +13 -2
+{
+	igt_plane_t *primary;
+
+	test_cp_disable(output, s);
+	primary = igt_output_get_plane_type(output,
+					    DRM_PLANE_TYPE_PRIMARY);
+	igt_plane_set_fb(primary, NULL);
+	igt_output_set_pipe(output, PIPE_NONE);
+	igt_display_commit2(&data.display, s);
+}
+
  static void
  test_content_protection(enum igt_commit_style s, int content_type)
  {
  	igt_display_t *display = &data.display;
  	igt_output_t *output;
  	int valid_tests = 0;
+	enum pipe pipe;
 
  	if (data.cp_tests & CP_MEI_RELOAD)
  		igt_require_f(igt_kmod_is_loaded("mei_hdcp"),
  			      "mei_hdcp module is not loaded\n");
 
  	for_each_connected_output(display, output) {
-		if (!output_hdcp_capable(output, content_type))
-			continue;
+		for_each_pipe(display, pipe) {

tests/kms_content_protection.c static bool output_hdcp_capable(igt_output_t *output, int content_type) · line 508

Quoted 10 lines
tests/kms_content_protection.c +10 -0
+			if (!igt_pipe_connector_valid(pipe, output))
+				continue;
+
+			igt_display_reset(display);
+			modeset_with_fb(pipe, output, s);
+
+			if (!output_hdcp_capable(output, content_type))
+				continue;
+
+			test_content_protection_on_output(output, pipe, s, content_type);

Here should be increasing valid_tests var, see below.

Quoted 10 lines
tests/kms_content_protection.c +9 -0
+			test_fini(output, s);
+
+			/*
+			 * Testing a output with a pipe is enough for HDCP
+			 * testing. No ROI in testing the connector with other
+			 * pipes. So Break the loop on pipe.
+			 */
+			break;
+		}
 
Quoted 6 lines

tests/kms_content_protection.c static bool output_hdcp_capable(igt_output_t *output, int content_type) · line 519

Quoted 2 lines
tests/kms_content_protection.c +0 -1
-		test_content_protection_on_output(output, s, content_type);
  		valid_tests++;

--------------- ^

imho this one also should be moved after call to
test_content_protection_on_output()

Sure will move this.

Thanks,
Karthik.B.S

Quoted 53 lines

Regards,
Kamil

Quoted 49 lines
tests/kms_content_protection.c +12 -7
  	}
 
@@ -596,6 +597,7 @@ test_content_protection_mst(int content_type)
  	igt_output_t *output;
  	int valid_outputs = 0, dp_mst_outputs = 0, ret, count, max_pipe = 0, i;
  	enum pipe pipe;
+	bool pipe_found;
  	igt_output_t *mst_output[IGT_MAX_PIPES], *hdcp_mst_output[IGT_MAX_PIPES];
 
  	for_each_pipe(display, pipe)
@@ -607,16 +609,20 @@ test_content_protection_mst(int content_type)
  		if (!output_is_dp_mst(output, dp_mst_outputs))
  			continue;
 
-		igt_assert_f(igt_pipe_connector_valid(pipe, output), "Output-pipe combination invalid\n");
+		pipe_found = false;
+		for_each_pipe(display, pipe) {
+			if (igt_pipe_is_free(display, pipe) &&
+			    igt_pipe_connector_valid(pipe, output)) {
+				pipe_found = true;
+				break;
+			}
+		}
+
+		igt_assert_f(pipe_found, "No valid pipe found for %s\n", output->name);
 
  		igt_output_set_pipe(output, pipe);
  		prepare_modeset_on_mst_output(output);
  		mst_output[dp_mst_outputs++] = output;
-
-		pipe++;
-
-		if (pipe > max_pipe)
-			break;
  	}
 
  	igt_require_f(dp_mst_outputs > 1, "No DP MST set up with >= 2 outputs found in a single topology\n");
@@ -694,7 +700,7 @@ static void test_content_protection_cleanup(void)
  			continue;
 
  		igt_info("CP Prop being UNDESIRED on %s\n", output->name);
-		test_cp_disable(output, COMMIT_ATOMIC);
+		test_cp_disable(output, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
  	}
 
  	igt_remove_fb(data.drm_fd, &data.red);
Signature · 1 line
2.22.0
#4 lore raw

PATCH v5 2/2 tests/kms_content_protection: Convert test to dynamic

In reply to Karthik B S

Covert the existing subtests to dynamic subtests at pipe/output level.

---
 tests/kms_content_protection.c | 219 +++++++++++++++++++--------------
 1 file changed, 125 insertions(+), 94 deletions(-)
tests/kms_content_protection.c +125 -94
index c32767c8..1bfa5ada 100644
@@ -487,13 +487,17 @@ test_content_protection(enum igt_commit_style s, int content_type)
 {
 	igt_display_t *display = &data.display;
 	igt_output_t *output;
-	int valid_tests = 0;
 	enum pipe pipe;
 
 	if (data.cp_tests & CP_MEI_RELOAD)
 		igt_require_f(igt_kmod_is_loaded("mei_hdcp"),
 			      "mei_hdcp module is not loaded\n");
 
+	if (data.cp_tests & CP_UEVENT) {
+		data.uevent_monitor = igt_watch_uevents();
+		igt_flush_uevents(data.uevent_monitor);
+	}
+
 	for_each_connected_output(display, output) {
 		for_each_pipe(display, pipe) {
 			if (!igt_pipe_connector_valid(pipe, output))
@@ -505,9 +509,10 @@ test_content_protection(enum igt_commit_style s, int content_type)
 			if (!output_hdcp_capable(output, content_type))
 				continue;
 
-			test_content_protection_on_output(output, pipe, s, content_type);
-			test_fini(output, s);
+			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+				test_content_protection_on_output(output, pipe, s, content_type);
 
+			test_fini(output, s);
 			/*
 			 * Testing a output with a pipe is enough for HDCP
 			 * testing. No ROI in testing the connector with other
@@ -515,11 +520,10 @@ test_content_protection(enum igt_commit_style s, int content_type)
 			 */
 			break;
 		}
-
-		valid_tests++;
 	}
 
-	igt_require_f(valid_tests, "No connector found with HDCP capability\n");
+	if (data.cp_tests & CP_UEVENT)
+		igt_cleanup_uevents(data.uevent_monitor);
 }
 
 static int parse_path_blob(char *blob_data)
@@ -729,6 +733,94 @@ static void create_fbs(void)
 			    0.f, 1.f, 0.f, &data.green);
 }
 
+static const struct {
+	const char *desc;
+	const char *name;
+	unsigned int cp_tests;
+	bool content_type;
+} subtests[] = {
+	{ .desc = "Test content protection with atomic modesetting",
+	  .name = "atomic",
+	  .cp_tests = 0,
+	  .content_type = HDCP_CONTENT_TYPE_0
+	},
+	{ .desc = "Test content protection with DPMS ON/OFF during atomic modesetting.",
+	  .name = "atomic-dpms",
+	  .cp_tests = CP_DPMS,
+	  .content_type = HDCP_CONTENT_TYPE_0
+	},
+	{ .desc = "Test for the integrity of link.",
+	  .name = "LIC",
+	  .cp_tests = CP_LIC,
+	  .content_type = HDCP_CONTENT_TYPE_0,
+	},
+	{ .desc = "Test content protection with content type 1 "
+		  "that can be handled only through HDCP2.2.",
+	  .name = "type1",
+	  .cp_tests = 0,
+	  .content_type = HDCP_CONTENT_TYPE_1,
+	},
+	{ .desc = "Test the teardown and rebuild of the interface between "
+		  "I915 and mei hdcp.",
+	  .name = "mei_interface",
+	  .cp_tests = CP_MEI_RELOAD,
+	  .content_type = HDCP_CONTENT_TYPE_1,
+	},
+	{ .desc = "Test the content type change when the content protection already enabled",
+	  .name = "content_type_change",
+	  .cp_tests = CP_TYPE_CHANGE,
+	  .content_type = HDCP_CONTENT_TYPE_1,
+	},
+	{ .desc = "Test to detect the HDCP status change when we are reading the uevent "
+		  "sent with the corresponding connector id and property id.",
+	  .name = "uevent",
+	  .cp_tests = CP_UEVENT,
+	  .content_type = HDCP_CONTENT_TYPE_0,
+	},
+	/*
+	 *  Testing the revocation check through SRM needs a HDCP sink with
+	 *  programmable Ksvs or we need a uAPI from kernel to read the
+	 *  connected HDCP sink's Ksv. With that we would be able to add that
+	 *  Ksv into a SRM and send in for revocation check. Since we dont have
+	 *  either of these options, we test SRM writing from userspace and
+	 *  validation of the same at kernel. Something is better than nothing.
+	 */
+	{ .desc = "This test writes the facsimile SRM into the /lib/firmware/ "
+		  "and check the kernel parsing of it by invoking the hdcp authentication.",
+	  .name = "srm",
+	  .cp_tests = 0,
+	  .content_type = HDCP_CONTENT_TYPE_0,
+	},
+};
+
+static const struct {
+	const char *desc;
+	const char *name;
+	unsigned int cp_tests;
+	bool content_type;
+} mst_subtests[] = {
+	{ .desc = "Test Content protection(Type 0) over DP MST.",
+	  .name = "dp-mst-type-0",
+	  .cp_tests = 0,
+	  .content_type = HDCP_CONTENT_TYPE_0
+	},
+	{ .desc = "Test Content protection(Type 0) over DP MST with LIC.",
+	  .name = "dp-mst-lic-type-0",
+	  .cp_tests = CP_LIC,
+	  .content_type = HDCP_CONTENT_TYPE_0
+	},
+	{ .desc = "Test Content protection(Type 1) over DP MST.",
+	  .name = "dp-mst-type-1",
+	  .cp_tests = 0,
+	  .content_type = HDCP_CONTENT_TYPE_1,
+	},
+	{ .desc = "Test Content protection(Type 1) over DP MST with LIC.",
+	  .name = "dp-mst-lic-type-1",
+	  .cp_tests = CP_LIC,
+	  .content_type = HDCP_CONTENT_TYPE_1,
+	},
+};
+
 igt_main
 {
 	igt_fixture {
@@ -739,107 +831,46 @@ igt_main
 	}
 
 	igt_describe("Test content protection with legacy style commit.");
-	igt_subtest("legacy") {
+	igt_subtest_with_dynamic("legacy") {
 		data.cp_tests = 0;
 		test_content_protection(COMMIT_LEGACY, HDCP_CONTENT_TYPE_0);
 	}
 
-	igt_describe("Test content protection with atomic modesetting");
-	igt_subtest("atomic") {
-		igt_require(data.display.is_atomic);
-		data.cp_tests = 0;
-		test_content_protection(COMMIT_ATOMIC, HDCP_CONTENT_TYPE_0);
-	}
-
-	igt_describe("Test content protection with DPMS ON/OFF during atomic modesetting.");
-	igt_subtest("atomic-dpms") {
-		igt_require(data.display.is_atomic);
-		data.cp_tests = CP_DPMS;
-		test_content_protection(COMMIT_ATOMIC, HDCP_CONTENT_TYPE_0);
-	}
-
-	igt_describe("Test for the integrity of link.");
-	igt_subtest("LIC") {
-		igt_require(data.display.is_atomic);
-		data.cp_tests = CP_LIC;
-		test_content_protection(COMMIT_ATOMIC, HDCP_CONTENT_TYPE_0);
-	}
-
-	igt_describe("Test content protection with content type 1 that "
-		     "can be handled only through HDCP2.2.");
-	igt_subtest("type1") {
-		igt_require(data.display.is_atomic);
-		test_content_protection(COMMIT_ATOMIC, HDCP_CONTENT_TYPE_1);
-	}
+	igt_subtest_group {
+		igt_fixture
+			igt_require(data.display.is_atomic);
 
-	igt_describe("Test the teardown and rebuild of the interface between "
-		     "I915 and mei hdcp.");
-	igt_subtest("mei_interface") {
-		igt_require(data.display.is_atomic);
-		data.cp_tests = CP_MEI_RELOAD;
-		test_content_protection(COMMIT_ATOMIC, HDCP_CONTENT_TYPE_1);
-	}
+		for (int i = 0; i < ARRAY_SIZE(subtests); i++) {
+			igt_describe_f("%s", subtests[i].desc);
 
-	igt_describe("Test the content type change when the content protection already "
-		     "enabled.");
-	igt_subtest("content_type_change") {
-		igt_require(data.display.is_atomic);
-		data.cp_tests = CP_TYPE_CHANGE;
-		test_content_protection(COMMIT_ATOMIC, HDCP_CONTENT_TYPE_1);
-	}
+			igt_subtest_with_dynamic(subtests[i].name) {
+				data.cp_tests = subtests[i].cp_tests;
 
-	igt_describe("Test to detect the HDCP status change when we are reading the uevent "
-		     "sent with the corresponding connector id and property id.");
-	igt_subtest("uevent") {
-		igt_require(data.display.is_atomic);
-		data.cp_tests = CP_UEVENT;
-		data.uevent_monitor = igt_watch_uevents();
-		igt_flush_uevents(data.uevent_monitor);
-		test_content_protection(COMMIT_ATOMIC, HDCP_CONTENT_TYPE_0);
-		igt_cleanup_uevents(data.uevent_monitor);
-	}
+				if (!strcmp(subtests[i].name, "srm")) {
+					bool ret;
 
-	/*
-	 *  Testing the revocation check through SRM needs a HDCP sink with
-	 *  programmable Ksvs or we need a uAPI from kernel to read the
-	 *  connected HDCP sink's Ksv. With that we would be able to add that
-	 *  Ksv into a SRM and send in for revocation check. Since we dont have
-	 *  either of these options, we test SRM writing from userspace and
-	 *  validation of the same at kernel. Something is better than nothing.
-	 */
-	igt_describe("This test writes the facsimile SRM into the /lib/firmware/ "
-		     "and check the kernel parsing of it by invoking the hdcp authentication.");
-	igt_subtest("srm") {
-		bool ret;
-
-		igt_require(data.display.is_atomic);
-		data.cp_tests = 0;
-		ret = write_srm_as_fw((const __u8 *)facsimile_srm,
-				      sizeof(facsimile_srm));
-		igt_assert_f(ret, "SRM update failed");
-		test_content_protection(COMMIT_ATOMIC, HDCP_CONTENT_TYPE_0);
-	}
+					ret = write_srm_as_fw((const __u8 *)facsimile_srm,
+							     sizeof(facsimile_srm));
+					igt_assert_f(ret, "SRM update failed");
+				}
 
-	igt_describe("Test Content protection over DP MST");
-	igt_subtest("dp-mst-type-0") {
-		test_content_protection_mst(HDCP_CONTENT_TYPE_0);
+				test_content_protection(COMMIT_ATOMIC, subtests[i].content_type);
+			}
+		}
 	}
 
-	igt_describe("Test Content protection over DP MST with LIC");
-	igt_subtest("dp-mst-lic-type-0") {
-		data.cp_tests = CP_LIC;
-		test_content_protection_mst(HDCP_CONTENT_TYPE_0);
-	}
+	igt_subtest_group {
+		igt_fixture
+			igt_require(data.display.is_atomic);
 
-	igt_describe("Test Content protection over DP MST");
-	igt_subtest("dp-mst-type-1") {
-		test_content_protection_mst(HDCP_CONTENT_TYPE_1);
-	}
+		for (int i = 0; i < ARRAY_SIZE(mst_subtests); i++) {
+			igt_describe_f("%s", mst_subtests[i].desc);
 
-	igt_describe("Test Content protection over DP MST with LIC");
-	igt_subtest("dp-mst-lic-type-1") {
-		data.cp_tests = CP_LIC;
-		test_content_protection_mst(HDCP_CONTENT_TYPE_1);
+			igt_subtest(mst_subtests[i].name) {
+				data.cp_tests = mst_subtests[i].cp_tests;
+				test_content_protection_mst(mst_subtests[i].content_type);
+			}
+		}
 	}
 
 	igt_fixture {
Signature · 1 line
2.22.0
#5 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_content_protection: Test Refactoring (rev3)

In reply to Karthik B S
== Series Details ==

== Series Details ==

Series: tests/kms_content_protection: Test Refactoring (rev3)
URL : https://patchwork.freedesktop.org/series/108484/
State : success

== Summary ==

CI Bug Log - changes from IGT_6667 -> IGTPW_7855
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/index.html

Participating hosts (45 -> 44)
------------------------------

Missing (1): fi-bdw-samus

Known issues
------------

Here are the changes found in IGTPW_7855 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][1] ([i915#4312])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/fi-bdw-5557u/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3@smem:
- {bat-adlm-1}: [DMESG-WARN][2] ([i915#2867]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/bat-adlm-1/igt@gem_exec_suspend@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2:
- {bat-dg2-11}: [FAIL][4] ([i915#6818]) -> [PASS][5] +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/bat-dg2-11/igt@kms_pipe_crc_basic@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/bat-dg2-11/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6667 -> IGTPW_7855

CI-20190529: 20190529
CI_DRM_12193: 0f0716dcfd8446cde4391475c9c3656ca670b55f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7855: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/index.html
IGT_6667: 97ec0c0a3c6b9d02a4f63cf4ac699cee3dc6ac53 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/index.html

#6 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_content_protection: Test Refactoring (rev3)

In reply to Karthik B S
== Series Details ==

== Series Details ==

Series: tests/kms_content_protection: Test Refactoring (rev3)
URL : https://patchwork.freedesktop.org/series/108484/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6667_full -> IGTPW_7855_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7855_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7855_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/index.html

Participating hosts (7 -> 6)
------------------------------

Missing (1): shard-rkl

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7855_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_async_flips@crc@pipe-a-edp-1:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-tglb2/igt@kms_async_flips@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb8/igt@kms_async_flips@[email protected]

* {igt@kms_content_protection@lic@pipe-a-dp-1} (NEW):
- shard-apl: NOTRUN -> [INCOMPLETE][3] +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl7/igt@kms_content_protection@[email protected]

* {igt@kms_content_protection@uevent@pipe-a-dp-1} (NEW):
- shard-apl: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl8/igt@kms_content_protection@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-tglb: NOTRUN -> [SKIP][5] +31 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid:
- shard-iclb: NOTRUN -> [SKIP][6] +34 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

#### Warnings ####

* igt@kms_content_protection@atomic-dpms:
- shard-tglb: [SKIP][7] ([i915#1063]) -> [SKIP][8] +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-tglb3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb7/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-iclb: [SKIP][9] ([fdo#109300] / [fdo#111066]) -> [SKIP][10] +6 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

New tests
---------

New tests have been introduced between IGT_6667_full and IGTPW_7855_full:

### New IGT tests (5) ###

* igt@kms_content_protection@atomic-dpms@pipe-a-dp-1:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s

* igt@kms_content_protection@atomic@pipe-a-dp-1:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s

* igt@kms_content_protection@lic@pipe-a-dp-1:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s

* igt@kms_content_protection@srm@pipe-a-dp-1:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s

* igt@kms_content_protection@uevent@pipe-a-dp-1:
- Statuses : 1 fail(s)
- Exec time: [34.73] s

Known issues
------------

Here are the changes found in IGTPW_7855_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@close-race:
- shard-snb: [PASS][11] -> [TIMEOUT][12] ([i915#5748])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-snb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-snb7/igt@[email protected]

* igt@gem_ccs@suspend-resume:
- shard-iclb: NOTRUN -> [SKIP][13] ([i915#5327])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@[email protected]

* igt@gem_ctx_persistence@process:
- shard-snb: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#1099]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-snb4/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [PASS][15] -> [SKIP][16] ([i915#4525])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@[email protected]

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: NOTRUN -> [SKIP][17] ([i915#4525])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb5/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: NOTRUN -> [FAIL][18] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk3/igt@gem_exec_fair@[email protected]
- shard-tglb: NOTRUN -> [FAIL][19] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][20] -> [FAIL][21] ([i915#2842]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-glk5/igt@gem_exec_fair@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-iclb: NOTRUN -> [SKIP][22] ([i915#4613]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][23] ([i915#4613])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk3/igt@[email protected]

* igt@gem_pxp@regular-baseline-src-copy-readible:
- shard-tglb: NOTRUN -> [SKIP][25] ([i915#4270])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb7/igt@[email protected]

* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#4270]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb6/igt@[email protected]

* igt@gem_softpin@evict-single-offset:
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#4171])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-tglb1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb8/igt@[email protected]

* igt@gem_userptr_blits@access-control:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#3297])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#3297])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb1/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-iclb: NOTRUN -> [DMESG-WARN][31] ([i915#4991])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]
- shard-snb: NOTRUN -> [DMESG-WARN][32] ([i915#4991])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-snb5/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-WARN][33] ([i915#4991])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb5/igt@[email protected]
- shard-glk: NOTRUN -> [DMESG-WARN][34] ([i915#4991])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk6/igt@[email protected]

* igt@gen7_exec_parse@basic-allocation:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109289]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb1/igt@[email protected]

* igt@gen7_exec_parse@load-register-reg:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109289])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb3/igt@[email protected]

* igt@gen9_exec_parse@bb-start-param:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#2856]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@[email protected]

* igt@i915_selftest@mock@sanitycheck:
- shard-snb: [PASS][38] -> [SKIP][39] ([fdo#109271])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-snb5/igt@i915_selftest@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-snb6/igt@i915_selftest@[email protected]

* igt@kms_atomic@atomic_plane_damage:
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#4765])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@kms_atomic@atomic_plane_damage.html

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#1769] / [i915#3555])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb5/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html

* igt@kms_big_fb@4-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#5286])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@[email protected]

* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#111614])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb1/igt@[email protected]

* igt@kms_big_fb@y-tiled-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#110725] / [fdo#111614]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][45] ([fdo#111615])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#110723])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#6095])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb1/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_mc_ccs.html

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109278] / [i915#3886])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb7/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#3689] / [i915#6095]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb8/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html

* igt@kms_ccs@pipe-d-bad-aux-stride-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#111615] / [i915#3689]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb1/igt@kms_ccs@pipe-d-bad-aux-stride-yf_tiled_ccs.html

* igt@kms_cdclk@plane-scaling:
- shard-iclb: NOTRUN -> [SKIP][52] ([i915#3742])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#3742])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb8/igt@[email protected]

* igt@kms_chamelium@dp-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109284] / [fdo#111827]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-multiple:
- shard-glk: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk3/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-snb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109284] / [fdo#111827])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb3/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +4 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl2/igt@[email protected]

* igt@kms_cursor_crc@cursor-random-512x512:
- shard-iclb: NOTRUN -> [SKIP][59] ([i915#3359])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#3359])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb8/igt@[email protected]

* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109274]) +10 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@[email protected]

* igt@kms_flip@2x-wf_vblank-ts-check-interruptible:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109274] / [fdo#111825] / [i915#3637]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb1/igt@kms_flip@2x-wf_vblank-ts-check-interruptible.html

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#2672]) +6 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][64] -> [SKIP][65] ([i915#3555])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#2587] / [i915#2672]) +3 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#3555]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][68] ([i915#2587] / [i915#2672]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#2672] / [i915#3555])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109280]) +18 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][71] -> [DMESG-WARN][72] ([i915#180]) +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl8/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#6497]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109280] / [fdo#111825]) +6 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271]) +171 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3555])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb7/igt@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-d-edp-1:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#5176]) +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb8/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#5176]) +5 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb5/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-a-edp-1:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#5235]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][80] -> [SKIP][81] ([i915#5235]) +5 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html

* igt@kms_prime@basic-crc-hybrid:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#6524])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb7/igt@[email protected]

* igt@kms_psr@psr2_primary_render:
- shard-tglb: NOTRUN -> [FAIL][83] ([i915#132] / [i915#3467])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb8/igt@kms_psr@psr2_primary_render.html
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109441])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@kms_psr@psr2_primary_render.html

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][85] -> [SKIP][86] ([fdo#109441]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_rotation_crc@primary-4-tiled-reflect-x-180:
- shard-iclb: NOTRUN -> [SKIP][87] ([i915#5289])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][88] ([i915#5289])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb2/igt@[email protected]

* igt@kms_vblank@pipe-d-query-forked-hang:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109278]) +10 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

* igt@nouveau_crc@pipe-b-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#6971]) +46 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb5/igt@[email protected]

* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-glk: NOTRUN -> [SKIP][91] ([fdo#109271]) +115 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk2/igt@[email protected]

* igt@prime_nv_pcopy@test3_5:
- shard-snb: NOTRUN -> [SKIP][92] ([fdo#109271]) +131 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-snb5/igt@prime_nv_pcopy@test3_5.html

* igt@prime_nv_test@i915_blt_fill_nv_read:
- shard-iclb: NOTRUN -> [SKIP][93] ([i915#6971]) +47 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@prime_nv_test@i915_blt_fill_nv_read.html

* igt@prime_vgem@fence-write-hang:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109295])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

* igt@sysfs_clients@split-50:
- shard-iclb: NOTRUN -> [SKIP][95] ([i915#2994])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

#### Possible fixes ####

* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [TIMEOUT][96] ([i915#3063]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl3/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl2/igt@[email protected]

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][98] ([i915#4525]) -> [PASS][99] +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb3/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb4/igt@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][100] ([i915#2842]) -> [PASS][101] +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-glk3/igt@gem_exec_fair@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][102] ([i915#6537]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl3/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl2/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: [DMESG-FAIL][104] ([i915#118] / [i915#1888]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-glk2/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk6/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][106] ([i915#2346]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-glk1/igt@kms_cursor_legacy@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-glk3/igt@kms_cursor_legacy@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][108] ([i915#180] / [i915#1982] / [i915#4939]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl8/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl3/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][110] ([i915#3555]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu:
- shard-snb: [SKIP][112] ([fdo#109271]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-snb2/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-snb6/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [DMESG-WARN][114] ([i915#180]) -> [PASS][115] +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl6/igt@kms_hdr@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl2/igt@kms_hdr@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][116] ([i915#5235]) -> [PASS][117] +2 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb2/igt@kms_plane_scaling@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb1/igt@kms_plane_scaling@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][118] ([fdo#109441]) -> [PASS][119] +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [SKIP][120] ([i915#5519]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb4/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb8/igt@[email protected]

#### Warnings ####

* igt@kms_content_protection@uevent:
- shard-tglb: [SKIP][122] ([i915#1063]) -> [SKIP][123] ([i915#6944])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-tglb7/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-tglb7/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][124] ([i915#658]) -> [SKIP][125] ([i915#2920])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb4/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][126] ([i915#2920]) -> [SKIP][127] ([i915#658])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb2/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb3/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][128] ([i915#2920]) -> [SKIP][129] ([fdo#111068] / [i915#658]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-iclb2/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-iclb4/igt@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140]) ([fdo#109271] / [i915#180] / [i915#4312])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl8/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl3/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl6/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl2/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl8/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6667/shard-apl7/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl8/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl3/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl6/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl1/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/shard-apl1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4765]: https://gitlab.freedesktop.org/drm/intel/issues/4765
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5748]: https://gitlab.freedesktop.org/drm/intel/issues/5748
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6971]: https://gitlab.freedesktop.org/drm/intel/issues/6971

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6667 -> IGTPW_7855

CI-20190529: 20190529
CI_DRM_12193: 0f0716dcfd8446cde4391475c9c3656ca670b55f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7855: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/index.html
IGT_6667: 97ec0c0a3c6b9d02a4f63cf4ac699cee3dc6ac53 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7855/index.html