add device Xiaomi Mi 6 (codename sagit) and board binding
v5 cover add device Xiaomi Mi 6 (codename sagit) and board binding
Add initial support for Xiaomi Mi 6 phone (codename sagit)
Dzmitry Sankouski (2):
arm64: dts: qcom: sagit: add initial device tree for sagit
dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/msm8998-xiaomi-sagit.dts | 687 ++++++++++++++++++ arch/arm64/boot/dts/qcom/pm8998.dtsi | 6 + 4 files changed, 695 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
Signature · 1 line
2.30.2
PATCH v5 1/2 arm64: dts: qcom: sagit: add initial device tree for sagit
New device support - Xiaomi Mi6 phone
What works:
- storage
- usb
- power regulators
---
Changes for v5:
- use pm8005_regulators label
arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/msm8998-xiaomi-sagit.dts | 687 ++++++++++++++++++ arch/arm64/boot/dts/qcom/pm8998.dtsi | 6 + 3 files changed, 694 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -46,6 +46,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-oneplus-dumpling.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-lilac.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb
arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts new file +687 -0
687 lines not on this page · raw message
arch/arm64/boot/dts/qcom/pm8998.dtsi +6 -0
@@ -52,6 +52,12 @@ pm8998_pwrkey: pwrkey { bias-pull-up; linux,code = <KEY_POWER>; }; + + pm8998_resin: resin { + compatible = "qcom,pm8941-resin"; + bias-pull-up; + interrupts = <GIC_SPI 0x8 1 IRQ_TYPE_EDGE_BOTH>; + }; }; pm8998_temp: temp-alarm@2400 {
Signature · 1 line
2.30.2
Re: [PATCH v5 1/2] arm64: dts: qcom: sagit: add initial device tree for sagit
Quoted 11 lines · Dzmitry Sankouski
New device support - Xiaomi Mi6 phone
What works:
- storage
- usb
- power regulatorsSigned-off-by Dzmitry Sankouski <[email protected]>---
Changes for v5:
- usepm8005_regulatorslabel
It's the third patch sent right after another. No. You need to wait one day. More over, all previous changelog is gone, so I really have no clue what is happening here.
Send v6 with proper changelogs and all comments applied or keep discussing. You keep ignoring comments, then resending something three times. It's not the way to work with reviewers and make their life easier.
arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts line 623
Quoted 12 lines
arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts new file +12
-0+ + wcd_int_n: wcd-int-n { + pins = "gpio54"; + function = "gpio"; + bias-pull-down; + drive-strength = <2>; + input-enable; + }; + + wsa_leftspk_pwr_n: wsa-leftspk-pwr-n { + pins = "gpio65"; + function = "gpio";
Still wrong.
Best regards,
Krzysztof
PATCH v5 2/2 dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
In reply to Dzmitry Sankouskiadd xiaomi,sagit board (Xiaomi Mi 6) binding
---
Changes for v5: none
Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -239,6 +239,7 @@ properties: - sony,xperia-lilac - sony,xperia-maple - sony,xperia-poplar + - xiaomi,sagit - const: qcom,msm8998 - items:
Signature · 1 line
2.30.2
Re: [PATCH v5 2/2] dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
Quoted 2 lines · Dzmitry Sankouski
add xiaomi,sagit board (Xiaomi Mi 6) binding
NAK, still wrong. Apply comments from v3 and do not send more than one version per day.
Best regards,
Krzysztof