Skip to contentSkip to conversation

remoteproc: qcom: Add support for MSM8953 ADSP

PATCH Superseded Sireesh Kodali 2 participants 5 messages Oct 6, 2022

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover remoteproc: qcom: Add support for MSM8953 ADSP

This patch series adds support for the ADSP PIL as found on the MSM8953 platform. It is a subset of a previous patch series.

Changes since v1:
* Properly rebased driver patch, no longer introducing deleted symbols

Link to previous series:
https://lkml.kernel.org/lkml/[email protected]/t/

Sireesh Kodali (2):
remoteproc: qcom: pas: Add MSM8953 ADSP PIL support
dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

 Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
 drivers/remoteproc/qcom_q6v5_pas.c                          | 1 +
 2 files changed, 6 insertions(+)
Signature · 1 line
2.37.3
#1 lore raw

PATCH v2 1/2 remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

Add support for the Audio DSP PIL found on the Qualcomm MSM8953 platform. The same configuration is used on all SoCs based on the MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).

---
 drivers/remoteproc/qcom_q6v5_pas.c | 1 +
 1 file changed, 1 insertion(+)
drivers/remoteproc/qcom_q6v5_pas.c +1 -0
index 6afd0941e552..70b3a37c4814 100644
@@ -950,6 +950,7 @@ static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init},
 	{ .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
 	{ .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
+	{ .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},
 	{ .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
 	{ .compatible = "qcom,msm8998-adsp-pas", .data = &msm8996_adsp_resource},
 	{ .compatible = "qcom,msm8998-slpi-pas", .data = &slpi_resource_init},
Signature · 1 line
2.37.3
#2 lore raw

PATCH v2 2/2 dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

In reply to Sireesh Kodali

Add support for booting the Audio DSP on the MSM8953 platform. This is used by SoCs like SDM450, SDM625, SDM626, APQ8053, etc. Since the configuration is the same on all SoCs, a single compatible string is used.

---
 Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +5 -0
index 3072af5f9d79..c9d69f6160a1 100644
@@ -18,6 +18,7 @@ properties:
     enum:
       - qcom,msm8226-adsp-pil
       - qcom,msm8974-adsp-pil
+      - qcom,msm8953-adsp-pil
       - qcom,msm8996-adsp-pil
       - qcom,msm8996-slpi-pil
       - qcom,msm8998-adsp-pas
@@ -179,6 +180,7 @@ allOf:
             enum:
               - qcom,msm8226-adsp-pil
               - qcom,msm8974-adsp-pil
+              - qcom,msm8953-adsp-pil
               - qcom,msm8996-adsp-pil
               - qcom,msm8996-slpi-pil
               - qcom,msm8998-adsp-pas
@@ -298,6 +300,7 @@ allOf:
             enum:
               - qcom,msm8226-adsp-pil
               - qcom,msm8974-adsp-pil
+              - qcom,msm8953-adsp-pil
               - qcom,msm8996-adsp-pil
               - qcom,msm8996-slpi-pil
               - qcom,msm8998-adsp-pas
@@ -369,6 +372,7 @@ allOf:
           contains:
             enum:
               - qcom,msm8226-adsp-pil
+              - qcom,msm8953-adsp-pil
               - qcom,msm8996-adsp-pil
               - qcom,msm8998-adsp-pas
               - qcom,sm8150-adsp-pas
@@ -559,6 +563,7 @@ allOf:
             enum:
               - qcom,msm8226-adsp-pil
               - qcom,msm8974-adsp-pil
+              - qcom,msm8953-adsp-pil
               - qcom,msm8996-adsp-pil
               - qcom,msm8996-slpi-pil
               - qcom,msm8998-adsp-pas
Signature · 1 line
2.37.3
#3 lore raw

Re: [PATCH v2 2/2] dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

Quoted 15 lines · Sireesh Kodali

Add support for booting the Audio DSP on the MSM8953 platform. This is used by SoCs like SDM450, SDM625, SDM626, APQ8053, etc. Since the configuration is the same on all SoCs, a single compatible string is used.

---
 Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +0 -0
index 3072af5f9d79..c9d69f6160a1 100644

Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml properties: · line 21

Quoted 4 lines
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +1 -0
@@ -18,6 +18,7 @@ properties:
     enum:
       - qcom,msm8226-adsp-pil
       - qcom,msm8974-adsp-pil
+      - qcom,msm8953-adsp-pil

Alphanumeric order.

Same in other places.

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH v2 2/2] dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

Quoted 11 lines · Krzysztof Kozlowski
Quoted 10 lines · Sireesh Kodali

Add support for booting the Audio DSP on the MSM8953 platform. This is used by SoCs like SDM450, SDM625, SDM626, APQ8053, etc. Since the configuration is the same on all SoCs, a single compatible string is used.

---
 Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Quoted 11 lines

Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml properties: · line 21

Quoted 9 lines
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +1 -0
index 3072af5f9d79..c9d69f6160a1 100644
@@ -18,6 +18,7 @@ properties:
     enum:
       - qcom,msm8226-adsp-pil
       - qcom,msm8974-adsp-pil
+      - qcom,msm8953-adsp-pil

Alphanumeric order.

Ok, will be fixed in v3

Regards,
Sireesh Kodali

Quoted 5 lines

Same in other places.

Best regards,
Krzysztof