Skip to contentSkip to conversation

remoteproc: qcom: Add support for MSM8953 ADSP

PATCH Applied Sireesh Kodali 4 participants 6 messages Oct 13, 2022 – Dec 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v4 cover remoteproc: qcom: Add support for MSM8953 ADSP

This patch series adds support for the ADSP PIL as found on the MSM8953 platform. It is a subset of a previous patch series.

Changes since v3:
* Made ordering of compatible strings lexical in driver patch

Link to v3: https://lkml.org/lkml/2022/10/8/204

Sireesh Kodali (2):
remoteproc: qcom: pas: Add MSM8953 ADSP PIL support
dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

 Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
 drivers/remoteproc/qcom_q6v5_pas.c                          | 1 +
 2 files changed, 6 insertions(+)
Signature · 1 line
2.38.0
#1 lore raw

PATCH v4 1/2 remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

Add support for the Audio DSP PIL found on the Qualcomm MSM8953 platform. The same configuration is used on all SoCs based on the MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).

---
 drivers/remoteproc/qcom_q6v5_pas.c | 1 +
 1 file changed, 1 insertion(+)
drivers/remoteproc/qcom_q6v5_pas.c +1 -0
index 6afd0941e552..eff8d34d7f4b 100644
@@ -948,6 +948,7 @@ static const struct adsp_data sm8450_mpss_resource = {
 
 static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init},
+	{ .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},
 	{ .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
 	{ .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
 	{ .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
Signature · 1 line
2.38.0
Reviewed-by on v4 1/2
#2 lore raw

Re: [PATCH v4 1/2] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

Quoted 14 lines · Sireesh Kodali

Add support for the Audio DSP PIL found on the Qualcomm MSM8953 platform. The same configuration is used on all SoCs based on the MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).

---
  drivers/remoteproc/qcom_q6v5_pas.c | 1 +
  1 file changed, 1 insertion(+)
drivers/remoteproc/qcom_q6v5_pas.c +0 -0
index 6afd0941e552..eff8d34d7f4b 100644

drivers/remoteproc/qcom_q6v5_pas.c static const struct adsp_data sm8450_mpss_resource = { · line 954

Quoted 7 lines
drivers/remoteproc/qcom_q6v5_pas.c +1 -0
@@ -948,6 +948,7 @@ static const struct adsp_data sm8450_mpss_resource = {
 
  static const struct of_device_id adsp_of_match[] = {
  	{ .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init},
+	{ .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},
  	{ .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
  	{ .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
  	{ .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
Reviewed-by on v4 1/2
#3 lore raw

Re: [PATCH v4 1/2] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

In reply to Sireesh Kodali
Quoted 6 lines · Sireesh Kodali

Add support for the Audio DSP PIL found on the Qualcomm MSM8953 platform. The same configuration is used on all SoCs based on the MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).

---

Best regards,
Krzysztof

#4 lore raw

PATCH v4 2/2 dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

In reply to Sireesh Kodali

Add support for booting the Audio DSP on the MSM8953 platform. This is used by SoCs like SDM450, SDM625, SDM626, APQ8053, etc. Since the configuration is the same on all SoCs, a single compatible string is used.

---
 Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +5 -0
index db9e0f0c2bea..b1127bc0f01a 100644
@@ -17,6 +17,7 @@ properties:
   compatible:
     enum:
       - qcom,msm8226-adsp-pil
+      - qcom,msm8953-adsp-pil
       - qcom,msm8974-adsp-pil
       - qcom,msm8996-adsp-pil
       - qcom,msm8996-slpi-pil
@@ -179,6 +180,7 @@ allOf:
           contains:
             enum:
               - qcom,msm8226-adsp-pil
+              - qcom,msm8953-adsp-pil
               - qcom,msm8974-adsp-pil
               - qcom,msm8996-adsp-pil
               - qcom,msm8996-slpi-pil
@@ -298,6 +300,7 @@ allOf:
           contains:
             enum:
               - qcom,msm8226-adsp-pil
+              - qcom,msm8953-adsp-pil
               - qcom,msm8974-adsp-pil
               - qcom,msm8996-adsp-pil
               - qcom,msm8996-slpi-pil
@@ -370,6 +373,7 @@ allOf:
           contains:
             enum:
               - qcom,msm8226-adsp-pil
+              - qcom,msm8953-adsp-pil
               - qcom,msm8996-adsp-pil
               - qcom,msm8998-adsp-pas
               - qcom,sm8150-adsp-pas
@@ -559,6 +563,7 @@ allOf:
           contains:
             enum:
               - qcom,msm8226-adsp-pil
+              - qcom,msm8953-adsp-pil
               - qcom,msm8974-adsp-pil
               - qcom,msm8996-adsp-pil
               - qcom,msm8996-slpi-pil
Signature · 1 line
2.38.0
maintainer Applied
#5 lore raw
In reply to Sireesh Kodali
Quoted 9 lines · Sireesh Kodali

This patch series adds support for the ADSP PIL as found on the MSM8953 platform. It is a subset of a previous patch series.

Changes since v3:
* Made ordering of compatible strings lexical in driver patch

Link to v3: https://lkml.org/lkml/2022/10/8/204

[...]

Applied, thanks!

[1/2] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

      commit: 1cfaa13b82c73977e8ddaca63c791203addc39c1
[2/2] dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953
      commit: 4a0510a46c4447ad3e807a1e4d6cf195fd604c1d

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>